use lib instead of blib for local testing

[MARC-Fast] / Fast.pm

diff --git a/Fast.pm b/Fast.pm
index ace03b3..aef3d5b 100644 (file)
--- a/Fast.pm
+++ b/Fast.pm
@@ -2,12 +2,12 @@ package MARC::Fast;
 
 use strict;
 use Carp;
-use Data::Dumper;
+use Data::Dump qw/dump/;
 
 BEGIN {
        use Exporter ();
        use vars qw ($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
-       $VERSION     = 0.09;
+       $VERSION     = 0.10;
        @ISA         = qw (Exporter);
        #Give a hoot don't pollute, do not export more than needed by default
        @EXPORT      = qw ();
@@ -87,7 +87,8 @@ sub new {
                my $len = read($self->{fh}, $leader, 24);
 
                if ($len < 24) {
-                       carp "short read of leader, aborting\n";
+                       warn "short read of leader, aborting\n";
+                       $self->{count}--;
                        last;
                }
 
@@ -124,6 +125,7 @@ sub new {
 
                # skip to next record
                my $o = substr($leader,0,5);
+               warn "# in record ", $self->{count}," record length isn't number but: ",dump($o),"\n" unless $o =~ m/^\d+$/;
                if ($o > 24) {
                        seek($self->{fh},$o-24,1) if ($o);
                } else {
@@ -309,14 +311,14 @@ sub to_hash {
 
        my $row = $self->fetch($mfn) || return;
 
-       foreach my $rec_nr (keys %{$row}) {
-               foreach my $l (@{$row->{$rec_nr}}) {
+       foreach my $tag (keys %{$row}) {
+               foreach my $l (@{$row->{$tag}}) {
 
                        # remove end marker
                        $l =~ s/\x1E$//;
 
                        # filter output
-                       $l = $self->{'hash_filter'}->($l, $rec_nr) if ($self->{'hash_filter'});
+                       $l = $self->{'hash_filter'}->($l, $tag) if ($self->{'hash_filter'});
 
                        my $val;
 
@@ -349,7 +351,7 @@ sub to_hash {
                                $val = $l;
                        }
 
-                       push @{$rec->{$rec_nr}}, $val;
+                       push @{$rec->{$tag}}, $val;
                }
        }
 
@@ -383,6 +385,27 @@ sub to_ascii {
 1;
 __END__
 
+=head1 UTF-8 ENCODING
+
+This module does nothing with encoding. But, since MARC format is byte
+oriented even when using UTF-8 which has variable number of bytes for each
+character, file is opened in binary mode.
+
+As a result, all scalars recturned to perl don't have utf-8 flag. Solution is
+to use C<hash_filter> and L<Encode> to decode utf-8 encoding like this:
+
+  use Encode;
+
+  my $marc = new MARC::Fast(
+       marcdb => 'utf8.marc',
+       hash_filter => sub {
+               Encode::decode( 'utf-8', $_[0] );
+       },
+  );
+
+This will affect C<to_hash>, but C<fetch> will still return binary representation
+since it doesn't support C<hash_filter>.
+
 =head1 AUTHOR
 
        Dobrica Pavlinusic