projects / koha.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4f775cd) | patch
Bug 8037: (follow-up) bad sql query and variable renaming
authorJonathan Druart <jonathan.druart@biblibre.com>
Fri, 25 Oct 2013 12:27:10 +0000 (14:27 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Thu, 31 Oct 2013 14:53:17 +0000 (14:53 +0000)
commit380bfcedd529f5d5b52c11bd8b6d5f32dd3c10dd
tree5dd17a64139e15bc5fcb5186f352bd8cbbc3e952tree | snapshot
parent4f775cd640e35b8fb5c5b1af295e82086a4a7692commit | diff
Bug 8037: (follow-up) bad sql query and variable renaming

The first patch does a left join on aqorders_items which returns too
much order lines.

This patch follows the Galen's suggestion: it removes the join and calls
the GetItemnumbersFromOrder routine for retrieving itemnumbers.

Bonus: the "parcelitems" variable is badly named and obfuscates the code.
I changed it for "orders".

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Acquisition.pm diff | blob | history
acqui/parcel.pl diff | blob | history
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt diff | blob | history
Koha ILS @ FFZG - based on git://git.koha.org/pub/scm/koha.git