Bug 9454: Use placeholders when adding basket
authorColin Campbell <colin.campbell@ptfs-europe.com>
Wed, 23 Jan 2013 10:52:28 +0000 (10:52 +0000)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Fri, 15 Feb 2013 12:44:06 +0000 (07:44 -0500)
commit6ade3cf57e37b517ef054723112cd369ce270728
tree05d3f845d5ca2c13e0e90ca765607548fabd9e9e
parentb60a8397c15a321cec37f6a3b2fa4612631a103e
Bug 9454: Use placeholders when adding basket

Should always use placeholders when passing variables
to DBI; avoids unforeseen bugs and security issues.

Also:

- reformated the long lists of parameters to add CR
- moved the setting of defaults out of the call to ModBasket to
  clarify code
- Setting parameters to undef if they were not defined
  was unnecessary bloat and obscuration

Testing:
Patch should not change functional behaviour. To test check that
order baskets can still be correctly created.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Created a new basket, added order lines and closed basket.
Checked everything worked in the staff interface, also checked
the entry for the new basket in aqbasket in the database.
Logs are clean too.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
C4/Acquisition.pm