From: Colin Campbell <colin.campbell@ptfs-europe.com>
Date: Mon, 18 Jun 2012 10:23:42 +0000 (+0100)
Subject: Bug 6939 DefaultClassificationSource should be default in 942
X-Git-Url: http://git.rot13.org/?p=koha.git;a=commitdiff_plain;h=25eeaf0f8e67b065559218c78a15bcb3700a0f0f

Bug 6939 DefaultClassificationSource should be default in 942

A logic bug in the original code adding DefaultClassificationSource
caused the default not to be used (the last used value was used instead)
The bug was fixed in additem by bug 2398 but addbiblio's use
of the code was not fixed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
---

diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index 643fc538f3..3db1a65526 100755
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -215,10 +215,8 @@ sub build_authorized_values_list {
                         ($class_source eq $default_source);
             push @authorised_values, $class_source;
             $authorised_lib{$class_source} = $class_sources->{$class_source}->{'description'};
-            $value = $class_source unless ($value);
-            $value = $default_source unless ($value);
         }
-        #---- "true" authorised value
+        $value = $default_source unless $value;
     }
     else {
         $authorised_values_sth->execute(