From: Joe Atzberger <joe.atzberger@liblime.com>
Date: Sat, 20 Jun 2009 00:32:43 +0000 (-0500)
Subject: Remove unused variable and add FIXME.
X-Git-Tag: n_acq_a_porter~26^2~30
X-Git-Url: http://git.rot13.org/?p=koha.git;a=commitdiff_plain;h=4017d2449de2474c725aa952f2bc644e7559a9ca

Remove unused variable and add FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
---

diff --git a/C4/Context.pm b/C4/Context.pm
index 0d07ebfd8f..4dab9a98c5 100644
--- a/C4/Context.pm
+++ b/C4/Context.pm
@@ -866,7 +866,6 @@ sub _new_stopwords
     my $sth = $dbh->prepare("select word from stopwords");
     $sth->execute;
     while (my $stopword = $sth->fetchrow_array) {
-        my $retval = {};
         $stopwordlist->{$stopword} = uc($stopword);
     }
     $stopwordlist->{A} = "A" unless $stopwordlist;
@@ -957,7 +956,7 @@ sub get_shelves_userenv () {
 
 =item _new_userenv
 
-  C4::Context->_new_userenv($session);
+  C4::Context->_new_userenv($session);  # FIXME: This calling style is wrong for what looks like an _internal function
 
 Builds a hash for user environment variables.
 
@@ -971,7 +970,7 @@ _new_userenv is called in Auth.pm
 #'
 sub _new_userenv
 {
-    shift;
+    shift;  # Useless except it compensates for bad calling style
     my ($sessionID)= @_;
      $context->{"activeuser"}=$sessionID;
 }