From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Mon, 9 Jul 2018 18:05:29 +0000 (-0400)
Subject: Bug 21056: Changing the logged in library can fail sporadically
X-Git-Url: http://git.rot13.org/?p=koha.git;a=commitdiff_plain;h=76a06a7050643add32f4cbccbdc2fb00f66f5485

Bug 21056: Changing the logged in library can fail sporadically

We are getting reports that sometimes changing the logged in library via selectbranchprinter.pl sometimes appears to fail. Flushing the session after updating the branch appears to fix this.

Test Plan:
1) Change your logged in library repeatedly. Hopefully ( sort of ) it will fail to change.
   You may want to try various browsers.
2) Apply this patch
3) Note the change no longer fails

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/circ/selectbranchprinter.pl b/circ/selectbranchprinter.pl
index 03fa65b1ec..cff7f08013 100755
--- a/circ/selectbranchprinter.pl
+++ b/circ/selectbranchprinter.pl
@@ -62,6 +62,7 @@ if ( $branch and my $library = Koha::Libraries->find($branch) ) {
         $template->param(LoginBranchcode => $branch);       # update template for new branch
         $session->param('branchname', $branchname);         # update sesssion in DB
         $session->param('branch', $branch);                 # update sesssion in DB
+        $session->flush();
         push @updated, {
             updated_branch => 1,
                 old_branch => $userenv_branch,