koha.git
6 years agoupdated release notes for 3.14.0 beta master
Galen Charlton [Fri, 1 Nov 2013 15:04:49 +0000 (15:04 +0000)]
updated release notes for 3.14.0 beta

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoDBRev 3.13.00.042: mark Koha 3.14 beta
Galen Charlton [Fri, 1 Nov 2013 14:22:26 +0000 (14:22 +0000)]
DBRev 3.13.00.042: mark Koha 3.14 beta

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10403: (follow-up) fix test to use vendor created earlier during test
Galen Charlton [Fri, 1 Nov 2013 02:31:22 +0000 (02:31 +0000)]
Bug 10403: (follow-up) fix test to use vendor created earlier during test

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8307: (follow-up) fix discrepancy in name of the new syspref
Galen Charlton [Fri, 1 Nov 2013 00:46:16 +0000 (00:46 +0000)]
Bug 8307: (follow-up) fix discrepancy in name of the new syspref

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11132: don't clear the results list upon adding a biblio to a list
Jonathan Druart [Thu, 24 Oct 2013 15:06:08 +0000 (17:06 +0200)]
Bug 11132: don't clear the results list upon adding a biblio to a list

A "busc" param is cleared if the template name is not opac-.*detail.tt.
So if a user adds a biblio to a list, he cannot continue to browse
results.

Test plan:
- launch a search at the OPAC (opac-search.pl).
- click on a result and browse results (using previous/next links).
- a title attract your attention and you add it to a list
  ("Save to yours lists" link on the right).
- save the list.
- browse again results.

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested according to test plan, also checked some other pages and actions
accessible from the detail page.
Passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11033: Make Save button and Cancel link always visible on basketgroup page
Mathieu Saby [Thu, 10 Oct 2013 11:34:37 +0000 (13:34 +0200)]
Bug 11033: Make Save button and Cancel link always visible on basketgroup page

This patch suppresses the first CSS declaration in basketgroup.tt. It was
unneeded, and was the cause of the Save button and Cancel link not
being visible if the bar for changing language was activated.

To test :
1. activate the "language" syspref, with at least 2 languages
2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible
   at the bottom of basketgroup page
3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc.

Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10720: fix issue that prevented use of HTML tags in overdue notices
Sophie Meynieux [Tue, 13 Aug 2013 16:14:21 +0000 (18:14 +0200)]
Bug 10720: fix issue that prevented use of HTML tags in overdue notices

Substitution term in overdue notices shouldn't be removed if they don't match.
It prevents use of HTML in notices to use with CSS.

Test plan :
- define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css
- find a borrower with overdues that trigger this notice
- run overdue_notices.pl -html <directory>

Without patch, your html tags are missing in your html file
With the patch, they are present and can be used with a css to generate a formatted pdf file.

If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7684: (follow-up) fix UTF-8 encoding problems in CSV export
Galen Charlton [Fri, 1 Nov 2013 00:25:08 +0000 (00:25 +0000)]
Bug 7684: (follow-up) fix UTF-8 encoding problems in CSV export

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7684: (follow-up) use datatables.inc
Galen Charlton [Fri, 1 Nov 2013 00:17:35 +0000 (00:17 +0000)]
Bug 7684: (follow-up) use datatables.inc

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7684: (follow-up) fix crash when generating the CSV
Jonathan Druart [Fri, 11 Oct 2013 14:29:34 +0000 (16:29 +0200)]
Bug 7684: (follow-up) fix crash when generating the CSV

The cgi argument in missing for routine
C4::Reports::Guided::_get_column_defs. It causes a crash on generating
the CSV file.

Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7684: QA Followup and bugfixes
Jonathan Druart [Thu, 6 Jun 2013 12:37:19 +0000 (14:37 +0200)]
Bug 7684: QA Followup and bugfixes

This followup fixes some QA issues:
- replace the MySQLism SQL_CALC_FOUND_ROWS
- use Koha::DateUtils instead of C4::Dates
- replace "branch" and "location" with "library"
- fixe wrong capitalisation on "Clear all" and "Select all"

and fixes some behaviors:
- the inventory tools can be used without barcode file (fixed for the
  csv export too).
- mark as not scanned a non scanned item.
- update the datelastseen 1 time per biblio (and fixes the displayed
  count)

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7684: multiple fixes for inventory
Matthias Meusburger [Thu, 23 Aug 2012 14:02:52 +0000 (16:02 +0200)]
Bug 7684: multiple fixes for inventory

* when a file was uploaded and the comparison with catalogue range
 requested, the comparison was wrong: the logic was wrong
* items that were not supposed to be scanned (ie: supposed to be on another shelf)
  didn't had the author and title, it was hard to retrieve them on the shelved
* some useful fields were missing, like homebranch, location, status
* the CSV export contained all the item information. It should contain the same
   informations as the screen

Behaviour now:
   * scan a list of barcode & select a range of location
   * if a barcode has been scanned and should not be (misplaced item),
       the information is displayed
   * if you choose "compare barcodes list to result option", the
     resulting list contains all items that have been scanned and those
     that were supposed to be. Any item not in both list appears with a
     specific message on the last column

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9374: (follow-up) add FIXME suggesting that use of a regexp is not the long-term...
Galen Charlton [Fri, 1 Nov 2013 00:08:04 +0000 (00:08 +0000)]
Bug 9374: (follow-up) add FIXME suggesting that use of a regexp is not the long-term solution

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9374: The color should manage all zero format.
Jonathan Druart [Thu, 19 Sep 2013 15:03:00 +0000 (17:03 +0200)]
Bug 9374: The color should manage all zero format.

The format of prices in Koha is discuted in some bugs (e.g. 9410).
The good way will be to introduce a syspref in order to deal with the
number of decimal.
The previous patch is too restrictive, we should deal with other zero
format.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9374: Only 0.00 prices must have class error in basket.tt
Mathieu Saby [Sun, 15 Sep 2013 11:09:20 +0000 (13:09 +0200)]
Bug 9374: Only 0.00 prices must have class error in basket.tt

A regexp '^0' in basket.tt is used to give the class "error" to null prices.
It is wrong, because it matches prices like "0.15". It should only match "0.00".

To test :
- apply the patch
- display a basket with an order with a price between 0 and 1 (like "0.50") and an order with a price stricty null ("0.00")
- only the "0.00" price should be displayed in red

Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9780: (follow-up) suppress line feeds in javascript
Mathieu Saby [Mon, 21 Oct 2013 17:24:34 +0000 (19:24 +0200)]
Bug 9780: (follow-up) suppress line feeds in javascript

This patch suppress \n in javascript, in order to keep Pootle quiet.

String patch, no need to test I think.
But if you want to test, replay the test plan of main patch, and check
the messages in javascript alert are displaying the right way.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9780: restrict the ability to delete a bib record associated with an order
Mathieu Saby [Thu, 19 Sep 2013 12:12:02 +0000 (14:12 +0200)]
Bug 9780: restrict the ability to delete a bib record associated with an order

Currently, anyone can delete a record used in an order.

With this patch, only librarians with managing order permission
can delete it if it is used in an active or a deleted order.

This patch also add a specific warning informing that deleting a record
used in an active order is dangerous.

To test :
A. test what can do and see a librarian with order managing rights
0) Connect to Koha with a borrower with order managing rights
1) in a basket, create 2 orders A & B from new records
2) delete order B
3) in the catalogue, try to delete
- record used for order A : you should see a specific warning
   informing you the record is used in 1 order, and that deleting it
   is dangerous
- record used for order B : you should see a specific warning informing
  you the record is used in 1 deleted order
- a record not used in any order : you should see no specific warning

B. test what can do and see a librarian without order managing rights
4) Connect to Koha with a borrower without order managing rights
5) in a basket, create 2 orders A & B from new records
6) delete order B
7) in the catalogue, try to delete
- record used for order A : you should see a specific warning informing you that
   you need specific rights to delete the record
- record used for order B : idem
- a record not used in any order : you should see no specific warning

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9218: fix intranet cart email for non english templates
Jonathan Druart [Tue, 8 Oct 2013 08:52:28 +0000 (10:52 +0200)]
Bug 9218: fix intranet cart email for non english templates

This patch adapts the method from OPAC to the staff interface (cf bug 8062).

Test plan:
- add somes notices to the cart
- try to send the cart by email
- the email should be the same as before
- translate templates and retry with another language. Before this patch,
  the email was empty. With this patch, it contains the list of records
  and items.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Passes all tests and QA script.
Fixes quite a bad translation problem, tested with German templates
and umlauts in the message and records.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8307: DBrev 3.13.00.041
Galen Charlton [Thu, 31 Oct 2013 23:40:54 +0000 (23:40 +0000)]
Bug 8307: DBrev 3.13.00.041

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9044: (follow-up) fix merge conflict typo that broke this script
Galen Charlton [Thu, 31 Oct 2013 23:39:17 +0000 (23:39 +0000)]
Bug 9044: (follow-up) fix merge conflict typo that broke this script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8307: QA Followup for finishreceive.pl
Marcel de Rooy [Mon, 3 Jun 2013 08:19:39 +0000 (10:19 +0200)]
Bug 8307: QA Followup for finishreceive.pl

Only split the expression a=b on the first = sign.
Tested with the very unlikely z=x=1 :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
6 years agoBug 8307: Set a value for subfields when receiving
Jonathan Druart [Fri, 18 May 2012 11:42:36 +0000 (13:42 +0200)]
Bug 8307: Set a value for subfields when receiving

If items are created when ordering, this patch allows to add a value for
some items subfields.

Test plan:
Define status for items.notforloan (mapping 995$o in unimarc), for
example 4:On order, 5:On treatment

Set the Syspref AcqCreateItem on "ordering".

ACQ framework : set default value = 4 for 995$o (in unimarc)

Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'"

When ordering the item, default status will be 4 ; when receiving the
item, status will be changed from 4 to 5. The subfield b have to contain
'foo bar'

Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
6 years agoBug 10776: fix awkward wording in subscription notification screen
Liz Rea [Thu, 22 Aug 2013 04:55:48 +0000 (16:55 +1200)]
Bug 10776: fix awkward wording in subscription notification screen

to test:
- make a subscription available to be notified about
- log into the opac, click the subscriptions tab, then More details
- click "Subscribe to email notification on new issues"
- observe the text without the patch - there seems to be an extra "arrive?"
- apply the patch, refresh - wording should flow a bit better.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes bad wording and works as described.
Passes all tests and QA script, template change only.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11054: Specify UTF-8 encoding when creating a child record
Colin Campbell [Tue, 15 Oct 2013 14:09:08 +0000 (15:09 +0100)]
Bug 11054: Specify UTF-8 encoding when creating a child record

When the only non-ascii characters in a new child record
are latin + diacritic in the range covered by Latin-1 they
are not being added to a new child record correctly encoded.
Explicitly setting the record's encodiing ensures that
they are interpreted correctly.

see "Unicode Bug" in perldoc perlunicode for background on
why these characters are special

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works well. No koha-qa errors.

Same test as before
1) with a record with diacritics in author/title,
2) press new child record, on new record 773adt
with mangled accents
3) Apply patch
4) Repeat 2, now good results

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Tested with a record containing umlauts in the title,
$t was empty before and umlauts in $a mangled.
After applying the patch fields are correctly filled and
diacritics display correctly.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10671: Update patron help files [ FOLLOW-UP ]
Nicole C. Engard [Sat, 26 Oct 2013 03:47:54 +0000 (23:47 -0400)]
Bug 10671: Update patron help files [ FOLLOW-UP ]

This patch adds two new permissions that were just pushed
to the related patron help files. It is a follow up to the
previous patch that updated the patron help file.

To test:

Apply the patron help patch
Apply this patch
Visit the patron permissions page
Confirm that help is there and right

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10671: Update Acq Help Files
Nicole C. Engard [Sat, 26 Oct 2013 01:35:25 +0000 (21:35 -0400)]
Bug 10671: Update Acq Help Files

This patch updates the Acq help file links
to the manual.

To test:

* visit acq pages
* confirm manual links are right

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10671: Update patron help files
Nicole C. Engard [Sat, 26 Oct 2013 01:27:49 +0000 (21:27 -0400)]
Bug 10671: Update patron help files

This patch updates the text and links in the
patron related help files.

To test:

* visit all patron pages
* Click help
* confirm test and links

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10671: Update Admin Help Files
Nicole C. Engard [Sat, 26 Oct 2013 01:04:12 +0000 (21:04 -0400)]
Bug 10671: Update Admin Help Files

This patch updates the links to the manual in the
help files. It also updates the text a bit in a few.

To test:

* Visit admin pages
* Check the help files on each
* Make sure links and text appears

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10671: Update Tools Help Files
Nicole C. Engard [Sat, 26 Oct 2013 00:42:43 +0000 (20:42 -0400)]
Bug 10671: Update Tools Help Files

This patch updates the links to the manual in
the tool help files.

To test:

* Visit tool pages and click the help
* confirm links work

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10671: Update Serials Help
Nicole C. Engard [Sat, 26 Oct 2013 00:31:54 +0000 (20:31 -0400)]
Bug 10671: Update Serials Help

This patch updates the links to the manual in
the serials help files.

To test:

* Visit serials pages and click the help
* confirm links work

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10671: Update Cataloging Help
Nicole C. Engard [Sat, 26 Oct 2013 00:10:21 +0000 (20:10 -0400)]
Bug 10671: Update Cataloging Help

This patch updates the links to the manual in
the cataloging help files.

To test:

* Visit cataloging pages and click the help
* confirm links work

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) don't require userenv
Galen Charlton [Thu, 31 Oct 2013 22:36:39 +0000 (22:36 +0000)]
Bug 8015: (follow-up) don't require userenv

Core routines probably should never assume that they're
running with a valid userenv defined.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) update stage_file.pl
Galen Charlton [Thu, 31 Oct 2013 22:10:31 +0000 (22:10 +0000)]
Bug 8015: (follow-up) update stage_file.pl

This patch fixes the call to BatchStageMarcRecords() made
by the comand-line record importer.  At some point in the future
we could go further and teach that tool how to apply modification
templates.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) update DBIx::Class schema classes
Galen Charlton [Thu, 31 Oct 2013 22:04:22 +0000 (22:04 +0000)]
Bug 8015: (follow-up) update DBIx::Class schema classes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: DBRev 3.13.00.040
Galen Charlton [Thu, 31 Oct 2013 22:02:25 +0000 (22:02 +0000)]
Bug 8015: DBRev 3.13.00.040

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: QA Followup 2
Kyle M Hall [Tue, 22 Oct 2013 18:24:36 +0000 (14:24 -0400)]
Bug 8015: QA Followup 2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: QA Followup
Kyle M Hall [Tue, 22 Oct 2013 16:55:02 +0000 (12:55 -0400)]
Bug 8015: QA Followup

* Add bug number to database update
* Fix capitalization errors
* Fix JavaScript string translation errors

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) remove references to C4::Koha::Log
Kyle M Hall [Tue, 22 Oct 2013 16:24:10 +0000 (12:24 -0400)]
Bug 8015: (follow-up) remove references to C4::Koha::Log

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) add user permissions to all languages
Kyle M Hall [Tue, 22 Oct 2013 16:19:21 +0000 (12:19 -0400)]
Bug 8015: (follow-up) add user permissions to all languages

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines
Jonathan Druart [Fri, 29 Mar 2013 16:29:27 +0000 (17:29 +0100)]
Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Bug 8015: Fix complains from qa tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Bug 8015: Get rid of the eval in ModifyRecordWithTemplate

This patch removes the use of eval in the
C4::MarcModificationTemplates::ModifyRecordWithTemplate routine.

Now this routine call the wanted modification routine with the list of
parameters.
This call is done only if the condition is respected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Bug 8015: Get rid of eval for evaluating =~ m//

Koha::SimpleMarc::field_equals uses eval in order to check if a string
matches a pattern.
Now this eval is removed and the "regex" variable does not contain the
regex separated character (/ or |).

Regression: Before this patch, the user was able to user a modifier. Now
it is not possible.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Bug 8015: Get rid of the eval for substitution

Before this patch, the regex substitution was contain into only one
variable (e.g. my $regex = "/foo/bar/i").
Now each member of the regex is stored into a field in the
marc_modification_template_actions sql table.

In order to avoid a complex code, only modifiers i and g are take into
account.

Note: If you already add the mmta table, you have to drop it.
This patch also adds a foreign key from mmta to mmt tables.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Bug 8015: FIX ui issue

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Bug 8015: The template name is a required field

Test plan:
Try to add a template with an empty string as name.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) fix various issues (squashed patch)
Kyle M Hall [Tue, 19 Mar 2013 10:27:46 +0000 (03:27 -0700)]
Bug 8015: (follow-up) fix various issues (squashed patch)

Bug 8015: Fix template capitalization amd other template issues

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: Fix error where field object is returned instead of field value for fields without subfields

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: Fix bad ordering on function parameters

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: Escape escape characters for strings

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: Fix bad parameter list for direct external call to update_field

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: FIX QA issues

This patch fixes some stuffs failing qa tests: POD, indentation (tabs),
perlcritic

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) trap exceptions thrown by SetUTF8Flag()
Jonathan Druart [Tue, 16 Oct 2012 07:45:07 +0000 (09:45 +0200)]
Bug 8015: (follow-up) trap exceptions thrown by SetUTF8Flag()

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: Catch error in the SetUTF8Flag routine

The eval avoids the interface to run endlessly if an error occurred.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) move from the Koha to the C4 namespace
Kyle M Hall [Fri, 28 Sep 2012 12:39:58 +0000 (08:39 -0400)]
Bug 8015: (follow-up) move from the Koha to the C4 namespace

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: (follow-up) fix copy and move if subfields don't exist.
Jonathan Druart [Mon, 13 Aug 2012 15:04:05 +0000 (17:04 +0200)]
Bug 8015: (follow-up) fix copy and move if subfields don't exist.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Bug 8015: Followup: On move, we cant delete existing fields

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8015: Add MARC Modifications Templates
Kyle M Hall [Thu, 26 Apr 2012 20:08:57 +0000 (16:08 -0400)]
Bug 8015: Add MARC Modifications Templates

The MARC Modification Templates system gives Koha users
the power to make alterations to MARC records automatically
while staging MARC records for import.

This tool is useful for altering MARC records from
various venders work with your MARC framework.

The system essentially allows one to create a basic script
using actions to Copy, Move, Add, Update and Delete fields.

Each action can also have an optional condition to check
the value or existance of another field.

The Copy & Move actions also support Regular Expressions,
which can be used to automatically modify field values during the
copy/move. An example would be to strip out the '$' character
in field 020$c.

Furthermore, the value for an update can include variables
that change each time the template is used. Currently,
the system supports two variables, __BRANCHCODE__ which
is replaced with the branchcode of the library currently
using the template, and __CURRENTDATE__ which is replaced
with the current date in ISO format ( YYYY-MM-DD ).

At its simplist, it can perform functions such as:
Copy field 092$a to 952$c
At its most complex it can run actions like:
Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: (follow-up) prevent t/00-load.t failing
Galen Charlton [Thu, 31 Oct 2013 18:51:04 +0000 (18:51 +0000)]
Bug 8435: (follow-up) prevent t/00-load.t failing

C4::Serials now needs a valid context in order to
load.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10445: (follow-up) fix error
Kyle M Hall [Mon, 21 Oct 2013 00:27:31 +0000 (20:27 -0400)]
Bug 10445: (follow-up) fix error

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Followup to failed QA tests have helped pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10445: make SIP Server respect maxoutstanding system preference
Kyle M Hall [Tue, 11 Jun 2013 14:00:58 +0000 (10:00 -0400)]
Bug 10445: make SIP Server respect maxoutstanding system preference

The system preference 'maxoutstanding' is defined as the maximum amount
of fees owed by the patron before Koha should block placing holds (
terrible naming on this one ).

However, although the Koha OPAC respects this preference, placing holds
via a SIP2 device will not.

Test Plan:
1) Set maxoutstanding to $10
2) Pick a patron owning more than $10 in fees
3) Attempt to place a hold for this patron from a SIP2 device
   This attempt should succeed
4) Apply this patch
5) Restart your SIP2 server
6) Attempt to place a hold for this patron from a SIP2 device again
   This attempt should now fail

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10974: make OAI-PMH resumption tokens handle time correctly
David Cook [Mon, 30 Sep 2013 05:47:03 +0000 (15:47 +1000)]
Bug 10974: make OAI-PMH resumption tokens handle time correctly

This patch changes the value separator in OAI-PMH resumption tokens
from colons to slashes, so that the token string isn't split incorrectly
when a time is included.

TEST PLAN:

1) Turn on the OAI-PMH server syspref in Koha
2) Send a ListRecords request using 'from' and 'until' arguments that
include times (Best to use very far apart times so that you retrieve
more than 50 records which will likely be the trigger for a resumptionToken).
Here is an example:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
metadataPrefix=oai_dc&from=2012-09-05T13:44:33Z&until=2014-09-05T13:44:33Z

N.B. Replace KOHAINSTANCE with the URL of your Koha instance.

3) Scroll down to the bottom of the page until you find the resumptionToken.
It will look similar to this:

<resumptionToken cursor="50">
oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:
</resumptionToken>

4) Copy that resumption token and send a request with it like so:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
resumptionToken=oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:

5) The page should (incorrectly) show no records.

6) APPLY PATCH

7) Repeat steps 2, 3, and 4

8) Note that the resumptionToken now uses slashes (e.g. /) instead of
colons.

Note also that now the second request will show records!!!

N.B. This will only happen if Koha has enough records to serve to you.
If your Koha has less than 50 records, try lowering the number provided
in the "OAI-PMH:MaxCount" system preference.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>
I understand; I can now confirm the behaviour described in the test plan.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes test plan, all tests and QA script.
Resumption Token works correctly after applying the patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11178: Make the Bootstrap OPAC theme the default for new installs
Galen Charlton [Thu, 31 Oct 2013 17:03:32 +0000 (17:03 +0000)]
Bug 11178: Make the Bootstrap OPAC theme the default for new installs

This patch implements the proposal adopted by the community to
make Boostrap be the default OPAC theme for new Koha installs.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11142 - Update Bootstrap theme's place hold form to match the new version in...
Owen Leonard [Fri, 25 Oct 2013 19:31:51 +0000 (15:31 -0400)]
Bug 11142 - Update Bootstrap theme's place hold form to match the new version in prog

The update to the prog theme's place hold page (Bug 10836) happened
after the Bootstrap theme's place hold form had already been converted,
so it lags behind. This patch applies the changes made to prog to Bootstrap.

To test, switch to the Bootstrap theme and follow the test plan from Bug
10836:

Place single and multiple holds under various conditions:

- Items which are not available to be place on hold
- With OpacHoldNotes on and off
- With OPACItemHolds on and off
- With OPACAllowHoldDateInFuture on and off
- With IndependentBranches on and off
- With JavaScript disabled

Test setting hold notes, holding specific copies, and setting hold start
dates. When setting a hold start date and hold expiration date, the two
datepickers should work together to prevent invalid date combinations
(dates after today, expiration dates which precede the start date).

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors. Works as described, very well.

Tested all situations, all syspref, and without JavaScript.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10283: Hide "many items" on second tab when using OpacSeparateHoldings
Jonathan Druart [Mon, 20 May 2013 07:53:38 +0000 (09:53 +0200)]
Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings

If there are over 50 items in the holdings or Other holdings tab, the
warning and link 'This record has many physical items. Click here to
view them all.' is only shown for the first tab.

Test plan:
- Switch on the OpacSeparateHoldings pref.
- Go on a biblio detail page at the OPAC with more than 50 items
- Check that the 'view all' link appears on the second tab.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10523: Remove two obsolete routines from Installer.pm
Marcel de Rooy [Mon, 1 Jul 2013 13:12:53 +0000 (15:12 +0200)]
Bug 10523: Remove two obsolete routines from Installer.pm

The routines sql_file_list and marcflavour_list in Installer.pm are not used.
There are some references to them in probably obsolete '/lib' test units.
I changed these test units for the record too.

Also: removed the not-existing marcflavour parameter of sample_data_sql_list
in its call in install.pl.

Test plan:
Run a new install.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7295: DBRev 3.13.00.039
Galen Charlton [Thu, 31 Oct 2013 16:33:17 +0000 (16:33 +0000)]
Bug 7295: DBRev 3.13.00.039

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7295: (follow-up) update DBIx::Class schema classes
Galen Charlton [Thu, 31 Oct 2013 16:32:51 +0000 (16:32 +0000)]
Bug 7295: (follow-up) update DBIx::Class schema classes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7295: (follow-up) fix syntax error in kohastructure.sql
Galen Charlton [Thu, 31 Oct 2013 16:30:29 +0000 (16:30 +0000)]
Bug 7295: (follow-up) fix syntax error in kohastructure.sql

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7295 (follow-up) replace simple-quoted string by double-quoted string
Julian Maurice [Thu, 18 Jul 2013 09:04:08 +0000 (11:04 +0200)]
Bug 7295 (follow-up) replace simple-quoted string by double-quoted string

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7295: (follow-up) several fixes
Julian Maurice [Tue, 17 Jul 2012 08:51:36 +0000 (10:51 +0200)]
Bug 7295: (follow-up) several fixes

- List of libraries in basket.pl is now sorted by branch name, not code
- When IndependantBranches is ON, user has only the possibility to set
  basket branch to its own branch, or to no branch at all.
- When basket do not belong to any branch, selected branch by default is
  connection branch (was 'no branch')
- added id attributes to both added li elements
- change description of 'order_manage_all' permission to make it
  clearer.
- remove Test::MockModule dependency

Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7295: More granular permissions for baskets
Julian Maurice [Fri, 20 Apr 2012 15:12:29 +0000 (17:12 +0200)]
Bug 7295: More granular permissions for baskets

- Add branch info to baskets
- Add a list of borrowers that are allowed to manage a basket (one list
for each basket).
- Add a new subpermission: acquisition => order_manage_all

If user is superlibrarian, or if that user has permission acquisition = 1
(GranularPermissions = OFF), or subpermission acquisition =>
order_manage_all (GranularPermissions = ON), that user is authorised to manage
all baskets.

Depending on syspref AcqViewBaskets:
  'all': user can manage all baskets
  'branch': user can manage baskets of their branch (the basket branch is
            taken into account, not the branch of the basket's creator).
            If basket branch is not defined, all users can manage this
            basket.
  'user': user can manage baskets she created, and baskets in their
          user list

There are unit tests in t/Acquisition/CanUserManageBasket.t, which
require Test::MockModule

You can edit basket's branch and users list in basket modification page
(acqui/basket.pl)

Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11168: fix regression that broke exporting serial claims to CSV
Jonathan Druart [Wed, 30 Oct 2013 11:33:15 +0000 (12:33 +0100)]
Bug 11168: fix regression that broke exporting serial claims to CSV

Bug 7688 broke the exporting serial claims as CSV (see bug 10854).

For C4::Serials::GetLateOrMissingIssues(), $supplierid is not
meant to be mandatory.  This patch fixes that.

Test plan:
try to export a serial claim.
Without this patch, the csv is always empty.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7298: (follow-up) fix uninitialized variable warning
Galen Charlton [Thu, 31 Oct 2013 15:46:42 +0000 (15:46 +0000)]
Bug 7298: (follow-up) fix uninitialized variable warning

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7298: (follow-up) fix translation for CSV strings
Jonathan Druart [Tue, 24 Sep 2013 08:19:27 +0000 (10:19 +0200)]
Bug 7298: (follow-up) fix translation for CSV strings

Following the same way as bug 10935, the headers are in an include file.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Translatability tested successfully.
Passes all tests.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7298: (follow-up) various QA fixes
Jonathan Druart [Mon, 23 Sep 2013 08:43:20 +0000 (10:43 +0200)]
Bug 7298: (follow-up) various QA fixes

- use Modern::Perl;
- GPL version
- tabs

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script and all tests.

Testing notes:
- CSV header row is now translatable.
  Tested by updating the German po files and checking for the line.
- Tested that claiming for late serial issues still works as
  expected, as one file has been renamed. Filed 10931 for
  untranslatable CSV contents.
- Tested that claiming late orders still works:
  * Table searching and sorting
    Works nicely, but some columns could be split up for better
    searching and sorting:
      * Order date: 20/01/2013 (245 days)
      * Total cost:     10.00x1 = 10.00 Books
        => item type should be separate
      * Basket:  10 MPL
        => Library and basket number could be separate columns
  * Filters
     * Combined various filters, search results look correct.
  * Selecting order for claiming
      * Limiting by vendor makes it possible to check/uncheck all
      * With no vendor limit, entries for other vendors will be
        locked after the first checkbox is checked for one vendor
  * Exporting as CSV
     * Exported single line > CSV appears correct.
     * Exporting multiple lines > CSV appears correct.
     PROBLEM: Translated CSV don't work correctly, as line
     breaks are lost in the translation process.
     Needs to be fixed in a follow-up.
  * Sending serial claim email
     * No regressions found - there are some problems with the
       email contents noted on bug 7298.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7298: (follow-up) make CSV strings translatables.
Jonathan Druart [Tue, 13 Aug 2013 14:21:33 +0000 (16:21 +0200)]
Bug 7298: (follow-up) make CSV strings translatables.

Using a template file, the CSV headers become translatable.

Signed-off-by: sonia <koha@univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7298: (follow-up) fix checkboxes binding on load
Jonathan Druart [Tue, 13 Aug 2013 13:27:38 +0000 (15:27 +0200)]
Bug 7298: (follow-up) fix checkboxes binding on load

Click on checkboxes should be bound on load.

Signed-off-by: sonia <koha@univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7298: (follow-up) fix capitalization and moving supplier id
Katrin Fischer [Sat, 20 Jul 2013 17:52:11 +0000 (19:52 +0200)]
Bug 7298: (follow-up) fix capitalization and moving supplier id

Fixes a few capitalization errors on the late orders page like
- Claim orders
- filter
- Search results

Also moves the supplierid from the order date column to the
vendor column.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: sonia <koha@univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 7298: add option to export late orders as CSV
Jonathan Druart [Fri, 22 Jun 2012 09:10:57 +0000 (11:10 +0200)]
Bug 7298: add option to export late orders as CSV

This patch allows to export late orders as CSV.

Test plan:
- Go on the late orders page (acqui/lateorders.pl)
- Select one or more order and click on the button "Export as CSV".
- The generated file should contains some information on the orders
  (order date, estimated delivery date, vendor name, information field,
  cost, basket name (and basketid), claims count and the claimed date)
  The last line of the file is the total of orders.
- You are not allow to select order from different vendor.
- The check/uncheck all links appears only if a vendor is selected.
- Check that the check/uncheck works for all pages of the table.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: sonia <koha@univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Testing comments on last patch in this series.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: (follow-up) make SearchSubscriptions handle lack of userenv
Galen Charlton [Thu, 31 Oct 2013 15:37:00 +0000 (15:37 +0000)]
Bug 8435: (follow-up) make SearchSubscriptions handle lack of userenv

This patch allows t/db_dependent/Bookseller.t to pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: DBRev 3.13.00.038
Galen Charlton [Thu, 31 Oct 2013 15:26:51 +0000 (15:26 +0000)]
Bug 8435: DBRev 3.13.00.038

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: (follow-up) handle lack of userenv gracefully
Jonathan Druart [Thu, 31 Oct 2013 08:49:12 +0000 (09:49 +0100)]
Bug 8435: (follow-up) handle lack of userenv gracefully

C4::Serials::can_edit_subscription now deals with C4::Context->userenv.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: (follow-up) the unit tests should create the biblio
Jonathan Druart [Wed, 21 Aug 2013 12:23:24 +0000 (14:23 +0200)]
Bug 8435: (follow-up) the unit tests should create the biblio

Previous version does not create the biblio.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: (follow-up) use a transaction for unit tests
Jonathan Druart [Fri, 28 Jun 2013 07:27:39 +0000 (09:27 +0200)]
Bug 8435: (follow-up) use a transaction for unit tests

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: (follow-up) add unit tests for can_edit_subscription
Jonathan Druart [Wed, 27 Mar 2013 15:53:56 +0000 (16:53 +0100)]
Bug 8435: (follow-up) add unit tests for can_edit_subscription

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8435: add permission to enable editing other library's serials if IndependantBran...
Jonathan Druart [Mon, 12 Nov 2012 13:15:42 +0000 (14:15 +0100)]
Bug 8435: add permission to enable editing other library's serials if IndependantBranches is on

In the serial module, we want to hide serials from others libraries.
However, to permit central serials manage, this patch introduces a
new permission, 'superserials'. If a staff member has this permission,
that person can override the restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8037: (follow-up) fix undefined variable warning during template processing
Galen Charlton [Mon, 21 Oct 2013 23:49:01 +0000 (23:49 +0000)]
Bug 8037: (follow-up) fix undefined variable warning during template processing

Fix instances of the following warning appearing in the Apache log:

... parcel.pl: Argument "" isn't numeric in addition (+)

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8037: (follow-up) improve GetBudgetByOrderNumber test
Galen Charlton [Mon, 21 Oct 2013 23:34:46 +0000 (23:34 +0000)]
Bug 8037: (follow-up) improve GetBudgetByOrderNumber test

This patch moves the GetBudgetByOrderNumber() test from
Budgets.t to Acquisition.t, thereby making it easier to
test without doing a direct SQL insert into the aqorders table.

To test:

[1] Verify that prove -v t/db_dependent/Budgets.t passes
[2] Verify that prove -v t/db_dependent/Acquisition.t passes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8037: (follow-up) tweak fund subtotal note
Galen Charlton [Mon, 21 Oct 2013 23:20:39 +0000 (23:20 +0000)]
Bug 8037: (follow-up) tweak fund subtotal note

Use "Tax exc." rather than "GST exc." to be consistent with other parts
of the table footer.  Also remove the new style introduced in the previous
patch; defining non-semantic CSS classes like font-weight-normal is not
desirable.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8037: (follow-up) bad sql query and variable renaming
Jonathan Druart [Fri, 25 Oct 2013 12:27:10 +0000 (14:27 +0200)]
Bug 8037: (follow-up) bad sql query and variable renaming

The first patch does a left join on aqorders_items which returns too
much order lines.

This patch follows the Galen's suggestion: it removes the join and calls
the GetItemnumbersFromOrder routine for retrieving itemnumbers.

Bonus: the "parcelitems" variable is badly named and obfuscates the code.
I changed it for "orders".

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8037: (follow-up) adds the note "GST exc." for subtotals by fund
Kyle M Hall [Wed, 8 May 2013 13:06:17 +0000 (09:06 -0400)]
Bug 8037: (follow-up) adds the note "GST exc." for subtotals by fund

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8037: (follow-up) fix various issues
Kyle M Hall [Fri, 22 Mar 2013 10:35:41 +0000 (03:35 -0700)]
Bug 8037: (follow-up) fix various issues

[1] Add test for GetBudgetByOrderNumber()
[2] Remove unconditional warn.
[3] Remove MySQLism

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 8037: Display holds & fund on the already received table on order receipt summary
Kyle M Hall [Wed, 28 Mar 2012 17:33:36 +0000 (13:33 -0400)]
Bug 8037: Display holds & fund on the already received table on order receipt summary

Adds a column to indicate holds on received items, as well as adding
a new column for fund and showing the subtotals per fund above
the total subtotal.

To test:

[1] Create an order basket containing at least one title and
    ensure that an item is created for that title.  Close the
    basket.
[2] Place a hold on the title.
[3] Receive the order.  After receiving it, but before finishing
    the invoice, the table of already received orders should now
    have columns for the order budget and number of holds on the
    title as well as lines with the subtotal per fund.

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10572: DBrev 3.13.00.037
Galen Charlton [Thu, 31 Oct 2013 14:41:19 +0000 (14:41 +0000)]
Bug 10572: DBrev 3.13.00.037

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10572: (follow-up) ensure SQL for all translations has the phone transport type
Kyle M Hall [Thu, 12 Sep 2013 17:22:23 +0000 (13:22 -0400)]
Bug 10572: (follow-up) ensure SQL for all translations has the phone transport type

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10572: (follow-up) DBrev to ensure presence of phone transport type
Marcel de Rooy [Wed, 7 Aug 2013 12:24:23 +0000 (14:24 +0200)]
Bug 10572: (follow-up) DBrev to ensure presence of phone transport type

Test plan:
Run the updatestructure step of web installer.
Check if you have a phone message_transport_type.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 10572: Add phone to message_transport_types table for new installs
Marcel de Rooy [Thu, 11 Jul 2013 08:01:16 +0000 (10:01 +0200)]
Bug 10572: Add phone to message_transport_types table for new installs

In connection to bug 4246, commit 591bae324 added
phone to the message_transport_types table in updatedatabase.pl

This should be done also for new installs via the .sql files of the web
installer.

I am adding it only to English now, basing this change upon the work in
reports 10509 and 10520. (I discovered this tiny omission there too.)

Test plan:
Apply patches 10509/10520.
Run new install or run this particular sql file from command line.
Note: If you only run this particular file, you do not need patch 10509.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11135: (follow-up) improve testing of OVERRIDE_SYSPREF_NAMES
Galen Charlton [Thu, 31 Oct 2013 14:21:25 +0000 (14:21 +0000)]
Bug 11135: (follow-up) improve testing of OVERRIDE_SYSPREF_NAMES

This is a bit pedantic -- since for obvious reasons, I can't
see us ever letting '0' be the name of a system preference,
and I suspect it's impossible for the value of something in the
$ENV hash to be undefined -- but better to test for exactly what
we mean.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11135: avoid logging warnings if OVERRIDE_SYSPREF_NAME is not set
Colin Campbell [Thu, 24 Oct 2013 16:00:23 +0000 (17:00 +0100)]
Bug 11135: avoid logging warnings if OVERRIDE_SYSPREF_NAME is not set

Calling split on an undefined var generates warning to
the log. Let's check it exists before processing it

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 11134 - Typo on course reserves help
Bernardo Gonzalez Kriegel [Thu, 24 Oct 2013 15:32:26 +0000 (12:32 -0300)]
Bug 11134 - Typo on course reserves help

This patch fixes a small typo on course reserves help

To test:
1) Go to Course reserves
2) Press 'New course'
3) Press Help
4) On 3dr paragraph you will read "To link a ninstructor ..."
5) Apply patch
6) Now it reads "To link an instructor ..."

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
6 years agoBug 9456: (follow-up) use datatables.inc
Galen Charlton [Thu, 31 Oct 2013 05:54:26 +0000 (05:54 +0000)]
Bug 9456: (follow-up) use datatables.inc

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9456: (follow-up) remove whitespaces and tab
Jonathan Druart [Fri, 16 Aug 2013 07:28:40 +0000 (09:28 +0200)]
Bug 9456: (follow-up) remove whitespaces and tab

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9456: (follow-up) sort on callnumber only
Kyle M Hall [Mon, 22 Jul 2013 11:43:13 +0000 (07:43 -0400)]
Bug 9456: (follow-up) sort on callnumber only

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9456: (follow-up) Remove useless CSS
Kyle M Hall [Tue, 18 Jun 2013 15:08:32 +0000 (11:08 -0400)]
Bug 9456: (follow-up) Remove useless CSS

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9456: (follow-up) move sort filters to datatables.js
Kyle M Hall [Tue, 7 May 2013 16:24:56 +0000 (12:24 -0400)]
Bug 9456: (follow-up) move sort filters to datatables.js

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9456: (follow-up) add tooltip
Kyle M Hall [Thu, 7 Mar 2013 15:49:53 +0000 (10:49 -0500)]
Bug 9456: (follow-up) add tooltip

Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9456 - Add callnumber column to the cart
Kyle M Hall [Fri, 25 Jan 2013 14:57:30 +0000 (09:57 -0500)]
Bug 9456 - Add callnumber column to the cart

This patch adds call-number sorting to the staff client cart. Sortining is enabled
on the 'Items' column which uses a custom sorting routine to sort the callnumbers.
If the sort is ascending, each column will be sorted by the highest ordered
callnumber for that row. Likewise, if the sort is descending the table will be
sorted by the lowest valued callnumber for that row.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9044: (follow-up) restore the toolbar menu items
Galen Charlton [Thu, 31 Oct 2013 05:22:45 +0000 (05:22 +0000)]
Bug 9044: (follow-up) restore the toolbar menu items

This patch adds the following items back to the cataloging
toolbar:

- Edit items in batch
- Delete items in a batch

My rationale: the question of the best UI for selecting items for
batch operations is not yet settled.  Adding the ability to select
items from the bib details page is indeed useful, but as currently
implemented, it can hide the availability of the batch
edit/deletion operations if no item is yet selected.  Although
having both the toolbar items and the links that display when an
item is selected is a bit redundant, for now I think we can live
with that until we get more eyes on the UI.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9044: DBRev 3.13.00.036
Galen Charlton [Thu, 31 Oct 2013 05:15:06 +0000 (05:15 +0000)]
Bug 9044: DBRev 3.13.00.036

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9044: (follow-up) set the number of filters according to number of columns
Julian Maurice [Mon, 30 Sep 2013 07:02:30 +0000 (09:02 +0200)]
Bug 9044: (follow-up) set the number of filters according to number of columns

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Filters now shows correctly. No errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
This feature is a little controversial as it removes
the batch edit/delete options from the menu and moves them
to the item table, additionally controlled by a system
preference. Maybe later on, we can think about the UI a bit
more, but it works nicely.

Tested with.
- SeparateHoldings and SeparateHoldingsBranch activated/deactivated.
- Search filters.
- None, both, or one of the permissions.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9044: (follow-up) change dropdown list into links list
Julian Maurice [Tue, 2 Jul 2013 14:05:20 +0000 (14:05 +0000)]
Bug 9044: (follow-up) change dropdown list into links list

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
That's the one I sign.

Comment: At first I don't know where to find links, until
I selected an item.
Works as described. No koha-qa errors.

Solved merge conflict on updatedatabase.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoBug 9044: QA followup
Jonathan Druart [Mon, 17 Jun 2013 10:11:27 +0000 (12:11 +0200)]
Bug 9044: QA followup

1/ Remove filter and sort for the checkboxes column.
2/ Enable the pref by default.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>