Nahuel ANGELINETTI [Wed, 25 Mar 2009 16:34:31 +0000 (17:34 +0100)]
(bug #3058) show items that are excluded of loan in search results
This patchs show all items that are available for reading to the library but excluded of loan.
And don't show them as same way as "damaged" or other "not for loan" status.
Nahuel ANGELINETTI [Wed, 25 Mar 2009 15:08:48 +0000 (16:08 +0100)]
(bug #3057) mandatory subfield edition
modify the "name" of mandatory input field.
Nahuel ANGELINETTI [Mon, 23 Mar 2009 16:14:30 +0000 (17:14 +0100)]
(bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD view
this patch extract the generator of ISBD view in a C4 function, because it's used in intranet AND in OPAC but with 2 separate codes.
Now it's more reusable.
Nahuel ANGELINETTI [Mon, 23 Mar 2009 12:00:03 +0000 (13:00 +0100)]
(bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.
Nahuel ANGELINETTI [Tue, 10 Mar 2009 14:24:47 +0000 (15:24 +0100)]
(bug #3025) multiple check-in of a multiple times reserved item go wrong
This patch check that an item is not "Waiting" before do something in GetOtherReserves(because is the item is waiting, we don't need to do something).
Nahuel ANGELINETTI [Fri, 6 Mar 2009 11:24:29 +0000 (12:24 +0100)]
(bug #3011) csv export doesn't fill all the fields
This patch just fix the script which export to csv the overdue, and field the missing fields
Nahuel ANGELINETTI [Tue, 3 Feb 2009 08:45:48 +0000 (09:45 +0100)]
(bug #2939) delete a warning
just add a default value to $sep
Nahuel ANGELINETTI [Fri, 30 Jan 2009 16:17:12 +0000 (17:17 +0100)]
(bug #2938) add a serials subscriptions report
this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:32:14 +0000 (10:32 +0100)]
(bug #2908) adding send shelf by e-mail feature
This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.
David Birmingham [Thu, 30 Apr 2009 16:54:48 +0000 (12:54 -0400)]
Bug fix to OPAC shelf browsing query statement
If the items.location field was NULL, then the current
SQL query would produce no results. I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.
In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open. This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Fri, 1 May 2009 21:39:25 +0000 (09:39 +1200)]
Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Fri, 1 May 2009 01:54:31 +0000 (21:54 -0400)]
Bug #2974 Adding category code to BorrowerMandatoryField produced a "The following fields are mandatory: categorycode"
If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element. The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank. Added code to check for an empty string in the first
element.
You can test this by making salutation (title) mandatory.
Also fixed some typos in some of the comments. Why? Because I'm a Librarian.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 30 Apr 2009 09:36:52 +0000 (11:36 +0200)]
(bug #3174) fill borrower number, and show author and creation date in saved reports
This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 29 Apr 2009 21:51:11 +0000 (16:51 -0500)]
new author test for syntax errors in HTML templates
Added a new author test to look for syntax errors
in the HTML templates. Run by doing
prove xt/author/valid-templates.t
from the root of a Koha source tree.
This test will help catch the following errors:
* unbalanced TMPL_IF, TMPL_UNLESS, and TMPL_LOOP contructs, e.g.,
cases where a TMPL_IF is not closed by a /TMPL_IF.
* references to nonexistant include files
* syntax errors within a HTML::Template::Pro tag
This test currently ignores errors related to TMPL_IF EXPR, which
is currently deprecated for use in Koha -- this may be made
stricter in the future.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 1 May 2009 21:17:26 +0000 (16:17 -0500)]
fix XHTML validation error introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jane Wagner [Wed, 29 Apr 2009 18:14:56 +0000 (14:14 -0400)]
Enhancements/fixes for OPAC advanced search screen
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.
Added Publication Date Range search to advanced search screen
Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).
Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 30 Apr 2009 17:15:12 +0000 (12:15 -0500)]
Remove unused $toggle code
Some trivial other cleanups also.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Thu, 30 Apr 2009 21:41:08 +0000 (09:41 +1200)]
Adding the creation of sql library on the wiki
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Fri, 1 May 2009 08:32:27 +0000 (09:32 +0100)]
Correct comparison which was using an octal number
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Thu, 30 Apr 2009 03:33:13 +0000 (15:33 +1200)]
Adding Liz Rea to the history.txt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 30 Apr 2009 18:06:24 +0000 (13:06 -0500)]
fix to C4::Koha::_isbn_cleanup
Both valid ISBN-10s and -13s can use 'X' as a checkdigit
value.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
root [Thu, 30 Apr 2009 16:42:23 +0000 (11:42 -0500)]
Verbiage clarification in intranet advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Liz Rea [Thu, 30 Apr 2009 16:30:26 +0000 (11:30 -0500)]
Libraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Wed, 29 Apr 2009 21:52:13 +0000 (09:52 +1200)]
Whoops I typo'd Garry's name - fixed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
root [Wed, 29 Apr 2009 18:14:45 +0000 (13:14 -0500)]
Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Wed, 29 Apr 2009 20:24:19 +0000 (08:24 +1200)]
Updating history docs for new developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Liz Rea [Wed, 29 Apr 2009 16:22:53 +0000 (11:22 -0500)]
Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Tue, 28 Apr 2009 20:16:31 +0000 (14:16 -0600)]
OPAC Advanced Search - have user's branch selected by default
If SearchMyLibraryFirst is on, and the user is logged in, then have
their branch selected in the Location And Availability drop-down.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Tue, 28 Apr 2009 20:24:17 +0000 (14:24 -0600)]
Checkout page - Check Out's table sortable on barcode
Add the barcode column of the Check Out's table to the tablesorter
setup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 29 Apr 2009 02:55:21 +0000 (22:55 -0400)]
minPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorrect reference MinPasswordLength fixed. Could not find bug report.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 28 Apr 2009 17:08:31 +0000 (12:08 -0500)]
Bug 3126: remove comma for IE7
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Tue, 28 Apr 2009 23:32:27 +0000 (11:32 +1200)]
Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jane Wagner [Tue, 28 Apr 2009 12:01:25 +0000 (08:01 -0400)]
Bugs 2822, 2551, 3163 fixes to XSLT
Resent with additional comments.
Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music. Modified record display to use Sound.
Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource. Changed the record display page
to also use Continuing Resource.
Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display. Modified the utils file
to force a space.
The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png). Also, corrected spelling of icon name
from pencile.png to pencil.png.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Tue, 28 Apr 2009 13:58:05 +0000 (08:58 -0500)]
fix DOS newlines in MARC21slimUtils.xsl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:14:27 +0000 (15:14 +0100)]
(bug #2750) Cannot return to another branch if the independantbranch option is set as ON
The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 27 Apr 2009 15:13:08 +0000 (17:13 +0200)]
(bug #2961) change the workflow of the new issue
This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as "late"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 27 Apr 2009 15:31:03 +0000 (10:31 -0500)]
bug 2915 followup - small efficiency improvement
Following up on a suggestion by Joe Atzberger, save
a database query by not counting the subscriptions
to delete; instead, simply fetch a list of them.
No user-visible change.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 23 Oct 2008 20:56:22 +0000 (15:56 -0500)]
Followup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".
updatedatabase change deferred for now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 13 Oct 2008 16:46:14 +0000 (11:46 -0500)]
Correct iso639_2_code for Spanish is "spa" not "rus".
The result of this apparent copy/paste error is that adv. search
limits by Language=Spanish would return results for Russian!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 24 Apr 2009 22:31:53 +0000 (17:31 -0500)]
Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sun, 26 Apr 2009 16:45:24 +0000 (11:45 -0500)]
bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.
Changed so that <div> for the language chooser is output
only if there is more than one enabled language.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Mon, 27 Apr 2009 00:17:21 +0000 (12:17 +1200)]
Whoops missed Brendan's commit, fixed the history now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sun, 26 Apr 2009 15:23:55 +0000 (10:23 -0500)]
bug 2505: fix more warnings in opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sat, 25 Apr 2009 04:49:48 +0000 (16:49 +1200)]
Bug 2505 Adding use warnings, and fixing the warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sun, 26 Apr 2009 14:48:42 +0000 (09:48 -0500)]
fix warning in C4::AuthoritiesMarc::merge()
"my" variable @X masks earlier declaration in same scope at C4/AuthoritiesMarc.pm line 1200
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sun, 26 Apr 2009 14:48:41 +0000 (09:48 -0500)]
improved POD for C4::Serials::HasSubscriptionExpired()
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Thu, 20 Nov 2008 18:08:40 +0000 (11:08 -0700)]
Add items.itemnotes to the Notes/Comments search in Marc21
This uncomments the 952$z and assigns it to the Notes index in
marc21
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Ryan Higgins [Wed, 12 Nov 2008 03:31:34 +0000 (22:31 -0500)]
Bug 2776 : emailPurchaseSuggestions syspref deprecated
This patch removes the system preference from new installations.
No db revision is supplied to remove the system pref from existing installations.
It is recommended for administrators to use the scripts provided in the misc/ directory
to ensure that their system preferences are in sync with those used in code.
Admins should remove this preference from existing installations manually.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Sat, 25 Apr 2009 01:18:58 +0000 (13:18 +1200)]
BUG-3160: fixes 'itemlost' check on item return.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 25 Apr 2009 01:35:52 +0000 (20:35 -0500)]
fix XHTML error - duplicate tabindex
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Fri, 24 Apr 2009 20:11:02 +0000 (08:11 +1200)]
New developer for history.txt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 25 Apr 2009 00:46:36 +0000 (19:46 -0500)]
bug 3159: allow editing child patron that has no valid guarantor
If a patron with a child patron category is not linked
to a guarantor (or a valid one), it was not possible to edit
the child patron's record. When attempt, no changes were saved
and the following error is recorded in the Apache error log:
memberentry.pl: DBD::mysql::st execute failed: Cannot add or
update a child row: a foreign key constraint
fails (`gmc_koha/borrowers`, CONSTRAINT `borrowers_ibfk_2`
FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) ...
This patch fixes this bug, allowing a child patron record to be
edited even if it has no guarantor.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 24 Apr 2009 17:30:19 +0000 (12:30 -0500)]
Make js prompts translatable using _("...") and comment out unused vars.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Brian Harrington [Fri, 24 Apr 2009 18:39:54 +0000 (14:39 -0400)]
Revisions to auto-generated authorities patch
It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl. I
also realized I can't count. :-)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 19 Sep 2008 00:02:46 +0000 (19:02 -0500)]
Cleanup and tighten Letters module.
Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 24 Apr 2009 14:57:24 +0000 (09:57 -0500)]
bug 2505 followup: restored correct item type image display
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Andrew Moore [Wed, 17 Dec 2008 22:32:25 +0000 (16:32 -0600)]
Bug 2505: adding warnings to opac-detail.pl
Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frederic Demians [Wed, 21 Jan 2009 12:28:34 +0000 (13:28 +0100)]
Modify GoogleJacket display
On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.
This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Andrew Moore [Wed, 17 Dec 2008 22:30:46 +0000 (16:30 -0600)]
refactor: removing a few unnecessary loops and moving HTML out of script into template
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jane Wagner [Fri, 24 Apr 2009 12:33:50 +0000 (08:33 -0400)]
Bug 3152 OPAC reading history column headers don't line up with text
Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 23 Apr 2009 22:23:24 +0000 (17:23 -0500)]
Bug 3128 - followup and correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 22 Apr 2009 21:16:56 +0000 (16:16 -0500)]
Bug 3128: IE7 tweak
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Thu, 23 Apr 2009 21:59:17 +0000 (09:59 +1200)]
New Developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
John Beppu [Thu, 23 Apr 2009 19:35:53 +0000 (14:35 -0500)]
bug 1546 - replacing REPLACE statements
replaced REPLACE statements with a pair of INSERT and UPDATE statements.
Hopefully, these are the last ones.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 22 Apr 2009 20:22:38 +0000 (15:22 -0500)]
Bug 3118: Remove comment that perturbs IE
Formatting bugs not fixed. Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected. Go figure.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Wed, 22 Apr 2009 23:33:41 +0000 (11:33 +1200)]
Adding the dev weekend and another developer to the history docs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 22 Apr 2009 18:24:34 +0000 (13:24 -0500)]
IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.
Column selection improved with jquery and submit time check.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Wed, 22 Apr 2009 23:33:40 +0000 (11:33 +1200)]
Typo in history docs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Mon, 20 Apr 2009 18:25:01 +0000 (13:25 -0500)]
Fix for Bug 3119: Add due date to the patron circulation history window
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Tue, 21 Apr 2009 20:19:42 +0000 (15:19 -0500)]
Fix for Bug 1877, Link to patron record from manage suggestions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Brian Harrington [Tue, 21 Apr 2009 16:13:22 +0000 (12:13 -0400)]
Patch to improve auto-generated MARC21 authorities
This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040. If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Brendan A. Gallagher [Sat, 18 Apr 2009 21:15:01 +0000 (17:15 -0400)]
Bug #3101 - Changed the Print and Confirm button
Changed button to read "Print slip, Transfer and Confirm"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 20 Apr 2009 17:13:41 +0000 (12:13 -0500)]
fix to previous patch - use 'lt', not '<', to compare date strings
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 20 Apr 2009 17:00:15 +0000 (12:00 -0500)]
Visual alert (red) on overdue return.
This was requested by a Koha user at KohaCon09.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Cory Jaeger [Mon, 20 Apr 2009 16:57:56 +0000 (11:57 -0500)]
Bug 2847 - Added url escaping for categorie.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Cory Jaeger [Sun, 19 Apr 2009 22:41:55 +0000 (17:41 -0500)]
Bug 2847 - Fix html escaping in categorie.tmpl (more needed)
Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Sun, 19 Apr 2009 15:46:16 +0000 (10:46 -0500)]
Fix Bug #2925
This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.
In addition I have made it so that the Date Received
only shows if the item is 'Available'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sun, 19 Apr 2009 14:00:05 +0000 (02:00 +1200)]
Fixing xhtml errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Sun, 19 Apr 2009 13:42:04 +0000 (08:42 -0500)]
Partial fix for Bug #3139
Standardized all references to Address and Zip/Postal Code.
Also fixed bug #3138 by making the Alt address ready City, State.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Brendan A. Gallagher [Sat, 18 Apr 2009 23:15:47 +0000 (19:15 -0400)]
Modification on Bug # 3102 - "Location" instead of "Localization"
This a change to previous patch for Bug #3102 (That has been pushed to head).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 23:37:32 +0000 (01:37 +0200)]
fir for #2338
When I go to serials/claims.pl, "All Suppliers (2)" is selected in the supplier
dropdown list, and no missing issues are listed. When I choose another supplier
from that list ("Supplier 1 (2)"), then two missing issues are listed. Should
"All Suppliers" instead read "Choose a Supplier" ?
chris: I think it might be safe to remove the all suppliers option all together as its
doing nothing
paul: agreed, this patch removes the All Supplier line, that is useless, confusing & untranslatable
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 23:24:05 +0000 (01:24 +0200)]
fix for 2336
When you put a library in a group it doesn't show on the details list. The
details list has a properties column that maybe is supposed to be used for this
since there doesn't appear to be any other use for it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 23:04:23 +0000 (01:04 +0200)]
fix for #1731
The "place hold" button is hidden in detail.pl when there are no items or the
items are not for loan. MARC detail should do the same.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 21:46:24 +0000 (23:46 +0200)]
Fix for 2363
There is a comma at the beginning that shouldn't be there and then there are
commas in the vol, no combo making it hard to read. it should be something
like this:
Vol 28, No 7; Vol 28, No 8; Vol 28, No 9
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sat, 18 Apr 2009 21:44:29 +0000 (09:44 +1200)]
New developer added to the history
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sat, 18 Apr 2009 21:44:30 +0000 (09:44 +1200)]
Update for bug 1545 allowing for the title to be edited
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Brendan A. Gallagher [Sat, 18 Apr 2009 20:42:30 +0000 (16:42 -0400)]
Change typo Localisation to Localization for Bug # 3102
[RM note: I think there are a few people who wouldn't
call "localisation" a typo - such as our UK, NZ,
Australian, etc. contributors ;-) ]. That said,
I'm pushing this patch to consistent with the
general trend of the English varient used on the
/prog/ templates. There's no implication that en_US
is the "correct" version of the language.]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 21:01:01 +0000 (23:01 +0200)]
fix for #946
A member returns a book : it would be better to see the category of this member
in "information member" near his name.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Sat, 18 Apr 2009 20:21:21 +0000 (15:21 -0500)]
Added Koha 3 Manual Release
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Sat, 18 Apr 2009 19:58:32 +0000 (21:58 +0200)]
Repair the old repairmissingbiblionumbers script
This patch refound all the script which fix all records without any biblionumber.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jane Wagner [Sat, 18 Apr 2009 19:53:04 +0000 (15:53 -0400)]
Bug 3013 Fix for 007 value builder to include all material types
Delivered version only had Text material type; this patch includes
all 14 material types with appropriate values for each.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sat, 18 Apr 2009 17:59:55 +0000 (05:59 +1200)]
Allowing users to edit saved sql in guided reports. Bug 1545
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 19:32:43 +0000 (21:32 +0200)]
fix for #908
In an list of autorised values (Parameters >autotised values), if you delete an
autorised value after confirm, you go back to the first page of the list, and
you must return manually to the page you left before.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 19:34:40 +0000 (21:34 +0200)]
fix for #918
In authorities, you can create frameworks like for biblio.
But in these it's impossible to delete useless fields, because when you click on
delete button, you go back to the default framework.
SO if you confirm your deletion, it delete your field in the default framework
and so in all the framwork (I think...).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 18 Apr 2009 19:42:10 +0000 (14:42 -0500)]
Bug 3132: Reformatting guarantor entry based on C vs. P patron types
Professional patrons might have Organizations as guarantors, so display the guarantor entry form with a single line labelled appropriately. For Child patrons display the form fields as before.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Sat, 18 Apr 2009 17:43:06 +0000 (12:43 -0500)]
Bug 3133 - correct typos
This corrects 3 typographical errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 18 Apr 2009 17:12:06 +0000 (12:12 -0500)]
followup to 3004 - fix typo
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 18 Apr 2009 16:21:43 +0000 (11:21 -0500)]
Removing duplicate email form field. Fixes Bug 3010.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 18 Apr 2009 15:39:41 +0000 (10:39 -0500)]
remove last reference to deprecated syspref noOPACUserLogin
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 9 Apr 2009 14:55:41 +0000 (09:55 -0500)]
bug 2958: fix search results navigation for CCL, CQL, and PQF queries
The shortcut to build $query_cgi in C4::Search::buildQuery()
for CCL, CQL, and PQF queries is incorrect, as (for now)
the "q=" prefix is required.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
projects / koha.git / log