Dobrica Pavlinusic [Sat, 7 Apr 2012 21:26:32 +0000 (23:26 +0200)]
added combine.script( cdata => 'code()' ) and html( prefix => '/path'
Dobrica Pavlinusic [Sat, 7 Apr 2012 17:34:51 +0000 (19:34 +0200)]
die on css @import
Dobrica Pavlinusic [Sat, 7 Apr 2012 17:31:09 +0000 (19:31 +0200)]
removed @import from staff-global.css
Dobrica Pavlinusic [Sat, 7 Apr 2012 17:04:10 +0000 (19:04 +0200)]
combine javascript and css, always re-create with PLACK_DEBUG=1
Dobrica Pavlinusic [Sat, 7 Apr 2012 14:39:04 +0000 (16:39 +0200)]
remplaced javascript and css html with combine plugin
Dobrica Pavlinusic [Fri, 6 Apr 2012 17:00:58 +0000 (19:00 +0200)]
move evals to global our so we can modify it
Dobrica Pavlinusic [Fri, 6 Apr 2012 17:00:44 +0000 (19:00 +0200)]
plack - added DBD::Gofer example
Dobrica Pavlinusic [Fri, 6 Apr 2012 17:00:06 +0000 (19:00 +0200)]
GetMarcFromKohaField would benefit from memoize
Dobrica Pavlinusic [Fri, 6 Apr 2012 16:59:43 +0000 (18:59 +0200)]
plack - fix -E deployment
Dobrica Pavlinusic [Thu, 5 Apr 2012 16:34:16 +0000 (18:34 +0200)]
Bug 7872 - C4::Items GetItemStatus
Dobrica Pavlinusic [Thu, 5 Apr 2012 14:43:01 +0000 (16:43 +0200)]
Revert "use Koha::Persistant authorised_value"
This reverts commit
6cd524f99b1bbc03eb1ad7110b0b97016569387d.
Conflicts:
C4/Items.pm
Koha/Persistant.pm
Dobrica Pavlinusic [Thu, 5 Apr 2012 14:19:49 +0000 (16:19 +0200)]
Revert "marc_subfield_structure"
Code similar to this is already provided in C4::Koha, see Bug 7872
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872
This reverts commit
70a414d93bd0ae309e9d6097ea87a17e3341fe3c.
Conflicts:
C4/Items.pm
Koha/Persistant.pm
Dobrica Pavlinusic [Thu, 5 Apr 2012 12:15:30 +0000 (14:15 +0200)]
Bug 7857 - invalidate cached preferences after SetVersion
This allows plack to correctly move to login page after database upgrade
Dobrica Pavlinusic [Thu, 5 Apr 2012 12:08:29 +0000 (14:08 +0200)]
plackup - we need installer dir among perl includes
Could not compile /srv/koha/installer/install.pl: Can't locate InstallAuth.pm in @INC (@INC contains: ./lib /srv/koha /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 .) at /srv/koha/installer/install.pl line 7.
BEGIN failed--compilation aborted at /srv/koha/installer/install.pl line 7.
Dobrica Pavlinusic [Tue, 3 Apr 2012 21:59:33 +0000 (23:59 +0200)]
final cleanup of plack code
used in demo videos
Dobrica Pavlinusic [Tue, 3 Apr 2012 21:03:14 +0000 (23:03 +0200)]
Bug 7844 - README
Dobrica Pavlinusic [Tue, 3 Apr 2012 20:51:35 +0000 (22:51 +0200)]
drop Linux caches
This helps when re-running benchmarks
Dobrica Pavlinusic [Thu, 29 Mar 2012 10:27:05 +0000 (12:27 +0200)]
Bug 7844 - plack intranet tooling for developers
koha.psgi example and plackup.sh script to run any Koha site
intranet or opac interface under plack with optional multi-process
Starman server
plackup.sh site-name [intranet]
site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml
All configuration is specified in koha.psgi, which you are welcomed to edit
and tune according to your development needs.
When you are happy with it, rename it to site name and save it for safe-keeping.
Test scenario:
1. install plack and dependencies, using ./cpanm-install.pl
2. start ./plackup.sh sitename
3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl
and verify that it works
4. start ./plackup.sh sitename i[ntranet]
5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl
and verify that it works
Dobrica Pavlinusic [Tue, 3 Apr 2012 18:14:32 +0000 (20:14 +0200)]
rename script to unify plackup start script
Dobrica Pavlinusic [Mon, 2 Apr 2012 23:55:07 +0000 (01:55 +0200)]
enviroment config must be at top of file
Dobrica Pavlinusic [Mon, 2 Apr 2012 23:55:00 +0000 (01:55 +0200)]
run opac under Starman
Dobrica Pavlinusic [Mon, 2 Apr 2012 22:16:33 +0000 (00:16 +0200)]
use PROFILE_PER_PAGE for correct CGI-like stats
If you set this to 0, you will get statistics for whole lifetime of plack process,
making all numbers increase with each page load which makes them hard to compare when
benchmarking
Dobrica Pavlinusic [Mon, 2 Apr 2012 21:58:19 +0000 (23:58 +0200)]
added Plack::Middleware::Profiler::NYTProf and use symlinks
Dobrica Pavlinusic [Mon, 2 Apr 2012 20:48:18 +0000 (22:48 +0200)]
cache FETCH in memory to demonstrate preformance improvement
Dobrica Pavlinusic [Mon, 2 Apr 2012 20:47:37 +0000 (22:47 +0200)]
local copy of Memoize::Memcached
Dobrica Pavlinusic [Mon, 2 Apr 2012 19:17:45 +0000 (21:17 +0200)]
annotate select * from itemtypes with -- sql comment
This allows to see SQL queries in DBI Profile plack panel
I checked, DBI::Profile doesn't have notion on where query
came from other than filename, because it would be great to
have source file and line number automatically, but we
don't have it (yet :-)
Dobrica Pavlinusic [Mon, 2 Apr 2012 19:15:08 +0000 (21:15 +0200)]
move our panels to top, run only low-impact debug
Dobrica Pavlinusic [Mon, 2 Apr 2012 19:15:01 +0000 (21:15 +0200)]
plack enable memcached
Dobrica Pavlinusic [Mon, 2 Apr 2012 19:02:59 +0000 (21:02 +0200)]
remove debug output
Dobrica Pavlinusic [Mon, 2 Apr 2012 18:43:36 +0000 (20:43 +0200)]
Plack Koha panel to eval code and display result
This is useful to introspect current instance sense of various configuration values
Dobrica Pavlinusic [Mon, 2 Apr 2012 18:37:35 +0000 (20:37 +0200)]
fix MEMCACHED_DEBUG
Dobrica Pavlinusic [Mon, 2 Apr 2012 18:36:57 +0000 (20:36 +0200)]
Koha::Persist - emit debug output according to DEBUG=2 level
Dobrica Pavlinusic [Mon, 2 Apr 2012 17:59:08 +0000 (19:59 +0200)]
Bug 7177 - memoize GetItemTypes
echo 'select count(*) from itemtypes' | mysql koha_srvgit
count(*)
12
Profile Path: select * from itemtypes where itemtype=?
Profile Data: 0.021141s / 504 = 0.000042s avg (first 0.000048s, min 0.000015s, max 0.000097s)
504 >> 12
Dobrica Pavlinusic [Mon, 2 Apr 2012 17:41:14 +0000 (19:41 +0200)]
collect $Koha::Persistant::stats for existing code
Dobrica Pavlinusic [Mon, 2 Apr 2012 17:33:34 +0000 (19:33 +0200)]
drop Linux cache using sudo
Dobrica Pavlinusic [Mon, 2 Apr 2012 15:58:52 +0000 (17:58 +0200)]
Plack::Middleware::Debug::Persistant to view Koha::Persistant stats
Dobrica Pavlinusic [Mon, 2 Apr 2012 15:25:55 +0000 (17:25 +0200)]
marc_subfield_structure
Dobrica Pavlinusic [Mon, 2 Apr 2012 13:32:18 +0000 (15:32 +0200)]
use Koha::Persistant authorised_value
Dobrica Pavlinusic [Mon, 2 Apr 2012 13:31:29 +0000 (15:31 +0200)]
plack reload Koha modules
Dobrica Pavlinusic [Mon, 2 Apr 2012 00:14:41 +0000 (02:14 +0200)]
multi-dimensional cache using evals
Dobrica Pavlinusic [Sun, 1 Apr 2012 23:18:43 +0000 (01:18 +0200)]
Koha::Persistant authorised_values
Dobrica Pavlinusic [Sun, 1 Apr 2012 19:28:07 +0000 (21:28 +0200)]
update Plack::Middleware::Debug::Devel::Size to latest
Dobrica Pavlinusic [Sun, 1 Apr 2012 14:40:22 +0000 (16:40 +0200)]
added Plack::Middleware::Debug::Devel::Size
Dobrica Pavlinusic [Sun, 1 Apr 2012 13:20:41 +0000 (15:20 +0200)]
MEMCACHE_DEBUG added
Dobrica Pavlinusic [Sat, 31 Mar 2012 22:12:38 +0000 (00:12 +0200)]
7863 test scenario
Dobrica Pavlinusic [Sat, 31 Mar 2012 21:15:31 +0000 (23:15 +0200)]
plackup reload opac and modules
Dobrica Pavlinusic [Sat, 31 Mar 2012 00:09:07 +0000 (02:09 +0200)]
Bug 7844 - sudo with xmlstarlet
Dobrica Pavlinusic [Fri, 30 Mar 2012 20:45:07 +0000 (22:45 +0200)]
Bug 7857 - remove exit 1 for plack
Chris Cormack [Fri, 30 Mar 2012 20:33:51 +0000 (22:33 +0200)]
from http://wiki.koha-community.org/wiki/Plack
Dobrica Pavlinusic [Fri, 30 Mar 2012 20:03:20 +0000 (22:03 +0200)]
Bug 7857 - database upgrade fails with plack
Updating database structure
Update errors :
Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 .) at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.
BEGIN failed--compilation aborted at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.
It seems that plack cleans enviroment, so we have to re-instart PERL5LIB
so script invocation won't fail.
Dobrica Pavlinusic [Fri, 30 Mar 2012 19:32:21 +0000 (21:32 +0200)]
koha installers needs it's directory
Dobrica Pavlinusic [Thu, 29 Mar 2012 15:56:12 +0000 (17:56 +0200)]
Bug 7847 - OPAC search dies with plack
This bug was uncovered by @mglavica during HackFest in Marseille
It also showed it's ugly head during my plack presentation
Dobrica Pavlinusic [Thu, 29 Mar 2012 10:27:05 +0000 (12:27 +0200)]
Bug 7844 - plack intranet tooling for developers
koha.psgi example and script to run any Koha site intranet or opac under plack
It also defines new enviroment variables:
PLACK_DEBUG=1 - turn Plack debug panels on
PLACK_MINIFY=1 - minify JavaScript and CSS which saves us ~10k on each page load
Test scenario:
1. install plack and dependencies, using ./cpanm-install.pl
2. start ./intranet-plack.sh sitename
3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl
and verify that it works
4. start ./opac-plack.sh sitename
5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl
and very that it works
Chris Cormack [Mon, 21 May 2012 08:06:36 +0000 (20:06 +1200)]
Bug 4330 : Adding copyright headers and fixing FSF addresses
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 23:03:21 +0000 (11:03 +1200)]
Bug 4330 : Fixing FSF address and copyright headers for acqui/
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:45:50 +0000 (22:45 +1200)]
Bug 4330 : Last of the opac files with wrong FSF address
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:30:41 +0000 (22:30 +1200)]
Bug 4330 : Adding missing license statement
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:27:29 +0000 (22:27 +1200)]
Bug 4330 Fixing FSF statements
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:14:04 +0000 (22:14 +1200)]
Bug 4330 : Fixing FSF address and copyright statements
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 09:55:55 +0000 (21:55 +1200)]
Bug 4330 : Fixing FSF address and copyright headers
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Thu, 24 May 2012 14:17:31 +0000 (10:17 -0400)]
Bug 7127 - Templates must be valid XHTML
Fixing markup errors on OPAC detail page and OPAC results.
Also conditionally including ratings JS on OPAC detail.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Paul Poulain [Mon, 28 May 2012 15:36:32 +0000 (17:36 +0200)]
Bug 8144 - 775 tag in the MARC record causes display issue
Fixing XSL template in the OPAC and staff client following
recommendations by Jared.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Fixes the markup and correctly displays 775 notes.
Mason James [Wed, 23 May 2012 20:17:07 +0000 (08:17 +1200)]
Bug 8145 - [SIGNED-OFF] opac-tags.pl fails when DEBUG is set
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 28 May 2012 14:35:53 +0000 (16:35 +0200)]
Merge remote-tracking branch 'origin/new/bug_6858'
Matthias Meusburger [Wed, 23 Mar 2011 15:19:07 +0000 (16:19 +0100)]
Bug 6858: Adds staticfines.pl for static fines processing
Add a tool to calculate static fine. For example, 7 days left = 1€ fixed fine
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Paul Poulain [Mon, 28 May 2012 14:28:23 +0000 (16:28 +0200)]
Merge remote-tracking branch 'origin/new/bug_8150'
Colin Campbell [Thu, 24 May 2012 16:09:08 +0000 (17:09 +0100)]
Bug 8150 [SIGNED-OFF] Remove obsoleted navigation bar in circ history
The navigation bar is now supplied by the datatables plugin
however we are still calling the old navigation include
resulting in a second navigation bar which does nor work
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised, without introducing any bad side effects that
I can see.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 13 Apr 2012 19:21:49 +0000 (15:21 -0400)]
Bug 7959 - Update OPAC suggestions interface to match lists
Marking up suggestions "toolbar" to match the interface in
lists. Actions which require an item to be selected (deleting
a suggestion) should not be available if nothing is selected.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 13 Apr 2012 19:21:49 +0000 (15:21 -0400)]
Bug 7959 - Update OPAC suggestions interface to match lists
Marking up suggestions "toolbar" to match the interface in
lists. Actions which require an item to be selected (deleting
a suggestion) should not be available if nothing is selected.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Tue, 22 May 2012 09:46:34 +0000 (11:46 +0200)]
Bug 8122 - Followup Add a link to new library group creation from empty groups message
Set outside tables the "no group defined" message.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 18 May 2012 13:42:13 +0000 (09:42 -0400)]
Bug 8122 - Add a link to new library group creation from empty groups message
When there are no groups, add a link to group creation from
the message, "No properties defined."
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Owen Leonard [Fri, 18 May 2012 16:53:31 +0000 (12:53 -0400)]
Bug 8095 - Printed lists in the OPAC not easy to read
Adding more details to the print stylesheet to better
adapt the layout for printing.
Testers please clear your browser cache to ensure you
have the updated CSS file and test multiple pages, not
just the lists page.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Srdjan [Mon, 14 May 2012 03:17:13 +0000 (15:17 +1200)]
bug_8056: sorted out slip print calls
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
preference works as expected.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Tested that CircAutoPrintQuickSlip clear the screen still works well
Paul Poulain [Mon, 28 May 2012 10:00:02 +0000 (12:00 +0200)]
Bug 7792 follow-up DBRev number
Paul Poulain [Mon, 28 May 2012 09:59:44 +0000 (11:59 +0200)]
Bug 7792:redefine the field branchcode as PRIMARY KEY of branches
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Paul Poulain [Mon, 28 May 2012 09:55:23 +0000 (11:55 +0200)]
Bug 7794: follow-up DBRev number + removing UNIQUE index that is now useless
Stéphane Delaune [Thu, 22 Mar 2012 10:48:36 +0000 (11:48 +0100)]
Bug 7794:redefine the field id as PRIMARY KEY of sessions
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 27 Apr 2012 12:57:16 +0000 (08:57 -0400)]
Bug 8014 - On the patron entry form hide "restricted until" field if "Restricted: No" is checked
This patch adds JavaScript to automatically hide the "Restricted
unil" form field on the patron entry form if "Restricted: No" is
selected. If "Restricted: Yes" is chosen the "Until:" field
is shown and focus is given to it.
The patch also adds a note, "(optional)" after the "Until:" field
to make it clearer that a date is not required.
To test, open a patron record and try moving the selection
between "Restricted: No" and "Restricted: Yes." Confirm that
the "Until:" field is shown and hidden as expected. Confirm
that the restricted flag is correctly set or unset upon save,
including setting the flag with or without a date.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 28 May 2012 09:29:28 +0000 (11:29 +0200)]
Welcome to the 182th commiter !
Simon Story [Fri, 18 Nov 2011 14:52:09 +0000 (14:52 +0000)]
Bug 6684: Fixes to koha-remove
Fixes bugs 6684 6997 4880:
6684 koha-remove should check the number of arguments it gets
6997 koha-remove leaves system in inconsistent state if there is an error
4880 koha-remove sometimes fails because user is logged in
Amended by chrisc@catalyst.net.nz
Trying to resolve conflicts.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on top of bug 7924.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 11 May 2012 19:25:05 +0000 (15:25 -0400)]
ug 8078 [REVISED] my summary showing contents of incorrect tab
This patch moves the holdings tab content to the correct
position sequentially with regard to the order of the
tabs themselves. My guess is that the jQuery upgrade has
something to do with this change but I'm not sure why
(probably something in our aging tabs plugin which works
differently with the new jQuery version).
Making the sequence of the tab contents match the sequence
of the tabs seems to fix the problem.
Revised to correct the error in placement of the tags markup
in the staff client.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 29 Mar 2012 13:39:17 +0000 (15:39 +0200)]
Bug 7846 - get_batch_summary massive speedup
current code is using DISTINCT and another SQL query which can be replaced with GROUP BY
for massive speedup. In our case, generating Manage Batches screen DBI time decreased
from 24.762 s to 0.147 s
Aside from correct usage of relational database, this change also cleans up code nicely.
This change removed semi-columns from SQL query which broke Manage Patron batches.
Test scenario:
1. open Manage Batches screen and take note of time needed to generate it
2. apply this patch
3. reload page and check page genration time
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Mon, 9 Apr 2012 14:52:56 +0000 (16:52 +0200)]
Bug 7926: Acq search results show empty () for orders without basket group
To test:
- search for orders by title or vendor
- make sure some results are attached to a basket group, while others are not
- make sure correct information shows in the basket group column of search results
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Fixed merge conflict
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Wed, 18 Apr 2012 15:32:48 +0000 (11:32 -0400)]
Bug 7980: [SIGNED-OFF] Group search results tag input with other actions
This patch hides the tag input form in OPAC search results when
TagsInputOnList is turned on. An "Add tag" is added to the
"Actions" line. Clicking the link un-hides the tag input form.
A "Cancel" link hides it again.
The patch also moves the display of ratings to the bottom of
the list so that existing tags are grouped with the other
title details which are prefixed with a label ("Type:",
"Availability", etc.).
To test, enable the TagsInputOnList system preference. Do a search
and try adding tags from the search results list.
signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Mon, 14 May 2012 12:22:14 +0000 (08:22 -0400)]
Bug 8080 - login and password is pre-filled by the browser when creating a new patron
When creating a new patron, if you have chosen to let your browser remember your
login and password for you, the login and password fields will be pre-filled with
them, leading to a systematic error "the passwords entered do not match" since
the second password field was not filled. These fields should be blank.
Add the directive autocomplete="off" to the memberentry form tags.
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes t xt
enhances usability of password forms, gets my signoff.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 18 May 2012 15:51:17 +0000 (11:51 -0400)]
Bug 8107 - Disabled buttons not distinguishable from enabled buttons
Add a "greyed-out" style for disabled buttons.
Having looked through the templates for examples of usage of this
I'm not convinced that we should really be showing disabled buttons.
I think in general it would be better to hide or show a button
based on whether the action is available.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I agree, I think hiding or showing is better, but this patch is
harmless enough, until we want to go fixing our usage
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Thu, 24 May 2012 12:20:47 +0000 (14:20 +0200)]
Bug 5345: DataTables integration in acquisition module [4]
basket.tt
'Modify' and 'Delete' columns become unsortable
http://bugs.koha-community.org/show_bug.cgi?id=8109
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Fri, 17 Feb 2012 14:56:08 +0000 (15:56 +0100)]
Bug 5345: DataTables integration in acquisition module [4]
basket.tt
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Columns for 'Modify' and 'Delete' are sortable, which doesn't hurt but could be removed.
http://bugs.koha-community.org/show_bug.cgi?id=8109
Jonathan Druart [Tue, 15 May 2012 14:29:46 +0000 (16:29 +0200)]
Bug 8009: Followup Item descriptive data not populated on pay.pl
Separation of title from the description.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
D Ruth Bavousett [Wed, 25 Apr 2012 13:06:31 +0000 (06:06 -0700)]
Bug 8009: Item descriptive data not populated on pay.pl
GetBorNotifyAcctRecord was not populating the {title} element of the
hash, which pay.tt will use.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Owen Leonard [Thu, 17 May 2012 19:09:42 +0000 (15:09 -0400)]
Bug 7889 [Acquisitions] Use standard style for errors and messages
Correcting style of the warning on the Acquisitions home page
which appears if no budgets have been defined.
Also correcting the logic by which the warning appears, as a
change to the script inadvertently prevented it.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Thu, 17 May 2012 16:56:48 +0000 (12:56 -0400)]
Bug 7889 [Search errors] Use standard style for errors and messages
There are two instances in the templates where markup is defined
for displaying search errors. I've never seen these appear and I
have no idea what kind of error might trigger it, but now it will
display correctly.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Owen Leonard [Thu, 17 May 2012 16:58:30 +0000 (12:58 -0400)]
Bug 7889 [Authorities duplicates] Use standard style for errors and messages
The warning shown in the authorities editor when there is
a possible duplicate is styled incorrectly. In addition the
design of the warning is inconsistent with that shown in the
bibliographic record editor.
This patch revises the style and layout of the duplicate error
box. It also corrects a problem which appears in the biblio
and authority editors where a non-existent JS window function
was called. I have added the function to the default JS include
and revised the editor pages to use it.
To test:
- Create a record in both the cataloging and authorities
editors which will trigger a duplicate warning.
- Click the link to the existing record. A separate window
should pop up.
- In both editors try each option:
- Confirm the duplicate and go to the existing record.
- Deny that the record is duplicate and continue to save.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Owen Leonard [Thu, 17 May 2012 15:24:06 +0000 (11:24 -0400)]
Bug 7889 - Use standard style for errors and messages
Styling subscription renew message according to standard style.
Also:
- Adding direct link to renew from message suggesting renew.
- Adding output of expiration date to message.
To test open a subscription with an impending expiration. You
should see a dialog-styled message, "Subscription will expire XX/XX/XXXX.
Renew this subscription."
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Stéphane Delaune [Thu, 3 May 2012 08:29:53 +0000 (10:29 +0200)]
Bug 8040: bad name in acquisitions-menu
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 24 May 2012 16:08:36 +0000 (18:08 +0200)]
Bug 5795 follow-up, DBRev number
Amit Gupta [Tue, 22 May 2012 10:32:31 +0000 (16:02 +0530)]
Bug 5795 Update the database as follow-up If sys pref
ReservesControlBranch has null then update the table to
insert a PatronLibrary as value
To Test:
1) Go to mysql use koha database
2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary.
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
| variable | value | options | explanation | type |
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
| ReservesControlBranch | PatronLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice |
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Sat, 14 Apr 2012 11:12:54 +0000 (13:12 +0200)]
Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer
sysprefs.sql file was missing ReservesControlBranch.
To test:
1) Create a new installation and check sysprefs.sql loads correctly.
2) Check ReservesControlBranch shows up correctly in the sys pref editor.
3) Check sys pref can be edited and new value saves correctly.
Signed-off-by: Marc Veron <veron@veron.ch>
- Line is added at the end of installer/data/mysql/sysprefs.sql
- Tested Line diretly in MySQL with a systempreferences table where variable 'ReservesControlBranch' was missing. Data inserted correctly.
- Syspref shows up in Staff client
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Fixed merge conflict
Owen Leonard [Fri, 18 May 2012 14:53:11 +0000 (10:53 -0400)]
Bug 8124 - Hide option to download results of items with no checkouts report
We should not show disabled controls for features which don't work.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Wed, 8 Feb 2012 17:16:20 +0000 (12:16 -0500)]
Bug 7112 - Having two prices in 020$c causes basket creation to fail from staged marc import
The root problem here is that the price is being pulled from the MARC record
and is then run through Number::Format::unformat_number. This routine is
really being misused, and should only be used to reverse the effects of
Number::Format on a number string. We are apparently using it to strip
out currency characters and the like.
Number::Format::unformat_number will choke if there is more than one period (.)
in the price field. MARC standards do not limit this field to a single period,
so unless there is only one period, we should skip number unformatting.
Examples of that break unformat_number include '18.95 (U.S.)', and
'$5.99 ($7.75 CAN)', both of which are perfectly valid.
This commit adds the function MungeMarcPrice that will better handle
find a real price value in a given price field. It does a very good
job at finding a price in any currency format, and attempts to find
a price in whichever currency is active before falling back to
the first valid price it can find.
The variable $price may fail to have an actual price, in which case
the price then defaults to '0.00', which would be rarely if ever the
correct price. To combat this, I have added highlighting to any
price in the Order Details table that begins with 0 ( i.e. '0.00' ).
Also, fixed the incomplete table footer, adding a new td with a
span of 3 to fill in the nonexistant cells.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>