koha.git
8 years agoF4 to program tag
Dobrica Pavlinusic [Fri, 4 Apr 2014 12:45:02 +0000 (14:45 +0200)]
F4 to program tag

8 years agosearch catalog using barcode
Dobrica Pavlinusic [Fri, 4 Apr 2014 11:29:44 +0000 (13:29 +0200)]
search catalog using barcode

8 years agoalways respect check in tab if selected
Dobrica Pavlinusic [Thu, 3 Apr 2014 15:01:06 +0000 (17:01 +0200)]
always respect check in tab if selected

8 years agofirst change security and then submit form
Dobrica Pavlinusic [Thu, 3 Apr 2014 14:06:03 +0000 (16:06 +0200)]
first change security and then submit form

This allows librarians to remote book from reader as soon as page is
submitted instead of waiting for page load and one RFID scan to
correctly change tag security.

8 years agobetter extraction of script name
Dobrica Pavlinusic [Thu, 3 Apr 2014 14:03:53 +0000 (16:03 +0200)]
better extraction of script name

8 years agoremote debug output
Dobrica Pavlinusic [Thu, 3 Apr 2014 12:01:30 +0000 (14:01 +0200)]
remote debug output

8 years agocall rfid_secure JSONP only if security changed
Dobrica Pavlinusic [Thu, 3 Apr 2014 11:57:34 +0000 (13:57 +0200)]
call rfid_secure JSONP only if security changed

8 years agodisable rfid refresh before page load
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:36:30 +0000 (11:36 +0200)]
disable rfid refresh before page load

8 years agoadded javascript from Biblio::RFID
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:36:03 +0000 (11:36 +0200)]
added javascript from Biblio::RFID

8 years agocreate ip directory with correct permissions
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:34:02 +0000 (11:34 +0200)]
create ip directory with correct permissions

8 years agoregister rfid reader
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:33:14 +0000 (11:33 +0200)]
register rfid reader

records local (intranet) address and address inside vmware (behind NAT)
for access from local browser

8 years agomove script to rfid directory
Dobrica Pavlinusic [Tue, 1 Apr 2014 09:35:37 +0000 (11:35 +0200)]
move script to rfid directory

8 years agoffzg_inventarna_knjiga needs itemnumber
Dobrica Pavlinusic [Fri, 7 Mar 2014 15:39:25 +0000 (16:39 +0100)]
ffzg_inventarna_knjiga needs itemnumber

8 years agolookup borrower data using SmartX card data
Dobrica Pavlinusic [Thu, 6 Feb 2014 11:02:33 +0000 (12:02 +0100)]
lookup borrower data using SmartX card data

8 years agoupdate and install hr-HR language
Dobrica Pavlinusic [Tue, 5 Nov 2013 15:16:24 +0000 (16:16 +0100)]
update and install hr-HR language

8 years agoadded stocknumber in red to items detail page
Dobrica Pavlinusic [Tue, 5 Nov 2013 14:53:20 +0000 (15:53 +0100)]
added stocknumber in red to items detail page

8 years agoffzg-stocknumber: replace YUI with jquery
Dobrica Pavlinusic [Mon, 4 Nov 2013 12:04:52 +0000 (13:04 +0100)]
ffzg-stocknumber: replace YUI with jquery

8 years agoFFZG #390 - Signatura ZS - jquery changed location
Dobrica Pavlinusic [Mon, 4 Nov 2013 11:37:26 +0000 (12:37 +0100)]
FFZG #390 - Signatura ZS - jquery changed location

8 years agofamfamfam silk images
Marijana Glavica [Sun, 3 Nov 2013 19:43:25 +0000 (20:43 +0100)]
famfamfam silk images

8 years agocustom OPAC details template
Marijana Glavica [Sun, 3 Nov 2013 15:27:55 +0000 (16:27 +0100)]
custom OPAC details template

8 years agocustom intranet templates
Marijana Glavica [Sun, 3 Nov 2013 15:26:55 +0000 (16:26 +0100)]
custom intranet templates

8 years agocustom intranet templates
Marijana Glavica [Sun, 3 Nov 2013 13:43:46 +0000 (14:43 +0100)]
custom intranet templates

8 years agoMARC21slim2OPACResultsFFZG.xsl
Marijana Glavica [Tue, 22 Oct 2013 12:44:20 +0000 (14:44 +0200)]
MARC21slim2OPACResultsFFZG.xsl

8 years agocustom xsl for MARC21slim2intranetDetailISBD.xsl
Marijana Glavica [Thu, 17 Oct 2013 15:15:52 +0000 (17:15 +0200)]
custom xsl for MARC21slim2intranetDetailISBD.xsl

8 years agoFFZG stocknumber - use last year until 15th of january
Dobrica Pavlinusic [Tue, 1 Jan 2013 22:43:20 +0000 (23:43 +0100)]
FFZG stocknumber - use last year until 15th of january

8 years agoKoha-FFZG#1517: Actual cost kod zaprimanja je 0 a trebalo bi prepisati Budgeted cost
Dobrica Pavlinusic [Thu, 12 Jul 2012 10:43:01 +0000 (12:43 +0200)]
Koha-FFZG#1517: Actual cost kod zaprimanja je 0 a trebalo bi prepisati Budgeted cost

8 years agokeybord shortcuts for circulation
Marijana Glavica [Tue, 26 Jun 2012 11:39:36 +0000 (13:39 +0200)]
keybord shortcuts for circulation

8 years agopersistent location of RFID chip based on itemnumber
Dobrica Pavlinusic [Wed, 22 Feb 2012 19:23:31 +0000 (20:23 +0100)]
persistent location of RFID chip based on itemnumber

8 years agoadded autocomplete="off"
Dobrica Pavlinusic [Fri, 10 Feb 2012 14:44:04 +0000 (15:44 +0100)]
added autocomplete="off"

8 years agoauto-focus barcode field on load
Dobrica Pavlinusic [Fri, 10 Feb 2012 14:38:57 +0000 (15:38 +0100)]
auto-focus barcode field on load

8 years agoredirect to printer REST only if barcode was found
Dobrica Pavlinusic [Thu, 9 Feb 2012 21:26:54 +0000 (22:26 +0100)]
redirect to printer REST only if barcode was found

8 years agoadded form to print another barcode
Dobrica Pavlinusic [Thu, 9 Feb 2012 17:08:38 +0000 (18:08 +0100)]
added form to print another barcode

8 years agocorrectly encode utf8 callnumbers
Dobrica Pavlinusic [Thu, 9 Feb 2012 14:10:50 +0000 (15:10 +0100)]
correctly encode utf8 callnumbers

8 years agoopac-sendbasket.tt is not translatable
Marijana Glavica [Tue, 31 Jan 2012 21:02:01 +0000 (22:02 +0100)]
opac-sendbasket.tt is not translatable

this file was made manualy, not by translate tool, so that is
why it is commited to the repository

8 years agoAdding user email to message sent from cart
Marijana Glavica [Tue, 31 Jan 2012 19:50:51 +0000 (20:50 +0100)]
Adding user email to message sent from cart

8 years agofix currency exchange rates
Dobrica Pavlinusic [Fri, 27 Jan 2012 10:54:47 +0000 (11:54 +0100)]
fix currency exchange rates

8 years agoHNB currency update
Dobrica Pavlinusic [Wed, 25 Jan 2012 21:09:49 +0000 (22:09 +0100)]
HNB currency update

8 years agoinsert RFID chip position using javascript
Dobrica Pavlinusic [Thu, 5 Jan 2012 14:46:56 +0000 (15:46 +0100)]
insert RFID chip position using javascript

8 years agoAdding RFID tags to items using catalogue/moredetail template
Marijana Glavica [Wed, 28 Dec 2011 21:15:13 +0000 (22:15 +0100)]
Adding RFID tags to items using catalogue/moredetail template

8 years agonew inventory number confirmation
Dobrica Pavlinusic [Tue, 24 Jan 2012 19:56:34 +0000 (20:56 +0100)]
new inventory number confirmation

8 years agoopen items editor instad of normal view in received orders list
Marijana Glavica [Fri, 20 Jan 2012 06:17:48 +0000 (07:17 +0100)]
open items editor instad of normal view in received orders list

8 years agoFFZG stocknumber value_builder plugin for YEAR-NR
Dobrica Pavlinusic [Tue, 17 Jan 2012 19:04:08 +0000 (20:04 +0100)]
FFZG stocknumber value_builder plugin for YEAR-NR

Squashed commit of the following:

commit 87ff20b8470895b3261a408c503ca3d0f5130025
Author: Dobrica Pavlinusic <dpavlin@rot13.org>
Date:   Tue Jan 17 19:47:27 2012 +0100

    stocknumber in YEAR-NR format

commit 9084f5a1199d9305570da122d3b383f2b2662bf8
Author: Dobrica Pavlinusic <dpavlin@rot13.org>
Date:   Tue Jan 17 18:30:11 2012 +0100

    begin value builder for inventory book

8 years agoinsert RFID chip position using javascript
Dobrica Pavlinusic [Thu, 5 Jan 2012 14:46:56 +0000 (15:46 +0100)]
insert RFID chip position using javascript

8 years agoRFID position pictures
Dobrica Pavlinusic [Wed, 4 Jan 2012 15:08:40 +0000 (16:08 +0100)]
RFID position pictures

8 years agocorner images for library menu
Marijana Glavica [Thu, 5 Jan 2012 12:54:07 +0000 (13:54 +0100)]
corner images for library menu

8 years agoNormal view to look like ISBD
Marijana Glavica [Thu, 5 Jan 2012 01:35:32 +0000 (02:35 +0100)]
Normal view to look like ISBD

8 years agoplugins for thesis framework
Marijana Glavica [Tue, 3 Jan 2012 13:30:25 +0000 (14:30 +0100)]
plugins for thesis framework

8 years agoPlugins for leader and 008
Marijana Glavica [Tue, 3 Jan 2012 03:50:28 +0000 (04:50 +0100)]
Plugins for leader and 008

8 years agoSome images for OPAC
Marijana Glavica [Tue, 3 Jan 2012 01:04:00 +0000 (02:04 +0100)]
Some images for OPAC

8 years agoOPAC FFZG style
Marijana Glavica [Mon, 2 Jan 2012 18:18:27 +0000 (19:18 +0100)]
OPAC FFZG style

8 years agoAdding RFID tags to items using catalogue/moredetail template
Marijana Glavica [Wed, 28 Dec 2011 21:15:13 +0000 (22:15 +0100)]
Adding RFID tags to items using catalogue/moredetail template

8 years agoffzg site required local staff css
Marijana Glavica [Thu, 14 Jul 2011 21:34:59 +0000 (23:34 +0200)]
ffzg site required local staff css

8 years agobounce browser to printer URL and return with station
Dobrica Pavlinusic [Wed, 8 Feb 2012 13:47:53 +0000 (14:47 +0100)]
bounce browser to printer URL and return with station

This allows us to recurect to printer REST API, send ZPL file to printer
and return to Koha with station/printer IP address to record in log.

8 years agoFFZG #390 - Signatura zatvorenog spremišta
Dobrica Pavlinusic [Sun, 1 Jan 2012 12:18:50 +0000 (13:18 +0100)]
FFZG #390 - Signatura zatvorenog spremišta

Implementirati višestruke nizove signatura prema formatu

Ovo je port na Template Toolkit za Kohu 3.4 i novije

8 years agoBug 15443 - DBrev 3.23.00.015
Kyle M Hall [Mon, 4 Jan 2016 12:53:08 +0000 (12:53 +0000)]
Bug 15443 - DBrev 3.23.00.015

8 years agoBug 15443 - Re-code RESERVESLIP as HOLD_SLIP
Kyle M Hall [Wed, 30 Dec 2015 15:03:23 +0000 (15:03 +0000)]
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP

It's a bit confusing to have RESERVESLIP named "Hold Slip", we should
finish the job and recode the slip.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Try printing a hold slip, you should note no difference
   from pre-patch behavior

Followed test plan. The slip is triggered if you want to check out
an item that is reserved / on hold for another patron. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
8 years agoBug 13774 Add the unique anchors of news as links in the RSS for news in Opac
Viktor Sarge [Mon, 2 Mar 2015 13:27:01 +0000 (13:27 +0000)]
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac

This patch adds the unique anchors of bugs from bug13729 into the rss stream of the news in opac from bug7843.
Since 7843 is already passed QA and I'm new to Git and mess things up I chose to post this update in a separate patch even if it's a tiny change.

The addition of a unique guid tag both help users and keeps validators happy.

Test plan:
* Make sure you are on master in order to get the anchors from bug 13729 (or you could apply it manually).
* Apply bug 7843
* Apply this patch.
* Make shure you have enough news to make the Opac main page scroll.
* Find the RSS link at the bottom om opac main and klick it.
* Verify that the link displayed for each newsitem takes you to the right anchor.

Followed test plan, works as expected. Signed-off-by: Marc Véron
<veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14034: Fix logout on refresh for shibboleth
Martin Renvoize [Fri, 18 Sep 2015 08:10:27 +0000 (08:10 +0000)]
Bug 14034: Fix logout on refresh for shibboleth

This is similar to bug 12877

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
While this is missing a detailed test plan, what I did to test was

1/ Login to koha .. it works
2/ Apply patch
3/ Login to koha .. it still works, no regressions. I can't test the
shibboleth part but it doesnt break anything else so I'm happy to sign
off

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
We had to implement this fix for one of our customers using Shibboleth.
Can verify that it fixes the issue (which, incidentally, breaks
stage-marc-import since that depends on a constant sessionID).

Passing QA (verified with QA tools). Thanks, Martin!

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoremoving the actomic update
Brendan Gallagher [Thu, 31 Dec 2015 20:39:01 +0000 (20:39 +0000)]
removing the actomic update

8 years agoBumping the DBrev to .014 (fixed earlier DBrev too)
Brendan Gallagher [Thu, 31 Dec 2015 20:36:30 +0000 (20:36 +0000)]
Bumping the DBrev to .014 (fixed earlier DBrev too)

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues
Charles Farmer [Tue, 1 Dec 2015 13:55:50 +0000 (08:55 -0500)]
Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues

There is already a syspref called "OverdueNoticeBcc" for sending Bcc
copies of mails sent for overdues and other notices. This patch add a
new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues
alerts.

Changed the wording of the system preference to:

[Send|Don't send] blind copy (BCC) to logged in user when sending
serial or acquisitions claims notices.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14131: Reduce the greybox height to 400px
Jonathan Druart [Fri, 23 Oct 2015 08:21:21 +0000 (09:21 +0100)]
Bug 14131: Reduce the greybox height to 400px

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14131 - Adding print patron cards to patron lists home page
Liz [Thu, 15 Oct 2015 04:11:39 +0000 (04:11 +0000)]
Bug 14131 - Adding print patron cards to patron lists home page

To test:

Go to /cgi-bin/koha/patron-lists/lists.pl
Make a patron list
Click "Print patron cards"
Success: you get a pdf of cards to print.
Failure: you can't get a pdf of cards to print.

Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14131 - Patroncard: Add possibility to print from patron lists
Marc Véron [Sun, 3 May 2015 21:26:11 +0000 (23:26 +0200)]
Bug 14131 - Patroncard: Add possibility to print from patron lists

This patch adds the possibility to print patron cards from patron lists.

To test:

- Go to Home > Tools > Patron card creator
- Prepare a patron card and create some cards using the batch functionality
- Apply patch
- Prepare a patron list e.g. from patron search
- Go to Home > Tools > Patron card creator > Manage batches
- Below the list of batches you have a dropdown to select a patron list
- Select your list and hit "Export from patron list"
- Select template and layout as you would do with batches
- Hit "Export"
- Download PDF

Modified patch to work with Bug 14676 changes. Functionality unchanged.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Liz <wizzyrea@gmail.com>
(Amended to make it apply on current master)

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoAdding Koha.pm update
Brendan Gallagher [Thu, 31 Dec 2015 19:47:06 +0000 (19:47 +0000)]
Adding Koha.pm update

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoRemoving the amoticupdate file
Brendan Gallagher [Thu, 31 Dec 2015 19:45:35 +0000 (19:45 +0000)]
Removing the amoticupdate file

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoUpdating the DBrev.
Brendan Gallagher [Thu, 31 Dec 2015 19:44:50 +0000 (19:44 +0000)]
Updating the DBrev.

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14945: Add 2 more tests for StoreLastBorrower
Jonathan Druart [Wed, 9 Dec 2015 10:24:15 +0000 (10:24 +0000)]
Bug 14945: Add 2 more tests for StoreLastBorrower

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14945 - Add the ability to store the last patron to return an item
Kyle M Hall [Mon, 5 Nov 2012 19:35:23 +0000 (14:35 -0500)]
Bug 14945 - Add the ability to store the last patron to return an item

Currently if the AnonymousPatron system preference is in use, all patron
data is anonymized. Some libraries would like to be able to see the last
patron who returned out an item ( in case of damage ) but still keep all
other patrons anonymized.

* Add the table items_last_borrower ( id, itemnumber, borrowernumber )
* Add new system preference StoreLastBorrower
* If StoreLastBorrower is enabled, upon checkin have Koha insert into
  this table the patron who last returned this item. Replace existing
  row based on itemnumber if exists.
* If table has a row for a given item, link to the patron from the item
  details page.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Enable StoreLastBorrower
4) Issue an item to a patron and return said item
5) Issue the same item to a second patron, do not return it.
6) View moredetail.pl for the given bib, find the given item. There
   should be a new field in the history list 'Last returned by' with a link
   to the last patron to return the item.

Optionally, you can also verify this works even if patron issuing
history has been set to anonymize issues upon return.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jen DeMuth <JDeMuth@roseville.ca.us>
Signed-off-by: Tom Misilo <misilot@fit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it
Joonas Kylmälä [Wed, 4 Nov 2015 15:15:04 +0000 (15:15 +0000)]
Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it

Test plan:
1. Make sure that in koha/admin/smart-rules.pl you can still create
   new rules and that the new rules have all their values remained
   after saving the rule (so put to every field something).
2. Make sure you can edit that rule
3. Make sure you can delete that rule

Sponsored-by: Vaara-kirjastot
Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Add tests for Koha::BiblioFramework[s]
Jonathan Druart [Mon, 26 Oct 2015 08:56:49 +0000 (08:56 +0000)]
Bug 14889: Add tests for Koha::BiblioFramework[s]

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Fix error msg on duplicate
Jonathan Druart [Mon, 26 Oct 2015 08:55:43 +0000 (08:55 +0000)]
Bug 14889: Fix error msg on duplicate

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: QA Follow-up
Katrin Fischer [Sun, 25 Oct 2015 09:33:50 +0000 (10:33 +0100)]
Bug 14889: QA Follow-up

- Removes unused package from BiblioFramework.pm
- Makes framework table sortable
- Some small changes in wording of error messages

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Use Koha::BiblioFramework[s] in admin/biblio_framework.pl
Jonathan Druart [Thu, 24 Sep 2015 15:08:54 +0000 (16:08 +0100)]
Bug 14889: Use Koha::BiblioFramework[s] in admin/biblio_framework.pl

Test plan:
Add/edit/remove biblio frameworks from the administration module
(admin/biblio_framework.pl).
You should get message feedback after each action.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No problems found. Tested add/edit/delete
No koha-qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Add Koha::BiblioFramework[s] classes
Jonathan Druart [Thu, 24 Sep 2015 15:08:49 +0000 (16:08 +0100)]
Bug 14889: Add Koha::BiblioFramework[s] classes

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Fix error in SearchAuthorities when no authtypecode
Frédéric Demians [Sun, 20 Dec 2015 16:17:08 +0000 (17:17 +0100)]
Bug 15381: Fix error in SearchAuthorities when no authtypecode

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Remove GetAuthType and GetAuthTypeCode
Jonathan Druart [Tue, 15 Dec 2015 13:43:47 +0000 (13:43 +0000)]
Bug 15381: Remove GetAuthType and GetAuthTypeCode

Test this patch with the previous one.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Remove getauthtypes and getauthtype
Jonathan Druart [Tue, 15 Dec 2015 13:19:53 +0000 (13:19 +0000)]
Bug 15381: Remove getauthtypes and getauthtype

These 2 subroutines are now not necessary anymore, we can use
Koha::Authority::Types to retrieve the authority types.

This patch won't be easy to test. Indeed, a lot of file are updated.
To test it I would suggest to focus on the merge authority

You should also confirm that the authtypecode and the authtypetext
values are correctly displayed when navigating in the authority module.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Use Koha::Authority::Types in some other places
Jonathan Druart [Tue, 15 Dec 2015 11:59:02 +0000 (11:59 +0000)]
Bug 15381: Use Koha::Authority::Types in some other places

There are 3 place where the auth_types table were requested directly
from the script or a subroutine.  These 3 occurrences are easy to
replace with the new module.

Test plan:
1/ Search for authorities and use the "did you mean" feature for
authorities.
Focus on the authtypecode
2/ Edit authority and biblio frameworks.
The "Thesaurus" dropdown list should be correctly populated (UNIMARC
only).

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15380: Use Koha::Authority::Type[s] in admin script
Jonathan Druart [Tue, 15 Dec 2015 11:41:51 +0000 (11:41 +0000)]
Bug 15380: Use Koha::Authority::Type[s] in admin script

This path rewrites the admin/authtypes.pl script to use the new modules
instead of executing the SQL queries from the script.

Test plan:
1/ Create 1+ authority types
2/ Update one
3/ Delete it
4/ Create an authority record using this authority type.
5/ Try to delete the authority type
Here there is a change in the behavior.
Prior to this patch, the user was able to delete the authority type, now
it's not.
I think it was a bug, feel free to give your opinion if you disagree on
this change.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s]
Jonathan Druart [Tue, 15 Dec 2015 11:41:24 +0000 (11:41 +0000)]
Bug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s]

Based on Koha::Objects.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority
Jonathan Druart [Tue, 15 Dec 2015 10:21:02 +0000 (10:21 +0000)]
Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority

The existing Koha::Authority does not use Koha::Objects and does not
exclusively deal with DB objects.
It makes much sense to move it to let the space free for a
Koha::Authority and Koha::Authorities modules based on Koha::Object.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBumping the DBrev up
Brendan Gallagher [Thu, 31 Dec 2015 18:38:40 +0000 (18:38 +0000)]
Bumping the DBrev up

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 13022 [QA Followup] - Highlight the results with inaccurate status, add explanati...
Kyle M Hall [Fri, 17 Apr 2015 14:41:13 +0000 (10:41 -0400)]
Bug 13022 [QA Followup] - Highlight the results with inaccurate status, add explanation when mouse hovers over.

Bug 13022 [QA Followup] - Revert changes in whitespace back to original for items count lines

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks
Kyle M Hall [Fri, 17 Apr 2015 13:51:03 +0000 (09:51 -0400)]
Bug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate...
Kyle M Hall [Thu, 2 Oct 2014 13:19:21 +0000 (09:19 -0400)]
Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses

If a record has more than 20 items, all the items over 20 will show as
available on the search results even if they are not!

This is a hard coded limit in the Search module. This number should be
configurable.

Test Plan:
1) Create a record with more than 20 items
2) Set all the items to waiting holds or in transit
3) Search for results that will include that item
4) Note some say they are available even though they are not
5) Apply this patch
6) Run updatedatabase.pl
7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck
   to a number larger than the number of items on your record
8) Re-run the search
9) Note that the hold and transit statuses for the items are now correct

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 10154: QA follow-up - Spelling and terminology
Katrin Fischer [Mon, 30 Nov 2015 23:47:54 +0000 (00:47 +0100)]
Bug 10154: QA follow-up - Spelling and terminology

- Changing capitalization: Any Patron category > Any patron category
- Changing Collection code > Collection

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 10154 Add Call number in the filter of most circulated items
Eivin Giske Skaaren [Wed, 28 Oct 2015 00:28:28 +0000 (00:28 +0000)]
Bug 10154 Add Call number in the filter of most circulated items

This patch adds call number, collection code and shelving location to
the filter.

To test:

It is of course a prerequisite to have items in the DB with the correct
MARC fields and that they have been checked out etc. to get a valid
result when testing.

1. Apply patch to koha synced to master.
2. Go to /cgi-bin/koha/reports/cat_issues_top.pl
3. Select filters, the new ones are Call number, Collection code and
   Shelving location
4. Hit submit.

Expected result:
The filters chosen will be printed under "Filtered on".
A table with the result is shown.

For manual verification here is some SQL to run:

SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues`
                  LEFT JOIN items USING(itemnumber)
                  LEFT JOIN biblio USING(biblionumber)
                  LEFT JOIN biblioitems USING(biblionumber)
                  LEFT JOIN borrowers USING(borrowernumber)
                  WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC;

Put in your valid values in the WHERE clause for the values in the
single quotes ''.

Sponsored-by: Halland county library
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  It works as described. Valid results, tested in various combinations.
  Follows the coding (awful) style of the original script, without
  introducing any regression. It would have been great to have
  callnumber interval, but anyway...

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 12923 Improve error logging for advance_notices.pl
Olli-Antti Kivilahti [Mon, 15 Sep 2014 08:42:34 +0000 (11:42 +0300)]
Bug 12923 Improve error logging for advance_notices.pl

Show borrowernumber when no letter of type is found and force utf8
output when running advance_notices.pl with -n flag, diacritics run awol
in the console output!

Also when debugging which borrower requests undefined letter templates,
it is very handy to log the borrowernumber so we catch and fix bad
borrower message transport settings.

TEST PREPARATION:

0. Edit the ODUEDGST letter, find an undefined letter for any trasport
   type.

::TESTS ARE (ALMOST) THE SAME AS IN bugg 12922::
TEST PLAN:

1. Find a borrower and from the messaging preferences set the "Advance
   notice" transport type to the undefined digest. Set the "Days in
   Advance" to 1.
2. Check-out something for that borrower and set the due date for
   tomorrow.
3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
4. BEFORE THIS PATCH: You get an error "no letter of type 'PREDUEDGST'
   found. Please see sample_notices.sql at ./advance_notices.pl line
   366."
4. AFTER THIS PATCH: You get an error "no letter of type 'PREDUEDGST'
   found for borrowernumber 1104659. Please see sample_notices.sql at
   ./advance_notices.pl line 368."
   Makes life more worth living for!
   Also diacritics printed on screen are displayed properly.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I confirm the diacritics issue and solution. borrowernumber is
  displayed with warning when the 'no letter...' message is displayed.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592 - DBrev 3.23.00.011
Kyle M Hall [Thu, 31 Dec 2015 16:01:26 +0000 (16:01 +0000)]
Bug 13592 - DBrev 3.23.00.011

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592 [QA Followup] - Make the system preference description self documenting
Kyle M Hall [Fri, 18 Dec 2015 18:50:32 +0000 (18:50 +0000)]
Bug 13592 [QA Followup] - Make the system preference description self documenting

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592: Add an option to charge for any hold placed
Jonathan Druart [Wed, 11 Nov 2015 15:12:45 +0000 (15:12 +0000)]
Bug 13592: Add an option to charge for any hold placed

Currently the fee is applied on if all items for the record are issued
and at least one hold already exists on the record.
This patch does not give a complete answer to the problem (see
discussion on bug 13592 for the other user's expectations).
It only adds the ability to charge for any hold placed regardless of the
conditions.

Test plan:
1) Execute the updatedb entry to insert the new pref
2) Confirm that the behavior is the same as before applying this patch
3) Change the HoldFeeMode pref to 'always'
4) Note that the fee is applied for any hold placed

Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15225: [QA Follow-up] Improve changes to gethtml5media
Marcel de Rooy [Wed, 16 Dec 2015 14:54:49 +0000 (15:54 +0100)]
Bug 15225: [QA Follow-up] Improve changes to gethtml5media

[1] Improve readability, add some checks.
[2] Add the public flag for OPAC use. (If a file has not been marked as
    public, we should not return it in OPAC.)

Test plan:
See original commit. No changes in behavior.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15225: Make HTML5Media work with file upload feature.
Mirko Tietgen [Mon, 16 Nov 2015 17:10:27 +0000 (18:10 +0100)]
Bug 15225: Make HTML5Media work with file upload feature.

Koha::Upload allows files to be attached to bibliographic records.
HTML5Media streaming in Koha does not work with these files.

Test plan:
- apply patch
- make sure OPACBaseURL is set correctly
- enable HTML5MediaEnabled in OPAC and staff client
- connect upload.pl to 856$u in your framework
- upload a file with an extension set in HTML5MediaExtensions,
  make sure to set the codec correctly if you use WEBM (subfield c,
  eg. 'vp8, vorbis')
- save record, view in staff client and browser, check if 'Play
  media' option is available and works

Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15321: No need to add the change trigger conditionally
Jonathan Druart [Wed, 9 Dec 2015 09:04:35 +0000 (09:04 +0000)]
Bug 15321: No need to add the change trigger conditionally

It will be applied if the button exists.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15321 - Add delete report link to Show, Edit and Run screens
Magnus Enger [Tue, 8 Dec 2015 19:45:39 +0000 (20:45 +0100)]
Bug 15321 - Add delete report link to Show, Edit and Run screens

Currently, if you are editing or viewing the results of running a
report and you decide you want to delete it, you have to go back
to the list of saved reports to do so. This patch adds a "Delete"
link in some convenient places.

To test:
- Apply the patch
- Make sure you have at least one saved report
- Make sure you have the create_reports permission
- Go to the Show, Edit and Run screens and verify the Delete link
  is present and functional, including the JavaScript confirmation
  dialogue
- Change to a user without the create_reports permission and check
  that the Delete link is not displayed on the Show, Edit and Run
  screens
- Sign ye off merrily!

Version 2: This version makes sure the JavaScript confirmation is
shown before an actual delete is carried out.

Signed-off-by: Heather Braum <hbraum@nekls.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - DBrev 3.23.00.010
Kyle M Hall [Thu, 31 Dec 2015 15:35:31 +0000 (15:35 +0000)]
Bug 9129 - DBrev 3.23.00.010

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 [QA Followup] - Make unit test file conform to PBP
Kyle M Hall [Thu, 31 Dec 2015 15:31:19 +0000 (15:31 +0000)]
Bug 9129 [QA Followup] - Make unit test file conform to PBP

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Add the ability to set the maximum fine for an item to its replacement...
Kyle M Hall [Thu, 22 Oct 2015 10:40:12 +0000 (06:40 -0400)]
Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price

This patch adds the ability to set the maximum fine for a given item to
its replacement price ( assuming the replacement price is set ). If
overduefinescap is also set, the fine will be the lesser of the two, if
both apply to the given overdue checkout.

To enable this new limit, create or edit your circulation rules and
check the checkbox for "Cap fines at replacement price"

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Pick an item, and set it's replacement price to 3.99
4) Edit the circulation rule that would apply to this item
   and the patron you will check it out to.
5) Check out the item to the patron, and backdate the due date
   such that the fine generated would be more than 3.99
6) Enable CalculateFinesOnReturn
7) Return the item, and view the fine generated, it should be 3.99

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Update schema
Kyle M Hall [Thu, 31 Dec 2015 15:29:13 +0000 (15:29 +0000)]
Bug 9129 - Update schema

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>