Garry Collum [Fri, 26 Jun 2009 00:27:56 +0000 (20:27 -0400)]
Bug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous patch.
Cleaned up toggle variable in opac-readingrecord.pl and tmpl. Used __odd__ variable instead.
Missed </TMPL_UNLESS> in previous patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Fri, 26 Jun 2009 00:35:14 +0000 (20:35 -0400)]
Bug 2889: Removed toggle variable from z3950_search.pl.
Removed unused toggle variable from z3959_search.pl. Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 25 Jun 2009 13:28:42 +0000 (08:28 -0500)]
Another fix for Bug 3119 (Add date due to circ history)
Moving links (non-table data) out of table to correct persistent table border display issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
J. David Bavousett [Thu, 25 Jun 2009 14:43:39 +0000 (10:43 -0400)]
Modified fines.pl to not throw warning if --out not specified
It appears, in Ryan's patch, that he wants to throw a warning to the log if
the directory specified in --out is not present. (Further messages will
be given when the open-or-die occurs a few lines later.) However, it was
throwing the warning if --out was not specified at all, which is
undesirable. This patch modifies that bit to check for the presence of
whatever directory is going to be used, either --out, ENV{TMPDIR}, or /tmp.
As before, if the write to the directory fails for any reason--including
its' non-existence--that is handled later, but this message will help
inform the troubleshooter.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Liz Rea [Thu, 25 Jun 2009 14:46:31 +0000 (09:46 -0500)]
bug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake of consistency.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Sun, 14 Jun 2009 05:17:40 +0000 (07:17 +0200)]
Bug 3301 - Speed up rebuild_zebra script
With this patch, rebuild_zebra can re-index a whole Koha DB
quickly:
rebuild_zebra -r -b -nosanitize
Biblio (authority) records are dump directly in a file
from marcxml field without beeing transformed into
MARC::Record object and corrected.
DOCUMENTATION:
rebuild_zebra.pl new paramater:
-nosanitize export biblio/authority records directly from DB marcxml
field without sanitizing records. It speed up
dump process but could fail if DB contains badly
encoded records. Works now only with -x and -b
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 18 Jun 2009 16:31:33 +0000 (11:31 -0500)]
Returns reworking to handle empty GetItemIssue
Code cannot rely on issueinformation being populated.
Note there is room for better efficiency to have AddReturn also provide the
itemnumber (where existing) so that GetItemnumberFromBarcode is not called
at both levels. Unfortunately there is discrepancy between this idea (for
efficiency) and the stated purpose of the $iteminformation object returned,
since $iteminformation is specifically the info from the issues table and
MUST be empty when the item was not in fact issued.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Sat, 20 Jun 2009 00:32:42 +0000 (19:32 -0500)]
checkoverdues should not require $dbh
Passing $dbh around is an ancient style that doesn't know
to use C4::Context. C4::Context->dbh is efficient, especially
for modules that already use Context, including almost all C4.
I also internalized $today into the SQL using NOW() in the query
and removed sth->finish. Even though I dislike the return style
that gives the count, then the array, I left it becuase I don't
have time to fix/test all the callers. However, I did convert
it so it doesn't require a $count variable and its own loop.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Sat, 20 Jun 2009 00:32:44 +0000 (19:32 -0500)]
Return amount for CREDITS, POD rework.
The main change here is to get an {amount} field for CREDITS,
not just CHARGES. I also use a fallback to default value (5)
in case noissuescharge has been deleted or set to 0.
POD is reworked to keep the salient chunks
about patronflags in the correct section and format them for
easier reference. Deprecated display layer code.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Sat, 20 Jun 2009 00:32:45 +0000 (19:32 -0500)]
Cleanup Members.pm - minor
MoveMemberToDeleted is problematic. It has a bad name, since it
only copies, not moves. Also the POD for it referenced a totally
different function name and was largely useless. Sanity checks inserted.
A couple sth->finish removed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Sat, 20 Jun 2009 00:32:43 +0000 (19:32 -0500)]
Remove unused variable and add FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Nighswonger [Tue, 23 Jun 2009 17:18:04 +0000 (13:18 -0400)]
Adding installation documentation for Ubuntu
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 24 Jun 2009 14:09:27 +0000 (09:09 -0500)]
fixed table row highlighting CSS class
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Colin Campbell [Tue, 23 Jun 2009 08:14:31 +0000 (09:14 +0100)]
Enable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings Remove toggle variable
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Sat, 20 Jun 2009 00:32:41 +0000 (19:32 -0500)]
Functional SIP run and shutdown scripts. Update example SIPconfig.xml
Note the shutdown script is quick and dirty, and probably
platform (debian) specific.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jane Wagner [Fri, 19 Jun 2009 13:10:20 +0000 (09:10 -0400)]
Bug # 2368 Change holds to pull default date range
Delivered range was 10 years ago to yesterday; changed default
to be two days ago to today. Also removed notes field from report
output; 5xx fields can be quite large and including them in the
display resulted in a very lengthy printout for staff.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 22 Jun 2009 19:40:56 +0000 (14:40 -0500)]
Bug 3350 - fail on queued emails w/ no address
If a patron has no email address, we need to avoid stockpiling all
their messages indefinitely. Otherwise they get mailbombed when
their email IS added.
Note that overdues should not be affected, since the overdues job
checks whether the patron email exists before sending the message
(falling back to the admin). The other messaging features are the
targets affected by this patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Tue, 23 Jun 2009 12:01:14 +0000 (14:01 +0200)]
Bug 3351 - Limit Serials Search for Biblio to an item type
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Liz Rea [Tue, 23 Jun 2009 18:11:24 +0000 (13:11 -0500)]
Adding links to guided reports wizard, dictionary, create from sql to reports home page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Fri, 19 Jun 2009 11:23:33 +0000 (13:23 +0200)]
Bug Fixing : 3334
MANIFEST.SKIP with grouping orig back and old
had a problem with hold-transfer-slip.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 18 Jun 2009 16:31:32 +0000 (11:31 -0500)]
Correct POD and misleading variable names from copy/paste laziness
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Thu, 18 Jun 2009 13:43:29 +0000 (15:43 +0200)]
(bug #3339) fix rollover showed value
This patch just print the value of "whenmorethan1", that was missed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Thu, 18 Jun 2009 09:18:26 +0000 (05:18 -0400)]
Bug 3338: Fix for missing closing brackets in authorities/detail.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 17 Jun 2009 13:00:57 +0000 (08:00 -0500)]
bug 2893: extend conditions handled by AllowNotForLoanOverride
Prior to this patch, turning AllowNotForLoanOverride on
allowed the circ operator to permit the loan of an
item who's individual not-for-loan flag was set, but did
not allow the loan of an item whose item type's not-for-loan
flag was set. This patch extends the definition of the
system preference so that both cases are covered.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 17 Jun 2009 21:27:34 +0000 (16:27 -0500)]
use Memoize to cache results of GetAuthorisedValues
Thanks to Frédéric Demians for the original impetus
to improve this function and for doing profiling.
Note that Memoize is a core module since at least 5.8.0.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Mon, 15 Jun 2009 22:20:29 +0000 (17:20 -0500)]
Add MARC21 Fast-add Framework.
Development is in progress for brief records
in Koha; until that's done, this framework can
be used to add a minimal record.
Created by debra.denault@liblime.com
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jane Wagner [Tue, 16 Jun 2009 16:28:06 +0000 (12:28 -0400)]
Revision to my earlier patch for displaying the user name on checked-out items
My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Tue, 16 Jun 2009 17:11:35 +0000 (12:11 -0500)]
Expand interactive SIP tests.
Also tweak interactive item dump to suppress huge fields (marc, marcxml).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Wed, 17 Jun 2009 00:37:51 +0000 (20:37 -0400)]
Bug 3317: Author displaying inconsistently or not at all. Revision to previous patch.
Revision to previous patch for bug 3317. Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.
NTS: Don't use EXPR.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Wed, 17 Jun 2009 13:46:45 +0000 (15:46 +0200)]
(bug #2829) allow isbn13 in sql requests
this patch add the support of the plugin to search for isbn13.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Wed, 17 Jun 2009 12:39:02 +0000 (14:39 +0200)]
(bug #2829) mistake un isbn field
I compare the bad part of the isbn in my first version, now fixed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Sun, 14 Jun 2009 21:43:37 +0000 (17:43 -0400)]
Bug 3317: Author displaying inconsistently or not at all in Cart.
This patch fixes the author and added author fields for the 'More Details' view of opac-basket.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Sat, 13 Jun 2009 02:44:27 +0000 (22:44 -0400)]
Bug 3325: Fixes XHTML errors in opac-basket.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Sat, 13 Jun 2009 14:51:45 +0000 (10:51 -0400)]
Bug 3228: Fix for Type: label in XSLT displays.
Empty nodes must be generated in the XML for MARC21slim2OPACResults - typeOf008 and MARC21slim2OPACResults - materialTypeCode when the fields in the Marc record do not exist. This patch fixes the "Type: " label. More testing needs to be done to see if any other labels appear in the Opac if the data is not defined in the MARC record.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Sun, 14 Jun 2009 05:17:42 +0000 (07:17 +0200)]
Add a Debian Lenny package
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Sun, 14 Jun 2009 08:36:16 +0000 (04:36 -0400)]
Bug 2889: Removed toggle variable from member.pl and .tmpl
Removed toggle variable from member.pl and member.tmpl. Replaced with template variable __odd__.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Mon, 15 Jun 2009 03:20:42 +0000 (22:20 -0500)]
Add Getopt::Long to fines.pl, and option to specify log output directory.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Mon, 15 Jun 2009 10:19:37 +0000 (12:19 +0200)]
(bug #3329) Dependency missing in inventory.pl
The called function AddReturn is in C4::Circulation which is not loaded, this patch do it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
MJ Ray [Mon, 15 Jun 2009 12:51:43 +0000 (13:51 +0100)]
Use strftime to format sessionlog times
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Mon, 15 Jun 2009 15:32:51 +0000 (17:32 +0200)]
Fix an unstranslatable string in JavaScript
For an explanation, see:
http://wiki.koha.org/doku.php?id=en:development:codingguidelines#translatable_text
This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 15 Jun 2009 16:32:19 +0000 (11:32 -0500)]
Update references to batchRebuildBiblioTables
Also fixed escaping of literal "$" characters in usage.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Mon, 15 Jun 2009 17:18:51 +0000 (19:18 +0200)]
Fix bug 3330 - Report notes modification
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 12 Jun 2009 22:33:02 +0000 (17:33 -0500)]
Cleanup stopwords.pl and .tmpl
Remove "toggle" code and useless javascript.
Rework "SimpleSearch" to use just one argument.
Remove unnecessary dependencies.
Remove incorrectly pasted comments.
Remove queries that didn't do anything.
Enable warnings. Use one $dbh. Remove $sth->finish calls.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 12 Jun 2009 22:33:03 +0000 (17:33 -0500)]
Cleanup - moremember.pl and .tmpl
Removed last 3 EXPR statements. Removed toggle code.
Fixed jquery for warning on image deletion.
Fixed permission check for image upload to be granular.
Lots of formatting/whitespace cleanup.
Removed useless form and unused template vars.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Liz Rea [Fri, 12 Jun 2009 13:02:59 +0000 (08:02 -0500)]
Adding a notes column, fixing a typo in TMPL_VAR statement that caused notes not to display.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Thu, 11 Jun 2009 19:15:38 +0000 (15:15 -0400)]
Bug 2889: Removed toggle variable from auth_tag_structure.pl and auth_subfields_structure.pl
Removed toggle variable from auth_tag_structure.pl and .tmpl. Used template __odd__ in auth_tag_structure.tmpl.
Removed toggle variable from auth_subfields_structure.pl and .tmpl. Use __odd__. Removed a type in the highlight class definition. Fixed a minor xhtml error.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 12 Jun 2009 15:31:10 +0000 (10:31 -0500)]
followup - restore correct conditional
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 12 Jun 2009 15:08:40 +0000 (10:08 -0500)]
fixed broken link in patron label search
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Thu, 11 Jun 2009 18:53:31 +0000 (06:53 +1200)]
Missed Chris Nighswonger from the developer list, fixed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Thu, 11 Jun 2009 21:38:59 +0000 (17:38 -0400)]
Bug 2889: Removed unused toggle variables from booksellers.pl. Added table highlighting to booksellers.tmpl.
Removed unused toggle and line(even) variables from booksellers.pl. Added highlighting to the two display tables in booksellers.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 10 Jun 2009 21:53:28 +0000 (16:53 -0500)]
Cleanup: biblio_framework and marctagstructure
Removed unused javascript. Enabled warnings. Use common $dbh.
Removed sth->finish calls. Removed toggle code. Added row highlight where
none had been implemented. Repaired validation error w/ mislocated input tag.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 10 Jun 2009 21:53:27 +0000 (16:53 -0500)]
Cleanup classsources.pl and .tmpl
Relatively minor cleaning.
Remove unused javascript. Add row highlighting to both tables. Remove conditionals where the
behavior is the same for both possibilities.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Thu, 11 Jun 2009 20:44:30 +0000 (16:44 -0400)]
Bug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl
Removed toggle variable from marc_subfields_structure.pl and marc_subfields_structure.tmpl. Used template __odd__ variable instead.
Corrected a typo in the highlight class definition in .tmpl.
Corrected a readability issue with the description when deleting a subfield in .tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Wed, 10 Jun 2009 23:59:01 +0000 (19:59 -0400)]
Bug 2889: Removed toggle variable from stopwords.pl and .tmpl.
Removed toggle variable from stopwords.pl and stopwords.tmpl. Used template __odd_ variable instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 12 Jun 2009 14:25:47 +0000 (09:25 -0500)]
Cleanup - admin scripts
Fixed useless redirect statements that weren't even printed.
Removed unused javascript and script variables;
Removed sth->finish. Use get instead of post on "cancel" button (no data to post).
Reduce duplicative variables (e.g. scriptname and script_name).
Many other problems are still in the scripts, including use of META-REFRESH instead of
redirect, and the whole idea of redirecting back to the same page for no valid reason.
We should be able to formulate the right response on THIS pass, not ask the browser to start over.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Fri, 12 Jun 2009 00:42:37 +0000 (20:42 -0400)]
Bug 2889: Removed unused toggle variable from pcard-member-search.pl. Added table highlighting to .tmpl.
Removed unused toggle variable form pcard-member-search.pl.
Added highlighting to pcard-members-search.tmpl and fixed some XHMTL errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Mon, 8 Jun 2009 19:52:37 +0000 (15:52 -0400)]
Bug 2889: Removed toggle variable from aqbudget.tmpl. Used template variable __odd__ instead.
Removed toggle variable from aqbudget.pl and aqbudget.tmpl. Used template variable __odd__ instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Tue, 9 Jun 2009 14:24:37 +0000 (16:24 +0200)]
Add +(" ")+ to make few strings translatable (with Paul & Galen fix)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Tue, 9 Jun 2009 19:47:07 +0000 (07:47 +1200)]
Adding 10,000th commit to the history
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Tue, 9 Jun 2009 22:13:26 +0000 (18:13 -0400)]
Bug 2889: Added template __odd__ variable to letter.tmpl
Used __odd__ variable instead of toggle in letter.tmpl. No toggle variable was defined in letter.pl.
The table in letter.tmpl uses jquery for highlighting so the above may not be necessary, unless javascript is turned off.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Tue, 9 Jun 2009 22:34:55 +0000 (18:34 -0400)]
Bug 2889: Removed toggle variable from categorie.pl and categorie.tmpl.
Removed toggle variable from categorie.pl and categorie.tmpl. Used template __odd__variable in categorie.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Tue, 9 Jun 2009 22:35:24 +0000 (18:35 -0400)]
Bug 2889: Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl.
Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl. Used template __odd__ variable in aqbookfund.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 10 Jun 2009 19:04:50 +0000 (14:04 -0500)]
Cleanup authtypes and currency .pl and .tmpl
Removed unused javascript. Enabled warnings. Use common $dbh.
Removed sth->finish calls. Removed toggle code. Added row highlight where
none had been implemented. Added some HTML escaping in TMPL.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Wed, 10 Jun 2009 23:48:40 +0000 (19:48 -0400)]
Bug 2889: Removed toggle variables from z3950servers.pl and .tmpl
Removed toggle variables from z3950servers.pl and z3950servers.tmpl. Used template __odd__variable instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Thu, 11 Jun 2009 00:23:52 +0000 (20:23 -0400)]
Bug 2889: Added highlighting to smart-rules.tmpl
Removed unused toggle variable form smart-rules.pl and added highlighting to smart-rules.tmpl through template __odd__.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Thu, 11 Jun 2009 00:47:31 +0000 (20:47 -0400)]
Bug 2889: Removed toggle variable from roadtype.pl and .tmpl.
Removed toggle variable from roadtype.pl and roadtype.tmpl. Corrected typo in class definition in roadtype.tmpl and add highlighting through the templated __odd__ variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 9 Jun 2009 14:29:14 +0000 (09:29 -0500)]
removing disused C4::Serials functions
The following functions are no longer in use:
* old_newsubscription
* old_modsubscription
* old_getserials
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 9 Jun 2009 14:26:11 +0000 (09:26 -0500)]
removing disused script
serials/subscription-copy.pl had been removed
in commit
8c78ff5aa5d52e3b16ea4c45cc38dc6999100ac3 but
for some reason had been accidentally restored in
a subsequent commit.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Tue, 9 Jun 2009 08:17:07 +0000 (10:17 +0200)]
Bug 3316 - Improve last 3 issues displayed on OPAC detail page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Mon, 8 Jun 2009 23:29:48 +0000 (11:29 +1200)]
Escaping HTML in the search results in the Librarian interface
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Mon, 8 Jun 2009 23:58:13 +0000 (19:58 -0400)]
Bug 2889: Removed toggle variable from itemtypes.tmpl. (resubmittal)
Removed toggle variable from itemtypes.tmpl and itemtypes.pl. Used the __odd__ template variable instead.
Resubmittal - first patch contained a typo.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Mon, 8 Jun 2009 09:10:07 +0000 (11:10 +0200)]
(bug #3304) fix notices trigger with diacritics in categorycodes
This just utf8::encode the $key if needed to permit categorycodes with diacritics.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 8 Jun 2009 20:11:42 +0000 (15:11 -0500)]
bug 3314: remove disused scripts and API functions
The distributedto column of the subscription table is
no longer used, having been replaced by the serials
routing list table. This patch removes two C4::Serials
functions and a script and template, none of which were
reachable by current code:
C4::Serials::GetDistributedTo()
C4::Serials::SetDistributedTo()
koha-tmpl/intranet-tmpl/prog/en/modules/serials/distributedto.tmpl
serials/distributedto.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Brian Harrington [Mon, 8 Jun 2009 19:43:20 +0000 (15:43 -0400)]
Bug 3313, bulkauthimport.pl skips MARC21 subdivision records.
This patch adds the MARC21 subdivsion record tags (18x) to the
block which recognizes and assigns authtypecodes to imported
authority records.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 8 Jun 2009 21:57:12 +0000 (16:57 -0500)]
fixed bug resulting in invalid XHTML
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Mon, 8 Jun 2009 19:45:01 +0000 (15:45 -0400)]
Bug 2889: Removed toggle variable from overduerules.tmpl - added __odd__
Removed toggle variable from overduerules.pl and overduerules.tmpl. Used template variable __odd__ instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Mon, 8 Jun 2009 19:48:21 +0000 (15:48 -0400)]
Bug 2889: Added shading for alternating rows to authorised_values.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Mon, 8 Jun 2009 20:54:23 +0000 (16:54 -0400)]
Bug 2889: Removed toggle variable from koha2marclinks.tmpl. Used template __odd__ variable.
Removed toggle variable from koha2marclinks.tmpl and koh2marclinks.pl. Used template __odd__ variable instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Mon, 8 Jun 2009 21:36:25 +0000 (17:36 -0400)]
Bug 2889: Removed toggle variable from currency.tmpl. Used template __odd__ instead.
Removed toggle variable from currency.tmpl and currency.pl. Used template __odd_ variable instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 8 Jun 2009 16:06:05 +0000 (11:06 -0500)]
fix XHTML error
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Matthias Meusburger [Mon, 8 Jun 2009 12:32:08 +0000 (14:32 +0200)]
bug 3292: in opac branchcode should be replaced with name
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:51 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4::Breeding
* also start to standardize ISBN normalization
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:50 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4::Log
Also corrected several links to viewlog.pl that
didn't take into account the recent renaming
of one of its parameters from 'module' to 'modules'
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:49 +0000 (10:02 +1200)]
bug 2505: enable warnings in call number normalization modules
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:48 +0000 (10:02 +1200)]
removed incorrect module import
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:47 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4/Input.pm
Also removed POD containing disused function
checkvalidisbn.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:46 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4::ImportBatch and C4::Matcher
Also fix issues with normalizing ISBNs and the default
normalizer in C4::Matcher.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:45 +0000 (10:02 +1200)]
bug 3303: removed references to news_channels*
Removed routines in C4/NewsChannels.pm that refered
to missing database tables news_channels and news_channel_categories.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:44 +0000 (10:02 +1200)]
bug 3302: removed disused references to opac_electronic
Removed routines in C4/NewsChannels.pm that refer to
a missing opac_electronic table.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:43 +0000 (10:02 +1200)]
bug 2505: enabled warnings in C4::NewsChannels
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 22:02:42 +0000 (10:02 +1200)]
bug 2505: turn on warnings in seven modules
C4::XSLT
C4::VirtualShelves
C4::Review
C4::Output
C4::Boolean
C4::Charset
C4::Stats
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 7 Jun 2009 19:31:43 +0000 (14:31 -0500)]
additional cleanup in GetItemsInfo()
* remove unused variable
* moved declaration of $count_reseves
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
David Birmingham [Fri, 5 Jun 2009 20:40:55 +0000 (16:40 -0400)]
Removed a buggy conditional if that resulted in an incorrect item status
Previous conditional check with if ($restype) is not needed because a true
result for one item will result in subsqeuent items defaulting to this true
value.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 6 Jun 2009 19:26:18 +0000 (14:26 -0500)]
bug 3299: fix setting renewal due date explicitly
When renewing a loan from the patron details page, setting
the renewal due date now works again. Broken by patch
for bug 2770.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 6 Jun 2009 21:45:54 +0000 (16:45 -0500)]
bug 2926: fix staging import hang
Fixes a hang of the staging import tool when it
attempts to process a MARC21 record that claims
that it's UTF-8 when it is not. The staging import
will now attempt to fix the character encoding of such
records.
Also added a FIXME to bulkmarcimport.pl, which because
of its use of MARC::Batch will skip over such records -
better than the original hang of the staging import, but
worse than the staging import's new ability to fix such
records.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 6 Jun 2009 21:54:48 +0000 (16:54 -0500)]
bug 3278: move three sysprefs to Staff client tab
* viewMARC
* viewISBN
* viewLabeledMARC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 6 Jun 2009 23:13:22 +0000 (18:13 -0500)]
bug 3201: missing090field.pl - skip bad bibs
Patch courtesy of G. Henry <henry@cmi.univ-mrs.fr>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 6 Jun 2009 23:25:21 +0000 (18:25 -0500)]
bug 2737: fixed typo in MARC21 008 plugin
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Garry Collum [Thu, 7 May 2009 23:40:16 +0000 (19:40 -0400)]
Bug 3081: Add description for category code.
Adds the category code to the description in "my personal details" in opac.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 8 Apr 2009 10:18:39 +0000 (12:18 +0200)]
bug 3097: statistics on itemcount not working
replacing issues.itemnumber by statistics.itemnumber
since issues was not included in the query.
All statistics on circulation for item count were zeroed.
[RM note: specifically, this patch fixes the results
when you set the 'cell value' to 'count unique items']
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
projects / koha.git / log