koha.git
11 years agomove our panels to top, run only low-impact debug
Dobrica Pavlinusic [Mon, 2 Apr 2012 19:15:08 +0000 (21:15 +0200)]
move our panels to top, run only low-impact debug

11 years agoplack enable memcached
Dobrica Pavlinusic [Mon, 2 Apr 2012 19:15:01 +0000 (21:15 +0200)]
plack enable memcached

11 years agoremove debug output
Dobrica Pavlinusic [Mon, 2 Apr 2012 19:02:59 +0000 (21:02 +0200)]
remove debug output

11 years agoPlack Koha panel to eval code and display result
Dobrica Pavlinusic [Mon, 2 Apr 2012 18:43:36 +0000 (20:43 +0200)]
Plack Koha panel to eval code and display result

This is useful to introspect current instance sense of various configuration values

11 years agofix MEMCACHED_DEBUG
Dobrica Pavlinusic [Mon, 2 Apr 2012 18:37:35 +0000 (20:37 +0200)]
fix MEMCACHED_DEBUG

11 years agoKoha::Persist - emit debug output according to DEBUG=2 level
Dobrica Pavlinusic [Mon, 2 Apr 2012 18:36:57 +0000 (20:36 +0200)]
Koha::Persist - emit debug output according to DEBUG=2 level

11 years agoBug 7177 - memoize GetItemTypes
Dobrica Pavlinusic [Mon, 2 Apr 2012 17:59:08 +0000 (19:59 +0200)]
Bug 7177 - memoize GetItemTypes

echo 'select count(*) from itemtypes' | mysql koha_srvgit
count(*)
12

Profile Path: select * from itemtypes where itemtype=?
Profile Data: 0.021141s / 504 = 0.000042s avg (first 0.000048s, min 0.000015s, max 0.000097s)

504 >> 12

11 years agocollect $Koha::Persistant::stats for existing code
Dobrica Pavlinusic [Mon, 2 Apr 2012 17:41:14 +0000 (19:41 +0200)]
collect $Koha::Persistant::stats for existing code

11 years agodrop Linux cache using sudo
Dobrica Pavlinusic [Mon, 2 Apr 2012 17:33:34 +0000 (19:33 +0200)]
drop Linux cache using sudo

11 years agoPlack::Middleware::Debug::Persistant to view Koha::Persistant stats
Dobrica Pavlinusic [Mon, 2 Apr 2012 15:58:52 +0000 (17:58 +0200)]
Plack::Middleware::Debug::Persistant to view Koha::Persistant stats

11 years agomarc_subfield_structure
Dobrica Pavlinusic [Mon, 2 Apr 2012 15:25:55 +0000 (17:25 +0200)]
marc_subfield_structure

11 years agouse Koha::Persistant authorised_value
Dobrica Pavlinusic [Mon, 2 Apr 2012 13:32:18 +0000 (15:32 +0200)]
use Koha::Persistant authorised_value

11 years agoplack reload Koha modules
Dobrica Pavlinusic [Mon, 2 Apr 2012 13:31:29 +0000 (15:31 +0200)]
plack reload Koha modules

11 years agomulti-dimensional cache using evals
Dobrica Pavlinusic [Mon, 2 Apr 2012 00:14:41 +0000 (02:14 +0200)]
multi-dimensional cache using evals

11 years agoKoha::Persistant authorised_values
Dobrica Pavlinusic [Sun, 1 Apr 2012 23:18:43 +0000 (01:18 +0200)]
Koha::Persistant authorised_values

11 years agoupdate Plack::Middleware::Debug::Devel::Size to latest
Dobrica Pavlinusic [Sun, 1 Apr 2012 19:28:07 +0000 (21:28 +0200)]
update Plack::Middleware::Debug::Devel::Size to latest

11 years agoadded Plack::Middleware::Debug::Devel::Size
Dobrica Pavlinusic [Sun, 1 Apr 2012 14:40:22 +0000 (16:40 +0200)]
added Plack::Middleware::Debug::Devel::Size

11 years agoMEMCACHE_DEBUG added
Dobrica Pavlinusic [Sun, 1 Apr 2012 13:20:41 +0000 (15:20 +0200)]
MEMCACHE_DEBUG added

11 years ago7863 test scenario
Dobrica Pavlinusic [Sat, 31 Mar 2012 22:12:38 +0000 (00:12 +0200)]
7863 test scenario

11 years agoplackup reload opac and modules
Dobrica Pavlinusic [Sat, 31 Mar 2012 21:15:31 +0000 (23:15 +0200)]
plackup reload opac and modules

11 years agoBug 7844 - sudo with xmlstarlet
Dobrica Pavlinusic [Sat, 31 Mar 2012 00:09:07 +0000 (02:09 +0200)]
Bug 7844 - sudo with xmlstarlet

11 years agoBug 7857 - remove exit 1 for plack
Dobrica Pavlinusic [Fri, 30 Mar 2012 20:45:07 +0000 (22:45 +0200)]
Bug 7857 - remove exit 1 for plack

11 years agofrom http://wiki.koha-community.org/wiki/Plack
Chris Cormack [Fri, 30 Mar 2012 20:33:51 +0000 (22:33 +0200)]
from http://wiki.koha-community.org/wiki/Plack

11 years agoBug 7857 - database upgrade fails with plack
Dobrica Pavlinusic [Fri, 30 Mar 2012 20:03:20 +0000 (22:03 +0200)]
Bug 7857 - database upgrade fails with plack

Updating database structure

Update errors :

    Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 .) at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.
    BEGIN failed--compilation aborted at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.

It seems that plack cleans enviroment, so we have to re-instart PERL5LIB
so script invocation won't fail.

11 years agokoha installers needs it's directory
Dobrica Pavlinusic [Fri, 30 Mar 2012 19:32:21 +0000 (21:32 +0200)]
koha installers needs it's directory

11 years agoBug 7847 - OPAC search dies with plack
Dobrica Pavlinusic [Thu, 29 Mar 2012 15:56:12 +0000 (17:56 +0200)]
Bug 7847 - OPAC search dies with plack

This bug was uncovered by @mglavica during HackFest in Marseille
It also showed it's ugly head during my plack presentation

11 years agoBug 7844 - plack intranet tooling for developers
Dobrica Pavlinusic [Thu, 29 Mar 2012 10:27:05 +0000 (12:27 +0200)]
Bug 7844 - plack intranet tooling for developers

koha.psgi example and script to run any Koha site intranet or opac under plack

It also defines new enviroment variables:

PLACK_DEBUG=1  - turn Plack debug panels on
PLACK_MINIFY=1 - minify JavaScript and CSS which saves us ~10k on each page load

Test scenario:
1. install plack and dependencies, using ./cpanm-install.pl

2. start ./intranet-plack.sh sitename

3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl
   and verify that it works

4. start ./opac-plack.sh sitename

5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl
   and very that it works

11 years agoBug 4330 : Adding copyright headers and fixing FSF addresses
Chris Cormack [Mon, 21 May 2012 08:06:36 +0000 (20:06 +1200)]
Bug 4330 : Adding copyright headers and fixing FSF addresses

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 4330 : Fixing FSF address and copyright headers for acqui/
Chris Cormack [Sun, 20 May 2012 23:03:21 +0000 (11:03 +1200)]
Bug 4330 : Fixing FSF address and copyright headers for acqui/

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 4330 : Last of the opac files with wrong FSF address
Chris Cormack [Sun, 20 May 2012 10:45:50 +0000 (22:45 +1200)]
Bug 4330 : Last of the opac files with wrong FSF address

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 4330 : Adding missing license statement
Chris Cormack [Sun, 20 May 2012 10:30:41 +0000 (22:30 +1200)]
Bug 4330 : Adding missing license statement

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 4330 Fixing FSF statements
Chris Cormack [Sun, 20 May 2012 10:27:29 +0000 (22:27 +1200)]
Bug 4330 Fixing FSF statements

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 4330 : Fixing FSF address and copyright statements
Chris Cormack [Sun, 20 May 2012 10:14:04 +0000 (22:14 +1200)]
Bug 4330 : Fixing FSF address and copyright statements

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 4330 : Fixing FSF address and copyright headers
Chris Cormack [Sun, 20 May 2012 09:55:55 +0000 (21:55 +1200)]
Bug 4330 : Fixing FSF address and copyright headers

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7127 - Templates must be valid XHTML
Owen Leonard [Thu, 24 May 2012 14:17:31 +0000 (10:17 -0400)]
Bug 7127 - Templates must be valid XHTML

Fixing markup errors on OPAC detail page and OPAC results.
Also conditionally including ratings JS on OPAC detail.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8144 - 775 tag in the MARC record causes display issue
Paul Poulain [Mon, 28 May 2012 15:36:32 +0000 (17:36 +0200)]
Bug 8144 - 775 tag in the MARC record causes display issue

Fixing XSL template in the OPAC and staff client following
recommendations by Jared.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Fixes the markup and correctly displays 775 notes.

11 years agoBug 8145 - [SIGNED-OFF] opac-tags.pl fails when DEBUG is set
Mason James [Wed, 23 May 2012 20:17:07 +0000 (08:17 +1200)]
Bug 8145 - [SIGNED-OFF] opac-tags.pl fails when DEBUG is set

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoMerge remote-tracking branch 'origin/new/bug_6858'
Paul Poulain [Mon, 28 May 2012 14:35:53 +0000 (16:35 +0200)]
Merge remote-tracking branch 'origin/new/bug_6858'

11 years agoBug 6858: Adds staticfines.pl for static fines processing
Matthias Meusburger [Wed, 23 Mar 2011 15:19:07 +0000 (16:19 +0100)]
Bug 6858: Adds staticfines.pl for static fines processing

Add a tool to calculate static fine. For example, 7 days left = 1€ fixed fine

Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
11 years agoMerge remote-tracking branch 'origin/new/bug_8150'
Paul Poulain [Mon, 28 May 2012 14:28:23 +0000 (16:28 +0200)]
Merge remote-tracking branch 'origin/new/bug_8150'

11 years agoBug 8150 [SIGNED-OFF] Remove obsoleted navigation bar in circ history
Colin Campbell [Thu, 24 May 2012 16:09:08 +0000 (17:09 +0100)]
Bug 8150 [SIGNED-OFF] Remove obsoleted navigation bar in circ history

The navigation bar is now supplied by the datatables plugin
however we are still calling the old navigation include
resulting in a second navigation bar which does nor work

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised, without introducing any bad side effects that
I can see.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7959 - Update OPAC suggestions interface to match lists
Owen Leonard [Fri, 13 Apr 2012 19:21:49 +0000 (15:21 -0400)]
Bug 7959 - Update OPAC suggestions interface to match lists

Marking up suggestions "toolbar" to match the interface in
lists. Actions which require an item to be selected (deleting
a suggestion) should not be available if nothing is selected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7959 - Update OPAC suggestions interface to match lists
Owen Leonard [Fri, 13 Apr 2012 19:21:49 +0000 (15:21 -0400)]
Bug 7959 - Update OPAC suggestions interface to match lists

Marking up suggestions "toolbar" to match the interface in
lists. Actions which require an item to be selected (deleting
a suggestion) should not be available if nothing is selected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 8122 - Followup Add a link to new library group creation from empty groups message
Jonathan Druart [Tue, 22 May 2012 09:46:34 +0000 (11:46 +0200)]
Bug 8122 - Followup Add a link to new library group creation from empty groups message

Set outside tables the "no group defined" message.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 8122 - Add a link to new library group creation from empty groups message
Owen Leonard [Fri, 18 May 2012 13:42:13 +0000 (09:42 -0400)]
Bug 8122 - Add a link to new library group creation from empty groups message

When there are no groups, add a link to group creation from
the message, "No properties defined."

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
11 years agoBug 8095 - Printed lists in the OPAC not easy to read
Owen Leonard [Fri, 18 May 2012 16:53:31 +0000 (12:53 -0400)]
Bug 8095 - Printed lists in the OPAC not easy to read

Adding more details to the print stylesheet to better
adapt the layout for printing.

Testers please clear your browser cache to ensure you
have the updated CSS file and test multiple pages, not
just the lists page.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agobug_8056: sorted out slip print calls
Srdjan [Mon, 14 May 2012 03:17:13 +0000 (15:17 +1200)]
bug_8056: sorted out slip print calls

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
preference works as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Tested that CircAutoPrintQuickSlip clear the screen still works well

11 years agoBug 7792 follow-up DBRev number
Paul Poulain [Mon, 28 May 2012 10:00:02 +0000 (12:00 +0200)]
Bug 7792 follow-up DBRev number

11 years agoBug 7792:redefine the field branchcode as PRIMARY KEY of branches
Paul Poulain [Mon, 28 May 2012 09:59:44 +0000 (11:59 +0200)]
Bug 7792:redefine the field branchcode as PRIMARY KEY of branches

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7794: follow-up DBRev number + removing UNIQUE index that is now useless
Paul Poulain [Mon, 28 May 2012 09:55:23 +0000 (11:55 +0200)]
Bug 7794: follow-up DBRev number + removing UNIQUE index that is now useless

11 years agoBug 7794:redefine the field id as PRIMARY KEY of sessions
Stéphane Delaune [Thu, 22 Mar 2012 10:48:36 +0000 (11:48 +0100)]
Bug 7794:redefine the field id as PRIMARY KEY of sessions

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 8014 - On the patron entry form hide "restricted until" field if "Restricted...
Owen Leonard [Fri, 27 Apr 2012 12:57:16 +0000 (08:57 -0400)]
Bug 8014 - On the patron entry form hide "restricted until" field if "Restricted: No" is checked

This patch adds JavaScript to automatically hide the "Restricted
unil" form field on the patron entry form if "Restricted: No" is
selected. If "Restricted: Yes" is chosen the "Until:" field
is shown and focus is given to it.

The patch also adds a note, "(optional)" after the "Until:" field
to make it clearer that a date is not required.

To test, open a patron record and try moving the selection
between "Restricted: No" and "Restricted: Yes." Confirm that
the "Until:" field is shown and hidden as expected. Confirm
that the restricted flag is correctly set or unset upon save,
including setting the flag with or without a date.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoWelcome to the 182th commiter !
Paul Poulain [Mon, 28 May 2012 09:29:28 +0000 (11:29 +0200)]
Welcome to the 182th commiter !

11 years agoBug 6684: Fixes to koha-remove
Simon Story [Fri, 18 Nov 2011 14:52:09 +0000 (14:52 +0000)]
Bug 6684: Fixes to koha-remove

Fixes bugs 6684 6997 4880:
6684 koha-remove should check the number of arguments it gets
6997 koha-remove leaves system in inconsistent state if there is an error
4880 koha-remove sometimes fails because user is logged in

Amended by chrisc@catalyst.net.nz
Trying to resolve conflicts.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on top of bug 7924.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoug 8078 [REVISED] my summary showing contents of incorrect tab
Owen Leonard [Fri, 11 May 2012 19:25:05 +0000 (15:25 -0400)]
ug 8078 [REVISED] my summary showing contents of incorrect tab

This patch moves the holdings tab content to the correct
position sequentially with regard to the order of the
tabs themselves. My guess is that the jQuery upgrade has
something to do with this change but I'm not sure why
(probably something in our aging tabs plugin which works
differently with the new jQuery version).

Making the sequence of the tab contents match the sequence
of the tabs seems to fix the problem.

Revised to correct the error in placement of the tags markup
in the staff client.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7846 - get_batch_summary massive speedup
Dobrica Pavlinusic [Thu, 29 Mar 2012 13:39:17 +0000 (15:39 +0200)]
Bug 7846 - get_batch_summary massive speedup

current code is using DISTINCT and another SQL query which can be replaced with GROUP BY
for massive speedup. In our case, generating Manage Batches screen DBI time decreased
from 24.762 s to 0.147 s

Aside from correct usage of relational database, this change also cleans up code nicely.

This change removed semi-columns from SQL query which broke Manage Patron batches.

Test scenario:

1. open Manage Batches screen and take note of time needed to generate it
2. apply this patch
3. reload page and check page genration time

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7926: Acq search results show empty () for orders without basket group
Katrin Fischer [Mon, 9 Apr 2012 14:52:56 +0000 (16:52 +0200)]
Bug 7926: Acq search results show empty () for orders without basket group

To test:
- search for orders by title or vendor
- make sure some results are attached to a basket group, while others are not
- make sure correct information shows in the basket group column of search results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Fixed merge conflict

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7980: [SIGNED-OFF] Group search results tag input with other actions
Owen Leonard [Wed, 18 Apr 2012 15:32:48 +0000 (11:32 -0400)]
Bug 7980: [SIGNED-OFF] Group search results tag input with other actions

This patch hides the tag input form in OPAC search results when
TagsInputOnList is turned on. An "Add tag" is added to the
"Actions" line. Clicking the link un-hides the tag input form.
A "Cancel" link hides it again.

The patch also moves the display of ratings to the bottom of
the list so that existing tags are grouped with the other
title details which are prefixed with a label ("Type:",
"Availability", etc.).

To test, enable the TagsInputOnList system preference. Do a search
and try adding tags from the search results list.

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 8080 - login and password is pre-filled by the browser when creating a new patron
Kyle M Hall [Mon, 14 May 2012 12:22:14 +0000 (08:22 -0400)]
Bug 8080 - login and password is pre-filled by the browser when creating a new patron

When creating a new patron, if you have chosen to let your browser remember your
login and password for you, the login and password fields will be pre-filled with
them, leading to a systematic error "the passwords entered do not match" since
the second password field was not filled. These fields should be blank.

Add the directive autocomplete="off" to the memberentry form tags.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes t xt
enhances usability of password forms, gets my signoff.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 8107 - Disabled buttons not distinguishable from enabled buttons
Owen Leonard [Fri, 18 May 2012 15:51:17 +0000 (11:51 -0400)]
Bug 8107 - Disabled buttons not distinguishable from enabled buttons

Add a "greyed-out" style for disabled buttons.

Having looked through the templates for examples of usage of this
I'm not convinced that we should really be showing disabled buttons.
I think in general it would be better to hide or show a button
based on whether the action is available.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I agree, I think hiding or showing is better, but this patch is
harmless enough, until we want to go fixing our usage

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 5345: DataTables integration in acquisition module [4]
Jonathan Druart [Thu, 24 May 2012 12:20:47 +0000 (14:20 +0200)]
Bug 5345: DataTables integration in acquisition module [4]

basket.tt
'Modify' and 'Delete' columns become unsortable

http://bugs.koha-community.org/show_bug.cgi?id=8109
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 5345: DataTables integration in acquisition module [4]
Jonathan Druart [Fri, 17 Feb 2012 14:56:08 +0000 (15:56 +0100)]
Bug 5345: DataTables integration in acquisition module [4]

basket.tt

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Columns for 'Modify' and 'Delete' are sortable, which doesn't hurt but could be removed.

http://bugs.koha-community.org/show_bug.cgi?id=8109

11 years agoBug 8009: Followup Item descriptive data not populated on pay.pl
Jonathan Druart [Tue, 15 May 2012 14:29:46 +0000 (16:29 +0200)]
Bug 8009: Followup Item descriptive data not populated on pay.pl

Separation of title from the description.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 8009: Item descriptive data not populated on pay.pl
D Ruth Bavousett [Wed, 25 Apr 2012 13:06:31 +0000 (06:06 -0700)]
Bug 8009: Item descriptive data not populated on pay.pl

GetBorNotifyAcctRecord was not populating the {title} element of the
hash, which pay.tt will use.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7889 [Acquisitions] Use standard style for errors and messages
Owen Leonard [Thu, 17 May 2012 19:09:42 +0000 (15:09 -0400)]
Bug 7889 [Acquisitions] Use standard style for errors and messages

Correcting style of the warning on the Acquisitions home page
which appears if no budgets have been defined.

Also correcting the logic by which the warning appears, as a
change to the script inadvertently prevented it.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7889 [Search errors] Use standard style for errors and messages
Owen Leonard [Thu, 17 May 2012 16:56:48 +0000 (12:56 -0400)]
Bug 7889 [Search errors] Use standard style for errors and messages

There are two instances in the templates where markup is defined
for displaying search errors. I've never seen these appear and I
have no idea what kind of error might trigger it, but now it will
display correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
11 years agoBug 7889 [Authorities duplicates] Use standard style for errors and messages
Owen Leonard [Thu, 17 May 2012 16:58:30 +0000 (12:58 -0400)]
Bug 7889 [Authorities duplicates] Use standard style for errors and messages

The warning shown in the authorities editor when there is
a possible duplicate is styled incorrectly. In addition the
design of the warning is inconsistent with that shown in the
bibliographic record editor.

This patch revises the style and layout of the duplicate error
box. It also corrects a problem which appears in the biblio
and authority editors where a non-existent JS window function
was called. I have added the function to the default JS include
and revised the editor pages to use it.

To test:

- Create a record in both the cataloging and authorities
  editors which will trigger a duplicate warning.
- Click the link to the existing record. A separate window
  should pop up.
- In both editors try each option:
   - Confirm the duplicate and go to the existing record.
   - Deny that the record is duplicate and continue to save.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
11 years agoBug 7889 - Use standard style for errors and messages
Owen Leonard [Thu, 17 May 2012 15:24:06 +0000 (11:24 -0400)]
Bug 7889 - Use standard style for errors and messages

Styling subscription renew message according to standard style.
Also:
 - Adding direct link to renew from message suggesting renew.
 - Adding output of expiration date to message.

To test open a subscription with an impending expiration. You
should see a dialog-styled message, "Subscription will expire XX/XX/XXXX.
Renew this subscription."

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
11 years agoBug 8040: bad name in acquisitions-menu
Stéphane Delaune [Thu, 3 May 2012 08:29:53 +0000 (10:29 +0200)]
Bug 8040: bad name in acquisitions-menu

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 5795 follow-up, DBRev number
Paul Poulain [Thu, 24 May 2012 16:08:36 +0000 (18:08 +0200)]
Bug 5795 follow-up, DBRev number

11 years agoBug 5795 Update the database as follow-up If sys pref
Amit Gupta [Tue, 22 May 2012 10:32:31 +0000 (16:02 +0530)]
Bug 5795 Update the database as follow-up If sys pref

ReservesControlBranch has null then update the table to
insert a PatronLibrary as value

To Test:
1) Go to mysql use koha database
2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary.
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
| variable              | value           | options                       | explanation                                     | type   |
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
| ReservesControlBranch | PatronLibrary   | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice |
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer
Katrin Fischer [Sat, 14 Apr 2012 11:12:54 +0000 (13:12 +0200)]
Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer

sysprefs.sql file was missing ReservesControlBranch.

To test:
1) Create a new installation and check sysprefs.sql loads correctly.
2) Check ReservesControlBranch shows up correctly in the sys pref editor.
3) Check sys pref can be edited and new value saves correctly.

Signed-off-by: Marc Veron <veron@veron.ch>
- Line is added at the end of installer/data/mysql/sysprefs.sql
- Tested Line diretly in MySQL with a systempreferences table where variable 'ReservesControlBranch' was missing. Data inserted correctly.
- Syspref shows up in Staff client

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Fixed merge conflict

11 years agoBug 8124 - Hide option to download results of items with no checkouts report
Owen Leonard [Fri, 18 May 2012 14:53:11 +0000 (10:53 -0400)]
Bug 8124 - Hide option to download results of items with no checkouts report

We should not show disabled controls for features which don't work.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7112 - Having two prices in 020$c causes basket creation to fail from staged...
Kyle M Hall [Wed, 8 Feb 2012 17:16:20 +0000 (12:16 -0500)]
Bug 7112 - Having two prices in 020$c causes basket creation to fail from staged marc import

The root problem here is that the price is being pulled from the MARC record
and is then run through Number::Format::unformat_number. This routine is
really being misused, and should only be used to reverse the effects of
Number::Format on a number string. We are apparently using it to strip
out currency characters and the like.

Number::Format::unformat_number will choke if there is more than one period (.)
in the price field. MARC standards do not limit this field to a single period,
so unless there is only one period, we should skip number unformatting.
Examples of that break unformat_number include '18.95 (U.S.)', and
'$5.99 ($7.75 CAN)', both of which are perfectly valid.

This commit adds the function MungeMarcPrice that will better handle
find a real price value in a given price field. It does a very good
job at finding a price in any currency format, and attempts to find
a price in whichever currency is active before falling back to
the first valid price it can find.

The variable $price may fail to have an actual price, in which case
the price then defaults to '0.00', which would be rarely if ever the
correct price. To combat this, I have added highlighting to any
price in the Order Details table that begins with 0 ( i.e. '0.00' ).

Also, fixed the incomplete table footer, adding a new td with a
span of 3 to fill in the nonexistant cells.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8135 : Fix installer to copy services/ dir
Chris Cormack [Tue, 22 May 2012 07:35:59 +0000 (19:35 +1200)]
Bug 8135 : Fix installer to copy services/ dir

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
http://bugs.koha-community.org/show_bug.cgi?id=7318

11 years agoBug 8128 - [SIGNED-OFF]Followup - Change default value for cache_expiry
Kyle M Hall [Tue, 22 May 2012 12:21:47 +0000 (08:21 -0400)]
Bug 8128 - [SIGNED-OFF]Followup - Change default value for cache_expiry

Change default value for cache_expiry from 0 to 300.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 8128 - can't seem to run new sql reports
Kyle M Hall [Fri, 18 May 2012 19:01:45 +0000 (15:01 -0400)]
Bug 8128 - can't seem to run new sql reports

Reports cannot be saved because saved_sql.cache_expiry cannot be null.
Fixed by setting default to 0 if a cache_expiry value is not
passed into the function.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes t xt

Verified original bug, patch resolves issue.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7398 follow-up DBRev number
Paul Poulain [Thu, 24 May 2012 13:47:37 +0000 (15:47 +0200)]
Bug 7398 follow-up DBRev number

11 years agobug_7398: Replaced OPACDisplayRequestPriority syspref with OPACShowHoldQueueDetails
Srdjan [Wed, 23 May 2012 01:03:02 +0000 (13:03 +1200)]
bug_7398: Replaced OPACDisplayRequestPriority syspref with OPACShowHoldQueueDetails

New syspref is Choice, options being:
- None
- Priority only
- Holds number only
- Holds number and priority

Show holds count on OPAC detail

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoMerge remote-tracking branch 'origin/new/bug_7178'
Paul Poulain [Thu, 24 May 2012 13:02:21 +0000 (15:02 +0200)]
Merge remote-tracking branch 'origin/new/bug_7178'

11 years agoBug 7178 follow-up: Do not fill items table with "(undefined)"
Julian Maurice [Tue, 22 May 2012 08:47:01 +0000 (10:47 +0200)]
Bug 7178 follow-up: Do not fill items table with "(undefined)"

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7178 follow-up: Fix check_additem when UniqueItemFields is empty
Julian Maurice [Fri, 11 May 2012 14:40:11 +0000 (16:40 +0200)]
Bug 7178 follow-up: Fix check_additem when UniqueItemFields is empty

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoBug 7977 follow-up DBRev number
Paul Poulain [Thu, 24 May 2012 12:33:30 +0000 (14:33 +0200)]
Bug 7977 follow-up DBRev number

11 years agoBug 7977 follow-up, fixing UC breaking coding guidelines
Paul Poulain [Thu, 24 May 2012 12:33:19 +0000 (14:33 +0200)]
Bug 7977 follow-up, fixing UC breaking coding guidelines

11 years agoadd edit_quotes to es-ES/mandatory/userpermissions.sql
Mason James [Tue, 22 May 2012 23:27:55 +0000 (11:27 +1200)]
add edit_quotes to es-ES/mandatory/userpermissions.sql

Signed-off-by: Mason James <mtj@kohaaloha.com>
http://bugs.koha-community.org/show_bug.cgi?id=7977
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
11 years agoFixing a typo in the quotes-upload help file and hardcoded css
Chris Nighswonger [Mon, 21 May 2012 18:11:29 +0000 (14:11 -0400)]
Fixing a typo in the quotes-upload help file and hardcoded css

http://bugs.koha-community.org/show_bug.cgi?id=7977
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoMaking source a text field rather than a varchar to avoid potential length limitations
Chris Nighswonger [Mon, 21 May 2012 18:08:57 +0000 (14:08 -0400)]
Making source a text field rather than a varchar to avoid potential length limitations

http://bugs.koha-community.org/show_bug.cgi?id=7977
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Improving upload result message display
Chris Nighswonger [Fri, 11 May 2012 15:49:22 +0000 (11:49 -0400)]
Bug 7977: Improving upload result message display

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Fixing a bug which results in quote fields being incorrectly offset when...
Chris Nighswonger [Fri, 11 May 2012 14:35:25 +0000 (10:35 -0400)]
Bug 7977: Fixing a bug which results in quote fields being incorrectly offset when saving uploaded quotes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Removing unused code from quotes_ajax.pl
Chris Nighswonger [Fri, 11 May 2012 11:42:06 +0000 (07:42 -0400)]
Bug 7977: Removing unused code from quotes_ajax.pl

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Followup patch addressing items pointed out by Jonathan Druart
Chris Nighswonger [Fri, 11 May 2012 00:57:33 +0000 (20:57 -0400)]
Bug 7977: Followup patch addressing items pointed out by Jonathan Druart

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Adding Koha standard help files for QOTD feature
Chris Nighswonger [Mon, 7 May 2012 23:59:54 +0000 (19:59 -0400)]
Bug 7977: Adding Koha standard help files for QOTD feature

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Adding Daily Quotes Tests to Koha.t test suite; also fixing sort order...
Chris Nighswonger [Mon, 7 May 2012 18:53:50 +0000 (14:53 -0400)]
Bug 7977: Adding Daily Quotes Tests to Koha.t test suite; also fixing sort order on quote selection SQL

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Fixing quote sample data timestamps
Chris Nighswonger [Mon, 7 May 2012 19:02:44 +0000 (15:02 -0400)]
Bug 7977: Fixing quote sample data timestamps

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Fixing captialization on the tools main page
Chris Nighswonger [Mon, 7 May 2012 16:07:55 +0000 (12:07 -0400)]
Bug 7977: Fixing captialization on the tools main page

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Further UI work on the QOTD editor
Chris Nighswonger [Mon, 7 May 2012 15:58:09 +0000 (11:58 -0400)]
Bug 7977: Further UI work on the QOTD editor

This patch implements more of oleonard's suggestions as well as other
improvments:

--Adds instructions for using the QOTD editor
--Moves inline css to quotes.css, etc.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Further UI work on the QOTD uploader
Chris Nighswonger [Mon, 7 May 2012 15:34:37 +0000 (11:34 -0400)]
Bug 7977: Further UI work on the QOTD uploader

This patch addresses another of oleonard's points as well as
some general cleanup:

--Adds instructions to each stage of the uploader
--Consolidates quote tool css into quotes.css

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: QOTD uploader to enable uploading csv files containing quotes
Chris Nighswonger [Fri, 20 Apr 2012 20:12:26 +0000 (16:12 -0400)]
Bug 7977: QOTD uploader to enable uploading csv files containing quotes

This series will add a DataTable's based upload/editor with which
to upload csv files containing quotes to be used by the QOTD
feature.

The file should be formatted thusly:

"source","text-of-quote"
"source","text-of-quote"
...

Note: This work serves as a good example of potential improvements
in all other "editor" and file upload areas of Koha.

This patch is a squash of the following work:

--Adding code to parse CSV file contents and push it into a DataTable
--Adding in jEditable to enable table editing
--Adding ajax to post data back to the server to be saved
--Fixing edit and adding delete functionality
--Adding some missing css as well as server feedback on save
--Fixing a bug which limited the number of quotes which could be uploaded
--Also fixing a minor bug with fnCSVToArray and doing some style cleanup.
--Adding sanity checks to verify file type and size
--Implements YUI button widget/toolbar
--Improved handling of hiding uploader UI
--Adds row selectability
--Adds multi-delete capability
--Adds YUI button/toolbar widget
--Fixing capitalization in quote uploader
--Implements improvments suggested by jcamins and oleonard

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Quote-of-the-day (QOTD) Feature for OPAC
Chris Nighswonger [Mon, 9 Apr 2012 20:35:06 +0000 (16:35 -0400)]
Bug 7977: Quote-of-the-day (QOTD) Feature for OPAC

This feature will add the option of displaying a select quote
for the day on the OPAC homepage. It will include the addition
of a QOTD editor in the tools section of the staff interface
which will allow the addition, editing, and deletion of quotes.
A single system preference will enable/disable the display of
the QOTD on the OPAC homepage. A new granular permission will
also be added to conrol user access to the QOTD editor tool.

Possible extentions to this would be code to allow alternate
quote selection algorithms to be added to vary how the currently
displayed quote is selected from the table of quotes.

This patch is a squash of the following work:

--Adding quotes table to kohastructure.sql and updatedatabase.pl

Note: This patch is intended for a MySQL based installation only.
That means that it includes backticks because that is what is required
at this point in history to install Koha correctly on a MySQL based
installation.

Feel free to port this over to the Pg stuff in the data/Pg directory.

--Adding system preference to control display of QOTD on OPAC main page
--Adding sample quote data

These quotes are taken from various US presidents. I'm not sure these
are applicable to the rest of the world, so I'm leaving it to translators
and others to add sample quote data for other languages.

--Adding edit_quotes user permissions
--Squash with other db related patches in this series
--Adding quotes editor pages to tools
--Adding QOTD editor link to tools homepage
--Integration of DataTables into QOTD Editor
--Impleminting jEditable into the quote editor
--Adding delete and add option to editor
--Fixing OPAC display so the QOTD div does not show if no quote is returned
--Also removing useless code from tools/quotes.pl
--Adding spans around QOTD foo in opac-main.tt
--Also fixing quote selection logic to accomodate the possibility of
    a single quote in the db a litte better.
--Changing timestamp column header to a more user-friendly 'Last Displayed'
--Fixing bug in quote selection logic. This bug caused a situation where
    when the table had only a single quote with an id greater than 1 in it,
    no quote would be selected.
--Fixing up sorting in the quote editor table. --jcamins
--Adding span element to quote separator --jcamins
--Overriding the default empty table message supplied by datatables-strings.inc
--Adds missing page heading
--Adds beginning of click-for-help elements.
--Refactors delete functionality to allow selecting of quotes to delete,
    enabling multi-delete.
--Refactors saving added quote functionality so that striking <Enter>
    saves the new quote.
--Refactors canceling aded quote functionality so that striking <Esc>
    cancels the new quote.
--Removing debug console.log statements
--Implementng the YUI button widget/toolbar used on other pages.
--Adds a 5px radius to all YUI buttons to bring them into
    conformity with the general trend toward rounded corners
--Fixes capitalization in quote editor
--Implements improvements suggested by jcamins and oleonard
--Adds DataTables Plugin dataTables.fnReloadAjax.js

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
11 years agoBug 7977: Adding DateTime::Format::MySQL as a core dependency
Chris Nighswonger [Thu, 19 Apr 2012 14:50:21 +0000 (10:50 -0400)]
Bug 7977: Adding DateTime::Format::MySQL as a core dependency

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>