From 0134341d9a9883013b7eee3bdc84aa339e618bcc Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Sat, 6 Jul 2013 15:50:54 -0400 Subject: [PATCH] bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton --- koha_perl_deps.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/koha_perl_deps.pl b/koha_perl_deps.pl index 123bcd26e4..54e6de0b75 100755 --- a/koha_perl_deps.pl +++ b/koha_perl_deps.pl @@ -62,7 +62,6 @@ foreach my $type (@pm) { print color 'yellow' if $type eq 'upgrade_pm' && $color; print color 'red' if $type eq 'missing_pm' && $color; print color 'green' if $type eq 'current_pm' && $color; - $count++; my $required = ($_->{$pm}->{'required'}?'Yes':'No'); my $current_version = ($color ? $_->{$pm}->{'cur_ver'} : $type eq 'missing_pm' || $type eq 'upgrade_pm' ? $_->{$pm}->{'cur_ver'}." *" : $_->{$pm}->{'cur_ver'}); @@ -73,11 +72,13 @@ format = $pm, $current_version, $_->{$pm}->{'min_ver'}, $required . write; + $count++; } } else { if (($req && $required eq 'Yes') || !$req) { print "$pm\n"; + $count++; } } } -- 2.20.1