From 1dabb45a5004e577259cc757d192a019c55d12e9 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Wed, 23 Jan 2013 10:31:31 +0000 Subject: [PATCH] Bug 9455: Remove unnecessary quoting from sql Wa've removed the mysql specific back quotes from sql files But this case remained of them embedded in an sql string Also removed the unnecessary call to finish and temporary variable in the subroutine return Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected Signed-off-by: Owen Leonard Works according to test instructions: Basketgroups functionality appears to work normally. Signed-off-by: Katrin Fischer Checked SQL produces the same results as before and did some tests on the basket group functionality. Signed-off-by: Jared Camins-Esakov --- C4/Acquisition.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 376a20bb5d..4a9eae6c2d 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -801,14 +801,12 @@ Returns a reference to the array of all the basketgroups of bookseller $booksell sub GetBasketgroups { my $booksellerid = shift; - die "bookseller id is required to edit a basketgroup" unless $booksellerid; - my $query = "SELECT * FROM aqbasketgroups WHERE booksellerid=? ORDER BY `id` DESC"; + die 'bookseller id is required to edit a basketgroup' unless $booksellerid; + my $query = 'SELECT * FROM aqbasketgroups WHERE booksellerid=? ORDER BY id DESC'; my $dbh = C4::Context->dbh; my $sth = $dbh->prepare($query); $sth->execute($booksellerid); - my $results = $sth->fetchall_arrayref({}); - $sth->finish; - return $results + return $sth->fetchall_arrayref({}); } #------------------------------------------------------------# -- 2.20.1