From 89a8a17fdc793b145fc0d7bdcef601698b36fdaa Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Thu, 10 Oct 2013 14:09:19 +0100 Subject: [PATCH] Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verify that relevant authority records are linked to from the bib. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton --- cataloguing/addbiblio.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index cb403968ae..bfb62f04b3 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbiblio.pl @@ -865,7 +865,7 @@ if ( $op eq "addbiblio" ) { my $oldbibnum; my $oldbibitemnum; if (C4::Context->preference("BiblioAddsAuthorities")){ - my ($countlinked,$countcreated)=BiblioAutoLink($record,$frameworkcode); + BiblioAutoLink( $record, $frameworkcode ); } if ( $is_a_modif ) { ModBiblioframework( $biblionumber, $frameworkcode ); -- 2.20.1