From 8b9d9cb2d1a44375bd81a018719a9ccf834bed9a Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 25 Feb 2013 15:21:57 +0100 Subject: [PATCH] Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- .../en/modules/admin/preferences/opac.pref | 8 ++++ koha-tmpl/opac-tmpl/prog/en/css/opac.css | 10 +++++ .../opac-tmpl/prog/en/modules/opac-reserve.tt | 41 ++++++++++++++++++- opac/opac-reserve.pl | 8 +++- 4 files changed, 63 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index d1225b4b59..81824e4702 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -417,6 +417,14 @@ OPAC: yes: Display no: Don't display - the list of authors/subjects in a popup for a combined search on OPAC detail pages. + - + - pref: OpacShowHoldNotes + default: 0 + choices: + yes: Allow + no: Do not allow + - users to add a note when placing a hold. + Policy: - - pref: singleBranchMode diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css index 24a62a17cf..5e5d2f4391 100644 --- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css +++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css @@ -2795,6 +2795,7 @@ div.authorizedheading { width: 75%; } + .contentblock { position: relative; margin-left: 2em; @@ -2950,3 +2951,12 @@ a.reviewlink,a.reviewlink:visited { float:left; padding: 0.1em 0; } +.notesrow label { + font-weight: bold; +} +.notesrow span { + display: block; +} +.notesrow textarea { + width: 100%; +} diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt index 85f1c3008d..c77a11e047 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt @@ -4,6 +4,9 @@