From f01606d89b487d585bf06eae1dd6de6ff138eab9 Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 27 Jun 2013 16:02:08 +1000 Subject: [PATCH] Bug 9801: display facet labels in search results only when there are facet values Currently, the headings for facets (such as location) are showing even if there are no actual values/links for that facet type. This patch simply checks if the facet array contains any facets before printing the heading and HTML for each facet value/link. Test Plan: Before applying: 0) If you want to check the location facet (which is easiest), enable singlebranch mode in the globals system preferences. 1) Do a search for records/items that you have no shelving location specified (or simply remove the shelving location for a small range of records that you can find in a search query). 2) Note that "Location" appears amongst the facets even though there are no values/links present. (If you look at the HTML source, you'll see some empty HTML tags have been printed out.) Apply patch. 3) Flush your cache and refresh your page. 4) You should no longer see a "Location" facet (or those empty HTML tags) on the facet sidebar. Signed-off-by: Katrin Fischer Template changes only. Checked according to test plan, made sure location facet still shows up when values exist, otherwise it's hidden. It might make sense to add ids to the facets so libraries can decide to hide some of them easily. Or alternatively add a system preference to make that possible. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton --- koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 ++ koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc | 2 ++ 2 files changed, 4 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc index fd2302a2c9..8853ec7e05 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc @@ -8,6 +8,7 @@ [% FOREACH facets_loo IN facets_loop %] +[% IF facets_loo.facets.size > 0 %]
  • [% facets_loo.type_label %] [% IF ( facets_loo.type_label_Authors ) %]Authors[% END %] @@ -24,6 +25,7 @@ [% END %]
    • [% END %] +[% END %] [% END %] diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc index fbb7c55df5..5486b0c33e 100644 --- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc +++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc @@ -8,6 +8,7 @@ [% FOREACH facets_loo IN facets_loop %] +[% IF facets_loo.facets.size > 0 %]
  • [% IF ( facets_loo.type_label_Authors ) %]Authors[% END %] [% IF ( facets_loo.type_label_Titles ) %]Titles[% END %] @@ -25,6 +26,7 @@ [% END %]
    • [% END %] +[% END %] [% IF ( OPACResultsSidebar ) %] -- 2.20.1