X-Git-Url: http://git.rot13.org/?p=perl-Redis.git;a=blobdiff_plain;f=lib%2FRedis.pm;h=3ac761943306ec4766795a7a3fd6cb030f34d92e;hp=31d7eb03696be340c356e76cc5613f0708a3367f;hb=b9bd006758ee8dea10c6e2ff21e4bfc686d44a6a;hpb=0530ee25184daf62214ddb3b281cb806aff7f9db

diff --git a/lib/Redis.pm b/lib/Redis.pm
index 31d7eb0..3ac7619 100644
--- a/lib/Redis.pm
+++ b/lib/Redis.pm
@@ -63,8 +63,10 @@ sub _sock_read_bulk {
 	warn "## bulk len: ",dump($len);
 	return undef if $len eq "nil\r\n";
 	my $v;
-	read($sock, $v, $len) || die $!;
-	warn "## bulk v: ",dump($v);
+	if ( $len > 0 ) {
+		read($sock, $v, $len) || die $!;
+		warn "## bulk v: ",dump($v);
+	}
 	my $crlf;
 	read($sock, $crlf, 2); # skip cr/lf
 	return $v;
@@ -79,6 +81,7 @@ sub _sock_result_bulk {
 
 sub __sock_ok {
 	my $ok = <$sock>;
+	return undef if $ok eq "nil\r\n";
 	confess dump($ok) unless $ok eq "+OK\r\n";
 }
 
@@ -100,7 +103,8 @@ sub __sock_send_bulk_raw {
 	my $self = shift;
 	warn "## _sock_send_bulk ",dump( @_ );
 	my $value = pop;
-	print $sock join(' ',@_) . ' ' . length($value) . "\r\n$value\r\n";
+	$value = '' unless defined $value; # FIXME errr? nil?
+	print $sock join(' ',@_) . ' ' . length($value) . "\r\n$value\r\n"
 }
 
 sub _sock_send_bulk {
@@ -362,7 +366,7 @@ sub lset {
 
 =head2 lrem
 
-  $r->lrem( $key, $count, $value );
+  my $modified_count = $r->lrem( $key, $count, $value );
 
 =cut
 
@@ -371,6 +375,28 @@ sub lrem {
 	$self->_sock_send_bulk_number( 'LREM', $key, $count, $value );
 }
 
+=head2 lpop
+
+  my $value = $r->lpop( $key );
+
+=cut
+
+sub lpop {
+	my ( $self, $key ) = @_;
+	$self->_sock_result_bulk( 'lpop', $key );
+}
+
+=head2 rpop
+
+  my $value = $r->rpop( $key );
+
+=cut
+
+sub rpop {
+	my ( $self, $key ) = @_;
+	$self->_sock_result_bulk( 'rpop', $key );
+}
+
 =head1 AUTHOR
 
 Dobrica Pavlinusic, C<< <dpavlin at rot13.org> >>