From: Dobrica Pavlinusic Date: Mon, 14 Sep 2009 11:37:25 +0000 (+0000) Subject: use Data::Dumper instead of Data::Dump so all our dependencies are perl core modules X-Git-Tag: 0.0801 X-Git-Url: http://git.rot13.org/?p=perl-Redis.git;a=commitdiff_plain;h=8a36a2c05814b1b0a6c40ffc595e5c8283c088c2 use Data::Dumper instead of Data::Dump so all our dependencies are perl core modules git-svn-id: svn+ssh://llin/home/dpavlin/private/svn/Redis@63 447b33ff-793d-4489-8442-9bea7d161be5 --- diff --git a/Makefile.PL b/Makefile.PL index fb2edf5..96f6ad0 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -11,7 +11,7 @@ WriteMakefile( PREREQ_PM => { 'Test::More' => 0, 'IO::Socket::INET' => 0, - 'Data::Dump' => 0, + 'Data::Dumper' => 0, 'Carp' => 0, }, dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', }, diff --git a/lib/Redis.pm b/lib/Redis.pm index 2caa3b7..7c8bf23 100644 --- a/lib/Redis.pm +++ b/lib/Redis.pm @@ -4,7 +4,7 @@ use warnings; use strict; use IO::Socket::INET; -use Data::Dump qw/dump/; +use Data::Dumper; use Carp qw/confess/; =head1 NAME @@ -75,7 +75,7 @@ sub AUTOLOAD { my $command = $AUTOLOAD; $command =~ s/.*://; - warn "## $command ",dump(@_) if $self->{debug}; + warn "## $command ",Dumper(@_) if $self->{debug}; my $send; @@ -147,7 +147,7 @@ sub __read_bulk { my $v; if ( $len > 0 ) { read($self->{sock}, $v, $len) || die $!; - warn "<< ",dump($v),$/ if $self->{debug}; + warn "<< ",Dumper($v),$/ if $self->{debug}; } my $crlf; read($self->{sock}, $crlf, 2); # skip cr/lf @@ -166,7 +166,7 @@ sub __read_multi_bulk { $list[ $_ ] = $self->__read_bulk( substr(<$sock>,1,-2) ); } - warn "## list = ", dump( @list ) if $self->{debug}; + warn "## list = ", Dumper( @list ) if $self->{debug}; return @list; } diff --git a/lib/Redis/Hash.pm b/lib/Redis/Hash.pm index d85e71f..c56a22f 100644 --- a/lib/Redis/Hash.pm +++ b/lib/Redis/Hash.pm @@ -6,8 +6,6 @@ use warnings; use Tie::Hash; use base qw/Redis Tie::StdHash/; -use Data::Dump qw/dump/; - =head1 NAME Redis::Hash - tie perl hashes into Redis diff --git a/t/01-Redis.t b/t/01-Redis.t index cc8d95b..a54d88c 100755 --- a/t/01-Redis.t +++ b/t/01-Redis.t @@ -4,7 +4,7 @@ use warnings; use strict; use Test::More tests => 108; -use Data::Dump qw/dump/; +use Data::Dumper; use lib 'lib'; @@ -184,7 +184,7 @@ diag "Remote server control commands"; ok( my $info = $o->info, 'info' ); isa_ok( $info, 'HASH' ); -diag dump( $info ); +diag Dumper( $info ); diag "Connection handling"; diff --git a/t/10-Redis-List.t b/t/10-Redis-List.t index 1ebdd75..4910e16 100755 --- a/t/10-Redis-List.t +++ b/t/10-Redis-List.t @@ -5,7 +5,6 @@ use strict; use Test::More tests => 8; use lib 'lib'; -use Data::Dump qw/dump/; BEGIN { use_ok( 'Redis::List' ); @@ -27,4 +26,3 @@ is_deeply( [ @a ], [ 'foo', 'bar', 'baz' ] ); ok( push( @a, 'push' ), 'push' ); is_deeply( [ @a ], [ 'foo', 'bar', 'baz', 'push' ] ); -#diag dump( @a ); diff --git a/t/20-Redis-Hash.t b/t/20-Redis-Hash.t index 660c8f3..169eda4 100755 --- a/t/20-Redis-Hash.t +++ b/t/20-Redis-Hash.t @@ -5,7 +5,6 @@ use strict; use Test::More tests => 8; use lib 'lib'; -use Data::Dump qw/dump/; BEGIN { use_ok( 'Redis::Hash' );