- added clean parametar to stores to start with empty database

[perl-cwmp.git] / lib / CWMP / Session.pm

diff --git a/lib/CWMP/Session.pm b/lib/CWMP/Session.pm
index 40e5822..bd24efd 100644 (file)
--- a/lib/CWMP/Session.pm
+++ b/lib/CWMP/Session.pm
@@ -7,7 +7,7 @@ use warnings;
 use base qw/Class::Accessor/;
 __PACKAGE__->mk_accessors( qw/
 debug
-store_path
+store
 
 sock
 state
@@ -34,7 +34,7 @@ CWMP::Session - implement logic of CWMP protocol
 
   my $server = CWMP::Session->new({
        sock => $io_socket_object,
-       store_path => 'state.db',
+       store => 'state.db',
        queue => [ qw/GetRPCMethods GetParameterNames/ ],
        debug => 1,
   });
@@ -51,12 +51,15 @@ sub new {
 
        warn "created ", __PACKAGE__, "(", dump( @_ ), ") for ", $self->sock->peerhost, "\n" if $self->debug;
 
-       $self->store( CWMP::Store->new({
+       my $store_obj = CWMP::Store->new({
                debug => $self->debug,
-               path => $self->store_path,
-       }) );
+               %{ $self->store },
+       });
+
+       croak "can't open ", dump( $self->store ), ": $!" unless $store_obj;
 
-       croak "can't open ", $self->store_path, ": $!" unless $self->store;
+       # FIXME looks ugly. Should we have separate accessor for this?
+       $self->store( $store_obj );
 
        return $self;
 }
@@ -68,7 +71,7 @@ facilitate brain-dead concept of adding state to stateless protocol like
 HTTP.
 
 If used with debugging level of 3 or more, it will also create dumps of
-requests named C<< nr.dump >> where C<nr> is number from 0 to total number
+requests named C<< dump/nr.request >> where C<nr> is number from 0 to total number
 of requests in single session.
 
 =cut
@@ -102,7 +105,7 @@ sub process_request {
        warn "<<<< ", $sock->peerhost, " [" . localtime() . "] ", $r->method, " ", $r->uri, " $size bytes\n";
 
        if ( $self->debug > 2 ) {
-               my $file = $dump_nr++ . '.dump';
+               my $file = sprintf("dump/%04d-%s.request", $dump_nr++, $sock->peerhost);
                write_file( $file, $r->as_string );
                warn "### request dump: $file\n";
        }
@@ -113,24 +116,20 @@ sub process_request {
 
                die "no SOAPAction header in ",dump($chunk) unless defined ( $r->header('SOAPAction') );
 
+               $state = CWMP::Request->parse( $chunk );
 
-               if ( $chunk ) {
-                       warn "## request chunk: ",length($chunk)," bytes\n$chunk\n" if $self->debug;
+               warn "## acquired state = ", dump( $state ), "\n";
 
-                       $state = CWMP::Request->parse( $chunk );
+               $self->state( $state );
+               $self->store->update_state( ID => $state->{ID}, $state );
 
-                       warn "## acquired state = ", dump( $state ), "\n";
-
-                       $self->state( $state );
-                       $self->store->update_state( ID => $state->{ID}, $state );
+       } else {
 
-               } else {
-                       warn "## empty request\n";
-               }
+               warn "## empty request, using last request state\n";
 
-       } else {
                $state = $self->state;
-               warn "last request state = ", dump( $state ), "\n" if $self->debug > 1;
+               delete( $state->{_dispatch} );
+               #warn "last request state = ", dump( $state ), "\n" if $self->debug > 1;
        }
 
 
@@ -150,7 +149,7 @@ sub process_request {
        } elsif ( $dispatch = shift @{ $self->queue } ) {
                $xml = $self->dispatch( $dispatch );
        } elsif ( $size == 0 ) {
-               warn ">>> closing connection\n";
+               warn ">>> no more queued commands, closing connection\n";
                return 0;
        } else {
                warn ">>> empty response\n";
@@ -172,6 +171,8 @@ sub process_request {
 
   $xml = $self->dispatch('Inform', $response_arguments );
 
+If debugging level of 3 or more, it will create dumps of responses named C<< dump/nr.response >>
+
 =cut
 
 sub dispatch {
@@ -185,6 +186,11 @@ sub dispatch {
                warn ">>> dispatching to $dispatch\n";
                my $xml = $response->$dispatch( $self->state, @_ );
                warn "## response payload: ",length($xml)," bytes\n$xml\n" if $self->debug;
+               if ( $self->debug > 2 ) {
+                       my $file = sprintf("dump/%04d-%s.response", $dump_nr++, $self->sock->peerhost);
+                       write_file( $file, $xml );
+                       warn "### response dump: $file\n";
+               }
                return $xml;
        } else {
                confess "can't dispatch to $dispatch";