projects
/
simavr
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1f93391
)
Revert "examples: hd44780 responds on falling edge of E pin"
author
Jakob Gruber
<jakob.gruber@gmail.com>
Fri, 31 Aug 2012 07:39:14 +0000
(09:39 +0200)
committer
Jakob Gruber
<jakob.gruber@gmail.com>
Fri, 31 Aug 2012 07:51:14 +0000
(09:51 +0200)
This reverts commit
fddb2a02e9feadaefaf690b07a69a1556fb96fd1
.
The hd44780 was misbehaving and bisecting ended up at this commit.
examples/parts/hd44780.c
patch
|
blob
|
history
diff --git
a/examples/parts/hd44780.c
b/examples/parts/hd44780.c
index
8fe194c
..
144cbfc
100644
(file)
--- a/
examples/parts/hd44780.c
+++ b/
examples/parts/hd44780.c
@@
-340,8
+340,8
@@
hd44780_pin_changed_hook(
b->pinstate = (b->pinstate & ~(1 << irq->irq)) | (value << irq->irq);
int eo = old & (1 << IRQ_HD44780_E);
int e = b->pinstate & (1 << IRQ_HD44780_E);
- // on the E pin
fall
ing edge, do stuff otherwise just exit
- if (
eo && !
e)
+ // on the E pin
ris
ing edge, do stuff otherwise just exit
+ if (
!eo &&
e)
avr_cycle_timer_register(b->avr, 1, _hd44780_process_e_pinchange, b);
}