From: Jakob Gruber <jakob.gruber@gmail.com>
Date: Fri, 20 Jul 2012 12:19:48 +0000 (+0200)
Subject: examples: hd44780 responds on falling edge of E pin
X-Git-Url: http://git.rot13.org/?p=simavr;a=commitdiff_plain;h=fddb2a02e9feadaefaf690b07a69a1556fb96fd1;hp=d63e2a190fcc83978ffcead60e2d6db597ed8ecc

examples: hd44780 responds on falling edge of E pin

The example itself works both ways, but the actual HD44780 chip
processes data on the falling edge - see the data sheet.
---

diff --git a/examples/parts/hd44780.c b/examples/parts/hd44780.c
index 144cbfc..8fe194c 100644
--- a/examples/parts/hd44780.c
+++ b/examples/parts/hd44780.c
@@ -340,8 +340,8 @@ hd44780_pin_changed_hook(
 	b->pinstate = (b->pinstate & ~(1 << irq->irq)) | (value << irq->irq);
 	int eo = old & (1 << IRQ_HD44780_E);
 	int e = b->pinstate & (1 << IRQ_HD44780_E);
-	// on the E pin rising edge, do stuff otherwise just exit
-	if (!eo && e)
+	// on the E pin falling edge, do stuff otherwise just exit
+	if (eo && !e)
 		avr_cycle_timer_register(b->avr, 1, _hd44780_process_e_pinchange, b);
 }