we really need AutoCommit => 1 so we see changes

[virtual-ldap] / lib / LDAP / Koha.pm

diff --git a/lib/LDAP/Koha.pm b/lib/LDAP/Koha.pm
index f3527d7..eec8cd1 100644 (file)
--- a/lib/LDAP/Koha.pm
+++ b/lib/LDAP/Koha.pm
@@ -26,7 +26,7 @@ our $max_results = 10; # 100; # FIXME
 
 require 'config.pl' if -e 'config.pl';
 
-my $dbh = DBI->connect($dsn . $database, $user,$passwd, { RaiseError => 1, AutoCommit => 0 }) || die $DBI::errstr;
+my $dbh = DBI->connect($dsn . $database, $user,$passwd, { RaiseError => 1, AutoCommit => 1 }) || die $DBI::errstr;
 
 # Net::LDAP::Entry will lc all our attribute names anyway, so
 # we don't really care about correctCapitalization for LDAP
@@ -40,7 +40,7 @@ my $sql_select = q{
 
                -- SAFEQ specific mappings from UMgr-LDAP.conf
                surname                                         as displayName,
-               cardnumber                                      as pager,
+               rfid_sid                                        as pager,
                email                                           as mail,
                categorycode                                    as organizationalUnit,
                borrowernumber                                  as objectGUID,
@@ -54,7 +54,7 @@ my $ldap_sql_mapping = {
        'objectGUID'    => 'borrowernumber',
        'displayName'   => 'surname',
        'sn'            => 'surname',
-       'pager'         => 'cardnumber',
+       'pager'         => 'rfid_sid',
 };
 
 # attributes which are same for whole set, but somehow
@@ -148,19 +148,25 @@ sub search {
 
                        @limits = ();
 
-                       foreach my $filter ( @{ $reqData->{'filter'}->{ $join_with } } ) {
-                               warn "### filter ",dump($filter),$/;
-                               foreach my $how ( keys %$filter ) {
-                                       if ( $how eq 'or' ) {
-                                               __ldap_search_to_sql( %$_ ) foreach ( @{ $filter->{$how} } );
-                                       } else {
-                                               __ldap_search_to_sql( $how, $filter->{$how} );
+                       if ( ref $reqData->{'filter'}->{ $join_with } ) {
+
+                               foreach my $filter ( @{ $reqData->{'filter'}->{ $join_with } } ) {
+                                       warn "### filter ",dump($filter),$/;
+                                       foreach my $how ( keys %$filter ) {
+                                               if ( $how eq 'or' ) {
+                                                       __ldap_search_to_sql( %$_ ) foreach ( @{ $filter->{$how} } );
+                                               } else {
+                                                       __ldap_search_to_sql( $how, $filter->{$how} );
+                                               }
+                                               warn "## limits ",dump(@limits), " values ",dump(@values);
                                        }
-                                       warn "## limits ",dump(@limits), " values ",dump(@values);
                                }
-                       }
 
-                       $sql_where .= ' ' . join( " $join_with ", @limits );
+                               $sql_where .= ' ' . join( " $join_with ", @limits );
+
+                       } else {
+                               __ldap_search_to_sql( $join_with, $reqData->{'filter'}->{$join_with} );
+                       }
 
                }
 
@@ -180,12 +186,21 @@ sub search {
 
                        my $dn = 'uid=' . $row->{uid} || die "no uid";
                        $dn =~ s{[@\.]}{,dc=}g;
+                       $dn .= ',' . $base unless $dn =~ m{dc}i;
 
                        my $entry = Net::LDAP::Entry->new;
-                       $entry->dn( $dn . $base );
+                       $entry->dn( $dn );
+                       $entry->add( objectClass => [
+                               "person",
+                               "organizationalPerson",
+                               "inetOrgPerson",
+                               "hrEduPerson",
+                       ] );
                        $entry->add( %$row );
 
-                       #warn "### entry ",dump( $entry );
+                       #$entry->changetype( 'modify' );
+
+                       warn "### entry ",$entry->dump( \*STDERR );
 
                        push @entries, $entry;
                }