From: Dobrica Pavlinusic Date: Tue, 2 Jun 2009 13:14:59 +0000 (+0000) Subject: document rec_array and fix tests X-Git-Url: http://git.rot13.org/?p=webpac2;a=commitdiff_plain;h=759105e8d88d6b4405239ee8fe437505cfc12ec0;ds=sidebyside document rec_array and fix tests git-svn-id: svn+ssh://mjesec/home/dpavlin/svn/webpac2/trunk@1214 07558da8-63fa-0310-ba24-9fe276d99e06 --- diff --git a/lib/WebPAC/Normalize.pm b/lib/WebPAC/Normalize.pm index 49ba7a3..ff14736 100644 --- a/lib/WebPAC/Normalize.pm +++ b/lib/WebPAC/Normalize.pm @@ -153,12 +153,6 @@ sub _set_ds { sub _get_rec { $rec }; -sub rec_array { - my $d = $rec->{ $_[0] }; - return @$d if ref($d) eq 'ARRAY'; - die "field $_[0] not array: ",dump( $d ); -} - =head2 _set_config Set current config hash @@ -956,5 +950,21 @@ sub count { return @_ . ''; } +=head2 rec_array + +Always return field as array + + foreach my $d ( rec_array('field') { + warn $d; + } + +=cut + +sub rec_array { + my $d = $rec->{ $_[0] }; + return @$d if ref($d) eq 'ARRAY'; + return ($d); +} + # END 1; diff --git a/t/3-normalize.t b/t/3-normalize.t index b69ecd1..0eb6f2a 100755 --- a/t/3-normalize.t +++ b/t/3-normalize.t @@ -908,9 +908,9 @@ sub test_s { _clean_ds(); _set_ds( $rec ); test_s(q{ - row( e => $_ ) foreach ( rec_array('arr') ); + row( 'table', e => $_ ) foreach ( rec_array('arr') ); }); - ok( my $rows = _get_ds->{_rows}, 'ds have _rows' ); + ok( my $rows = _get_ds->{_rows}->{table}, 'ds have _rows' ); foreach my $i ( 1 .. 3 ) { cmp_ok( $rows->[ $i - 1 ]->{e}, '==', $i, "e $i" );