Small style stuff

[zxing.git] / core / src / com / google / zxing / ReaderException.java

diff --git a/core/src/com/google/zxing/ReaderException.java b/core/src/com/google/zxing/ReaderException.java
index 750dde8..224a497 100644 (file)
--- a/core/src/com/google/zxing/ReaderException.java
+++ b/core/src/com/google/zxing/ReaderException.java
@@ -23,7 +23,7 @@ package com.google.zxing;
  *
  * @author Sean Owen
  */
-public final class ReaderException extends Exception {
+public abstract class ReaderException extends Exception {
 
   // TODO: Currently we throw up to 400 ReaderExceptions while scanning a single 240x240 image before
   // rejecting it. This involves a lot of overhead and memory allocation, and affects both performance
@@ -34,18 +34,64 @@ public final class ReaderException extends Exception {
   // by disabling the generation of stack traces, which is especially time consuming. These are just
   // temporary measures, pending the big cleanup.
 
-  private static final ReaderException instance = new ReaderException();
+  //private static final ReaderException instance = new ReaderException();
 
-  private ReaderException() {
+  // EXCEPTION TRACKING SUPPORT
+  // Identifies who is throwing exceptions and how often. To use:
+  //
+  // 1. Uncomment these lines and the code below which uses them.
+  // 2. Uncomment the two corresponding lines in j2se/CommandLineRunner.decode()
+  // 3. Change core to build as Java 1.5 temporarily
+//  private static int exceptionCount = 0;
+//  private static Map<String,Integer> throwers = new HashMap<String,Integer>(32);
+
+  ReaderException() {
     // do nothing
   }
 
-  public static ReaderException getInstance() {
-    return instance;
-  }
+  //public static ReaderException getInstance() {
+//    Exception e = new Exception();
+//    // Take the stack frame before this one.
+//    StackTraceElement stack = e.getStackTrace()[1];
+//    String key = stack.getClassName() + "." + stack.getMethodName() + "(), line " +
+//        stack.getLineNumber();
+//    if (throwers.containsKey(key)) {
+//      Integer value = throwers.get(key);
+//      value++;
+//      throwers.put(key, value);
+//    } else {
+//      throwers.put(key, 1);
+//    }
+//    exceptionCount++;
+
+    //return instance;
+  //}
+
+//  public static int getExceptionCountAndReset() {
+//    int temp = exceptionCount;
+//    exceptionCount = 0;
+//    return temp;
+//  }
+//
+//  public static String getThrowersAndReset() {
+//    StringBuilder builder = new StringBuilder(1024);
+//    Object[] keys = throwers.keySet().toArray();
+//    for (int x = 0; x < keys.length; x++) {
+//      String key = (String) keys[x];
+//      Integer value = throwers.get(key);
+//      builder.append(key);
+//      builder.append(": ");
+//      builder.append(value);
+//      builder.append("\n");
+//    }
+//    throwers.clear();
+//    return builder.toString();
+//  }
 
   // Prevent stack traces from being taken
-  public Throwable fillInStackTrace() {
+  // srowen says: huh, my IDE is saying this is not an override. native methods can't be overridden?
+  // This, at least, does not hurt. Because we use a singleton pattern here, it doesn't matter anyhow.
+  public final Throwable fillInStackTrace() {
     return null;
   }