Finished work on the local binarizer and renamed it to HybridBinarizer. It uses the...

[zxing.git] / javase / src / com / google / zxing / client / j2se / CommandLineRunner.java

diff --git a/javase/src/com/google/zxing/client/j2se/CommandLineRunner.java b/javase/src/com/google/zxing/client/j2se/CommandLineRunner.java
index 73bc6ec..a7ad9d6 100644 (file)
--- a/javase/src/com/google/zxing/client/j2se/CommandLineRunner.java
+++ b/javase/src/com/google/zxing/client/j2se/CommandLineRunner.java
@@ -16,6 +16,7 @@
 
 package com.google.zxing.client.j2se;
 
+import com.google.zxing.BarcodeFormat;
 import com.google.zxing.BinaryBitmap;
 import com.google.zxing.DecodeHintType;
 import com.google.zxing.LuminanceSource;
@@ -26,7 +27,7 @@ import com.google.zxing.client.result.ParsedResult;
 import com.google.zxing.client.result.ResultParser;
 import com.google.zxing.common.BitArray;
 import com.google.zxing.common.BitMatrix;
-import com.google.zxing.common.GlobalHistogramBinarizer;
+import com.google.zxing.common.HybridBinarizer;
 
 import java.awt.image.BufferedImage;
 import java.io.File;
@@ -40,6 +41,7 @@ import java.net.URI;
 import java.net.URISyntaxException;
 import java.nio.charset.Charset;
 import java.util.Hashtable;
+import java.util.Vector;
 
 import javax.imageio.ImageIO;
 
@@ -62,23 +64,28 @@ public final class CommandLineRunner {
       printUsage();
       return;
     }
-    Hashtable<DecodeHintType, Object> hints = null;
+
+    boolean tryHarder = false;
+    boolean productsOnly = false;
     boolean dumpResults = false;
     boolean dumpBlackPoint = false;
     for (String arg : args) {
       if ("--try_harder".equals(arg)) {
-        hints = new Hashtable<DecodeHintType, Object>(3);
-        hints.put(DecodeHintType.TRY_HARDER, Boolean.TRUE);
+        tryHarder = true;
+      } else if ("--products_only".equals(arg)) {
+        productsOnly = true;
       } else if ("--dump_results".equals(arg)) {
         dumpResults = true;
       } else if ("--dump_black_point".equals(arg)) {
         dumpBlackPoint = true;
       } else if (arg.startsWith("-")) {
-        System.out.println("Unknown command line option " + arg);
+        System.err.println("Unknown command line option " + arg);
         printUsage();
         return;
       }
     }
+
+    Hashtable<DecodeHintType, Object> hints = buildHints(tryHarder, productsOnly);
     for (String arg : args) {
       if (!arg.startsWith("--")) {
         decodeOneArgument(arg, hints, dumpResults, dumpBlackPoint);
@@ -86,12 +93,37 @@ public final class CommandLineRunner {
     }
   }
 
+  // Manually turn on all formats, even those not yet considered production quality.
+  private static Hashtable<DecodeHintType, Object> buildHints(boolean tryHarder,
+      boolean productsOnly) {
+    Hashtable<DecodeHintType, Object> hints = new Hashtable<DecodeHintType, Object>(3);
+    Vector<BarcodeFormat> vector = new Vector<BarcodeFormat>(8);
+    vector.addElement(BarcodeFormat.UPC_A);
+    vector.addElement(BarcodeFormat.UPC_E);
+    vector.addElement(BarcodeFormat.EAN_13);
+    vector.addElement(BarcodeFormat.EAN_8);
+    if (!productsOnly) {
+      vector.addElement(BarcodeFormat.CODE_39);
+      vector.addElement(BarcodeFormat.CODE_128);
+      vector.addElement(BarcodeFormat.ITF);
+      vector.addElement(BarcodeFormat.QR_CODE);
+      vector.addElement(BarcodeFormat.DATAMATRIX);
+      vector.addElement(BarcodeFormat.PDF417);
+    }
+    hints.put(DecodeHintType.POSSIBLE_FORMATS, vector);
+    if (tryHarder) {
+      hints.put(DecodeHintType.TRY_HARDER, Boolean.TRUE);
+    }
+    return hints;
+  }
+
   private static void printUsage() {
-    System.out.println("Decode barcode images using the ZXing library\n");
-    System.out.println("usage: CommandLineRunner { file | dir | url } [ options ]");
-    System.out.println("  --try_harder: Use the TRY_HARDER hint, default is normal (mobile) mode");
-    System.out.println("  --dump_results: Write the decoded contents to input.txt");
-    System.out.println("  --dump_black_point: Compare black point algorithms as input.mono.png");
+    System.err.println("Decode barcode images using the ZXing library\n");
+    System.err.println("usage: CommandLineRunner { file | dir | url } [ options ]");
+    System.err.println("  --try_harder: Use the TRY_HARDER hint, default is normal (mobile) mode");
+    System.err.println("  --products_only: Only decode the UPC and EAN families of barcodes");
+    System.err.println("  --dump_results: Write the decoded contents to input.txt");
+    System.err.println("  --dump_black_point: Compare black point algorithms as input.mono.png");
   }
 
   private static void decodeOneArgument(String argument, Hashtable<DecodeHintType, Object> hints,
@@ -168,7 +200,7 @@ public final class CommandLineRunner {
     }
     try {
       LuminanceSource source = new BufferedImageLuminanceSource(image);
-      BinaryBitmap bitmap = new BinaryBitmap(new GlobalHistogramBinarizer(source));
+      BinaryBitmap bitmap = new BinaryBitmap(new HybridBinarizer(source));
       if (dumpBlackPoint) {
         dumpBlackPoint(uri, image, bitmap);
       }
@@ -181,6 +213,10 @@ public final class CommandLineRunner {
     } catch (ReaderException e) {
       System.out.println(uri.toString() + ": No barcode found");
       return null;
+    } finally {
+      // Uncomment these lines when turning on exception tracking in ReaderException.
+      //System.out.println("Threw " + ReaderException.getExceptionCountAndReset() + " exceptions");
+      //System.out.println("Throwers:\n" + ReaderException.getThrowersAndReset());
     }
   }
 
@@ -205,7 +241,6 @@ public final class CommandLineRunner {
       image.getRGB(0, y, width, 1, argb, 0, width);
       System.arraycopy(argb, 0, pixels, y * stride, width);
     }
-    argb = null;
 
     // Row sampling
     BitArray row = new BitArray(width);
@@ -253,10 +288,10 @@ public final class CommandLineRunner {
 
     // Use the current working directory for URLs
     String resultName = inputName;
-    if (uri.getScheme().equals("http")) {
+    if ("http".equals(uri.getScheme())) {
       int pos = resultName.lastIndexOf('/');
       if (pos > 0) {
-        resultName = "." + resultName.substring(pos);
+        resultName = '.' + resultName.substring(pos);
       }
     }
     int pos = resultName.lastIndexOf('.');
@@ -264,13 +299,22 @@ public final class CommandLineRunner {
       resultName = resultName.substring(0, pos);
     }
     resultName += ".mono.png";
+    OutputStream outStream = null;
     try {
-      OutputStream outStream = new FileOutputStream(resultName);
+      outStream = new FileOutputStream(resultName);
       ImageIO.write(result, "png", outStream);
     } catch (FileNotFoundException e) {
-      System.out.println("Could not create " + resultName);
+      System.err.println("Could not create " + resultName);
     } catch (IOException e) {
-      System.out.println("Could not write to " + resultName);
+      System.err.println("Could not write to " + resultName);
+    } finally {
+      try {
+        if (outStream != null) {
+          outStream.close();
+        }
+      } catch (IOException ioe) {
+        // continue
+      }
     }
   }