Tiny changes to System.err usage, closed a stream, saved a reused Pattern

[zxing.git] / zxingorg / src / com / google / zxing / web / DoSFilter.java

diff --git a/zxingorg/src/com/google/zxing/web/DoSFilter.java b/zxingorg/src/com/google/zxing/web/DoSFilter.java
index 083dd30..177fc2b 100755 (executable)
--- a/zxingorg/src/com/google/zxing/web/DoSFilter.java
+++ b/zxingorg/src/com/google/zxing/web/DoSFilter.java
@@ -33,6 +33,7 @@ import java.util.HashSet;
 import java.util.Set;\r
 import java.util.Timer;\r
 import java.util.TimerTask;\r
+import java.util.regex.Pattern;\r
 \r
 /**\r
  * A {@link Filter} that rejects requests from hosts that are sending too many\r
@@ -45,6 +46,7 @@ public final class DoSFilter implements Filter {
   private static final int MAX_ACCESSES_PER_IP_PER_TIME = 10;\r
   private static final long MAX_ACCESS_INTERVAL_MSEC = 10L * 1000L;\r
   private static final long UNBAN_INTERVAL_MSEC = 60L * 60L * 1000L;\r
+  private static final Pattern COMMA_PATTERN = Pattern.compile(",");\r
 \r
   private final IPTrie numRecentAccesses;\r
   private final Timer timer;\r
@@ -63,7 +65,7 @@ public final class DoSFilter implements Filter {
     context = filterConfig.getServletContext();\r
     String bannedIPs = filterConfig.getInitParameter("bannedIPs");\r
     if (bannedIPs != null) {\r
-      for (String ip : bannedIPs.split(",")) {\r
+      for (String ip : COMMA_PATTERN.split(bannedIPs)) {\r
         manuallyBannedIPAddresses.add(ip.trim());\r
       }\r
     }\r