zxing.git
15 years agoISSUE: http://code.google.com/p/zxing/issues/detail?id=110
kev.sully [Thu, 20 Nov 2008 17:27:12 +0000 (17:27 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110

Renamed ITF14Reader to ITFReader. ITFReader now reads arbitrary number of digits. Added a QuietZone check. Removed checksum validation. Added more test cases.

git-svn-id: http://zxing.googlecode.com/svn/trunk@745 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoISSUE: http://code.google.com/p/zxing/issues/detail?id=110
kev.sully [Thu, 20 Nov 2008 17:26:34 +0000 (17:26 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110

Renamed ITF14Reader to ITFReader. ITFReader now reads arbitrary number of digits. Added a QuietZone check. Removed checksum validation. Added more test cases.

git-svn-id: http://zxing.googlecode.com/svn/trunk@744 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agogit-svn-id: http://zxing.googlecode.com/svn/trunk@743 59b500cc-1b3d-0410-9834-0bbf25f...
srowen [Thu, 20 Nov 2008 17:10:44 +0000 (17:10 +0000)]
git-svn-id: zxing.googlecode.com/svn/trunk@743 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoPorted over the BitVector bug fix and new unit test from Satoru.
dswitkin [Thu, 20 Nov 2008 17:08:30 +0000 (17:08 +0000)]
Ported over the BitVector bug fix and new unit test from Satoru.

git-svn-id: http://zxing.googlecode.com/svn/trunk@742 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded ITF-14 decoder from Kevin. Not enabled yet as we need to think a bit about...
srowen [Thu, 20 Nov 2008 14:07:19 +0000 (14:07 +0000)]
Added ITF-14 decoder from Kevin. Not enabled yet as we need to think a bit about how to handle this first. Also, the unit tests aren't passing for me but are for Kevin so I have commented them for the moment.

git-svn-id: http://zxing.googlecode.com/svn/trunk@741 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoRemove Debug and switch to eceptions in Encoder / Writer API
srowen [Thu, 20 Nov 2008 12:26:20 +0000 (12:26 +0000)]
Remove Debug and switch to eceptions in Encoder / Writer API

git-svn-id: http://zxing.googlecode.com/svn/trunk@740 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoUpdated the Android client to use native/local QR Code encoding. For now it still...
dswitkin [Wed, 19 Nov 2008 20:54:39 +0000 (20:54 +0000)]
Updated the Android client to use native/local QR Code encoding. For now it still runs on a thread and has a temporary "Working..." dialog. As I optimize a bit further, these may not be necessary.

git-svn-id: http://zxing.googlecode.com/svn/trunk@739 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoChanged the Writer interface to provide contents as a String instead of a byte array.
dswitkin [Wed, 19 Nov 2008 20:12:38 +0000 (20:12 +0000)]
Changed the Writer interface to provide contents as a String instead of a byte array.

git-svn-id: http://zxing.googlecode.com/svn/trunk@738 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed more unit tests.
dswitkin [Wed, 19 Nov 2008 19:16:16 +0000 (19:16 +0000)]
Fixed more unit tests.

git-svn-id: http://zxing.googlecode.com/svn/trunk@737 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed testIsValidKanjiSequence(). Looks like the data arrays got copied over wrong...
dswitkin [Wed, 19 Nov 2008 18:55:28 +0000 (18:55 +0000)]
Fixed testIsValidKanjiSequence(). Looks like the data arrays got copied over wrong from the C++ hex strings.

git-svn-id: http://zxing.googlecode.com/svn/trunk@736 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoDeleted a big honking polynomial table that was unused, and a related class.
dswitkin [Wed, 19 Nov 2008 18:50:51 +0000 (18:50 +0000)]
Deleted a big honking polynomial table that was unused, and a related class.

git-svn-id: http://zxing.googlecode.com/svn/trunk@735 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoDid some optimization and cleanup.
dswitkin [Wed, 19 Nov 2008 18:35:10 +0000 (18:35 +0000)]
Did some optimization and cleanup.

git-svn-id: http://zxing.googlecode.com/svn/trunk@734 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded the quiet zone to the QRCodeWriter.
dswitkin [Wed, 19 Nov 2008 16:39:59 +0000 (16:39 +0000)]
Added the quiet zone to the QRCodeWriter.

git-svn-id: http://zxing.googlecode.com/svn/trunk@733 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed testInterleaveWithECBytes().
dswitkin [Wed, 19 Nov 2008 16:04:48 +0000 (16:04 +0000)]
Fixed testInterleaveWithECBytes().

git-svn-id: http://zxing.googlecode.com/svn/trunk@732 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed two more tests.
dswitkin [Wed, 19 Nov 2008 15:51:44 +0000 (15:51 +0000)]
Fixed two more tests.

git-svn-id: http://zxing.googlecode.com/svn/trunk@731 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoCorrected logic to handle case where remainder polynomial has leading 0 coefficients.
srowen [Wed, 19 Nov 2008 12:39:18 +0000 (12:39 +0000)]
Corrected logic to handle case where remainder polynomial has leading 0 coefficients.

git-svn-id: http://zxing.googlecode.com/svn/trunk@730 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoChanges to the matrix and debug classes to make some tests pass.
ccmysen [Wed, 19 Nov 2008 09:26:54 +0000 (09:26 +0000)]
Changes to the matrix and debug classes to make some tests pass.
I'm not super happy about making LOG_INFO a noop, but I don't know the general
solution off hand.

In any case, MatrixUtilTestCase and MaskUtilTestCase both pass now.

git-svn-id: http://zxing.googlecode.com/svn/trunk@729 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed a bunch more tests, and commented out all of the Renderer tests for now so...
dswitkin [Wed, 19 Nov 2008 01:58:31 +0000 (01:58 +0000)]
Fixed a bunch more tests, and commented out all of the Renderer tests for now so everything compiles.

Sean, try commenting out testEncode(). It'll let you run a bit further to see a genuine problem that testInterleaveWithECBytes() finds.

git-svn-id: http://zxing.googlecode.com/svn/trunk@728 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMoved ByteArray up to core/common now that it has no dependencies on qrcode/encoder.
dswitkin [Tue, 18 Nov 2008 23:01:42 +0000 (23:01 +0000)]
Moved ByteArray up to core/common now that it has no dependencies on qrcode/encoder.

git-svn-id: http://zxing.googlecode.com/svn/trunk@727 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade several good fixes to and because of the unit tests. Turns out the EC array...
dswitkin [Tue, 18 Nov 2008 22:54:04 +0000 (22:54 +0000)]
Made several good fixes to and because of the unit tests. Turns out the EC array was never being set to the right size. I've now established that the Reed Solomon code is generating one fewer coefficient than the layer above it asked for.

git-svn-id: http://zxing.googlecode.com/svn/trunk@726 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoCreated a WriterException class and updated a bunch of documentation.
dswitkin [Tue, 18 Nov 2008 21:46:24 +0000 (21:46 +0000)]
Created a WriterException class and updated a bunch of documentation.

git-svn-id: http://zxing.googlecode.com/svn/trunk@725 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade some incremental progress on the Encoder unit test. I think we've now hit the...
dswitkin [Tue, 18 Nov 2008 21:34:17 +0000 (21:34 +0000)]
Made some incremental progress on the Encoder unit test. I think we've now hit the first real bug in the code.

git-svn-id: http://zxing.googlecode.com/svn/trunk@724 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded support for adding a contact with multiple email addresses and phone numbers...
dswitkin [Tue, 18 Nov 2008 21:31:35 +0000 (21:31 +0000)]
Added support for adding a contact with multiple email addresses and phone numbers. This change requires Android 1.1 to work, but is harmless on 1.0.

git-svn-id: http://zxing.googlecode.com/svn/trunk@723 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFinally submit tiny change to comments here
srowen [Tue, 18 Nov 2008 21:18:10 +0000 (21:18 +0000)]
Finally submit tiny change to comments here

git-svn-id: http://zxing.googlecode.com/svn/trunk@722 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoReplace IllegalStateException; still want to make it WriterException
srowen [Tue, 18 Nov 2008 21:15:30 +0000 (21:15 +0000)]
Replace IllegalStateException; still want to make it WriterException

git-svn-id: http://zxing.googlecode.com/svn/trunk@721 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade a small change to allow discovery of multiple email addresses within a Docomo...
dswitkin [Tue, 18 Nov 2008 19:44:25 +0000 (19:44 +0000)]
Made a small change to allow discovery of multiple email addresses within a Docomo MECARD.

git-svn-id: http://zxing.googlecode.com/svn/trunk@720 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdding in the rest of the qrcode test cases.
ccmysen [Tue, 18 Nov 2008 18:56:19 +0000 (18:56 +0000)]
Adding in the rest of the qrcode test cases.
Most of them seem to be having run errors right now, but most of the major
syntax errors are now gone. The main missing feature right now is the use of
the GaloisField polynomial and a working Renderer class.

git-svn-id: http://zxing.googlecode.com/svn/trunk@719 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdd testdata for the qrcode encoder tests (mainly part of the renderer testcase).
ccmysen [Tue, 18 Nov 2008 18:17:22 +0000 (18:17 +0000)]
Add testdata for the qrcode encoder tests (mainly part of the renderer testcase).

git-svn-id: http://zxing.googlecode.com/svn/trunk@718 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMy BitVector implementation was totally buggy. I rewrote a lot of it and ported the...
dswitkin [Tue, 18 Nov 2008 15:34:45 +0000 (15:34 +0000)]
My BitVector implementation was totally buggy. I rewrote a lot of it and ported the test case, which now passes.

Now I'm tracking down an assertion in Encoder.InterleaveWithECBytes().

git-svn-id: http://zxing.googlecode.com/svn/trunk@717 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoCreated the base Writer object for all barcode encoding, then wrote a QR Code version...
dswitkin [Mon, 17 Nov 2008 22:10:45 +0000 (22:10 +0000)]
Created the base Writer object for all barcode encoding, then wrote a QR Code version. A Writer encodes a series of raw bytes into a 2D greyscale bitmap, represented by a ByteArray. This seems like a better container than MonochromeBitmapSource, because we may want shades of grey when encoding future formats. The next step is to hook this up to the Android client.

git-svn-id: http://zxing.googlecode.com/svn/trunk@716 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed the build.
dswitkin [Mon, 17 Nov 2008 20:49:10 +0000 (20:49 +0000)]
Fixed the build.

git-svn-id: http://zxing.googlecode.com/svn/trunk@715 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agomove to singleton ReaderException for a bit more performance
srowen [Mon, 17 Nov 2008 17:56:31 +0000 (17:56 +0000)]
move to singleton ReaderException for a bit more performance

git-svn-id: http://zxing.googlecode.com/svn/trunk@714 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoLatent bug I think from earlier change to List from Vector
srowen [Mon, 17 Nov 2008 17:53:05 +0000 (17:53 +0000)]
Latent bug I think from earlier change to List from Vector

git-svn-id: http://zxing.googlecode.com/svn/trunk@713 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdd a bit of a hack to better detect UTF-8 in the wild, versus ISO88591
srowen [Sun, 16 Nov 2008 12:46:18 +0000 (12:46 +0000)]
Add a bit of a hack to better detect UTF-8 in the wild, versus ISO88591

git-svn-id: http://zxing.googlecode.com/svn/trunk@712 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoChange assert to an exception since this facility would not be available in J2ME...
srowen [Sun, 16 Nov 2008 12:03:11 +0000 (12:03 +0000)]
Change assert to an exception since this facility would not be available in J2ME. I vote for removing use of Debug anyway.

git-svn-id: http://zxing.googlecode.com/svn/trunk@711 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAppear to have fixed the URL escaping issues this time without regression
srowen [Sun, 16 Nov 2008 10:20:20 +0000 (10:20 +0000)]
Appear to have fixed the URL escaping issues this time without regression

git-svn-id: http://zxing.googlecode.com/svn/trunk@710 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoNow uses new Reed Solomon encoder code
srowen [Sat, 15 Nov 2008 20:23:32 +0000 (20:23 +0000)]
Now uses new Reed Solomon encoder code

git-svn-id: http://zxing.googlecode.com/svn/trunk@709 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdd to result the raw, but parsed, bytes of byte segments in 2D barcodes
srowen [Sat, 15 Nov 2008 13:50:18 +0000 (13:50 +0000)]
Add to result the raw, but parsed, bytes of byte segments in 2D barcodes

git-svn-id: http://zxing.googlecode.com/svn/trunk@708 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoBug fix to unrandomization routine from sanfordsquires
srowen [Sat, 15 Nov 2008 12:58:36 +0000 (12:58 +0000)]
Bug fix to unrandomization routine from sanfordsquires

git-svn-id: http://zxing.googlecode.com/svn/trunk@707 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoRemove my old email address from files. Might as well save spammers the trouble.
srowen [Sat, 15 Nov 2008 00:07:25 +0000 (00:07 +0000)]
Remove my old email address from files. Might as well save spammers the trouble.

git-svn-id: http://zxing.googlecode.com/svn/trunk@706 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoWrote a new ByteArray class to replace StringPiece and fixed all uses of it. Also...
dswitkin [Fri, 14 Nov 2008 21:51:26 +0000 (21:51 +0000)]
Wrote a new ByteArray class to replace StringPiece and fixed all uses of it. Also converted all uses of stl::string (which was being used as vector<unsigned char>) to ByteArray. Everything in the Encoder but the Reed Solomon related code compiles now.

ByteArray could certainly move up to the common package, although it currently has a dependency on BitVector. We'll have to figure out what to do with the latter first.

This is the first set of changes I've made which are error prone. They involved a lot of pointer conversion, signed/unsigned semantics, etc. These diffs may have clues for later bugs.

git-svn-id: http://zxing.googlecode.com/svn/trunk@705 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoHuge progress on the Encoder. I'm down to StringPiece errors (that class hasn't been...
dswitkin [Fri, 14 Nov 2008 18:43:54 +0000 (18:43 +0000)]
Huge progress on the Encoder. I'm down to StringPiece errors (that class hasn't been replaced yet) and a few nasty methods, which call into Reed Solomon (not done yet).

git-svn-id: http://zxing.googlecode.com/svn/trunk@704 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMore enhancements to Reed-Solomon tests
srowen [Fri, 14 Nov 2008 18:34:19 +0000 (18:34 +0000)]
More enhancements to Reed-Solomon tests

git-svn-id: http://zxing.googlecode.com/svn/trunk@703 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoGot MatrixUtil to compile, and refactored some methods out of it, and into Matrix...
dswitkin [Fri, 14 Nov 2008 16:21:05 +0000 (16:21 +0000)]
Got MatrixUtil to compile, and refactored some methods out of it, and into Matrix where they belong.

git-svn-id: http://zxing.googlecode.com/svn/trunk@702 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoDid a bunch of comments cleanup.
dswitkin [Fri, 14 Nov 2008 15:40:38 +0000 (15:40 +0000)]
Did a bunch of comments cleanup.

git-svn-id: http://zxing.googlecode.com/svn/trunk@701 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded note about dex's issue with post-optimization debug symbol table
srowen [Fri, 14 Nov 2008 14:13:45 +0000 (14:13 +0000)]
Added note about dex's issue with post-optimization debug symbol table

git-svn-id: http://zxing.googlecode.com/svn/trunk@700 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded Reed-Solomon encoder, suitable for QR Code encoding
srowen [Fri, 14 Nov 2008 12:40:55 +0000 (12:40 +0000)]
Added Reed-Solomon encoder, suitable for QR Code encoding

git-svn-id: http://zxing.googlecode.com/svn/trunk@699 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoWrote a reasonable implementation of BitVector which now compiles.
dswitkin [Thu, 13 Nov 2008 21:59:08 +0000 (21:59 +0000)]
Wrote a reasonable implementation of BitVector which now compiles.

git-svn-id: http://zxing.googlecode.com/svn/trunk@698 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoWrote a Matrix class and fixed all uses of it, as well as other small fixes like...
dswitkin [Thu, 13 Nov 2008 21:18:56 +0000 (21:18 +0000)]
Wrote a Matrix class and fixed all uses of it, as well as other small fixes like StringBuffer. MaskUtil and QRCode now compile with no errors.

git-svn-id: http://zxing.googlecode.com/svn/trunk@697 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoComment out QR code encoder package for the moment
srowen [Thu, 13 Nov 2008 19:08:25 +0000 (19:08 +0000)]
Comment out QR code encoder package for the moment

git-svn-id: http://zxing.googlecode.com/svn/trunk@696 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoConverted the Mode and ECLevel enums in QRCode.java.
dswitkin [Thu, 13 Nov 2008 17:12:53 +0000 (17:12 +0000)]
Converted the Mode and ECLevel enums in QRCode.java.

git-svn-id: http://zxing.googlecode.com/svn/trunk@695 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoBegan porting the QR Code encoder from ChartServer to Java/ZXing. Some important...
dswitkin [Thu, 13 Nov 2008 16:14:44 +0000 (16:14 +0000)]
Began porting the QR Code encoder from ChartServer to Java/ZXing. Some important comments are flagged with JAVAPORT. I've done the following so far:

- Created Java files with our headers, packages, etc.
- Converted includes to imports, or commented out the unresolved dependencies
- Merged all the .h and .cpp contents into Java classes
- Fixed most of the formatting
- Did all the simple transformations (bool, NULL, const, struct, string, ::, ->)
- Created a Debug class to handle all the asserts and logging
- Fixed about half of the static arrays
- Removed some pthread cruft

IMPORTANT:

- Please do not start hacking this code up as I'm going to keep making large changes to it. In particular, we need to leave the trailing underscores on member variables for now. Once everything is compiling with no errors, we can revisit stylistic issues.
- There will be a number of similar classes within the encoder and in the rest of ZXing. We should refactor those later (BitVector and BitArray come to mind). In the mean time, I want to get everything working and the tests passing before we do that.

git-svn-id: http://zxing.googlecode.com/svn/trunk@694 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agomaking stuff final, weakening types, etc. per IntelliJ analysis
srowen [Thu, 13 Nov 2008 13:14:53 +0000 (13:14 +0000)]
making stuff final, weakening types, etc. per IntelliJ analysis

git-svn-id: http://zxing.googlecode.com/svn/trunk@693 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade a small change to the KDDI AU parsing code to handle pronunciation (aka Furigana...
dswitkin [Wed, 12 Nov 2008 16:21:19 +0000 (16:21 +0000)]
Made a small change to the KDDI AU parsing code to handle pronunciation (aka Furigana) specifically.

git-svn-id: http://zxing.googlecode.com/svn/trunk@692 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoWrote a new bookmark picker activity for use by the Share button, because I couldn...
dswitkin [Wed, 12 Nov 2008 15:42:44 +0000 (15:42 +0000)]
Wrote a new bookmark picker activity for use by the Share button, because I couldn't get the platform version to work.

git-svn-id: http://zxing.googlecode.com/svn/trunk@691 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed a regression in the QR Code encoder. The contents do not need to be run through...
dswitkin [Wed, 12 Nov 2008 14:40:23 +0000 (14:40 +0000)]
Fixed a regression in the QR Code encoder. The contents do not need to be run through URLEncoder first.

git-svn-id: http://zxing.googlecode.com/svn/trunk@690 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoUpdates from sanfordsquires to fix RS decoding for Datamatrix
srowen [Wed, 12 Nov 2008 13:47:45 +0000 (13:47 +0000)]
Updates from sanfordsquires to fix RS decoding for Datamatrix

git-svn-id: http://zxing.googlecode.com/svn/trunk@689 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoUpdates from sanfordsquires to fix RS decoding for Datamatrix
srowen [Wed, 12 Nov 2008 12:59:47 +0000 (12:59 +0000)]
Updates from sanfordsquires to fix RS decoding for Datamatrix

git-svn-id: http://zxing.googlecode.com/svn/trunk@688 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoChanged the ChartServer and Search Book Contents URLs back to google.com instead...
dswitkin [Tue, 11 Nov 2008 19:19:11 +0000 (19:19 +0000)]
Changed the ChartServer and Search Book Contents URLs back to google.com instead of using the LocaleManager, as they are API calls, not user-facing websites.

git-svn-id: http://zxing.googlecode.com/svn/trunk@687 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded support for Furigana using the SOUND field in MECARD. AddressBookParsedResult...
dswitkin [Tue, 11 Nov 2008 16:31:27 +0000 (16:31 +0000)]
Added support for Furigana using the SOUND field in MECARD. AddressBookParsedResult now has a pronunciation field to represent this. I'm not aware of whether this is supported in other formats like VCARD, so they all pass null for now.

git-svn-id: http://zxing.googlecode.com/svn/trunk@686 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoNow attempts to use locale-specific Google property in client. Also made some stuff...
srowen [Tue, 11 Nov 2008 15:32:31 +0000 (15:32 +0000)]
Now attempts to use locale-specific Google property in client. Also made some stuff final that can be.

git-svn-id: http://zxing.googlecode.com/svn/trunk@685 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoSomehow the IntelliJ Subversion integration did not commit these deleted files when...
dswitkin [Tue, 11 Nov 2008 14:48:11 +0000 (14:48 +0000)]
Somehow the IntelliJ Subversion integration did not commit these deleted files when I did the rename.

git-svn-id: http://zxing.googlecode.com/svn/trunk@684 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoHid the Share menu if the results screen was showing, since it didn't make sense...
dswitkin [Mon, 10 Nov 2008 22:47:09 +0000 (22:47 +0000)]
Hid the Share menu if the results screen was showing, since it didn't make sense. Also change the autofocus delay to 1.5 seconds, to make it hunt a little less, and give the autoexposure system more time to run.

git-svn-id: http://zxing.googlecode.com/svn/trunk@683 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoDid a bunch of renaming, there was no need for the Barcodes prefix.
dswitkin [Mon, 10 Nov 2008 20:50:34 +0000 (20:50 +0000)]
Did a bunch of renaming, there was no need for the Barcodes prefix.

git-svn-id: http://zxing.googlecode.com/svn/trunk@682 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFirst pass at adding a UI for sharing data via QR Codes. There's now a Share button...
dswitkin [Mon, 10 Nov 2008 20:35:33 +0000 (20:35 +0000)]
First pass at adding a UI for sharing data via QR Codes. There's now a Share button in the main capture menu which leads to a choice of contacts, bookmarks, and clipboard contents, which will be encoded and shown full screen. Launching the bookmarks picker currently crashes with a permission problem, which I'm investigating.

git-svn-id: http://zxing.googlecode.com/svn/trunk@681 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoPartially addressed Reed-Solomon decoding issue for Datamatrix, but not entirely...
srowen [Sun, 9 Nov 2008 16:22:43 +0000 (16:22 +0000)]
Partially addressed Reed-Solomon decoding issue for Datamatrix, but not entirely. Still some small issue that prevents correcting as many errors as possible.

git-svn-id: http://zxing.googlecode.com/svn/trunk@680 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade new array fields final
srowen [Sun, 9 Nov 2008 16:20:15 +0000 (16:20 +0000)]
Made new array fields final

git-svn-id: http://zxing.googlecode.com/svn/trunk@679 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAddress a small but clear bug in detector logic
srowen [Sat, 8 Nov 2008 14:27:08 +0000 (14:27 +0000)]
Address a small but clear bug in detector logic

git-svn-id: http://zxing.googlecode.com/svn/trunk@678 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAttempt to make encoding detection slightly more accurate -- rule out Shift_JIS in...
srowen [Sat, 8 Nov 2008 14:25:36 +0000 (14:25 +0000)]
Attempt to make encoding detection slightly more accurate -- rule out Shift_JIS in a few more cases

git-svn-id: http://zxing.googlecode.com/svn/trunk@677 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoRenamed launcher icon.
dswitkin [Fri, 7 Nov 2008 15:07:54 +0000 (15:07 +0000)]
Renamed launcher icon.

git-svn-id: http://zxing.googlecode.com/svn/trunk@676 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed two leaks when using AndroidHttpClient.
dswitkin [Thu, 6 Nov 2008 19:55:38 +0000 (19:55 +0000)]
Fixed two leaks when using AndroidHttpClient.

git-svn-id: http://zxing.googlecode.com/svn/trunk@675 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoSmall additional error check in decoder
srowen [Thu, 6 Nov 2008 19:14:48 +0000 (19:14 +0000)]
Small additional error check in decoder

git-svn-id: http://zxing.googlecode.com/svn/trunk@674 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded support for landscape mode when encoding QR Codes, and made some small layout...
dswitkin [Thu, 6 Nov 2008 17:17:07 +0000 (17:17 +0000)]
Added support for landscape mode when encoding QR Codes, and made some small layout improvements.

git-svn-id: http://zxing.googlecode.com/svn/trunk@672 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFinished renaming UPC --> Product in a few places.
dswitkin [Thu, 6 Nov 2008 16:25:39 +0000 (16:25 +0000)]
Finished renaming UPC --> Product in a few places.

git-svn-id: http://zxing.googlecode.com/svn/trunk@671 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded support for supplying a postal address when encoding a QR Code.
dswitkin [Thu, 6 Nov 2008 16:13:16 +0000 (16:13 +0000)]
Added support for supplying a postal address when encoding a QR Code.

git-svn-id: http://zxing.googlecode.com/svn/trunk@670 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade some temporary changes to make throwing ReaderExceptions more efficient. Long...
dswitkin [Wed, 5 Nov 2008 19:16:27 +0000 (19:16 +0000)]
Made some temporary changes to make throwing ReaderExceptions more efficient. Long term, we need to delete this class and change the decoders to return errors instead of throwing.

git-svn-id: http://zxing.googlecode.com/svn/trunk@669 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoRenamed UPC result type to Product, and introduced an idea of 'product ID' and 'norma...
srowen [Tue, 4 Nov 2008 12:08:19 +0000 (12:08 +0000)]
Renamed UPC result type to Product, and introduced an idea of 'product ID' and 'normalized product ID' to account for UPC-E, where the actual visible ID is different from what we may want to search for as a key. Updated clients to use this too.

git-svn-id: http://zxing.googlecode.com/svn/trunk@668 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed Search Book Contents when built under ProGuard.
dswitkin [Mon, 3 Nov 2008 16:13:56 +0000 (16:13 +0000)]
Fixed Search Book Contents when built under ProGuard.

git-svn-id: http://zxing.googlecode.com/svn/trunk@667 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed the ZXing Test camera mode when using ProGuard.
dswitkin [Sun, 2 Nov 2008 16:10:54 +0000 (16:10 +0000)]
Fixed the ZXing Test camera mode when using ProGuard.

git-svn-id: http://zxing.googlecode.com/svn/trunk@666 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAnother round of optimization, focused on reusing arrays and small objects.
dswitkin [Sun, 2 Nov 2008 16:07:36 +0000 (16:07 +0000)]
Another round of optimization, focused on reusing arrays and small objects.

git-svn-id: http://zxing.googlecode.com/svn/trunk@665 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoRevamp the character encoding detection to use a more complicated but still crude...
srowen [Sun, 2 Nov 2008 12:22:33 +0000 (12:22 +0000)]
Revamp the character encoding detection to use a more complicated but still crude algorithm that detects more Shift_JIS sequences correctly.

git-svn-id: http://zxing.googlecode.com/svn/trunk@664 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoUpdated qrcode-2 with corrected output for some Japanese-language results. Also stand...
srowen [Sun, 2 Nov 2008 11:06:20 +0000 (11:06 +0000)]
Updated qrcode-2 with corrected output for some Japanese-language results. Also standardized on UTF-8 encoding for test result files and enabled --dump_results for single-file case.

git-svn-id: http://zxing.googlecode.com/svn/trunk@663 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoNow more lenient in detecting Shift_JIS to detect more byte sequences as Shift_JIS
srowen [Sun, 2 Nov 2008 10:30:09 +0000 (10:30 +0000)]
Now more lenient in detecting Shift_JIS to detect more byte sequences as Shift_JIS

git-svn-id: http://zxing.googlecode.com/svn/trunk@662 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoDiscovered that our 1D Readers were being reallocated for every row scanned - yikes...
dswitkin [Sat, 1 Nov 2008 02:31:05 +0000 (02:31 +0000)]
Discovered that our 1D Readers were being reallocated for every row scanned - yikes! I made them reusable across both rows and different scans. This saved 26 ms on the worst case rejection. We can now consistently reject any 240x240 image on Android in 150 ms or less, checking all 7 formats.

git-svn-id: http://zxing.googlecode.com/svn/trunk@661 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoWhoops, the benchmarks are in microseconds, not milliseconds.
dswitkin [Sat, 1 Nov 2008 00:40:07 +0000 (00:40 +0000)]
Whoops, the benchmarks are in microseconds, not milliseconds.

git-svn-id: http://zxing.googlecode.com/svn/trunk@660 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAllow up to 3 superfluous bits at end of stream
srowen [Fri, 31 Oct 2008 18:49:54 +0000 (18:49 +0000)]
Allow up to 3 superfluous bits at end of stream

git-svn-id: http://zxing.googlecode.com/svn/trunk@659 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded 17 new, unusual QR Codes to the blackbox tests. We can decode the majority...
dswitkin [Fri, 31 Oct 2008 18:09:24 +0000 (18:09 +0000)]
Added 17 new, unusual QR Codes to the blackbox tests. We can decode the majority OK, but some of the contents are not agreeing with the golden results because of a text encoding issue.

git-svn-id: http://zxing.googlecode.com/svn/trunk@658 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded a --dump_results flag to the J2SE client, which will create a text file of...
dswitkin [Fri, 31 Oct 2008 17:57:31 +0000 (17:57 +0000)]
Added a --dump_results flag to the J2SE client, which will create a text file of the contents of each file scanned. This is very useful for adding golden results for new blackbox images tests.

git-svn-id: http://zxing.googlecode.com/svn/trunk@657 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoDid a big refactoring on the MonochromeBitmapSource. I removed all the caching lumina...
dswitkin [Thu, 30 Oct 2008 18:44:10 +0000 (18:44 +0000)]
Did a big refactoring on the MonochromeBitmapSource. I removed all the caching luminance calls and converted them to getting luminance data on demand. This saved another 33,000 function calls per rejected scan, good for another 15 ms savings. I also moved the luminance calls to BaseMonochromeBitmapSource and made them protected, to indicate that the decoders shouldn't use them.

Overall the recent optimizations took one rejected scan from 307 to 135 ms, which is definitely noticeable.

WARNING: I am not able to build the Bug or J2ME clients, but I believe they are correct.

git-svn-id: http://zxing.googlecode.com/svn/trunk@656 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed a crash in calendar parsing when encountering an illegal VEVENT without newlines.
dswitkin [Thu, 30 Oct 2008 16:35:26 +0000 (16:35 +0000)]
Fixed a crash in calendar parsing when encountering an illegal VEVENT without newlines.

git-svn-id: http://zxing.googlecode.com/svn/trunk@655 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoFixed the Android client when using ProGuard. The ViewfinderView constructor is loade...
dswitkin [Thu, 30 Oct 2008 15:41:52 +0000 (15:41 +0000)]
Fixed the Android client when using ProGuard. The ViewfinderView constructor is loaded dynamically by the XML view inflation code, which requires explicitly preserving it.

git-svn-id: http://zxing.googlecode.com/svn/trunk@654 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade the data members of BitArray public so they will be inlined. This saves about...
dswitkin [Wed, 29 Oct 2008 21:16:46 +0000 (21:16 +0000)]
Made the data members of BitArray public so they will be inlined. This saves about 60,000 function calls per rejected scan. We can make these private again once we figure out the ProGuard problems with -allowaccessmodification.

git-svn-id: http://zxing.googlecode.com/svn/trunk@653 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoLooks like -allowaccessmodification to ProGuard results in a bogus binary. It compile...
dswitkin [Wed, 29 Oct 2008 20:38:33 +0000 (20:38 +0000)]
Looks like -allowaccessmodification to ProGuard results in a bogus binary. It compiles, but the Dalvik verifier rejects it at runtime. I'm removing this flag for now, which means we lose inlining on some important getters and setters.

git-svn-id: http://zxing.googlecode.com/svn/trunk@652 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded androidtest to the top-level clean target and set it up for ProGuard too. Made...
dswitkin [Wed, 29 Oct 2008 20:13:05 +0000 (20:13 +0000)]
Added androidtest to the top-level clean target and set it up for ProGuard too. Made both Android builds depend on clean so they work when switching between normal and ProGuard builds, and made install and reinstall use the latest binary instead of recompiling.

git-svn-id: http://zxing.googlecode.com/svn/trunk@651 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdded another target for building a debug key signed Android client, and removed...
dswitkin [Wed, 29 Oct 2008 19:50:37 +0000 (19:50 +0000)]
Added another target for building a debug key signed Android client, and removed the old optimized target from core.

git-svn-id: http://zxing.googlecode.com/svn/trunk@650 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agomoved ProGuard optimization into Android build file since it's the only way to fully...
srowen [Wed, 29 Oct 2008 15:42:22 +0000 (15:42 +0000)]
moved ProGuard optimization into Android build file since it's the only way to fully optimize the final build product (inlining of key methods). Also always dump proguard results.

git-svn-id: http://zxing.googlecode.com/svn/trunk@649 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoMade a change to the QR detector which cuts the worst case rejection time from 300...
dswitkin [Wed, 29 Oct 2008 14:22:44 +0000 (14:22 +0000)]
Made a change to the QR detector which cuts the worst case rejection time from 300 ms to 160 ms, with almost no penalty in decoding ability. Given that we're emphasizing continuous decoding, I feel it's much better to reject the occasional borderline image in half the time, and get on with the next scan.

git-svn-id: http://zxing.googlecode.com/svn/trunk@648 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoInner class elements now not private since it is pointless and confuses Proguard
srowen [Tue, 28 Oct 2008 15:59:51 +0000 (15:59 +0000)]
Inner class elements now not private since it is pointless and confuses Proguard

git-svn-id: http://zxing.googlecode.com/svn/trunk@647 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoAdd back basic link
srowen [Tue, 28 Oct 2008 10:30:32 +0000 (10:30 +0000)]
Add back basic link

git-svn-id: http://zxing.googlecode.com/svn/trunk@646 59b500cc-1b3d-0410-9834-0bbf25fbcc57

15 years agoUpdated the Android benchmark with more accurate timing and better results output...
dswitkin [Mon, 27 Oct 2008 16:30:36 +0000 (16:30 +0000)]
Updated the Android benchmark with more accurate timing and better results output. Also fixed walking the tree to use a consistent order to make comparison between the device and emulator easier.

git-svn-id: http://zxing.googlecode.com/svn/trunk@644 59b500cc-1b3d-0410-9834-0bbf25fbcc57