From 1d84eea1c629cba669945bed477a6e6b22d29c75 Mon Sep 17 00:00:00 2001 From: dswitkin Date: Wed, 19 Aug 2009 14:52:16 +0000 Subject: [PATCH] Made a new fix to turn off the Samsung Galaxy flash, and cut release 2.91. git-svn-id: http://zxing.googlecode.com/svn/trunk@1035 59b500cc-1b3d-0410-9834-0bbf25fbcc57 --- android/AndroidManifest.xml | 4 ++-- android/assets/html/whatsnew.html | 5 +++++ .../src/com/google/zxing/client/android/CameraManager.java | 5 +++-- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/android/AndroidManifest.xml b/android/AndroidManifest.xml index 4721afca..920bb4be 100755 --- a/android/AndroidManifest.xml +++ b/android/AndroidManifest.xml @@ -20,8 +20,8 @@ version to be published. The next versionCode will be 7, regardless of whether t versionName is 2.31, 2.4, or 3.0. --> + android:versionName="2.91" + android:versionCode="26"> diff --git a/android/assets/html/whatsnew.html b/android/assets/html/whatsnew.html index 43436763..734c2d0f 100644 --- a/android/assets/html/whatsnew.html +++ b/android/assets/html/whatsnew.html @@ -3,6 +3,11 @@

What's new in this version

+

New in version 2.91:

+
    +
  • Forced the Samsung Galaxy flash off, which was interfering with scanning.
    • +
  • A few other minor fixes.
    • +

New in version 2.9:

  • Added a new custom search function for advanced users.
    • diff --git a/android/src/com/google/zxing/client/android/CameraManager.java b/android/src/com/google/zxing/client/android/CameraManager.java index cb33dd07..6a01783d 100755 --- a/android/src/com/google/zxing/client/android/CameraManager.java +++ b/android/src/com/google/zxing/client/android/CameraManager.java @@ -205,8 +205,9 @@ final class CameraManager { Camera.Parameters parameters = mCamera.getParameters(); parameters.setPreviewSize(mScreenResolution.x, mScreenResolution.y); - // Disables the built-in flash if present. Hopefully devices will honor this setting. - parameters.set("flash-mode", "off"); + // FIXME: This is a hack to turn the flash off on the Samsung Galaxy. In the future there + // will hopefully be a standard setting like "off" that all devices will honor. + parameters.set("flash-mode", "2"); mCamera.setParameters(parameters); Log.v(TAG, "Setting params for preview: width " + mScreenResolution.x + " height " + mScreenResolution.y); -- 2.20.1