From af2c063671d50999a94f70762e7b554dc188e81f Mon Sep 17 00:00:00 2001 From: dswitkin Date: Thu, 29 Apr 2010 22:07:11 +0000 Subject: [PATCH] Fixed a crash with using SCAN_FORMATS - Pattern.split() does not like null as an argument. git-svn-id: http://zxing.googlecode.com/svn/trunk@1323 59b500cc-1b3d-0410-9834-0bbf25fbcc57 --- .../zxing/client/android/CaptureActivity.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/android/src/com/google/zxing/client/android/CaptureActivity.java b/android/src/com/google/zxing/client/android/CaptureActivity.java index 068d5788..aa476c0f 100755 --- a/android/src/com/google/zxing/client/android/CaptureActivity.java +++ b/android/src/com/google/zxing/client/android/CaptureActivity.java @@ -264,11 +264,14 @@ public final class CaptureActivity extends Activity implements SurfaceHolder.Cal } private static Vector parseDecodeFormats(Intent intent) { - return parseDecodeFormats( - Arrays.asList(COMMA_PATTERN.split(intent.getStringExtra(Intents.Scan.SCAN_FORMATS))), - intent.getStringExtra(Intents.Scan.MODE)); + String formats = intent.getStringExtra(Intents.Scan.SCAN_FORMATS); + if (formats != null) { + return parseDecodeFormats(Arrays.asList(COMMA_PATTERN.split(formats)), + intent.getStringExtra(Intents.Scan.MODE)); + } + return null; } - + private static Vector parseDecodeFormats(Uri inputUri) { List formats = inputUri.getQueryParameters(Intents.Scan.SCAN_FORMATS); if (formats.size() == 1){ @@ -276,7 +279,7 @@ public final class CaptureActivity extends Activity implements SurfaceHolder.Cal } return parseDecodeFormats(formats, inputUri.getQueryParameter(Intents.Scan.MODE)); } - + private static Vector parseDecodeFormats(List scanFormats, String decodeMode) { if (scanFormats != null) { -- 2.20.1