3 # This file is a test script for C4::VirtualShelves.pm
4 # Author : Antoine Farnault, antoine@koha-fr.org
5 # Larger modifications by Jonathan Druart and Marcel de Rooy
8 use Test::More tests => 81;
11 use C4::Biblio qw( AddBiblio DelBiblio );
14 # Getting some borrowers from database.
15 my $dbh = C4::Context->dbh;
16 my $query = q{SELECT borrowernumber FROM borrowers LIMIT 10};
17 my $borr_ref=$dbh->selectall_arrayref($query);
18 if(@$borr_ref==0) { #no borrowers? should not occur of course
19 $borr_ref->[0][0]=undef;
20 #but even then, we can run this robust test :)
24 my $t= $_> @$borr_ref ? int(rand()*@$borr_ref): $_-1; #repeat if not enough
25 push @borrowers, $borr_ref->[$t][0];
28 # Creating some biblios
31 my ($biblionumber)= AddBiblio(MARC::Record->new, '');
33 push @biblionumbers, $biblionumber;
36 #----------------------------------------------------------------------#
40 #----------------------------------------------------------------------#
42 use_ok('C4::VirtualShelves');
44 #-----------------------TEST AddShelf function------------------------#
45 # usage : $shelfnumber = &AddShelf( $shelfname, $owner, $category);
47 # creating shelves (could be <10 when names are not unique)
49 for(my $i=0; $i<10;$i++) {
50 my $name= randomname();
51 my $catg= int(rand(2))+1;
52 my $ShelfNumber= AddShelf(
60 ok($ShelfNumber > -1, "created shelf"); # Shelf creation successful;
63 my $t= C4::VirtualShelves::_CheckShelfName(
64 $name, $catg, $borrowers[$i], 0);
65 ok($t==0, "Name clash expected on shelf creation");
68 number => $ShelfNumber,
71 owner => $borrowers[$i],
72 }; #also push the errors
75 # try to create shelves with duplicate names
76 for(my $i=0;$i<10;$i++){
77 if($shelves[$i]->{number}<0) {
78 ok(1, 'skip duplicate test for earlier name clash');
81 my @shlf=GetShelf($shelves[$i]->{number}); #number, name, owner, catg, ...
83 # A shelf name is not per se unique!
84 if( $shlf[3]==2 ) { #public list: try to create with same name
85 my $badNumShelf= AddShelf( {
86 shelfname=> $shelves[$i]->{name},
89 ok(-1==$badNumShelf, 'do not create public lists with duplicate names');
90 #AddShelf returns -1 if name already exist.
91 DelShelf($badNumShelf) if $badNumShelf>-1; #delete if went wrong..
93 else { #private list, try to add another one for SAME user (owner)
94 my $badNumShelf= defined($shlf[2])? AddShelf(
96 shelfname=> $shelves[$i]->{name},
100 ok(-1==$badNumShelf, 'do not create private lists with duplicate name for same user');
101 DelShelf($badNumShelf) if $badNumShelf>-1; #delete if went wrong..
105 #-----------TEST AddToShelf & GetShelfContents & DelFromShelf functions--------------#
106 # usage : &AddToShelf($biblionumber, $shelfnumber);
107 # usage : $biblist = &GetShelfContents($shelfnumber);
108 # usage : $biblist = GetShelfContents($shelfnumber);
111 for(my $i=0; $i<10;$i++){
112 my $bib = $biblionumbers[int(rand(9))];
113 my $shelfnumber = $shelves[int(rand(9))]->{number};
115 ok(1, 'skip add to list-test for shelf -1');
116 ok(1, 'skip counting list entries for shelf -1');
120 my $key = "$bib\t$shelfnumber";
121 my $should_fail = exists($used{$key}) ? 1 : 0;
122 #FIXME We assume here that we have permission to add..
123 #The different permissions could be tested too.
125 my ($biblistBefore,$countbefore) = GetShelfContents($shelfnumber);
126 my $status = AddToShelf($bib,$shelfnumber,$borrowers[$i]);
127 my ($biblistAfter,$countafter) = GetShelfContents($shelfnumber);
130 ok(!defined($status), 'failed to add to list when we should');
132 ok(defined($status), 'added to list when we should');
135 if (defined $status) {
136 ok($countbefore == $countafter - 1, 'added bib to list'); # the bib has been successfuly added.
138 ok($countbefore == $countafter, 'did not add duplicate bib to list');
144 #-----------------------TEST ModShelf & GetShelf functions------------------------#
145 # usage : ModShelf($shelfnumber, $shelfname, $owner, $category )
146 # usage : (shelfnumber,shelfname,owner,category) = GetShelf($shelfnumber);
148 for(my $i=0; $i<10;$i++){
149 my $rand = int(rand(9));
150 my $numA = $shelves[$rand]->{number};
152 ok(1, 'Skip ModShelf test for shelf -1');
153 ok(1, 'Skip ModShelf test for shelf -1');
154 ok(1, 'Skip ModShelf test for shelf -1');
157 my $newname= randomname();
159 shelfname => $newname,
160 category => 3-$shelves[$rand]->{catg}, # tric: 1->2 and 2->1
162 #check name change (with category change)
163 if(C4::VirtualShelves::_CheckShelfName($newname,$shelf->{category},
164 $shelves[$rand]->{owner}, $numA)) {
165 ModShelf($numA,$shelf);
166 my ($numB,$nameB,$ownerB,$categoryB) = GetShelf($numA);
167 ok($numA == $numB, 'modified shelf');
168 ok($shelf->{shelfname} eq $nameB, '... and name change took');
169 ok($shelf->{category} eq $categoryB, '... and category change took');
172 ok(1, "No ModShelf for $newname") for 1..3;
176 #-----------------------TEST DelShelf & DelFromShelf functions------------------------#
177 # usage : ($status) = &DelShelf($shelfnumber);
179 for(my $i=0; $i<10;$i++){
180 my $shelfnumber = $shelves[$i]->{number};
182 ok(1, 'Skip DelShelf for shelf -1');
185 my $status = DelShelf($shelfnumber);
186 ok(1 == $status, "deleted shelf $shelfnumber and its contents");
189 #----------------------- CLEANUP ----------------------------------------------#
191 DelBiblio($_) for @biblionumbers;
193 #----------------------- SOME SUBS --------------------------------------------#
198 $rv.= ('a'..'z','A'..'Z',0..9) [int(rand()*62)];