#
# This file is part of Koha.
#
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
#
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
#
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
+use Modern::Perl;
+
+use vars qw(@ISA @EXPORT);
+BEGIN {
+ require Exporter;
+ @ISA = qw(Exporter);
+
+ @EXPORT = qw(
+ AddBiblio
+ GetBiblioData
+ GetMarcBiblio
+ GetRecordValue
+ GetISBDView
+ GetMarcControlnumber
+ GetMarcNotes
+ GetMarcISBN
+ GetMarcISSN
+ GetMarcSubjects
+ GetMarcAuthors
+ GetMarcSeries
+ GetMarcHosts
+ GetMarcUrls
+ GetUsedMarcStructure
+ GetXmlBiblio
+ GetCOinSBiblio
+ GetMarcPrice
+ MungeMarcPrice
+ GetMarcQuantity
+ GetAuthorisedValueDesc
+ GetMarcStructure
+ IsMarcStructureInternal
+ GetMarcFromKohaField
+ GetMarcSubfieldStructureFromKohaField
+ GetFrameworkCode
+ TransformKohaToMarc
+ PrepHostMarcField
+ CountItemsIssued
+ CountBiblioInOrders
+ ModBiblio
+ ModZebra
+ UpdateTotalIssues
+ RemoveAllNsb
+ DelBiblio
+ BiblioAutoLink
+ LinkBibHeadingsToAuthorities
+ TransformMarcToKoha
+ TransformHtmlToMarc
+ TransformHtmlToXml
+ prepare_host_field
+ );
+
+ # Internal functions
+ # those functions are exported but should not be used
+ # they are useful in a few circumstances, so they are exported,
+ # but don't use them unless you are a core developer ;-)
+ push @EXPORT, qw(
+ ModBiblioMarc
+ );
+}
-use strict;
-use warnings;
use Carp;
-# use utf8;
+use Encode qw( decode is_utf8 );
+use List::MoreUtils qw( uniq );
use MARC::Record;
use MARC::File::USMARC;
use MARC::File::XML;
use Module::Load::Conditional qw(can_load);
use C4::Koha;
-use C4::Dates qw/format_date/;
use C4::Log; # logaction
+use C4::Budgets;
use C4::ClassSource;
use C4::Charset;
use C4::Linker;
use C4::OAI::Sets;
+use C4::Debug;
-use vars qw($VERSION @ISA @EXPORT);
-
-BEGIN {
- $VERSION = 3.07.00.049;
-
- require Exporter;
- @ISA = qw( Exporter );
-
- # to add biblios
- # EXPORTED FUNCTIONS.
- push @EXPORT, qw(
- &AddBiblio
- );
-
- # to get something
- push @EXPORT, qw(
- &Get
- &GetBiblio
- &GetBiblioData
- &GetBiblioItemData
- &GetBiblioItemInfosOf
- &GetBiblioItemByBiblioNumber
- &GetBiblioFromItemNumber
- &GetBiblionumberFromItemnumber
-
- &GetRecordValue
- &GetFieldMapping
- &SetFieldMapping
- &DeleteFieldMapping
-
- &GetISBDView
-
- &GetMarcControlnumber
- &GetMarcNotes
- &GetMarcISBN
- &GetMarcISSN
- &GetMarcSubjects
- &GetMarcBiblio
- &GetMarcAuthors
- &GetMarcSeries
- &GetMarcHosts
- GetMarcUrls
- &GetUsedMarcStructure
- &GetXmlBiblio
- &GetCOinSBiblio
- &GetMarcPrice
- &MungeMarcPrice
- &GetMarcQuantity
-
- &GetAuthorisedValueDesc
- &GetMarcStructure
- &GetMarcFromKohaField
- &GetFrameworkCode
- &TransformKohaToMarc
- &PrepHostMarcField
-
- &CountItemsIssued
- &CountBiblioInOrders
- &GetSubscriptionsId
- &GetHolds
- );
-
- # To modify something
- push @EXPORT, qw(
- &ModBiblio
- &ModBiblioframework
- &ModZebra
- &UpdateTotalIssues
- &RemoveAllNsb
- );
-
- # To delete something
- push @EXPORT, qw(
- &DelBiblio
- );
+use Koha::Caches;
+use Koha::Authority::Types;
+use Koha::Acquisition::Currencies;
+use Koha::Biblio::Metadatas;
+use Koha::Holds;
+use Koha::ItemTypes;
+use Koha::SearchEngine;
+use Koha::Libraries;
+use Koha::Util::MARC;
- # To link headings in a bib record
- # to authority records.
- push @EXPORT, qw(
- &BiblioAutoLink
- &LinkBibHeadingsToAuthorities
- );
-
- # Internal functions
- # those functions are exported but should not be used
- # they are usefull is few circumstances, so are exported.
- # but don't use them unless you're a core developer ;-)
- push @EXPORT, qw(
- &ModBiblioMarc
- );
-
- # Others functions
- push @EXPORT, qw(
- &TransformMarcToKoha
- &TransformHtmlToMarc2
- &TransformHtmlToMarc
- &TransformHtmlToXml
- &GetNoZebraIndexes
- prepare_host_field
- );
-}
+use vars qw($debug $cgi_debug);
-eval {
- if (C4::Context->ismemcached) {
- require Memoize::Memcached;
- import Memoize::Memcached qw(memoize_memcached);
-
- memoize_memcached( 'GetMarcStructure',
- memcached => C4::Context->memcached);
- }
-};
=head1 NAME
=item 2. as raw MARC in the Zebra index and storage engine
-=item 3. as raw MARC the biblioitems.marc and biblioitems.marcxml
+=item 3. as MARC XML in biblio_metadata.metadata
=back
-In the 3.0 version of Koha, the authoritative record-level information is in biblioitems.marcxml
+In the 3.0 version of Koha, the authoritative record-level information is in biblio_metadata.metadata
Because the data isn't completely normalized there's a chance for information to get out of sync. The design choice to go with a un-normalized schema was driven by performance and stability concerns. However, if this occur, it can be considered as a bug : The API is (or should be) complete & the only entry point for all biblio/items managements.
=item 2. _koha_* - low-level internal functions for managing the koha tables
-=item 3. Marc management function : as the MARC record is stored in biblioitems.marc(xml), some subs dedicated to it's management are in this package. They should be used only internally by Biblio.pm, the only official entry points being AddBiblio, AddItem, ModBiblio, ModItem.
+=item 3. Marc management function : as the MARC record is stored in biblio_metadata.metadata, some subs dedicated to it's management are in this package. They should be used only internally by Biblio.pm, the only official entry points being AddBiblio, AddItem, ModBiblio, ModItem.
=item 4. Zebra functions used to update the Zebra index
=back
-The MARC record (in biblioitems.marcxml) contains the complete marc record, including items. It also contains the biblionumber. That is the reason why it is not stored directly by AddBiblio, with all other fields . To save a biblio, we need to :
+The MARC record (in biblio_metadata.metadata) contains the complete marc record, including items. It also contains the biblionumber. That is the reason why it is not stored directly by AddBiblio, with all other fields . To save a biblio, we need to :
=over 4
=back
-When dealing with items, we must :
-
-=over 4
-
-=item 1. save the item in items table, that gives us an itemnumber
-
-=item 2. add the itemnumber to the item MARC field
-
-=item 3. overwrite the MARC record (with the added item) into biblioitems.marc(xml)
-
-When modifying a biblio or an item, the behaviour is quite similar.
-
-=back
-
=head1 EXPORTED FUNCTIONS
=head2 AddBiblio
This function also accepts a third, optional argument: a hashref
to additional options. The only defined option is C<defer_marc_save>,
which if present and mapped to a true value, causes C<AddBiblio>
-to omit the call to save the MARC in C<bibilioitems.marc>
-and C<biblioitems.marcxml> This option is provided B<only>
+to omit the call to save the MARC in C<biblio_metadata.metadata>
+This option is provided B<only>
for the use of scripts such as C<bulkmarcimport.pl> that may need
to do some manipulation of the MARC record for item parsing before
saving it and which cannot afford the performance hit of saving
my $frameworkcode = shift;
my $options = @_ ? shift : undef;
my $defer_marc_save = 0;
+ if (!$record) {
+ carp('AddBiblio called with undefined record');
+ return;
+ }
if ( defined $options and exists $options->{'defer_marc_save'} and $options->{'defer_marc_save'} ) {
$defer_marc_save = 1;
}
+ if (C4::Context->preference('BiblioAddsAuthorities')) {
+ BiblioAutoLink( $record, $frameworkcode );
+ }
+
my ( $biblionumber, $biblioitemnumber, $error );
my $dbh = C4::Context->dbh;
# transform the data into koha-table style data
SetUTF8Flag($record);
- my $olddata = TransformMarcToKoha( $dbh, $record, $frameworkcode );
+ my $olddata = TransformMarcToKoha( $record, $frameworkcode );
( $biblionumber, $error ) = _koha_add_biblio( $dbh, $olddata, $frameworkcode );
$olddata->{'biblionumber'} = $biblionumber;
( $biblioitemnumber, $error ) = _koha_add_biblioitem( $dbh, $olddata );
which fields are used to store embedded item, biblioitem,
and biblionumber data for indexing.
+Returns 1 on success 0 on failure
+
=cut
sub ModBiblio {
my ( $record, $biblionumber, $frameworkcode ) = @_;
- croak "No record" unless $record;
+ if (!$record) {
+ carp 'No record passed to ModBiblio';
+ return 0;
+ }
if ( C4::Context->preference("CataloguingLog") ) {
- my $newrecord = GetMarcBiblio($biblionumber);
- logaction( "CATALOGUING", "MODIFY", $biblionumber, "BEFORE=>" . $newrecord->as_formatted );
+ my $newrecord = GetMarcBiblio({ biblionumber => $biblionumber });
+ logaction( "CATALOGUING", "MODIFY", $biblionumber, "biblio BEFORE=>" . $newrecord->as_formatted );
+ }
+
+ if (C4::Context->preference('BiblioAddsAuthorities')) {
+ BiblioAutoLink( $record, $frameworkcode );
}
# Cleaning up invalid fields must be done early or SetUTF8Flag is liable to
_koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber, $biblioitemnumber );
# load the koha-table data object
- my $oldbiblio = TransformMarcToKoha( $dbh, $record, $frameworkcode );
+ my $oldbiblio = TransformMarcToKoha( $record, $frameworkcode );
# update MARC subfield that stores biblioitems.cn_sort
_koha_marc_update_biblioitem_cn_sort( $record, $oldbiblio, $frameworkcode );
}
}
-=head2 ModBiblioframework
-
- ModBiblioframework($biblionumber,$frameworkcode);
-
-Exported function to modify a biblio framework
-
-=cut
-
-sub ModBiblioframework {
- my ( $biblionumber, $frameworkcode ) = @_;
- my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare( "UPDATE biblio SET frameworkcode=? WHERE biblionumber=?" );
- $sth->execute( $frameworkcode, $biblionumber );
- return 1;
-}
-
=head2 DelBiblio
my $error = &DelBiblio($biblionumber);
Exported function (core API) for deleting a biblio in koha.
-Deletes biblio record from Zebra and Koha tables (biblio,biblioitems,items)
-Also backs it up to deleted* tables
-Checks to make sure there are not issues on any of the items
+Deletes biblio record from Zebra and Koha tables (biblio & biblioitems)
+Also backs it up to deleted* tables.
+Checks to make sure that the biblio has no items attached.
return:
C<$error> : undef unless an error occurs
sub DelBiblio {
my ($biblionumber) = @_;
+
+ my $biblio = Koha::Biblios->find( $biblionumber );
+ return unless $biblio; # Should we throw an exception instead?
+
my $dbh = C4::Context->dbh;
my $error; # for error handling
}
# We delete any existing holds
- require C4::Reserves;
- my ($count, $reserves) = C4::Reserves::GetReservesFromBiblionumber($biblionumber);
- foreach my $res ( @$reserves ) {
- C4::Reserves::CancelReserve( $res->{'biblionumber'}, $res->{'itemnumber'}, $res->{'borrowernumber'} );
+ my $holds = $biblio->holds;
+ while ( my $hold = $holds->next ) {
+ $hold->cancel;
}
# Delete in Zebra. Be careful NOT to move this line after _koha_delete_biblio
# for at least 2 reasons :
- # - we need to read the biblio if NoZebra is set (to remove it from the indexes
# - if something goes wrong, the biblio may be deleted from Koha but not from zebra
# and we would have no way to remove it (except manually in zebra, but I bet it would be very hard to handle the problem)
- my $oldRecord;
- if ( C4::Context->preference("NoZebra") ) {
-
- # only NoZebra indexing needs to have
- # the previous version of the record
- $oldRecord = GetMarcBiblio($biblionumber);
- }
- ModZebra( $biblionumber, "recordDelete", "biblioserver", $oldRecord, undef );
+ ModZebra( $biblionumber, "recordDelete", "biblioserver" );
# delete biblioitems and items from Koha tables and save in deletedbiblioitems,deleteditems
$sth = $dbh->prepare("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber=?");
return $error if $error;
}
+
# delete biblio from Koha tables and save in deletedbiblio
# must do this *after* _koha_delete_biblioitems, otherwise
# delete cascade will prevent deletedbiblioitems rows
# from being generated by _koha_delete_biblioitems
$error = _koha_delete_biblio( $dbh, $biblionumber );
- logaction( "CATALOGUING", "DELETE", $biblionumber, "" ) if C4::Context->preference("CataloguingLog");
+ logaction( "CATALOGUING", "DELETE", $biblionumber, "biblio" ) if C4::Context->preference("CataloguingLog");
return;
}
Automatically links headings in a bib record to authorities.
+Returns the number of headings changed
+
=cut
sub BiblioAutoLink {
my $record = shift;
my $frameworkcode = shift;
+ if (!$record) {
+ carp('Undefined record passed to BiblioAutoLink');
+ return 0;
+ }
my ( $num_headings_changed, %results );
my $linker_module =
unless ( can_load( modules => { $linker_module => undef } ) ) {
$linker_module = 'C4::Linker::Default';
unless ( can_load( modules => { $linker_module => undef } ) ) {
- return 0, 0;
+ return 0;
}
}
my $frameworkcode = shift;
my $allowrelink = shift;
my %results;
+ if (!$bib) {
+ carp 'LinkBibHeadingsToAuthorities called on undefined bib record';
+ return ( 0, {});
+ }
require C4::Heading;
require C4::AuthoritiesMarc;
$results{'fuzzy'}->{ $heading->display_form() }++;
}
elsif ( C4::Context->preference('AutoCreateAuthorities') ) {
- my $authtypedata =
- C4::AuthoritiesMarc::GetAuthType( $heading->auth_type() );
- my $marcrecordauth = MARC::Record->new();
- if ( C4::Context->preference('marcflavour') eq 'MARC21' ) {
- $marcrecordauth->leader(' nz a22 o 4500');
- SetMarcUnicodeFlag( $marcrecordauth, 'MARC21' );
+ if ( _check_valid_auth_link( $current_link, $field ) ) {
+ $results{'linked'}->{ $heading->display_form() }++;
}
- my $authfield =
- MARC::Field->new( $authtypedata->{auth_tag_to_report},
- '', '', "a" => "" . $field->subfield('a') );
- map {
- $authfield->add_subfields( $_->[0] => $_->[1] )
- if ( $_->[0] =~ /[A-z]/ && $_->[0] ne "a" )
- } $field->subfields();
- $marcrecordauth->insert_fields_ordered($authfield);
+ else {
+ my $authority_type = Koha::Authority::Types->find( $heading->auth_type() );
+ my $marcrecordauth = MARC::Record->new();
+ if ( C4::Context->preference('marcflavour') eq 'MARC21' ) {
+ $marcrecordauth->leader(' nz a22 o 4500');
+ SetMarcUnicodeFlag( $marcrecordauth, 'MARC21' );
+ }
+ $field->delete_subfield( code => '9' )
+ if defined $current_link;
+ my $authfield =
+ MARC::Field->new( $authority_type->auth_tag_to_report,
+ '', '', "a" => "" . $field->subfield('a') );
+ map {
+ $authfield->add_subfields( $_->[0] => $_->[1] )
+ if ( $_->[0] =~ /[A-z]/ && $_->[0] ne "a"
+ && C4::Heading::valid_bib_heading_subfield(
+ $authority_type->auth_tag_to_report, $_->[0] )
+ );
+ } $field->subfields();
+ $marcrecordauth->insert_fields_ordered($authfield);
# bug 2317: ensure new authority knows it's using UTF-8; currently
# only need to do this for MARC21, as MARC::Record->as_xml_record() handles
# use UTF-8, but as of 2008-08-05, did not want to introduce that kind
# of change to a core API just before the 3.0 release.
- if ( C4::Context->preference('marcflavour') eq 'MARC21' ) {
- $marcrecordauth->insert_fields_ordered(
- MARC::Field->new(
- '667', '', '',
- 'a' => "Machine generated authority record."
- )
- );
- my $cite =
- $bib->author() . ", "
- . $bib->title_proper() . ", "
- . $bib->publication_date() . " ";
- $cite =~ s/^[\s\,]*//;
- $cite =~ s/[\s\,]*$//;
- $cite =
- "Work cat.: ("
- . C4::Context->preference('MARCOrgCode') . ")"
- . $bib->subfield( '999', 'c' ) . ": "
- . $cite;
- $marcrecordauth->insert_fields_ordered(
- MARC::Field->new( '670', '', '', 'a' => $cite ) );
- }
+ if ( C4::Context->preference('marcflavour') eq 'MARC21' ) {
+ my $userenv = C4::Context->userenv;
+ my $library;
+ if ( $userenv && $userenv->{'branch'} ) {
+ $library = Koha::Libraries->find( $userenv->{'branch'} );
+ }
+ $marcrecordauth->insert_fields_ordered(
+ MARC::Field->new(
+ '667', '', '',
+ 'a' => "Machine generated authority record."
+ )
+ );
+ my $cite =
+ $bib->author() . ", "
+ . $bib->title_proper() . ", "
+ . $bib->publication_date() . " ";
+ $cite =~ s/^[\s\,]*//;
+ $cite =~ s/[\s\,]*$//;
+ $cite =
+ "Work cat.: ("
+ . ( $library ? $library->get_effective_marcorgcode : C4::Context->preference('MARCOrgCode') ) . ")"
+ . $bib->subfield( '999', 'c' ) . ": "
+ . $cite;
+ $marcrecordauth->insert_fields_ordered(
+ MARC::Field->new( '670', '', '', 'a' => $cite ) );
+ }
# warn "AUTH RECORD ADDED : ".$marcrecordauth->as_formatted;
- $authid =
- C4::AuthoritiesMarc::AddAuthority( $marcrecordauth, '',
- $heading->auth_type() );
- $field->add_subfields( '9', $authid );
- $num_headings_changed++;
- $results{'added'}->{ $heading->display_form() }++;
+ $authid =
+ C4::AuthoritiesMarc::AddAuthority( $marcrecordauth, '',
+ $heading->auth_type() );
+ $field->add_subfields( '9', $authid );
+ $num_headings_changed++;
+ $linker->update_cache($heading, $authid);
+ $results{'added'}->{ $heading->display_form() }++;
+ }
}
elsif ( defined $current_link ) {
- $field->delete_subfield( code => '9' );
- $num_headings_changed++;
- $results{'unlinked'}->{ $heading->display_form() }++;
+ if ( _check_valid_auth_link( $current_link, $field ) ) {
+ $results{'linked'}->{ $heading->display_form() }++;
+ }
+ else {
+ $field->delete_subfield( code => '9' );
+ $num_headings_changed++;
+ $results{'unlinked'}->{ $heading->display_form() }++;
+ }
}
else {
$results{'unlinked'}->{ $heading->display_form() }++;
return $num_headings_changed, \%results;
}
+=head2 _check_valid_auth_link
+
+ if ( _check_valid_auth_link($authid, $field) ) {
+ ...
+ }
+
+Check whether the specified heading-auth link is valid without reference
+to Zebra. Ideally this code would be in C4::Heading, but that won't be
+possible until we have de-cycled C4::AuthoritiesMarc, so this is the
+safest place.
+
+=cut
+
+sub _check_valid_auth_link {
+ my ( $authid, $field ) = @_;
+
+ require C4::AuthoritiesMarc;
+
+ my $authorized_heading =
+ C4::AuthoritiesMarc::GetAuthorizedHeading( { 'authid' => $authid } ) || '';
+
+ return ($field->as_string('abcdefghijklmnopqrstuvwxyz') eq $authorized_heading);
+}
+
=head2 GetRecordValue
my $values = GetRecordValue($field, $record, $frameworkcode);
sub GetRecordValue {
my ( $field, $record, $frameworkcode ) = @_;
+
+ if (!$record) {
+ carp 'GetRecordValue called with undefined record';
+ return;
+ }
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare('SELECT fieldcode, subfieldcode FROM fieldmapping WHERE frameworkcode = ? AND field = ?');
return \@result;
}
-=head2 SetFieldMapping
-
- SetFieldMapping($framework, $field, $fieldcode, $subfieldcode);
-
-Set a Field to MARC mapping value, if it already exists we don't add a new one.
-
-=cut
-
-sub SetFieldMapping {
- my ( $framework, $field, $fieldcode, $subfieldcode ) = @_;
- my $dbh = C4::Context->dbh;
-
- my $sth = $dbh->prepare('SELECT * FROM fieldmapping WHERE fieldcode = ? AND subfieldcode = ? AND frameworkcode = ? AND field = ?');
- $sth->execute( $fieldcode, $subfieldcode, $framework, $field );
- if ( not $sth->fetchrow_hashref ) {
- my @args;
- $sth = $dbh->prepare('INSERT INTO fieldmapping (fieldcode, subfieldcode, frameworkcode, field) VALUES(?,?,?,?)');
-
- $sth->execute( $fieldcode, $subfieldcode, $framework, $field );
- }
-}
-
-=head2 DeleteFieldMapping
-
- DeleteFieldMapping($id);
-
-Delete a field mapping from an $id.
-
-=cut
-
-sub DeleteFieldMapping {
- my ($id) = @_;
- my $dbh = C4::Context->dbh;
-
- my $sth = $dbh->prepare('DELETE FROM fieldmapping WHERE id = ?');
- $sth->execute($id);
-}
-
-=head2 GetFieldMapping
-
- GetFieldMapping($frameworkcode);
-
-Get all field mappings for a specified frameworkcode
-
-=cut
-
-sub GetFieldMapping {
- my ($framework) = @_;
- my $dbh = C4::Context->dbh;
-
- my $sth = $dbh->prepare('SELECT * FROM fieldmapping where frameworkcode = ?');
- $sth->execute($framework);
-
- my @return;
- while ( my $row = $sth->fetchrow_hashref ) {
- push @return, $row;
- }
- return \@return;
-}
-
=head2 GetBiblioData
$data = &GetBiblioData($biblionumber);
my ($bibnum) = @_;
my $dbh = C4::Context->dbh;
- # my $query = C4::Context->preference('item-level_itypes') ?
- # " SELECT * , biblioitems.notes AS bnotes, biblio.notes
- # FROM biblio
- # LEFT JOIN biblioitems ON biblio.biblionumber = biblioitems.biblionumber
- # WHERE biblio.biblionumber = ?
- # AND biblioitems.biblionumber = biblio.biblionumber
- #";
-
my $query = " SELECT * , biblioitems.notes AS bnotes, itemtypes.notforloan as bi_notforloan, biblio.notes
FROM biblio
LEFT JOIN biblioitems ON biblio.biblionumber = biblioitems.biblionumber
LEFT JOIN itemtypes ON biblioitems.itemtype = itemtypes.itemtype
- WHERE biblio.biblionumber = ?
- AND biblioitems.biblionumber = biblio.biblionumber ";
+ WHERE biblio.biblionumber = ?";
my $sth = $dbh->prepare($query);
$sth->execute($bibnum);
return ($data);
} # sub GetBiblioData
-=head2 &GetBiblioItemData
-
- $itemdata = &GetBiblioItemData($biblioitemnumber);
-
-Looks up the biblioitem with the given biblioitemnumber. Returns a
-reference-to-hash. The keys are the fields from the C<biblio>,
-C<biblioitems>, and C<itemtypes> tables in the Koha database, except
-that C<biblioitems.notes> is given as C<$itemdata-E<gt>{bnotes}>.
-
-=cut
-
-#'
-sub GetBiblioItemData {
- my ($biblioitemnumber) = @_;
- my $dbh = C4::Context->dbh;
- my $query = "SELECT *,biblioitems.notes AS bnotes
- FROM biblio LEFT JOIN biblioitems on biblio.biblionumber=biblioitems.biblionumber ";
- unless ( C4::Context->preference('item-level_itypes') ) {
- $query .= "LEFT JOIN itemtypes on biblioitems.itemtype=itemtypes.itemtype ";
- }
- $query .= " WHERE biblioitemnumber = ? ";
- my $sth = $dbh->prepare($query);
- my $data;
- $sth->execute($biblioitemnumber);
- $data = $sth->fetchrow_hashref;
- $sth->finish;
- return ($data);
-} # sub &GetBiblioItemData
-
-=head2 GetBiblioItemByBiblioNumber
-
-NOTE : This function has been copy/paste from C4/Biblio.pm from head before zebra integration.
-
-=cut
-
-sub GetBiblioItemByBiblioNumber {
- my ($biblionumber) = @_;
- my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare("Select * FROM biblioitems WHERE biblionumber = ?");
- my $count = 0;
- my @results;
-
- $sth->execute($biblionumber);
-
- while ( my $data = $sth->fetchrow_hashref ) {
- push @results, $data;
- }
-
- $sth->finish;
- return @results;
-}
-
-=head2 GetBiblionumberFromItemnumber
-
-
-=cut
-
-sub GetBiblionumberFromItemnumber {
- my ($itemnumber) = @_;
- my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare("Select biblionumber FROM items WHERE itemnumber = ?");
-
- $sth->execute($itemnumber);
- my ($result) = $sth->fetchrow;
- return ($result);
-}
-
-=head2 GetBiblioFromItemNumber
-
- $item = &GetBiblioFromItemNumber($itemnumber,$barcode);
-
-Looks up the item with the given itemnumber. if undef, try the barcode.
-
-C<&itemnodata> returns a reference-to-hash whose keys are the fields
-from the C<biblio>, C<biblioitems>, and C<items> tables in the Koha
-database.
-
-=cut
-
-#'
-sub GetBiblioFromItemNumber {
- my ( $itemnumber, $barcode ) = @_;
- my $dbh = C4::Context->dbh;
- my $sth;
- if ($itemnumber) {
- $sth = $dbh->prepare(
- "SELECT * FROM items
- LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber
- LEFT JOIN biblioitems ON biblioitems.biblioitemnumber = items.biblioitemnumber
- WHERE items.itemnumber = ?"
- );
- $sth->execute($itemnumber);
- } else {
- $sth = $dbh->prepare(
- "SELECT * FROM items
- LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber
- LEFT JOIN biblioitems ON biblioitems.biblioitemnumber = items.biblioitemnumber
- WHERE items.barcode = ?"
- );
- $sth->execute($barcode);
- }
- my $data = $sth->fetchrow_hashref;
- $sth->finish;
- return ($data);
-}
-
=head2 GetISBDView
- $isbd = &GetISBDView($biblionumber);
+ $isbd = &GetISBDView({
+ 'record' => $marc_record,
+ 'template' => $interface, # opac/intranet
+ 'framework' => $framework,
+ });
Return the ISBD view which can be included in opac and intranet
=cut
sub GetISBDView {
- my ( $biblionumber, $template ) = @_;
- my $record = GetMarcBiblio($biblionumber, 1);
+ my ( $params ) = @_;
+
+ # Expecting record WITH items.
+ my $record = $params->{record};
return unless defined $record;
- my $itemtype = &GetFrameworkCode($biblionumber);
+
+ my $template = $params->{template} // q{};
+ my $sysprefname = $template eq 'opac' ? 'opacisbd' : 'isbd';
+ my $framework = $params->{framework};
+ my $itemtype = $framework;
my ( $holdingbrtagf, $holdingbrtagsubf ) = &GetMarcFromKohaField( "items.holdingbranch", $itemtype );
- my $tagslib = &GetMarcStructure( 1, $itemtype );
+ my $tagslib = GetMarcStructure( 1, $itemtype, { unsafe => 1 } );
- my $ISBD = C4::Context->preference('isbd');
+ my $ISBD = C4::Context->preference($sysprefname);
my $bloc = $ISBD;
my $res;
my $blocres;
# warn "ERROR IN ISBD DEFINITION at : $isbdfield" unless $fieldvalue;
# warn "FV : $fieldvalue";
if ( $subfvalue ne "" ) {
+ # OPAC hidden subfield
+ next
+ if ( ( $template eq 'opac' )
+ && ( $tagslib->{$fieldvalue}->{$subfvalue}->{'hidden'} || 0 ) > 0 );
foreach my $field (@fieldslist) {
foreach my $subfield ( $field->subfield($subfvalue) ) {
my $calculated = $analysestring;
for my $i ( 0 .. $#subf ) {
my $valuecode = $subf[$i][1];
my $subfieldcode = $subf[$i][0];
+ # OPAC hidden subfield
+ next
+ if ( ( $template eq 'opac' )
+ && ( $tagslib->{$fieldvalue}->{$subfieldcode}->{'hidden'} || 0 ) > 0 );
my $subfieldvalue = GetAuthorisedValueDesc( $tag, $subf[$i][0], $subf[$i][1], '', $tagslib );
my $tagsubf = $tag . $subfieldcode;
return $res;
}
-=head2 GetBiblio
-
- my $biblio = &GetBiblio($biblionumber);
+=head1 FUNCTIONS FOR HANDLING MARC MANAGEMENT
-=cut
+=head2 IsMarcStructureInternal
-sub GetBiblio {
- my ($biblionumber) = @_;
- my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare("SELECT * FROM biblio WHERE biblionumber = ?");
- my $count = 0;
- my @results;
- $sth->execute($biblionumber);
- if ( my $data = $sth->fetchrow_hashref ) {
- return $data;
+ my $tagslib = C4::Biblio::GetMarcStructure();
+ for my $tag ( sort keys %$tagslib ) {
+ next unless $tag;
+ for my $subfield ( sort keys %{ $tagslib->{$tag} } ) {
+ next if IsMarcStructureInternal($tagslib->{$tag}{$subfield});
+ }
+ # Process subfield
}
- return;
-} # sub GetBiblio
-
-=head2 GetBiblioItemInfosOf
- GetBiblioItemInfosOf(@biblioitemnumbers);
+GetMarcStructure creates keys (lib, tab, mandatory, repeatable) for a display purpose.
+These different values should not be processed as valid subfields.
=cut
-sub GetBiblioItemInfosOf {
- my @biblioitemnumbers = @_;
-
- my $query = '
- SELECT biblioitemnumber,
- publicationyear,
- itemtype
- FROM biblioitems
- WHERE biblioitemnumber IN (' . join( ',', @biblioitemnumbers ) . ')
- ';
- return get_infos_of( $query, 'biblioitemnumber' );
+sub IsMarcStructureInternal {
+ my ( $subfield ) = @_;
+ return ref $subfield ? 0 : 1;
}
-=head1 FUNCTIONS FOR HANDLING MARC MANAGEMENT
-
=head2 GetMarcStructure
- $res = GetMarcStructure($forlibrarian,$frameworkcode);
+ $res = GetMarcStructure($forlibrarian, $frameworkcode, [ $params ]);
Returns a reference to a big hash of hash, with the Marc structure for the given frameworkcode
$forlibrarian :if set to 1, the MARC descriptions are the librarians ones, otherwise it's the public (OPAC) ones
$frameworkcode : the framework code to read
+$params allows you to pass { unsafe => 1 } for better performance.
-=cut
+Note: If you call GetMarcStructure with unsafe => 1, do not modify or
+even autovivify its contents. It is a cached/shared data structure. Your
+changes c/would be passed around in subsequent calls.
-# cache for results of GetMarcStructure -- needed
-# for batch jobs
-our $marc_structure_cache;
+=cut
sub GetMarcStructure {
- my ( $forlibrarian, $frameworkcode ) = @_;
- my $dbh = C4::Context->dbh;
+ my ( $forlibrarian, $frameworkcode, $params ) = @_;
$frameworkcode = "" unless $frameworkcode;
- if ( defined $marc_structure_cache and exists $marc_structure_cache->{$forlibrarian}->{$frameworkcode} ) {
- return $marc_structure_cache->{$forlibrarian}->{$frameworkcode};
- }
+ $forlibrarian = $forlibrarian ? 1 : 0;
+ my $unsafe = ($params && $params->{unsafe})? 1: 0;
+ my $cache = Koha::Caches->get_instance();
+ my $cache_key = "MarcStructure-$forlibrarian-$frameworkcode";
+ my $cached = $cache->get_from_cache($cache_key, { unsafe => $unsafe });
+ return $cached if $cached;
- # my $sth = $dbh->prepare(
- # "SELECT COUNT(*) FROM marc_tag_structure WHERE frameworkcode=?");
- # $sth->execute($frameworkcode);
- # my ($total) = $sth->fetchrow;
- # $frameworkcode = "" unless ( $total > 0 );
+ my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare(
- "SELECT tagfield,liblibrarian,libopac,mandatory,repeatable
+ "SELECT tagfield,liblibrarian,libopac,mandatory,repeatable,ind1_defaultvalue,ind2_defaultvalue
FROM marc_tag_structure
WHERE frameworkcode=?
ORDER BY tagfield"
);
$sth->execute($frameworkcode);
- my ( $liblibrarian, $libopac, $tag, $res, $tab, $mandatory, $repeatable );
+ my ( $liblibrarian, $libopac, $tag, $res, $tab, $mandatory, $repeatable, $ind1_defaultvalue, $ind2_defaultvalue );
- while ( ( $tag, $liblibrarian, $libopac, $mandatory, $repeatable ) = $sth->fetchrow ) {
+ while ( ( $tag, $liblibrarian, $libopac, $mandatory, $repeatable, $ind1_defaultvalue, $ind2_defaultvalue ) = $sth->fetchrow ) {
$res->{$tag}->{lib} = ( $forlibrarian or !$libopac ) ? $liblibrarian : $libopac;
$res->{$tag}->{tab} = "";
$res->{$tag}->{mandatory} = $mandatory;
$res->{$tag}->{repeatable} = $repeatable;
+ $res->{$tag}->{ind1_defaultvalue} = $ind1_defaultvalue;
+ $res->{$tag}->{ind2_defaultvalue} = $ind2_defaultvalue;
}
$sth = $dbh->prepare(
$res->{$tag}->{$subfield}->{maxlength} = $maxlength;
}
- $marc_structure_cache->{$forlibrarian}->{$frameworkcode} = $res;
-
+ $cache->set_in_cache($cache_key, $res);
return $res;
}
my $results = GetUsedMarcStructure($frameworkcode);
-C<$results> is a ref to an array which each case containts a ref
+C<$results> is a ref to an array which each case contains a ref
to a hash which each keys is the columns from marc_subfield_structure
C<$frameworkcode> is the framework code.
sub GetUsedMarcStructure {
my $frameworkcode = shift || '';
- my $query = qq/
+ my $query = q{
SELECT *
FROM marc_subfield_structure
WHERE tab > -1
AND frameworkcode = ?
ORDER BY tagfield, tagsubfield
- /;
+ };
my $sth = C4::Context->dbh->prepare($query);
$sth->execute($frameworkcode);
return $sth->fetchall_arrayref( {} );
}
+=pod
+
+=head2 GetMarcSubfieldStructure
+
+ my $structure = GetMarcSubfieldStructure($frameworkcode, [$params]);
+
+Returns a reference to hash representing MARC subfield structure
+for framework with framework code C<$frameworkcode>, C<$params> is
+optional and may contain additional options.
+
+=over 4
+
+=item C<$frameworkcode>
+
+The framework code.
+
+=item C<$params>
+
+An optional hash reference with additional options.
+The following options are supported:
+
+=over 4
+
+=item unsafe
+
+Pass { unsafe => 1 } do disable cached object cloning,
+and instead get a shared reference, resulting in better
+performance (but care must be taken so that retured object
+is never modified).
+
+Note: If you call GetMarcSubfieldStructure with unsafe => 1, do not modify or
+even autovivify its contents. It is a cached/shared data structure. Your
+changes would be passed around in subsequent calls.
+
+=back
+
+=back
+
+=cut
+
+sub GetMarcSubfieldStructure {
+ my ( $frameworkcode, $params ) = @_;
+
+ $frameworkcode //= '';
+
+ my $cache = Koha::Caches->get_instance();
+ my $cache_key = "MarcSubfieldStructure-$frameworkcode";
+ my $cached = $cache->get_from_cache($cache_key, { unsafe => ($params && $params->{unsafe}) });
+ return $cached if $cached;
+
+ my $dbh = C4::Context->dbh;
+ # We moved to selectall_arrayref since selectall_hashref does not
+ # keep duplicate mappings on kohafield (like place in 260 vs 264)
+ my $subfield_aref = $dbh->selectall_arrayref( q|
+ SELECT *
+ FROM marc_subfield_structure
+ WHERE frameworkcode = ?
+ AND kohafield > ''
+ ORDER BY frameworkcode,tagfield,tagsubfield
+ |, { Slice => {} }, $frameworkcode );
+ # Now map the output to a hash structure
+ my $subfield_structure = {};
+ foreach my $row ( @$subfield_aref ) {
+ push @{ $subfield_structure->{ $row->{kohafield} }}, $row;
+ }
+ $cache->set_in_cache( $cache_key, $subfield_structure );
+ return $subfield_structure;
+}
+
=head2 GetMarcFromKohaField
- ($MARCfield,$MARCsubfield)=GetMarcFromKohaField($kohafield,$frameworkcode);
+ ( $field,$subfield ) = GetMarcFromKohaField( $kohafield );
+ @fields = GetMarcFromKohaField( $kohafield );
+ $field = GetMarcFromKohaField( $kohafield );
+
+ Returns the MARC fields & subfields mapped to $kohafield.
+ Since the Default framework is considered as authoritative for such
+ mappings, the former frameworkcode parameter is obsoleted.
-Returns the MARC fields & subfields mapped to the koha field
-for the given frameworkcode
+ In list context all mappings are returned; there can be multiple
+ mappings. Note that in the above example you could miss a second
+ mappings in the first call.
+ In scalar context only the field tag of the first mapping is returned.
=cut
sub GetMarcFromKohaField {
- my ( $kohafield, $frameworkcode ) = @_;
- return (0, undef) unless $kohafield and defined $frameworkcode;
- my $relations = C4::Context->marcfromkohafield;
- if ( my $mf = $relations->{$frameworkcode}->{$kohafield} ) {
- return @$mf;
+ my ( $kohafield ) = @_;
+ return unless $kohafield;
+ # The next call uses the Default framework since it is AUTHORITATIVE
+ # for all Koha to MARC mappings.
+ my $mss = GetMarcSubfieldStructure( '', { unsafe => 1 } ); # Do not change framework
+ my @retval;
+ foreach( @{ $mss->{$kohafield} } ) {
+ push @retval, $_->{tagfield}, $_->{tagsubfield};
}
- return (0, undef);
+ return wantarray ? @retval : ( @retval ? $retval[0] : undef );
+}
+
+=head2 GetMarcSubfieldStructureFromKohaField
+
+ my $str = GetMarcSubfieldStructureFromKohaField( $kohafield );
+
+ Returns marc subfield structure information for $kohafield.
+ The Default framework is used, since it is authoritative for kohafield
+ mappings.
+ In list context returns a list of all hashrefs, since there may be
+ multiple mappings. In scalar context the first hashref is returned.
+
+=cut
+
+sub GetMarcSubfieldStructureFromKohaField {
+ my ( $kohafield ) = @_;
+
+ return unless $kohafield;
+
+ # The next call uses the Default framework since it is AUTHORITATIVE
+ # for all Koha to MARC mappings.
+ my $mss = GetMarcSubfieldStructure( '', { unsafe => 1 } ); # Do not change framework
+ return unless $mss->{$kohafield};
+ return wantarray ? @{$mss->{$kohafield}} : $mss->{$kohafield}->[0];
}
=head2 GetMarcBiblio
- my $record = GetMarcBiblio($biblionumber, [$embeditems]);
+ my $record = GetMarcBiblio({
+ biblionumber => $biblionumber,
+ embed_items => $embeditems,
+ opac => $opac,
+ borcat => $patron_category });
+
+Returns MARC::Record representing a biblio record, or C<undef> if the
+biblionumber doesn't exist.
+
+Both embed_items and opac are optional.
+If embed_items is passed and is 1, items are embedded.
+If opac is passed and is 1, the record is filtered as needed.
+
+=over 4
+
+=item C<$biblionumber>
+
+the biblionumber
-Returns MARC::Record representing bib identified by
-C<$biblionumber>. If no bib exists, returns undef.
-C<$embeditems>. If set to true, items data are included.
-The MARC record contains biblio data, and items data if $embeditems is set to true.
+=item C<$embeditems>
+
+set to true to include item information.
+
+=item C<$opac>
+
+set to true to make the result suited for OPAC view. This causes things like
+OpacHiddenItems to be applied.
+
+=item C<$borcat>
+
+If the OpacHiddenItemsExceptions system preference is set, this patron category
+can be used to make visible OPAC items which would be normally hidden.
+It only makes sense in combination both embed_items and opac values true.
+
+=back
=cut
sub GetMarcBiblio {
- my $biblionumber = shift;
- my $embeditems = shift || 0;
+ my ($params) = @_;
+
+ if (not defined $params) {
+ carp 'GetMarcBiblio called without parameters';
+ return;
+ }
+
+ my $biblionumber = $params->{biblionumber};
+ my $embeditems = $params->{embed_items} || 0;
+ my $opac = $params->{opac} || 0;
+ my $borcat = $params->{borcat} // q{};
+
+ if (not defined $biblionumber) {
+ carp 'GetMarcBiblio called with undefined biblionumber';
+ return;
+ }
+
my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare("SELECT marcxml FROM biblioitems WHERE biblionumber=? ");
+ my $sth = $dbh->prepare("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber=? ");
$sth->execute($biblionumber);
my $row = $sth->fetchrow_hashref;
- my $marcxml = StripNonXmlChars( $row->{'marcxml'} );
+ my $biblioitemnumber = $row->{'biblioitemnumber'};
+ my $marcxml = GetXmlBiblio( $biblionumber );
+ $marcxml = StripNonXmlChars( $marcxml );
+ my $frameworkcode = GetFrameworkCode($biblionumber);
MARC::File::XML->default_record_format( C4::Context->preference('marcflavour') );
my $record = MARC::Record->new();
if ($marcxml) {
- $record = eval { MARC::Record::new_from_xml( $marcxml, "utf8", C4::Context->preference('marcflavour') ) };
+ $record = eval {
+ MARC::Record::new_from_xml( $marcxml, "utf8",
+ C4::Context->preference('marcflavour') );
+ };
if ($@) { warn " problem with :$biblionumber : $@ \n$marcxml"; }
return unless $record;
- C4::Biblio::_koha_marc_update_bib_ids($record, '', $biblionumber, $biblionumber);
- C4::Biblio::EmbedItemsInMarcBiblio($record, $biblionumber) if ($embeditems);
+ C4::Biblio::_koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber,
+ $biblioitemnumber );
+ C4::Biblio::EmbedItemsInMarcBiblio({
+ marc_record => $record,
+ biblionumber => $biblionumber,
+ opac => $opac,
+ borcat => $borcat })
+ if ($embeditems);
return $record;
- } else {
+ }
+ else {
return;
}
}
my $marcxml = GetXmlBiblio($biblionumber);
-Returns biblioitems.marcxml of the biblionumber passed in parameter.
-The XML contains both biblio & item datas
+Returns biblio_metadata.metadata/marcxml of the biblionumber passed in parameter.
+The XML should only contain biblio information (item information is no longer stored in marcxml field)
=cut
sub GetXmlBiblio {
my ($biblionumber) = @_;
- my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare("SELECT marcxml FROM biblioitems WHERE biblionumber=? ");
- $sth->execute($biblionumber);
- my ($marcxml) = $sth->fetchrow;
+ my $dbh = C4::Context->dbh;
+ return unless $biblionumber;
+ my ($marcxml) = $dbh->selectrow_array(
+ q|
+ SELECT metadata
+ FROM biblio_metadata
+ WHERE biblionumber=?
+ AND format='marcxml'
+ AND `schema`=?
+ |, undef, $biblionumber, C4::Context->preference('marcflavour')
+ );
return $marcxml;
}
# get the coin format
if ( ! $record ) {
- return;
+ carp 'GetCOinSBiblio called with undefined record';
+ return;
}
my $pos7 = substr $record->leader(), 7, 1;
my $pos6 = substr $record->leader(), 6, 1;
$isbn = $record->subfield( '773', 'z' ) || '';
$issn = $record->subfield( '773', 'x' ) || '';
if ($mtx eq 'journal') {
- $title .= "&rft.title=" . (($record->subfield( '773', 't' ) || $record->subfield( '773', 'a')));
+ $title .= "&rft.title=" . ( $record->subfield( '773', 't' ) || $record->subfield( '773', 'a') || q{} );
} else {
- $title .= "&rft.btitle=" . (($record->subfield( '773', 't' ) || $record->subfield( '773', 'a')) || '');
+ $title .= "&rft.btitle=" . ( $record->subfield( '773', 't' ) || $record->subfield( '773', 'a') || q{} );
}
foreach my $rel ($record->subfield( '773', 'g' )) {
if ($pages) {
=head2 GetMarcPrice
return the prices in accordance with the Marc format.
+
+returns 0 if no price found
+returns undef if called without a marc record or with
+an unrecognized marc format
+
=cut
sub GetMarcPrice {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcPrice called on undefined record';
+ return;
+ }
+
my @listtags;
my $subfield;
- if ( $marcflavour eq "MARC21" ) {
+ if ( $marcflavour eq "MARC21" || $marcflavour eq "NORMARC" ) {
@listtags = ('345', '020');
$subfield="c";
} elsif ( $marcflavour eq "UNIMARC" ) {
=head2 MungeMarcPrice
Return the best guess at what the actual price is from a price field.
+
=cut
sub MungeMarcPrice {
my ( $price ) = @_;
-
return unless ( $price =~ m/\d/ ); ## No digits means no price.
-
- ## Look for the currency symbol of the active currency, if it's there,
- ## start the price string right after the symbol. This allows us to prefer
- ## this native currency price over other currency prices, if possible.
- my $active_currency = C4::Context->dbh->selectrow_hashref( 'SELECT * FROM currency WHERE active = 1', {} );
- my $symbol = quotemeta( $active_currency->{'symbol'} );
- if ( $price =~ m/$symbol/ ) {
- my @parts = split(/$symbol/, $price );
- $price = $parts[1];
- }
-
- ## Grab the first number in the string ( can use commas or periods for thousands separator and/or decimal separator )
- ( $price ) = $price =~ m/([\d\,\.]+[[\,\.]\d\d]?)/;
-
- ## Split price into array on periods and commas
- my @parts = split(/[\,\.]/, $price);
-
- ## If the last grouping of digits is more than 2 characters, assume there is no decimal value and put it back.
- my $decimal = pop( @parts );
- if ( length( $decimal ) > 2 ) {
- push( @parts, $decimal );
- $decimal = '';
- }
-
- $price = join('', @parts );
-
- if ( $decimal ) {
- $price .= ".$decimal";
+ # Look for the currency symbol and the normalized code of the active currency, if it's there,
+ my $active_currency = Koha::Acquisition::Currencies->get_active;
+ my $symbol = $active_currency->symbol;
+ my $isocode = $active_currency->isocode;
+ $isocode = $active_currency->currency unless defined $isocode;
+ my $localprice;
+ if ( $symbol ) {
+ my @matches =($price=~ /
+ \s?
+ ( # start of capturing parenthesis
+ (?:
+ (?:[\p{Sc}\p{L}\/.]){1,4} # any character from Currency signs or Letter Unicode categories or slash or dot within 1 to 4 occurrences : call this whole block 'symbol block'
+ |(?:\d+[\p{P}\s]?){1,4} # or else at least one digit followed or not by a punctuation sign or whitespace, all these within 1 to 4 occurrences : call this whole block 'digits block'
+ )
+ \s?\p{Sc}?\s? # followed or not by a whitespace. \p{Sc}?\s? are for cases like '25$ USD'
+ (?:
+ (?:[\p{Sc}\p{L}\/.]){1,4} # followed by same block as symbol block
+ |(?:\d+[\p{P}\s]?){1,4} # or by same block as digits block
+ )
+ \s?\p{L}{0,4}\s? # followed or not by a whitespace. \p{L}{0,4}\s? are for cases like '$9.50 USD'
+ ) # end of capturing parenthesis
+ (?:\p{P}|\z) # followed by a punctuation sign or by the end of the string
+ /gx);
+
+ if ( @matches ) {
+ foreach ( @matches ) {
+ $localprice = $_ and last if index($_, $isocode)>=0;
+ }
+ if ( !$localprice ) {
+ foreach ( @matches ) {
+ $localprice = $_ and last if $_=~ /(^|[^\p{Sc}\p{L}\/])\Q$symbol\E([^\p{Sc}\p{L}\/]+\z|\z)/;
+ }
+ }
+ }
}
-
+ if ( $localprice ) {
+ $price = $localprice;
+ } else {
+ ## Grab the first number in the string ( can use commas or periods for thousands separator and/or decimal separator )
+ ( $price ) = $price =~ m/([\d\,\.]+[[\,\.]\d\d]?)/;
+ }
+ # eliminate symbol/isocode, space and any final dot from the string
+ $price =~ s/[\p{Sc}\p{L}\/ ]|\.$//g;
+ # remove comma,dot when used as separators from hundreds
+ $price =~s/[\,\.](\d{3})/$1/g;
+ # convert comma to dot to ensure correct display of decimals if existing
+ $price =~s/,/./;
return $price;
}
return the quantity of a book. Used in acquisition only, when importing a file an iso2709 from a bookseller
Warning : this is not really in the marc standard. In Unimarc, Electre (the most widely used bookseller) use the 969$a
+returns 0 if no quantity found
+returns undef if called without a marc record or with
+an unrecognized marc format
+
=cut
sub GetMarcQuantity {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcQuantity called on undefined record';
+ return;
+ }
+
my @listtags;
my $subfield;
sub GetAuthorisedValueDesc {
my ( $tag, $subfield, $value, $framework, $tagslib, $category, $opac ) = @_;
- my $dbh = C4::Context->dbh;
if ( !$category ) {
#---- branch
if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "branches" ) {
- return C4::Branch::GetBranchName($value);
+ my $branch = Koha::Libraries->find($value);
+ return $branch? $branch->branchname: q{};
}
#---- itemtypes
if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "itemtypes" ) {
- return getitemtypeinfo($value)->{description};
+ my $itemtype = Koha::ItemTypes->find( $value );
+ return $itemtype ? $itemtype->translated_description : q||;
}
#---- "true" authorized value
$category = $tagslib->{$tag}->{$subfield}->{'authorised_value'};
}
+ my $dbh = C4::Context->dbh;
if ( $category ne "" ) {
my $sth = $dbh->prepare( "SELECT lib, lib_opac FROM authorised_values WHERE category = ? AND authorised_value = ?" );
$sth->execute( $category, $value );
sub GetMarcControlnumber {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcControlnumber called on undefined record';
+ return;
+ }
my $controlnumber = "";
# Control number or Record identifier are the same field in MARC21, UNIMARC and NORMARC
# Keep $marcflavour for possible later use
sub GetMarcISBN {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcISBN called on undefined record';
+ return;
+ }
my $scope;
if ( $marcflavour eq "UNIMARC" ) {
$scope = '010';
} else { # assume marc21 if not unimarc
$scope = '020';
}
+
my @marcisbns;
- my $isbn = "";
- my $tag = "";
- my $marcisbn;
foreach my $field ( $record->field($scope) ) {
- my $value = $field->as_string();
+ my $isbn = $field->subfield( 'a' );
if ( $isbn ne "" ) {
- $marcisbn = { marcisbn => $isbn, };
- push @marcisbns, $marcisbn;
- $isbn = $value;
- }
- if ( $isbn ne $value ) {
- $isbn = $isbn . " " . $value;
+ push @marcisbns, $isbn;
}
}
- if ($isbn) {
- $marcisbn = { marcisbn => $isbn };
- push @marcisbns, $marcisbn; #load last tag into array
- }
return \@marcisbns;
} # end GetMarcISBN
sub GetMarcISSN {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcISSN called on undefined record';
+ return;
+ }
my $scope;
if ( $marcflavour eq "UNIMARC" ) {
$scope = '011';
}
my @marcissns;
foreach my $field ( $record->field($scope) ) {
- push @marcissns, $field->subfield( 'a' );
+ push @marcissns, $field->subfield( 'a' )
+ if ( $field->subfield( 'a' ) ne "" );
}
return \@marcissns;
} # end GetMarcISSN
=head2 GetMarcNotes
- $marcnotesarray = GetMarcNotes( $record, $marcflavour );
+ $marcnotesarray = GetMarcNotes( $record, $marcflavour );
-Get all notes from the MARC record and returns them in an array.
-The note are stored in different fields depending on MARC flavour
+ Get all notes from the MARC record and returns them in an array.
+ The notes are stored in different fields depending on MARC flavour.
+ MARC21 5XX $u subfields receive special attention as they are URIs.
=cut
sub GetMarcNotes {
my ( $record, $marcflavour ) = @_;
- my $scope;
- if ( $marcflavour eq "UNIMARC" ) {
- $scope = '3..';
- } else { # assume marc21 if not unimarc
- $scope = '5..';
+ if (!$record) {
+ carp 'GetMarcNotes called on undefined record';
+ return;
}
+
+ my $scope = $marcflavour eq "UNIMARC"? '3..': '5..';
my @marcnotes;
- my $note = "";
- my $tag = "";
- my $marcnote;
+ my %blacklist = map { $_ => 1 }
+ split( /,/, C4::Context->preference('NotesBlacklist'));
foreach my $field ( $record->field($scope) ) {
- my $value = $field->as_string();
- if ( $note ne "" ) {
- $marcnote = { marcnote => $note, };
- push @marcnotes, $marcnote;
- $note = $value;
- }
- if ( $note ne $value ) {
- $note = $note . " " . $value;
+ my $tag = $field->tag();
+ next if $blacklist{ $tag };
+ if( $marcflavour ne 'UNIMARC' && $field->subfield('u') ) {
+ # Field 5XX$u always contains URI
+ # Examples: 505u, 506u, 510u, 514u, 520u, 530u, 538u, 540u, 542u, 552u, 555u, 561u, 563u, 583u
+ # We first push the other subfields, then all $u's separately
+ # Leave further actions to the template (see e.g. opac-detail)
+ my $othersub =
+ join '', ( 'a' .. 't', 'v' .. 'z', '0' .. '9' ); # excl 'u'
+ push @marcnotes, { marcnote => $field->as_string($othersub) };
+ foreach my $sub ( $field->subfield('u') ) {
+ $sub =~ s/^\s+|\s+$//g; # trim
+ push @marcnotes, { marcnote => $sub };
+ }
+ } else {
+ push @marcnotes, { marcnote => $field->as_string() };
}
}
-
- if ($note) {
- $marcnote = { marcnote => $note };
- push @marcnotes, $marcnote; #load last tag into array
- }
return \@marcnotes;
-} # end GetMarcNotes
+}
=head2 GetMarcSubjects
sub GetMarcSubjects {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcSubjects called on undefined record';
+ return;
+ }
my ( $mintag, $maxtag, $fields_filter );
if ( $marcflavour eq "UNIMARC" ) {
$mintag = "600";
my @marcsubjects;
my $subject_limit = C4::Context->preference("TraceCompleteSubfields") ? 'su,complete-subfield' : 'su';
- my $authoritysep = C4::Context->preference('authoritysep');
+ my $AuthoritySeparator = C4::Context->preference('AuthoritySeparator');
foreach my $field ( $record->field($fields_filter) ) {
next unless ($field->tag() >= $mintag && $field->tag() <= $maxtag);
code => $code,
value => $value,
link_loop => \@this_link_loop,
- separator => (scalar @subfields_loop) ? $authoritysep : ''
+ separator => (scalar @subfields_loop) ? $AuthoritySeparator : ''
};
}
}
push @marcsubjects, {
MARCSUBJECT_SUBFIELDS_LOOP => \@subfields_loop,
authoritylink => $authoritylink,
- };
+ } if $authoritylink || @subfields_loop;
}
return \@marcsubjects;
sub GetMarcAuthors {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcAuthors called on undefined record';
+ return;
+ }
my ( $mintag, $maxtag, $fields_filter );
- # tagslib useful for UNIMARC author reponsabilities
- my $tagslib =
- &GetMarcStructure( 1, '' ); # FIXME : we don't have the framework available, we take the default framework. May be buggy on some setups, will be usually correct.
+ # tagslib useful only for UNIMARC author responsibilities
+ my $tagslib;
if ( $marcflavour eq "UNIMARC" ) {
+ # FIXME : we don't have the framework available, we take the default framework. May be buggy on some setups, will be usually correct.
+ $tagslib = GetMarcStructure( 1, '', { unsafe => 1 });
$mintag = "700";
$maxtag = "712";
$fields_filter = '7..';
}
my @marcauthors;
- my $authoritysep = C4::Context->preference('authoritysep');
+ my $AuthoritySeparator = C4::Context->preference('AuthoritySeparator');
foreach my $field ( $record->field($fields_filter) ) {
next unless $field->tag() >= $mintag && $field->tag() <= $maxtag;
}
# other subfields
+ my $unimarc3;
for my $authors_subfield (@subfields) {
next if ( $authors_subfield->[0] eq '9' );
+ # unimarc3 contains the $3 of the author for UNIMARC.
+ # For french academic libraries, it's the "ppn", and it's required for idref webservice
+ $unimarc3 = $authors_subfield->[1] if $marcflavour eq 'UNIMARC' and $authors_subfield->[0] =~ /3/;
+
# don't load unimarc subfields 3, 5
next if ( $marcflavour eq 'UNIMARC' and ( $authors_subfield->[0] =~ /3|5/ ) );
code => $code,
value => $value,
link_loop => \@this_link_loop,
- separator => (scalar @subfields_loop) ? $authoritysep : ''
+ separator => (scalar @subfields_loop) ? $AuthoritySeparator : ''
};
}
}
push @marcauthors, {
MARCAUTHOR_SUBFIELDS_LOOP => \@subfields_loop,
authoritylink => $subfield9,
+ unimarc3 => $unimarc3
};
}
return \@marcauthors;
sub GetMarcUrls {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcUrls called on undefined record';
+ return;
+ }
my @marcurls;
for my $field ( $record->field('856') ) {
}
my @urls = $field->subfield('u');
foreach my $url (@urls) {
+ $url =~ s/^\s+|\s+$//g; # trim
my $marcurl;
if ( $marcflavour eq 'MARC21' ) {
my $s3 = $field->subfield('3');
sub GetMarcSeries {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcSeries called on undefined record';
+ return;
+ }
+
my ( $mintag, $maxtag, $fields_filter );
if ( $marcflavour eq "UNIMARC" ) {
- $mintag = "600";
- $maxtag = "619";
- $fields_filter = '6..';
+ $mintag = "225";
+ $maxtag = "225";
+ $fields_filter = '2..';
} else { # marc21/normarc
$mintag = "440";
$maxtag = "490";
}
my @marcseries;
- my $authoritysep = C4::Context->preference('authoritysep');
+ my $AuthoritySeparator = C4::Context->preference('AuthoritySeparator');
foreach my $field ( $record->field($fields_filter) ) {
next unless $field->tag() >= $mintag && $field->tag() <= $maxtag;
code => $code,
value => $value,
link_loop => \@link_loop,
- separator => (scalar @subfields_loop) ? $authoritysep : '',
+ separator => (scalar @subfields_loop) ? $AuthoritySeparator : '',
volumenum => $volume_number,
}
}
sub GetMarcHosts {
my ( $record, $marcflavour ) = @_;
+ if (!$record) {
+ carp 'GetMarcHosts called on undefined record';
+ return;
+ }
+
my ( $tag,$title_subf,$bibnumber_subf,$itemnumber_subf);
$marcflavour ||="MARC21";
if ( $marcflavour eq "MARC21" || $marcflavour eq "NORMARC" ) {
return $marchostsarray;
}
+=head2 UpsertMarcSubfield
+
+ my $record = C4::Biblio::UpsertMarcSubfield($MARC::Record, $fieldTag, $subfieldCode, $subfieldContent);
+
+=cut
+
+sub UpsertMarcSubfield {
+ my ($record, $tag, $code, $content) = @_;
+ my $f = $record->field($tag);
+
+ if ($f) {
+ $f->update( $code => $content );
+ }
+ else {
+ my $f = MARC::Field->new( $tag, '', '', $code => $content);
+ $record->insert_fields_ordered( $f );
+ }
+}
+
+=head2 UpsertMarcControlField
+
+ my $record = C4::Biblio::UpsertMarcControlField($MARC::Record, $fieldTag, $content);
+
+=cut
+
+sub UpsertMarcControlField {
+ my ($record, $tag, $content) = @_;
+ die "UpsertMarcControlField() \$tag '$tag' is not a control field\n" unless 0+$tag < 10;
+ my $f = $record->field($tag);
+
+ if ($f) {
+ $f->update( $content );
+ }
+ else {
+ my $f = MARC::Field->new($tag, $content);
+ $record->insert_fields_ordered( $f );
+ }
+}
+
=head2 GetFrameworkCode
$frameworkcode = GetFrameworkCode( $biblionumber )
=head2 TransformKohaToMarc
- $record = TransformKohaToMarc( $hash )
+ $record = TransformKohaToMarc( $hash [, $params ] )
-This function builds partial MARC::Record from a hash
-Hash entries can be from biblio or biblioitems.
+This function builds a (partial) MARC::Record from a hash.
+Hash entries can be from biblio, biblioitems or items.
+The params hash includes the parameter no_split used in C4::Items.
This function is called in acquisition module, to create a basic catalogue
-entry from user entry
+entry from user entry.
=cut
sub TransformKohaToMarc {
- my $hash = shift;
+ my ( $hash, $params ) = @_;
my $record = MARC::Record->new();
SetMarcUnicodeFlag( $record, C4::Context->preference("marcflavour") );
- my $db_to_marc = C4::Context->marcfromkohafield;
- while ( my ($name, $value) = each %$hash ) {
- next unless my $dtm = $db_to_marc->{''}->{$name};
- next unless ( scalar( @$dtm ) );
- my ($tag, $letter) = @$dtm;
- foreach my $value ( split(/\s?\|\s?/, $value, -1) ) {
- if ( my $field = $record->field($tag) ) {
- $field->add_subfields( $letter => $value );
- }
- else {
- $record->insert_fields_ordered( MARC::Field->new(
- $tag, " ", " ", $letter => $value ) );
+
+ # In the next call we use the Default framework, since it is considered
+ # authoritative for Koha to Marc mappings.
+ my $mss = GetMarcSubfieldStructure( '', { unsafe => 1 } ); # do not change framewok
+ my $tag_hr = {};
+ while ( my ($kohafield, $value) = each %$hash ) {
+ foreach my $fld ( @{ $mss->{$kohafield} } ) {
+ my $tagfield = $fld->{tagfield};
+ my $tagsubfield = $fld->{tagsubfield};
+ next if !$tagfield;
+ my @values = $params->{no_split}
+ ? ( $value )
+ : split(/\s?\|\s?/, $value, -1);
+ foreach my $value ( @values ) {
+ next if $value eq '';
+ $tag_hr->{$tagfield} //= [];
+ push @{$tag_hr->{$tagfield}}, [($tagsubfield, $value)];
}
}
-
+ }
+ foreach my $tag (sort keys %$tag_hr) {
+ my @sfl = @{$tag_hr->{$tag}};
+ @sfl = sort { $a->[0] cmp $b->[0]; } @sfl;
+ @sfl = map { @{$_}; } @sfl;
+ # Special care for control fields: remove the subfield indication @
+ # and do not insert indicators.
+ my @ind = $tag < 10 ? () : ( " ", " " );
+ @sfl = grep { $_ ne '@' } @sfl if $tag < 10;
+ $record->insert_fields_ordered( MARC::Field->new($tag, @ind, @sfl) );
}
return $record;
}
my ($hostbiblionumber,$hostitemnumber, $marcflavour) = @_;
$marcflavour ||="MARC21";
- require C4::Items;
- my $hostrecord = GetMarcBiblio($hostbiblionumber);
- my $item = C4::Items::GetItem($hostitemnumber);
-
+ my $hostrecord = GetMarcBiblio({ biblionumber => $hostbiblionumber });
+ my $item = Koha::Items->find($hostitemnumber);
+
my $hostmarcfield;
if ( $marcflavour eq "MARC21" || $marcflavour eq "NORMARC" ) {
#other fields
my $ed = $hostrecord->subfield('250','a');
- my $barcode = $item->{'barcode'};
+ my $barcode = $item->barcode;
my $title = $hostrecord->subfield('245','a');
# record control number, 001 with 003 and prefix
sub TransformHtmlToXml {
my ( $tags, $subfields, $values, $indicator, $ind_tag, $auth_type ) = @_;
+ # NOTE: The parameter $ind_tag is NOT USED -- BZ 11247
+
my $xml = MARC::File::XML::header('UTF-8');
$xml .= "<record>\n";
$auth_type = C4::Context->preference('marcflavour') unless $auth_type;
my $prevtag = -1;
my $first = 1;
my $j = -1;
+ my $close_last_tag;
for ( my $i = 0 ; $i < @$tags ; $i++ ) {
if ( C4::Context->preference('marcflavour') eq 'UNIMARC' and @$tags[$i] eq "100" and @$subfields[$i] eq "a" ) {
@$values[$i] =~ s/"/"/g;
@$values[$i] =~ s/'/'/g;
- # if ( !utf8::is_utf8( @$values[$i] ) ) {
- # utf8::decode( @$values[$i] );
- # }
if ( ( @$tags[$i] ne $prevtag ) ) {
+ $close_last_tag = 0;
$j++ unless ( @$tags[$i] eq "" );
my $indicator1 = eval { substr( @$indicator[$j], 0, 1 ) };
my $indicator2 = eval { substr( @$indicator[$j], 1, 1 ) };
$xml .= "<datafield tag=\"@$tags[$i]\" ind1=\"$ind1\" ind2=\"$ind2\">\n";
$xml .= "<subfield code=\"@$subfields[$i]\">@$values[$i]</subfield>\n";
$first = 0;
+ $close_last_tag = 1;
} else {
$first = 1;
}
$xml .= "<datafield tag=\"@$tags[$i]\" ind1=\"$ind1\" ind2=\"$ind2\">\n";
$xml .= "<subfield code=\"@$subfields[$i]\">@$values[$i]</subfield>\n";
$first = 0;
+ $close_last_tag = 1;
}
}
}
if ($first) {
$xml .= "<datafield tag=\"@$tags[$i]\" ind1=\"$ind1\" ind2=\"$ind2\">\n";
$first = 0;
+ $close_last_tag = 1;
}
$xml .= "<subfield code=\"@$subfields[$i]\">@$values[$i]</subfield>\n";
}
}
$prevtag = @$tags[$i];
}
- $xml .= "</datafield>\n" if $xml =~ m/<datafield/;
+ $xml .= "</datafield>\n" if $close_last_tag;
if ( C4::Context->preference('marcflavour') eq 'UNIMARC' and !$unimarc_and_100_exist ) {
# warn "SETTING 100 for $auth_type";
=head2 TransformHtmlToMarc
L<$record> = TransformHtmlToMarc(L<$cgi>)
- L<$cgi> is the CGI object which containts the values for subfields
+ L<$cgi> is the CGI object which contains the values for subfields
{
'tag_010_indicator1_531951' ,
'tag_010_indicator2_531951' ,
=cut
sub TransformHtmlToMarc {
- my $cgi = shift;
+ my ($cgi, $isbiblio) = @_;
- my @params = $cgi->param();
+ my @params = $cgi->multi_param();
# explicitly turn on the UTF-8 flag for all
# 'tag_' parameters to avoid incorrect character
foreach my $param_name ( keys %$cgi_params ) {
if ( $param_name =~ /^tag_/ ) {
my $param_value = $cgi_params->{$param_name};
- if ( utf8::decode($param_value) ) {
- $cgi_params->{$param_name} = $param_value;
+ unless ( Encode::is_utf8( $param_value ) ) {
+ $cgi_params->{$param_name} = Encode::decode('UTF-8', $param_value );
}
-
- # FIXME - need to do something if string is not valid UTF-8
}
}
# creating a new record
my $record = MARC::Record->new();
- my $i = 0;
my @fields;
+ my ($biblionumbertagfield, $biblionumbertagsubfield) = (-1, -1);
+ ($biblionumbertagfield, $biblionumbertagsubfield) =
+ &GetMarcFromKohaField( "biblio.biblionumber", '' ) if $isbiblio;
#FIXME This code assumes that the CGI params will be in the same order as the fields in the template; this is no absolute guarantee!
- while ( $params[$i] ) { # browse all CGI params
+ for (my $i = 0; $params[$i]; $i++ ) { # browse all CGI params
my $param = $params[$i];
my $newfield = 0;
# if we are on biblionumber, store it in the MARC::Record (it may not be in the edited fields)
if ( $param eq 'biblionumber' ) {
- my ( $biblionumbertagfield, $biblionumbertagsubfield ) = &GetMarcFromKohaField( "biblio.biblionumber", '' );
if ( $biblionumbertagfield < 10 ) {
- $newfield = MARC::Field->new( $biblionumbertagfield, $cgi->param($param), );
+ $newfield = MARC::Field->new( $biblionumbertagfield, scalar $cgi->param($param), );
} else {
- $newfield = MARC::Field->new( $biblionumbertagfield, '', '', "$biblionumbertagsubfield" => $cgi->param($param), );
+ $newfield = MARC::Field->new( $biblionumbertagfield, '', '', "$biblionumbertagsubfield" => scalar $cgi->param($param), );
}
push @fields, $newfield if ($newfield);
} elsif ( $param =~ /^tag_(\d*)_indicator1_/ ) { # new field start when having 'input name="..._indicator1_..."
if ( $tag < 10 ) { # no code for theses fields
# in MARC editor, 000 contains the leader.
+ next if $tag == $biblionumbertagfield;
+ my $fval= $cgi->param($params[$j+1]);
if ( $tag eq '000' ) {
# Force a fake leader even if not provided to avoid crashing
# during decoding MARC record containing UTF-8 characters
$record->leader(
- length( $cgi->param($params[$j+1]) ) == 24
- ? $cgi->param( $params[ $j + 1 ] )
+ length( $fval ) == 24
+ ? $fval
: ' nam a22 4500'
)
;
# between 001 and 009 (included)
- } elsif ( $cgi->param( $params[ $j + 1 ] ) ne '' ) {
- $newfield = MARC::Field->new( $tag, $cgi->param( $params[ $j + 1 ] ), );
+ } elsif ( $fval ne '' ) {
+ $newfield = MARC::Field->new( $tag, $fval, );
}
# > 009, deal with subfields
# browse subfields for this tag (reason for _code_ match)
while(defined $params[$j] && $params[$j] =~ /_code_/) {
last unless defined $params[$j+1];
+ $j += 2 and next
+ if $tag == $biblionumbertagfield and
+ $cgi->param($params[$j]) eq $biblionumbertagsubfield;
#if next param ne subfield, then it was probably empty
#try next param by incrementing j
if($params[$j+1]!~/_subfield_/) {$j++; next; }
+ my $fkey= $cgi->param($params[$j]);
my $fval= $cgi->param($params[$j+1]);
#check if subfield value not empty and field exists
if($fval ne '' && $newfield) {
- $newfield->add_subfields( $cgi->param($params[$j]) => $fval);
+ $newfield->add_subfields( $fkey => $fval);
}
elsif($fval ne '') {
- $newfield = MARC::Field->new( $tag, $ind1, $ind2, $cgi->param($params[$j]) => $fval );
+ $newfield = MARC::Field->new( $tag, $ind1, $ind2, $fkey => $fval );
}
$j += 2;
} #end-of-while
}
push @fields, $newfield if ($newfield);
}
- $i++;
}
$record->append_fields(@fields);
return $record;
}
-# cache inverted MARC field map
-our $inverted_field_map;
-
=head2 TransformMarcToKoha
- $result = TransformMarcToKoha( $dbh, $record, $frameworkcode )
+ $result = TransformMarcToKoha( $record, undef, $limit )
Extract data from a MARC bib record into a hashref representing
-Koha biblio, biblioitems, and items fields.
+Koha biblio, biblioitems, and items fields.
+
+If passed an undefined record will log the error and return an empty
+hash_ref.
=cut
sub TransformMarcToKoha {
- my ( $dbh, $record, $frameworkcode, $limit_table ) = @_;
+ my ( $record, $frameworkcode, $limit_table ) = @_;
+ # FIXME Parameter $frameworkcode is obsolete and will be removed
+ $limit_table //= q{};
- my $result;
- $limit_table = $limit_table || 0;
- $frameworkcode = '' unless defined $frameworkcode;
-
- unless ( defined $inverted_field_map ) {
- $inverted_field_map = _get_inverted_marc_field_map();
+ my $result = {};
+ if (!defined $record) {
+ carp('TransformMarcToKoha called with undefined record');
+ return $result;
}
- my %tables = ();
- if ( defined $limit_table && $limit_table eq 'items' ) {
- $tables{'items'} = 1;
- } else {
- $tables{'items'} = 1;
- $tables{'biblio'} = 1;
- $tables{'biblioitems'} = 1;
+ my %tables = ( biblio => 1, biblioitems => 1, items => 1 );
+ if( $limit_table eq 'items' ) {
+ %tables = ( items => 1 );
}
- # traverse through record
- MARCFIELD: foreach my $field ( $record->fields() ) {
- my $tag = $field->tag();
- next MARCFIELD unless exists $inverted_field_map->{$frameworkcode}->{$tag};
- if ( $field->is_control_field() ) {
- my $kohafields = $inverted_field_map->{$frameworkcode}->{$tag}->{list};
- ENTRY: foreach my $entry ( @{$kohafields} ) {
- my ( $subfield, $table, $column ) = @{$entry};
- next ENTRY unless exists $tables{$table};
- my $key = _disambiguate( $table, $column );
- if ( $result->{$key} ) {
- unless ( ( $key eq "biblionumber" or $key eq "biblioitemnumber" ) and ( $field->data() eq "" ) ) {
- $result->{$key} .= " | " . $field->data();
- }
- } else {
- $result->{$key} = $field->data();
- }
- }
- } else {
-
- # deal with subfields
- MARCSUBFIELD: foreach my $sf ( $field->subfields() ) {
- my $code = $sf->[0];
- next MARCSUBFIELD unless exists $inverted_field_map->{$frameworkcode}->{$tag}->{sfs}->{$code};
- my $value = $sf->[1];
- SFENTRY: foreach my $entry ( @{ $inverted_field_map->{$frameworkcode}->{$tag}->{sfs}->{$code} } ) {
- my ( $table, $column ) = @{$entry};
- next SFENTRY unless exists $tables{$table};
- my $key = _disambiguate( $table, $column );
- if ( $result->{$key} ) {
- unless ( ( $key eq "biblionumber" or $key eq "biblioitemnumber" ) and ( $value eq "" ) ) {
- $result->{$key} .= " | " . $value;
- }
- } else {
- $result->{$key} = $value;
- }
- }
- }
- }
+ # The next call acknowledges Default as the authoritative framework
+ # for Koha to MARC mappings.
+ my $mss = GetMarcSubfieldStructure( '', { unsafe => 1 } ); # Do not change framework
+ foreach my $kohafield ( keys %{ $mss } ) {
+ my ( $table, $column ) = split /[.]/, $kohafield, 2;
+ next unless $tables{$table};
+ my $val = TransformMarcToKohaOneField( $kohafield, $record );
+ next if !defined $val;
+ my $key = _disambiguate( $table, $column );
+ $result->{$key} = $val;
}
-
- # modify copyrightdate to keep only the 1st year found
- if ( exists $result->{'copyrightdate'} ) {
- my $temp = $result->{'copyrightdate'};
- $temp =~ m/c(\d\d\d\d)/;
- if ( $temp =~ m/c(\d\d\d\d)/ and $1 > 0 ) { # search cYYYY first
- $result->{'copyrightdate'} = $1;
- } else { # if no cYYYY, get the 1st date.
- $temp =~ m/(\d\d\d\d)/;
- $result->{'copyrightdate'} = $1;
- }
- }
-
- # modify publicationyear to keep only the 1st year found
- if ( exists $result->{'publicationyear'} ) {
- my $temp = $result->{'publicationyear'};
- if ( $temp =~ m/c(\d\d\d\d)/ and $1 > 0 ) { # search cYYYY first
- $result->{'publicationyear'} = $1;
- } else { # if no cYYYY, get the 1st date.
- $temp =~ m/(\d\d\d\d)/;
- $result->{'publicationyear'} = $1;
- }
- }
-
return $result;
}
-sub _get_inverted_marc_field_map {
- my $field_map = {};
- my $relations = C4::Context->marcfromkohafield;
-
- foreach my $frameworkcode ( keys %{$relations} ) {
- foreach my $kohafield ( keys %{ $relations->{$frameworkcode} } ) {
- next unless @{ $relations->{$frameworkcode}->{$kohafield} }; # not all columns are mapped to MARC tag & subfield
- my $tag = $relations->{$frameworkcode}->{$kohafield}->[0];
- my $subfield = $relations->{$frameworkcode}->{$kohafield}->[1];
- my ( $table, $column ) = split /[.]/, $kohafield, 2;
- push @{ $field_map->{$frameworkcode}->{$tag}->{list} }, [ $subfield, $table, $column ];
- push @{ $field_map->{$frameworkcode}->{$tag}->{sfs}->{$subfield} }, [ $table, $column ];
- }
- }
- return $field_map;
-}
-
=head2 _disambiguate
$newkey = _disambiguate($table, $field);
=cut
-sub CountItemsIssued {
- my ($biblionumber) = @_;
- my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare('SELECT COUNT(*) as issuedCount FROM items, issues WHERE items.itemnumber = issues.itemnumber AND items.biblionumber = ?');
- $sth->execute($biblionumber);
- my $row = $sth->fetchrow_hashref();
- return $row->{'issuedCount'};
-}
-
sub _disambiguate {
my ( $table, $column ) = @_;
if ( $column eq "cn_sort" or $column eq "cn_source" ) {
}
-=head2 get_koha_field_from_marc
+=head2 TransformMarcToKohaOneField
- $result->{_disambiguate($table, $field)} =
- get_koha_field_from_marc($table,$field,$record,$frameworkcode);
+ $val = TransformMarcToKohaOneField( 'biblio.title', $marc );
-Internal function to map data from the MARC record to a specific non-MARC field.
-FIXME: this is meant to replace TransformMarcToKohaOneField after more testing.
+ Note: The authoritative Default framework is used implicitly.
=cut
-sub get_koha_field_from_marc {
- my ( $koha_table, $koha_column, $record, $frameworkcode ) = @_;
- my ( $tagfield, $subfield ) = GetMarcFromKohaField( $koha_table . '.' . $koha_column, $frameworkcode );
- my $kohafield;
- foreach my $field ( $record->field($tagfield) ) {
- if ( $field->tag() < 10 ) {
- if ($kohafield) {
- $kohafield .= " | " . $field->data();
+sub TransformMarcToKohaOneField {
+ my ( $kohafield, $marc ) = @_;
+
+ my ( @rv, $retval );
+ my @mss = GetMarcSubfieldStructureFromKohaField($kohafield);
+ foreach my $fldhash ( @mss ) {
+ my $tag = $fldhash->{tagfield};
+ my $sub = $fldhash->{tagsubfield};
+ foreach my $fld ( $marc->field($tag) ) {
+ if( $sub eq '@' || $fld->is_control_field ) {
+ push @rv, $fld->data if $fld->data;
} else {
- $kohafield = $field->data();
- }
- } else {
- if ( $field->subfields ) {
- my @subfields = $field->subfields();
- foreach my $subfieldcount ( 0 .. $#subfields ) {
- if ( $subfields[$subfieldcount][0] eq $subfield ) {
- if ($kohafield) {
- $kohafield .= " | " . $subfields[$subfieldcount][1];
- } else {
- $kohafield = $subfields[$subfieldcount][1];
- }
- }
- }
+ push @rv, grep { $_ } $fld->subfield($sub);
}
}
}
- return $kohafield;
+ return unless @rv;
+ $retval = join ' | ', uniq(@rv);
+
+ # Additional polishing for individual kohafields
+ if( $kohafield =~ /copyrightdate|publicationyear/ ) {
+ $retval = _adjust_pubyear( $retval );
+ }
+
+ return $retval;
}
-=head2 TransformMarcToKohaOneField
+=head2 _adjust_pubyear
- $result = TransformMarcToKohaOneField( $kohatable, $kohafield, $record, $result, $frameworkcode )
+ Helper routine for TransformMarcToKohaOneField
=cut
-sub TransformMarcToKohaOneField {
-
- # FIXME ? if a field has a repeatable subfield that is used in old-db,
- # only the 1st will be retrieved...
- my ( $kohatable, $kohafield, $record, $result, $frameworkcode ) = @_;
- my $res = "";
- my ( $tagfield, $subfield ) = GetMarcFromKohaField( $kohatable . "." . $kohafield, $frameworkcode );
- foreach my $field ( $record->field($tagfield) ) {
- if ( $field->tag() < 10 ) {
- if ( $result->{$kohafield} ) {
- $result->{$kohafield} .= " | " . $field->data();
- } else {
- $result->{$kohafield} = $field->data();
- }
- } else {
- if ( $field->subfields ) {
- my @subfields = $field->subfields();
- foreach my $subfieldcount ( 0 .. $#subfields ) {
- if ( $subfields[$subfieldcount][0] eq $subfield ) {
- if ( $result->{$kohafield} ) {
- $result->{$kohafield} .= " | " . $subfields[$subfieldcount][1];
- } else {
- $result->{$kohafield} = $subfields[$subfieldcount][1];
- }
- }
- }
- }
- }
+sub _adjust_pubyear {
+ my $retval = shift;
+ # modify return value to keep only the 1st year found
+ if( $retval =~ m/c(\d\d\d\d)/ and $1 > 0 ) { # search cYYYY first
+ $retval = $1;
+ } elsif( $retval =~ m/(\d\d\d\d)/ && $1 > 0 ) {
+ $retval = $1;
+ } elsif( $retval =~ m/
+ (?<year>\d)[-]?[.Xx?]{3}
+ |(?<year>\d{2})[.Xx?]{2}
+ |(?<year>\d{3})[.Xx?]
+ |(?<year>\d)[-]{3}\?
+ |(?<year>\d\d)[-]{2}\?
+ |(?<year>\d{3})[-]\?
+ /xms ) { # the form 198-? occurred in Dutch ISBD rules
+ my $digits = $+{year};
+ $retval = $digits * ( 10 ** ( 4 - length($digits) ));
}
- return $result;
+ return $retval;
}
+=head2 CountItemsIssued
-#"
+ my $count = CountItemsIssued( $biblionumber );
-#
-# true ModZebra commented until indexdata fixes zebraDB crashes (it seems they occur on multiple updates
-# at the same time
-# replaced by a zebraqueue table, that is filled with ModZebra to run.
-# the table is emptied by misc/cronjobs/zebraqueue_start.pl script
-# =head2 ModZebrafiles
-#
-# &ModZebrafiles( $dbh, $biblionumber, $record, $folder, $server );
-#
-# =cut
-#
-# sub ModZebrafiles {
-#
-# my ( $dbh, $biblionumber, $record, $folder, $server ) = @_;
-#
-# my $op;
-# my $zebradir =
-# C4::Context->zebraconfig($server)->{directory} . "/" . $folder . "/";
-# unless ( opendir( DIR, "$zebradir" ) ) {
-# warn "$zebradir not found";
-# return;
-# }
-# closedir DIR;
-# my $filename = $zebradir . $biblionumber;
-#
-# if ($record) {
-# open( OUTPUT, ">", $filename . ".xml" );
-# print OUTPUT $record;
-# close OUTPUT;
-# }
-# }
+=cut
+
+sub CountItemsIssued {
+ my ($biblionumber) = @_;
+ my $dbh = C4::Context->dbh;
+ my $sth = $dbh->prepare('SELECT COUNT(*) as issuedCount FROM items, issues WHERE items.itemnumber = issues.itemnumber AND items.biblionumber = ?');
+ $sth->execute($biblionumber);
+ my $row = $sth->fetchrow_hashref();
+ return $row->{'issuedCount'};
+}
=head2 ModZebra
- ModZebra( $biblionumber, $op, $server, $oldRecord, $newRecord );
+ ModZebra( $biblionumber, $op, $server, $record );
$biblionumber is the biblionumber we want to index
-$op is specialUpdate or delete, and is used to know what we want to do
+$op is specialUpdate or recordDelete, and is used to know what we want to do
$server is the server that we want to update
-$oldRecord is the MARC::Record containing the previous version of the record. This is used only when
-NoZebra=1, as NoZebra indexing needs to know the previous version of a record in order to
-do an update.
-
-$newRecord is the MARC::Record containing the new record. It is usefull only when NoZebra=1, and is used to know what to add to the nozebra database. (the record in mySQL being, if it exist, the previous record, the one just before the modif. We need both : the previous and the new one.
+$record is the update MARC record if it's available. If it's not supplied
+and is needed, it'll be loaded from the database.
=cut
sub ModZebra {
###Accepts a $server variable thus we can use it for biblios authorities or other zebra dbs
- my ( $biblionumber, $op, $server, $oldRecord, $newRecord ) = @_;
- my $dbh = C4::Context->dbh;
-
- # true ModZebra commented until indexdata fixes zebraDB crashes (it seems they occur on multiple updates
- # at the same time
- # replaced by a zebraqueue table, that is filled with ModZebra to run.
- # the table is emptied by misc/cronjobs/zebraqueue_start.pl script
-
- if ( C4::Context->preference("NoZebra") ) {
+ my ( $biblionumber, $op, $server, $record ) = @_;
+ $debug && warn "ModZebra: update requested for: $biblionumber $op $server\n";
+ if ( C4::Context->preference('SearchEngine') eq 'Elasticsearch' ) {
- # lock the nozebra table : we will read index lines, update them in Perl process
- # and write everything in 1 transaction.
- # lock the table to avoid someone else overwriting what we are doing
- $dbh->do('LOCK TABLES nozebra WRITE,biblio WRITE,biblioitems WRITE, systempreferences WRITE, auth_types WRITE, auth_header WRITE, auth_subfield_structure READ');
- my %result; # the result hash that will be built by deletion / add, and written on mySQL at the end, to improve speed
+ # TODO abstract to a standard API that'll work for whatever
+ require Koha::SearchEngine::Elasticsearch::Indexer;
+ my $indexer = Koha::SearchEngine::Elasticsearch::Indexer->new(
+ {
+ index => $server eq 'biblioserver'
+ ? $Koha::SearchEngine::BIBLIOS_INDEX
+ : $Koha::SearchEngine::AUTHORITIES_INDEX
+ }
+ );
if ( $op eq 'specialUpdate' ) {
-
- # OK, we have to add or update the record
- # 1st delete (virtually, in indexes), if record actually exists
- if ($oldRecord) {
- %result = _DelBiblioNoZebra( $biblionumber, $oldRecord, $server );
+ unless ($record) {
+ $record = GetMarcBiblio({
+ biblionumber => $biblionumber,
+ embed_items => 1 });
}
-
- # ... add the record
- %result = _AddBiblioNoZebra( $biblionumber, $newRecord, $server, %result );
- } else {
-
- # it's a deletion, delete the record...
- # warn "DELETE the record $biblionumber on $server".$record->as_formatted;
- %result = _DelBiblioNoZebra( $biblionumber, $oldRecord, $server );
+ my $records = [$record];
+ $indexer->update_index_background( [$biblionumber], [$record] );
}
-
- # ok, now update the database...
- my $sth = $dbh->prepare("UPDATE nozebra SET biblionumbers=? WHERE server=? AND indexname=? AND value=?");
- foreach my $key ( keys %result ) {
- foreach my $index ( keys %{ $result{$key} } ) {
- $sth->execute( $result{$key}->{$index}, $server, $key, $index );
- }
+ elsif ( $op eq 'recordDelete' ) {
+ $indexer->delete_index_background( [$biblionumber] );
}
- $dbh->do('UNLOCK TABLES');
- } else {
-
- #
- # we use zebra, just fill zebraqueue table
- #
- my $check_sql = "SELECT COUNT(*) FROM zebraqueue
- WHERE server = ?
- AND biblio_auth_number = ?
- AND operation = ?
- AND done = 0";
- my $check_sth = $dbh->prepare_cached($check_sql);
- $check_sth->execute( $server, $biblionumber, $op );
- my ($count) = $check_sth->fetchrow_array;
- $check_sth->finish();
- if ( $count == 0 ) {
- my $sth = $dbh->prepare("INSERT INTO zebraqueue (biblio_auth_number,server,operation) VALUES(?,?,?)");
- $sth->execute( $biblionumber, $server, $op );
- $sth->finish;
+ else {
+ croak "ModZebra called with unknown operation: $op";
}
}
-}
-
-=head2 GetNoZebraIndexes
- %indexes = GetNoZebraIndexes;
-
-return the data from NoZebraIndexes syspref.
-
-=cut
+ my $dbh = C4::Context->dbh;
-sub GetNoZebraIndexes {
- my $no_zebra_indexes = C4::Context->preference('NoZebraIndexes');
- my %indexes;
- INDEX: foreach my $line ( split /['"],[\n\r]*/, $no_zebra_indexes ) {
- $line =~ /(.*)=>(.*)/;
- my $index = $1; # initial ' or " is removed afterwards
- my $fields = $2;
- $index =~ s/'|"|\s//g;
- $fields =~ s/'|"|\s//g;
- $indexes{$index} = $fields;
- }
- return %indexes;
+ # true ModZebra commented until indexdata fixes zebraDB crashes (it seems they occur on multiple updates
+ # at the same time
+ # replaced by a zebraqueue table, that is filled with ModZebra to run.
+ # the table is emptied by rebuild_zebra.pl script (using the -z switch)
+ my $check_sql = "SELECT COUNT(*) FROM zebraqueue
+ WHERE server = ?
+ AND biblio_auth_number = ?
+ AND operation = ?
+ AND done = 0";
+ my $check_sth = $dbh->prepare_cached($check_sql);
+ $check_sth->execute( $server, $biblionumber, $op );
+ my ($count) = $check_sth->fetchrow_array;
+ $check_sth->finish();
+ if ( $count == 0 ) {
+ my $sth = $dbh->prepare("INSERT INTO zebraqueue (biblio_auth_number,server,operation) VALUES(?,?,?)");
+ $sth->execute( $biblionumber, $server, $op );
+ $sth->finish;
+ }
}
+
=head2 EmbedItemsInMarcBiblio
- EmbedItemsInMarcBiblio($marc, $biblionumber, $itemnumbers);
+ EmbedItemsInMarcBiblio({
+ marc_record => $marc,
+ biblionumber => $biblionumber,
+ item_numbers => $itemnumbers,
+ opac => $opac });
Given a MARC::Record object containing a bib record,
modify it to include the items attached to it as 9XX
per the bib's MARC framework.
-if $itemnumbers is defined, only specified itemnumbers are embedded
+if $itemnumbers is defined, only specified itemnumbers are embedded.
+
+If $opac is true, then opac-relevant suppressions are included.
+
+If opac filtering will be done, borcat should be passed to properly
+override if necessary.
=cut
sub EmbedItemsInMarcBiblio {
- my ($marc, $biblionumber, $itemnumbers) = @_;
- croak "No MARC record" unless $marc;
+ my ($params) = @_;
+ my ($marc, $biblionumber, $itemnumbers, $opac, $borcat);
+ $marc = $params->{marc_record};
+ if ( !$marc ) {
+ carp 'EmbedItemsInMarcBiblio: No MARC record passed';
+ return;
+ }
+ $biblionumber = $params->{biblionumber};
+ $itemnumbers = $params->{item_numbers};
+ $opac = $params->{opac};
+ $borcat = $params->{borcat} // q{};
+
+ $itemnumbers = [] unless defined $itemnumbers;
my $frameworkcode = GetFrameworkCode($biblionumber);
_strip_item_fields($marc, $frameworkcode);
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare("SELECT itemnumber FROM items WHERE biblionumber = ?");
$sth->execute($biblionumber);
- my @item_fields;
my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField( "items.itemnumber", $frameworkcode );
- while (my ($itemnumber) = $sth->fetchrow_array) {
- next if $itemnumbers and not grep { $_ == $itemnumber } @$itemnumbers;
- require C4::Items;
- my $item_marc = C4::Items::GetMarcItem($biblionumber, $itemnumber);
- push @item_fields, $item_marc->field($itemtag);
- }
- $marc->append_fields(@item_fields);
-}
-
-=head1 INTERNAL FUNCTIONS
-
-=head2 _DelBiblioNoZebra($biblionumber,$record,$server);
-
-function to delete a biblio in NoZebra indexes
-This function does NOT delete anything in database : it reads all the indexes entries
-that have to be deleted & delete them in the hash
-
-The SQL part is done either :
- - after the Add if we are modifying a biblio (delete + add again)
- - immediatly after this sub if we are doing a true deletion.
-
-$server can be 'biblioserver' or 'authorityserver' : it indexes biblios or authorities (in the same table, $server being part of the table itself
-=cut
-
-sub _DelBiblioNoZebra {
- my ( $biblionumber, $record, $server ) = @_;
-
- # Get the indexes
- my $dbh = C4::Context->dbh;
-
- # Get the indexes
- my %index;
- my $title;
- if ( $server eq 'biblioserver' ) {
- %index = GetNoZebraIndexes;
-
- # get title of the record (to store the 10 first letters with the index)
- my ( $titletag, $titlesubfield ) = GetMarcFromKohaField( 'biblio.title', '' ); # FIXME: should be GetFrameworkCode($biblionumber) ??
- $title = lc( $record->subfield( $titletag, $titlesubfield ) );
- } else {
-
- # for authorities, the "title" is the $a mainentry
- my ( $auth_type_tag, $auth_type_sf ) = C4::AuthoritiesMarc::get_auth_type_location();
- my $authref = C4::AuthoritiesMarc::GetAuthType( $record->subfield( $auth_type_tag, $auth_type_sf ) );
- warn "ERROR : authtype undefined for " . $record->as_formatted unless $authref;
- $title = $record->subfield( $authref->{auth_tag_to_report}, 'a' );
- $index{'mainmainentry'} = $authref->{'auth_tag_to_report'} . 'a';
- $index{'mainentry'} = $authref->{'auth_tag_to_report'} . '*';
- $index{'auth_type'} = "${auth_type_tag}${auth_type_sf}";
- }
-
- my %result;
-
- # remove blancks comma (that could cause problem when decoding the string for CQL retrieval) and regexp specific values
- $title =~ s/ |,|;|\[|\]|\(|\)|\*|-|'|=//g;
-
- # limit to 10 char, should be enough, and limit the DB size
- $title = substr( $title, 0, 10 );
-
- #parse each field
- my $sth2 = $dbh->prepare('SELECT biblionumbers FROM nozebra WHERE server=? AND indexname=? AND value=?');
- foreach my $field ( $record->fields() ) {
-
- #parse each subfield
- next if $field->tag < 10;
- foreach my $subfield ( $field->subfields() ) {
- my $tag = $field->tag();
- my $subfieldcode = $subfield->[0];
- my $indexed = 0;
-
- # check each index to see if the subfield is stored somewhere
- # otherwise, store it in __RAW__ index
- foreach my $key ( keys %index ) {
-
- # warn "examining $key index : ".$index{$key}." for $tag $subfieldcode";
- if ( $index{$key} =~ /$tag\*/ or $index{$key} =~ /$tag$subfieldcode/ ) {
- $indexed = 1;
- my $line = lc $subfield->[1];
+ my @item_fields; # Array holding the actual MARC data for items to be included.
+ my @items; # Array holding items which are both in the list (sitenumbers)
+ # and on this biblionumber
- # remove meaningless value in the field...
- $line =~ s/-|\.|\?|,|;|!|'|\(|\)|\[|\]|{|}|"|<|>|&|\+|\*|\/|=|:/ /g;
+ # Flag indicating if there is potential hiding.
+ my $opachiddenitems = $opac
+ && ( C4::Context->preference('OpacHiddenItems') !~ /^\s*$/ );
- # ... and split in words
- foreach ( split / /, $line ) {
- next unless $_; # skip empty values (multiple spaces)
- # if the entry is already here, do nothing, the biblionumber has already be removed
- unless ( defined( $result{$key}->{$_} ) && ( $result{$key}->{$_} =~ /$biblionumber,$title\-(\d);/ ) ) {
-
- # get the index value if it exist in the nozebra table and remove the entry, otherwise, do nothing
- $sth2->execute( $server, $key, $_ );
- my $existing_biblionumbers = $sth2->fetchrow;
-
- # it exists
- if ($existing_biblionumbers) {
-
- # warn " existing for $key $_: $existing_biblionumbers";
- $result{$key}->{$_} = $existing_biblionumbers;
- $result{$key}->{$_} =~ s/$biblionumber,$title\-(\d);//;
- }
- }
- }
- }
- }
-
- # the subfield is not indexed, store it in __RAW__ index anyway
- unless ($indexed) {
- my $line = lc $subfield->[1];
- $line =~ s/-|\.|\?|,|;|!|'|\(|\)|\[|\]|{|}|"|<|>|&|\+|\*|\/|=|:/ /g;
-
- # ... and split in words
- foreach ( split / /, $line ) {
- next unless $_; # skip empty values (multiple spaces)
- # if the entry is already here, do nothing, the biblionumber has already be removed
- unless ( $result{'__RAW__'}->{$_} =~ /$biblionumber,$title\-(\d);/ ) {
-
- # get the index value if it exist in the nozebra table and remove the entry, otherwise, do nothing
- $sth2->execute( $server, '__RAW__', $_ );
- my $existing_biblionumbers = $sth2->fetchrow;
-
- # it exists
- if ($existing_biblionumbers) {
- $result{'__RAW__'}->{$_} = $existing_biblionumbers;
- $result{'__RAW__'}->{$_} =~ s/$biblionumber,$title\-(\d);//;
- }
- }
- }
- }
- }
+ require C4::Items;
+ while ( my ($itemnumber) = $sth->fetchrow_array ) {
+ next if @$itemnumbers and not grep { $_ == $itemnumber } @$itemnumbers;
+ my $item;
+ if ( $opachiddenitems ) {
+ $item = Koha::Items->find($itemnumber);
+ $item = $item ? $item->unblessed : undef;
+ }
+ push @items, { itemnumber => $itemnumber, item => $item };
+ }
+ my @items2pass = map { $_->{item} } @items;
+ my @hiddenitems =
+ $opachiddenitems
+ ? C4::Items::GetHiddenItemnumbers({
+ items => \@items2pass,
+ borcat => $borcat })
+ : ();
+ # Convert to a hash for quick searching
+ my %hiddenitems = map { $_ => 1 } @hiddenitems;
+ foreach my $itemnumber ( map { $_->{itemnumber} } @items ) {
+ next if $hiddenitems{$itemnumber};
+ my $item_marc = C4::Items::GetMarcItem( $biblionumber, $itemnumber );
+ push @item_fields, $item_marc->field($itemtag);
}
- return %result;
+ $marc->append_fields(@item_fields);
}
-=head2 _AddBiblioNoZebra
-
- _AddBiblioNoZebra($biblionumber, $record, $server, %result);
-
-function to add a biblio in NoZebra indexes
-
-=cut
-
-sub _AddBiblioNoZebra {
- my ( $biblionumber, $record, $server, %result ) = @_;
- my $dbh = C4::Context->dbh;
-
- # Get the indexes
- my %index;
- my $title;
- if ( $server eq 'biblioserver' ) {
- %index = GetNoZebraIndexes;
-
- # get title of the record (to store the 10 first letters with the index)
- my ( $titletag, $titlesubfield ) = GetMarcFromKohaField( 'biblio.title', '' ); # FIXME: should be GetFrameworkCode($biblionumber) ??
- $title = lc( $record->subfield( $titletag, $titlesubfield ) );
- } else {
-
- # warn "server : $server";
- # for authorities, the "title" is the $a mainentry
- my ( $auth_type_tag, $auth_type_sf ) = C4::AuthoritiesMarc::get_auth_type_location();
- my $authref = C4::AuthoritiesMarc::GetAuthType( $record->subfield( $auth_type_tag, $auth_type_sf ) );
- warn "ERROR : authtype undefined for " . $record->as_formatted unless $authref;
- $title = $record->subfield( $authref->{auth_tag_to_report}, 'a' );
- $index{'mainmainentry'} = $authref->{auth_tag_to_report} . 'a';
- $index{'mainentry'} = $authref->{auth_tag_to_report} . '*';
- $index{'auth_type'} = "${auth_type_tag}${auth_type_sf}";
- }
-
- # remove blancks comma (that could cause problem when decoding the string for CQL retrieval) and regexp specific values
- $title =~ s/ |\.|,|;|\[|\]|\(|\)|\*|-|'|:|=|\r|\n//g;
-
- # limit to 10 char, should be enough, and limit the DB size
- $title = substr( $title, 0, 10 );
-
- #parse each field
- my $sth2 = $dbh->prepare('SELECT biblionumbers FROM nozebra WHERE server=? AND indexname=? AND value=?');
- foreach my $field ( $record->fields() ) {
-
- #parse each subfield
- ###FIXME: impossible to index a 001-009 value with NoZebra
- next if $field->tag < 10;
- foreach my $subfield ( $field->subfields() ) {
- my $tag = $field->tag();
- my $subfieldcode = $subfield->[0];
- my $indexed = 0;
-
- # warn "INDEXING :".$subfield->[1];
- # check each index to see if the subfield is stored somewhere
- # otherwise, store it in __RAW__ index
- foreach my $key ( keys %index ) {
-
- # warn "examining $key index : ".$index{$key}." for $tag $subfieldcode";
- if ( $index{$key} =~ /$tag\*/ or $index{$key} =~ /$tag$subfieldcode/ ) {
- $indexed = 1;
- my $line = lc $subfield->[1];
-
- # remove meaningless value in the field...
- $line =~ s/-|\.|\?|,|;|!|'|\(|\)|\[|\]|{|}|"|<|>|&|\+|\*|\/|=|:|\r|\n/ /g;
-
- # ... and split in words
- foreach ( split / /, $line ) {
- next unless $_; # skip empty values (multiple spaces)
- # if the entry is already here, improve weight
-
- # warn "managing $_";
- if ( exists $result{$key}->{$_} && $result{$key}->{"$_"} =~ /$biblionumber,\Q$title\E\-(\d+);/ ) {
- my $weight = $1 + 1;
- $result{$key}->{"$_"} =~ s/$biblionumber,\Q$title\E\-(\d+);//g;
- $result{$key}->{"$_"} .= "$biblionumber,$title-$weight;";
- } else {
-
- # get the value if it exist in the nozebra table, otherwise, create it
- $sth2->execute( $server, $key, $_ );
- my $existing_biblionumbers = $sth2->fetchrow;
-
- # it exists
- if ($existing_biblionumbers) {
- $result{$key}->{"$_"} = $existing_biblionumbers;
- my $weight = defined $1 ? $1 + 1 : 1;
- $result{$key}->{"$_"} =~ s/$biblionumber,\Q$title\E\-(\d+);//g;
- $result{$key}->{"$_"} .= "$biblionumber,$title-$weight;";
-
- # create a new ligne for this entry
- } else {
-
- # warn "INSERT : $server / $key / $_";
- $dbh->do( 'INSERT INTO nozebra SET server=' . $dbh->quote($server) . ', indexname=' . $dbh->quote($key) . ',value=' . $dbh->quote($_) );
- $result{$key}->{"$_"} .= "$biblionumber,$title-1;";
- }
- }
- }
- }
- }
-
- # the subfield is not indexed, store it in __RAW__ index anyway
- unless ($indexed) {
- my $line = lc $subfield->[1];
- $line =~ s/-|\.|\?|,|;|!|'|\(|\)|\[|\]|{|}|"|<|>|&|\+|\*|\/|=|:|\r|\n/ /g;
-
- # ... and split in words
- foreach ( split / /, $line ) {
- next unless $_; # skip empty values (multiple spaces)
- # if the entry is already here, improve weight
- my $tmpstr = $result{'__RAW__'}->{"$_"} || "";
- if ( $tmpstr =~ /$biblionumber,\Q$title\E\-(\d+);/ ) {
- my $weight = $1 + 1;
- $result{'__RAW__'}->{"$_"} =~ s/$biblionumber,\Q$title\E\-(\d+);//;
- $result{'__RAW__'}->{"$_"} .= "$biblionumber,$title-$weight;";
- } else {
-
- # get the value if it exist in the nozebra table, otherwise, create it
- $sth2->execute( $server, '__RAW__', $_ );
- my $existing_biblionumbers = $sth2->fetchrow;
-
- # it exists
- if ($existing_biblionumbers) {
- $result{'__RAW__'}->{"$_"} = $existing_biblionumbers;
- my $weight = ( $1 ? $1 : 0 ) + 1;
- $result{'__RAW__'}->{"$_"} =~ s/$biblionumber,\Q$title\E\-(\d+);//;
- $result{'__RAW__'}->{"$_"} .= "$biblionumber,$title-$weight;";
-
- # create a new ligne for this entry
- } else {
- $dbh->do( 'INSERT INTO nozebra SET server=' . $dbh->quote($server) . ', indexname="__RAW__",value=' . $dbh->quote($_) );
- $result{'__RAW__'}->{"$_"} .= "$biblionumber,$title-1;";
- }
- }
- }
- }
- }
- }
- return %result;
-}
+=head1 INTERNAL FUNCTIONS
=head2 _koha_marc_update_bib_ids
sub _koha_marc_update_bib_ids {
my ( $record, $frameworkcode, $biblionumber, $biblioitemnumber ) = @_;
- # we must add bibnum and bibitemnum in MARC::Record...
- # we build the new field with biblionumber and biblioitemnumber
- # we drop the original field
- # we add the new builded field.
my ( $biblio_tag, $biblio_subfield ) = GetMarcFromKohaField( "biblio.biblionumber", $frameworkcode );
die qq{No biblionumber tag for framework "$frameworkcode"} unless $biblio_tag;
my ( $biblioitem_tag, $biblioitem_subfield ) = GetMarcFromKohaField( "biblioitems.biblioitemnumber", $frameworkcode );
die qq{No biblioitemnumber tag for framework "$frameworkcode"} unless $biblioitem_tag;
- if ( $biblio_tag == $biblioitem_tag ) {
-
- # biblionumber & biblioitemnumber are in the same field (can't be <10 as fields <10 have only 1 value)
- my $new_field = MARC::Field->new(
- $biblio_tag, '', '',
- "$biblio_subfield" => $biblionumber,
- "$biblioitem_subfield" => $biblioitemnumber
- );
-
- # drop old field and create new one...
- my $old_field = $record->field($biblio_tag);
- $record->delete_field($old_field) if $old_field;
- $record->insert_fields_ordered($new_field);
+ if ( $biblio_tag < 10 ) {
+ C4::Biblio::UpsertMarcControlField( $record, $biblio_tag, $biblionumber );
} else {
-
- # biblionumber & biblioitemnumber are in different fields
-
- # deal with biblionumber
- my ( $new_field, $old_field );
- if ( $biblio_tag < 10 ) {
- $new_field = MARC::Field->new( $biblio_tag, $biblionumber );
- } else {
- $new_field = MARC::Field->new( $biblio_tag, '', '', "$biblio_subfield" => $biblionumber );
- }
-
- # drop old field and create new one...
- $old_field = $record->field($biblio_tag);
- $record->delete_field($old_field) if $old_field;
- $record->insert_fields_ordered($new_field);
-
- # deal with biblioitemnumber
- if ( $biblioitem_tag < 10 ) {
- $new_field = MARC::Field->new( $biblioitem_tag, $biblioitemnumber, );
- } else {
- $new_field = MARC::Field->new( $biblioitem_tag, '', '', "$biblioitem_subfield" => $biblioitemnumber, );
- }
-
- # drop old field and create new one...
- $old_field = $record->field($biblioitem_tag);
- $record->delete_field($old_field) if $old_field;
- $record->insert_fields_ordered($new_field);
+ C4::Biblio::UpsertMarcSubfield($record, $biblio_tag, $biblio_subfield, $biblionumber);
+ }
+ if ( $biblioitem_tag < 10 ) {
+ C4::Biblio::UpsertMarcControlField( $record, $biblioitem_tag, $biblioitemnumber );
+ } else {
+ C4::Biblio::UpsertMarcSubfield($record, $biblioitem_tag, $biblioitem_subfield, $biblioitemnumber);
}
}
$sth->execute(
$frameworkcode, $biblio->{'author'}, $biblio->{'title'}, $biblio->{'unititle'}, $biblio->{'notes'},
- $biblio->{'serial'}, $biblio->{'seriestitle'}, $biblio->{'copyrightdate'}, $biblio->{'abstract'}, $biblio->{'biblionumber'}
+ $biblio->{'serial'}, $biblio->{'seriestitle'}, $biblio->{'copyrightdate'} ? int($biblio->{'copyrightdate'}) : undef, $biblio->{'abstract'}, $biblio->{'biblionumber'}
) if $biblio->{'biblionumber'};
if ( $dbh->errstr || !$biblio->{'biblionumber'} ) {
my ($biblioitemnumber,$error) = _koha_modify_biblioitem_nonmarc( $dbh, $biblioitem );
-Updates biblioitems row except for marc and marcxml, which should be changed
-via ModBiblioMarc
-
=cut
sub _koha_modify_biblioitem_nonmarc {
size = ?,
place = ?,
lccn = ?,
- marc = ?,
url = ?,
cn_source = ?,
cn_class = ?,
$biblioitem->{'volumedate'}, $biblioitem->{'volumedesc'}, $biblioitem->{'collectiontitle'}, $biblioitem->{'collectionissn'},
$biblioitem->{'collectionvolume'}, $biblioitem->{'editionstatement'}, $biblioitem->{'editionresponsibility'}, $biblioitem->{'illus'},
$biblioitem->{'pages'}, $biblioitem->{'bnotes'}, $biblioitem->{'size'}, $biblioitem->{'place'},
- $biblioitem->{'lccn'}, $biblioitem->{'marc'}, $biblioitem->{'url'}, $biblioitem->{'biblioitems.cn_source'},
+ $biblioitem->{'lccn'}, $biblioitem->{'url'}, $biblioitem->{'biblioitems.cn_source'},
$biblioitem->{'cn_class'}, $biblioitem->{'cn_item'}, $biblioitem->{'cn_suffix'}, $cn_sort,
$biblioitem->{'totalissues'}, $biblioitem->{'ean'}, $biblioitem->{'agerestriction'}
);
my $sth = $dbh->prepare("SELECT * FROM biblio WHERE biblionumber=?");
$sth->execute($biblionumber);
+ # FIXME There is a transaction in _koha_delete_biblio_metadata
+ # But actually all the following should be done inside a single transaction
if ( my $data = $sth->fetchrow_hashref ) {
# save the record in deletedbiblio
$bkup_sth->execute(@bind);
$bkup_sth->finish;
+ _koha_delete_biblio_metadata( $biblionumber );
+
# delete the biblio
my $sth2 = $dbh->prepare("DELETE FROM biblio WHERE biblionumber=?");
$sth2->execute($biblionumber);
return;
}
+=head2 _koha_delete_biblio_metadata
+
+ $error = _koha_delete_biblio_metadata($biblionumber);
+
+C<$biblionumber> - the biblionumber of the biblio metadata to be deleted
+
+=cut
+
+sub _koha_delete_biblio_metadata {
+ my ($biblionumber) = @_;
+
+ my $dbh = C4::Context->dbh;
+ my $schema = Koha::Database->new->schema;
+ $schema->txn_do(
+ sub {
+ $dbh->do( q|
+ INSERT INTO deletedbiblio_metadata (biblionumber, format, `schema`, metadata)
+ SELECT biblionumber, format, `schema`, metadata FROM biblio_metadata WHERE biblionumber=?
+ |, undef, $biblionumber );
+ $dbh->do( q|DELETE FROM biblio_metadata WHERE biblionumber=?|,
+ undef, $biblionumber );
+ }
+ );
+}
+
=head1 UNEXPORTED FUNCTIONS
=head2 ModBiblioMarc
&ModBiblioMarc($newrec,$biblionumber,$frameworkcode);
-Add MARC data for a biblio to koha
+Add MARC XML data for a biblio to koha
Function exported, but should NOT be used, unless you really know what you're doing
sub ModBiblioMarc {
# pass the MARC::Record to this function, and it will create the records in
- # the marc field
+ # the marcxml field
my ( $record, $biblionumber, $frameworkcode ) = @_;
+ if ( !$record ) {
+ carp 'ModBiblioMarc passed an undefined record';
+ return;
+ }
# Clone record as it gets modified
$record = $record->clone();
# deal with UNIMARC field 100 (encoding) : create it if needed & set encoding to unicode
if ( $encoding eq "UNIMARC" ) {
+ my $defaultlanguage = C4::Context->preference("UNIMARCField100Language");
+ $defaultlanguage = "fre" if (!$defaultlanguage || length($defaultlanguage) != 3);
my $string = $record->subfield( 100, "a" );
if ( ($string) && ( length( $record->subfield( 100, "a" ) ) == 36 ) ) {
my $f100 = $record->field(100);
$string = POSIX::strftime( "%Y%m%d", localtime );
$string =~ s/\-//g;
$string = sprintf( "%-*s", 35, $string );
+ substr ( $string, 22, 3, $defaultlanguage);
}
- substr( $string, 22, 6, "frey50" );
+ substr( $string, 25, 3, "y50" );
unless ( $record->subfield( 100, "a" ) ) {
$record->insert_fields_ordered( MARC::Field->new( 100, "", "", "a" => $string ) );
}
$f005->update(sprintf("%4d%02d%02d%02d%02d%04.1f",@a)) if $f005;
}
- my $oldRecord;
- if ( C4::Context->preference("NoZebra") ) {
-
- # only NoZebra indexing needs to have
- # the previous version of the record
- $oldRecord = GetMarcBiblio($biblionumber);
- }
- $sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE biblionumber=?");
- $sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding), $biblionumber );
- $sth->finish;
- ModZebra( $biblionumber, "specialUpdate", "biblioserver", $oldRecord, $record );
- return $biblionumber;
-}
-
-=head2 get_biblio_authorised_values
-
-find the types and values for all authorised values assigned to this biblio.
-
-parameters:
- biblionumber
- MARC::Record of the bib
-
-returns: a hashref mapping the authorised value to the value set for this biblionumber
-
- $authorised_values = {
- 'Scent' => 'flowery',
- 'Audience' => 'Young Adult',
- 'itemtypes' => 'SER',
- };
-
-Notes: forlibrarian should probably be passed in, and called something different.
-
-=cut
-
-sub get_biblio_authorised_values {
- my $biblionumber = shift;
- my $record = shift;
+ my $metadata = {
+ biblionumber => $biblionumber,
+ format => 'marcxml',
+ schema => C4::Context->preference('marcflavour'),
+ };
+ $record->as_usmarc; # Bug 20126/10455 This triggers field length calculation
- my $forlibrarian = 1; # are we in staff or opac?
- my $frameworkcode = GetFrameworkCode($biblionumber);
+ my $m_rs = Koha::Biblio::Metadatas->find($metadata) //
+ Koha::Biblio::Metadata->new($metadata);
- my $authorised_values;
-
- my $tagslib = GetMarcStructure( $forlibrarian, $frameworkcode )
- or return $authorised_values;
-
- # assume that these entries in the authorised_value table are bibliolevel.
- # ones that start with 'item%' are item level.
- my $query = q(SELECT distinct authorised_value, kohafield
- FROM marc_subfield_structure
- WHERE authorised_value !=''
- AND (kohafield like 'biblio%'
- OR kohafield like '') );
- my $bibliolevel_authorised_values = C4::Context->dbh->selectall_hashref( $query, 'authorised_value' );
-
- foreach my $tag ( keys(%$tagslib) ) {
- foreach my $subfield ( keys( %{ $tagslib->{$tag} } ) ) {
-
- # warn "checking $subfield. type is: " . ref $tagslib->{ $tag }{ $subfield };
- if ( 'HASH' eq ref $tagslib->{$tag}{$subfield} ) {
- if ( defined $tagslib->{$tag}{$subfield}{'authorised_value'} && exists $bibliolevel_authorised_values->{ $tagslib->{$tag}{$subfield}{'authorised_value'} } ) {
- if ( defined $record->field($tag) ) {
- my $this_subfield_value = $record->field($tag)->subfield($subfield);
- if ( defined $this_subfield_value ) {
- $authorised_values->{ $tagslib->{$tag}{$subfield}{'authorised_value'} } = $this_subfield_value;
- }
- }
- }
- }
+ my $userenv = C4::Context->userenv;
+ if ($userenv) {
+ my $borrowernumber = $userenv->{number};
+ my $borrowername = join ' ', @$userenv{qw(firstname surname)};
+ unless ($m_rs->in_storage) {
+ Koha::Util::MARC::set_marc_field($record, C4::Context->preference('MarcFieldForCreatorId'), $borrowernumber);
+ Koha::Util::MARC::set_marc_field($record, C4::Context->preference('MarcFieldForCreatorName'), $borrowername);
}
+ Koha::Util::MARC::set_marc_field($record, C4::Context->preference('MarcFieldForModifierId'), $borrowernumber);
+ Koha::Util::MARC::set_marc_field($record, C4::Context->preference('MarcFieldForModifierName'), $borrowername);
}
- # warn ( Data::Dumper->Dump( [ $authorised_values ], [ 'authorised_values' ] ) );
- return $authorised_values;
+ $m_rs->metadata( $record->as_xml_record($encoding) );
+ $m_rs->store;
+
+ ModZebra( $biblionumber, "specialUpdate", "biblioserver" );
+ return $biblionumber;
}
=head2 CountBiblioInOrders
-=over 4
-$count = &CountBiblioInOrders( $biblionumber);
-
-=back
+ $count = &CountBiblioInOrders( $biblionumber);
This function return count of biblios in orders with $biblionumber
return ($count);
}
-=head2 GetSubscriptionsId
-
-=over 4
-$subscriptions = &GetSubscriptionsId($biblionumber);
-
-=back
-
-This function return an array of subscriptionid with $biblionumber
-
-=cut
-
-sub GetSubscriptionsId {
- my ($biblionumber) = @_;
- my $dbh = C4::Context->dbh;
- my $query = "SELECT subscriptionid
- FROM subscription
- WHERE biblionumber=?";
- my $sth = $dbh->prepare($query);
- $sth->execute($biblionumber);
- my @subscriptions = $sth->fetchrow_array;
- return (@subscriptions);
-}
-
-=head2 GetHolds
-
-=over 4
-$holds = &GetHolds($biblionumber);
-
-=back
-
-This function return the count of holds with $biblionumber
-
-=cut
-
-sub GetHolds {
- my ($biblionumber) = @_;
- my $dbh = C4::Context->dbh;
- my $query = "SELECT count(*)
- FROM reserves
- WHERE biblionumber=?";
- my $sth = $dbh->prepare($query);
- $sth->execute($biblionumber);
- my $holds = $sth->fetchrow;
- return ($holds);
-}
-
=head2 prepare_host_field
$marcfield = prepare_host_field( $hostbiblioitem, $marcflavour );
sub prepare_host_field {
my ( $hostbiblio, $marcflavour ) = @_;
$marcflavour ||= C4::Context->preference('marcflavour');
- my $host = GetMarcBiblio($hostbiblio);
+ my $host = GetMarcBiblio({ biblionumber => $hostbiblio });
# unfortunately as_string does not 'do the right thing'
# if field returns undef
my %sfd;
if ( $field = $host->field('205') ) {
my $s = $field->as_string();
if ($s) {
- $sfd{a} = $s;
+ $sfd{e} = $s;
}
}
#URL
my ($biblionumber, $increase, $value) = @_;
my $totalissues;
- my $data = GetBiblioData($biblionumber);
+ my $record = GetMarcBiblio({ biblionumber => $biblionumber });
+ unless ($record) {
+ carp "UpdateTotalIssues could not get biblio record";
+ return;
+ }
+ my $biblio = Koha::Biblios->find( $biblionumber );
+ unless ($biblio) {
+ carp "UpdateTotalIssues could not get datas of biblio";
+ return;
+ }
+ my $biblioitem = $biblio->biblioitem;
+ my ($totalissuestag, $totalissuessubfield) = GetMarcFromKohaField('biblioitems.totalissues', $biblio->frameworkcode);
+ unless ($totalissuestag) {
+ return 1; # There is nothing to do
+ }
if (defined $value) {
$totalissues = $value;
} else {
- $totalissues = $data->{'totalissues'} + $increase;
+ $totalissues = $biblioitem->totalissues + $increase;
}
- my ($totalissuestag, $totalissuessubfield) = GetMarcFromKohaField('biblioitems.totalissues', $data->{'frameworkcode'});
-
- my $record = GetMarcBiblio($biblionumber);
my $field = $record->field($totalissuestag);
if (defined $field) {
$record->insert_grouped_field($field);
}
- ModBiblio($record, $biblionumber, $data->{'frameworkcode'});
- return;
+ return ModBiblio($record, $biblionumber, $biblio->frameworkcode);
}
=head2 RemoveAllNsb
sub RemoveAllNsb {
my $record = shift;
+ if (!$record) {
+ carp 'RemoveAllNsb called with undefined record';
+ return;
+ }
SetUTF8Flag($record);
projects / koha.git / blobdiff