#
# This file is part of Koha.
#
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
#
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
#
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
use warnings;
use C4::Items;
use C4::Charset;
use C4::AuthoritiesMarc;
+use C4::MarcModificationTemplates;
+use Koha::Plugins::Handler;
+use Koha::Logger;
-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
+use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
BEGIN {
- # set the version for version checking
- $VERSION = 3.07.00.049;
require Exporter;
@ISA = qw(Exporter);
@EXPORT = qw(
GetStagedWebserviceBatches
GetImportBatchRangeDesc
GetNumberOfNonZ3950ImportBatches
+ GetImportBiblios
GetImportRecordsRange
GetItemNumbersFromImportBatch
);
}
+our $logger = Koha::Logger->get( { category => 'C4.ImportBatch' } );
+
=head1 NAME
C4::ImportBatch - manage batches of imported MARC records
my ($import_record_id) = @_;
my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare("SELECT marc, encoding FROM import_records WHERE import_record_id = ?");
- $sth->execute($import_record_id);
- my ($marc, $encoding) = $sth->fetchrow();
- $sth->finish();
+ my ( $marc, $encoding ) = $dbh->selectrow_array(q|
+ SELECT marc, encoding
+ FROM import_records
+ WHERE import_record_id = ?
+ |, undef, $import_record_id );
+
return $marc, $encoding;
+}
+
+sub GetRecordFromImportBiblio {
+ my ( $import_record_id, $embed_items ) = @_;
+
+ my ($marc) = GetImportRecordMarc($import_record_id);
+ my $record = MARC::Record->new_from_usmarc($marc);
+ EmbedItemsInImportBiblio( $record, $import_record_id ) if $embed_items;
+
+ return $record;
+}
+
+sub EmbedItemsInImportBiblio {
+ my ( $record, $import_record_id ) = @_;
+ my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField("items.itemnumber", '');
+ my $dbh = C4::Context->dbh;
+ my $import_items = $dbh->selectall_arrayref(q|
+ SELECT import_items.marcxml
+ FROM import_items
+ WHERE import_record_id = ?
+ |, { Slice => {} }, $import_record_id );
+ my @item_fields;
+ for my $import_item ( @$import_items ) {
+ my $item_marc = MARC::Record::new_from_xml($import_item->{marcxml});
+ push @item_fields, $item_marc->field($itemtag);
+ }
+ $record->append_fields(@item_fields);
+ return $record;
}
=head2 GetImportRecordMarcXML
=head2 BatchStageMarcRecords
- ($batch_id, $num_records, $num_items, @invalid_records) =
- BatchStageMarcRecords($record_type, $encoding, $marc_records, $file_name,
- $comments, $branch_code, $parse_items,
- $leave_as_staging,
- $progress_interval, $progress_callback);
+( $batch_id, $num_records, $num_items, @invalid_records ) =
+ BatchStageMarcRecords(
+ $encoding, $marc_records,
+ $file_name, $to_marc_plugin,
+ $marc_modification_template, $comments,
+ $branch_code, $parse_items,
+ $leave_as_staging, $progress_interval,
+ $progress_callback
+ );
=cut
-sub BatchStageMarcRecords {
+sub BatchStageMarcRecords {
my $record_type = shift;
my $encoding = shift;
my $marc_records = shift;
my $file_name = shift;
+ my $to_marc_plugin = shift;
+ my $marc_modification_template = shift;
my $comments = shift;
my $branch_code = shift;
my $parse_items = shift;
SetImportBatchItemAction($batch_id, 'ignore');
}
+ $marc_records = Koha::Plugins::Handler->run(
+ {
+ class => $to_marc_plugin,
+ method => 'to_marc',
+ params => { data => $marc_records }
+ }
+ ) if $to_marc_plugin;
+
my $marc_type = C4::Context->preference('marcflavour');
$marc_type .= 'AUTH' if ($marc_type eq 'UNIMARC' && $record_type eq 'auth');
my @invalid_records = ();
$encoding = $charset_guessed unless $encoding;
+ ModifyRecordWithTemplate( $marc_modification_template, $marc_record ) if ( $marc_modification_template );
+
my $import_record_id;
if (scalar($marc_record->fields()) == 0) {
push @invalid_records, $marc_blob;
=head2 BatchCommitRecords
- my ($num_added, $num_updated, $num_items_added, $num_items_errored, $num_ignored) =
+ my ($num_added, $num_updated, $num_items_added, $num_items_replaced, $num_items_errored, $num_ignored) =
BatchCommitRecords($batch_id, $framework,
$progress_interval, $progress_callback);
my $num_added = 0;
my $num_updated = 0;
my $num_items_added = 0;
+ my $num_items_replaced = 0;
my $num_items_errored = 0;
my $num_ignored = 0;
# commit (i.e., save, all records in the batch)
my $biblioitemnumber;
($recordid, $biblioitemnumber) = AddBiblio($marc_record, $framework);
$query = "UPDATE import_biblios SET matched_biblionumber = ? WHERE import_record_id = ?";
- if ($item_result eq 'create_new') {
- my ($bib_items_added, $bib_items_errored) = BatchCommitItems($rowref->{'import_record_id'}, $recordid);
+ if ($item_result eq 'create_new' || $item_result eq 'replace') {
+ my ($bib_items_added, $bib_items_replaced, $bib_items_errored) = BatchCommitItems($rowref->{'import_record_id'}, $recordid, $item_result);
$num_items_added += $bib_items_added;
+ $num_items_replaced += $bib_items_replaced;
$num_items_errored += $bib_items_errored;
}
} else {
$recordid = $record_match;
my $oldxml;
if ($record_type eq 'biblio') {
- my ($count, $oldbiblio) = GetBiblio($recordid);
+ my $oldbiblio = GetBiblio($recordid);
$oldxml = GetXmlBiblio($recordid);
# remove item fields so that they don't get
# added again if record is reverted
+ # FIXME: GetXmlBiblio output should not contain item info any more! So the next foreach should not be needed. Does not hurt either; may remove old 952s that should not have been there anymore.
my $old_marc = MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $rowref->{'encoding'}, $marc_type);
foreach my $item_field ($old_marc->field($item_tag)) {
$old_marc->delete_field($item_field);
ModBiblio($marc_record, $recordid, $oldbiblio->{'frameworkcode'});
$query = "UPDATE import_biblios SET matched_biblionumber = ? WHERE import_record_id = ?";
- if ($item_result eq 'create_new') {
- my ($bib_items_added, $bib_items_errored) = BatchCommitItems($rowref->{'import_record_id'}, $recordid);
+ if ($item_result eq 'create_new' || $item_result eq 'replace') {
+ my ($bib_items_added, $bib_items_replaced, $bib_items_errored) = BatchCommitItems($rowref->{'import_record_id'}, $recordid, $item_result);
$num_items_added += $bib_items_added;
+ $num_items_replaced += $bib_items_replaced;
$num_items_errored += $bib_items_errored;
}
} else {
SetImportRecordOverlayStatus($rowref->{'import_record_id'}, 'match_applied');
SetImportRecordStatus($rowref->{'import_record_id'}, 'imported');
} elsif ($record_result eq 'ignore') {
+ $recordid = $record_match;
$num_ignored++;
- if ($record_type eq 'biblio' and defined $recordid and $item_result eq 'create_new') {
- my ($bib_items_added, $bib_items_errored) = BatchCommitItems($rowref->{'import_record_id'}, $recordid);
+ $recordid = $record_match;
+ if ($record_type eq 'biblio' and defined $recordid and ( $item_result eq 'create_new' || $item_result eq 'replace' ) ) {
+ my ($bib_items_added, $bib_items_replaced, $bib_items_errored) = BatchCommitItems($rowref->{'import_record_id'}, $recordid, $item_result);
$num_items_added += $bib_items_added;
+ $num_items_replaced += $bib_items_replaced;
$num_items_errored += $bib_items_errored;
# still need to record the matched biblionumber so that the
# items can be reverted
}
$sth->finish();
SetImportBatchStatus($batch_id, 'imported');
- return ($num_added, $num_updated, $num_items_added, $num_items_errored, $num_ignored);
+ return ($num_added, $num_updated, $num_items_added, $num_items_replaced, $num_items_errored, $num_ignored);
}
=head2 BatchCommitItems
=cut
sub BatchCommitItems {
- my ($import_record_id, $biblionumber) = @_;
+ my ( $import_record_id, $biblionumber, $action ) = @_;
my $dbh = C4::Context->dbh;
my $num_items_added = 0;
my $num_items_errored = 0;
- my $sth = $dbh->prepare("SELECT import_items_id, import_items.marcxml, encoding
- FROM import_items
- JOIN import_records USING (import_record_id)
- WHERE import_record_id = ?
- ORDER BY import_items_id");
- $sth->bind_param(1, $import_record_id);
+ my $num_items_replaced = 0;
+
+ my $sth = $dbh->prepare( "
+ SELECT import_items_id, import_items.marcxml, encoding
+ FROM import_items
+ JOIN import_records USING (import_record_id)
+ WHERE import_record_id = ?
+ ORDER BY import_items_id
+ " );
+ $sth->bind_param( 1, $import_record_id );
$sth->execute();
- while (my $row = $sth->fetchrow_hashref()) {
- my $item_marc = MARC::Record->new_from_xml(StripNonXmlChars($row->{'marcxml'}), 'UTF-8', $row->{'encoding'});
- # FIXME - duplicate barcode check needs to become part of AddItemFromMarc()
- my $item = TransformMarcToKoha($dbh, $item_marc);
- my $duplicate_barcode = exists($item->{'barcode'}) && GetItemnumberFromBarcode($item->{'barcode'});
- if ($duplicate_barcode) {
- my $updsth = $dbh->prepare("UPDATE import_items SET status = ?, import_error = ? WHERE import_items_id = ?");
- $updsth->bind_param(1, 'error');
- $updsth->bind_param(2, 'duplicate item barcode');
- $updsth->bind_param(3, $row->{'import_items_id'});
+
+ while ( my $row = $sth->fetchrow_hashref() ) {
+ my $item_marc = MARC::Record->new_from_xml( StripNonXmlChars( $row->{'marcxml'} ), 'UTF-8', $row->{'encoding'} );
+
+ # Delete date_due subfield as to not accidentally delete item checkout due dates
+ my ( $MARCfield, $MARCsubfield ) = GetMarcFromKohaField( 'items.onloan', GetFrameworkCode($biblionumber) );
+ $item_marc->field($MARCfield)->delete_subfield( code => $MARCsubfield );
+
+ my $item = TransformMarcToKoha( $item_marc );
+
+ my $duplicate_barcode = exists( $item->{'barcode'} ) && GetItemnumberFromBarcode( $item->{'barcode'} );
+ my $duplicate_itemnumber = exists( $item->{'itemnumber'} );
+
+ my $updsth = $dbh->prepare("UPDATE import_items SET status = ?, itemnumber = ? WHERE import_items_id = ?");
+ if ( $action eq "replace" && $duplicate_itemnumber ) {
+ # Duplicate itemnumbers have precedence, that way we can update barcodes by overlaying
+ ModItemFromMarc( $item_marc, $biblionumber, $item->{itemnumber} );
+ $updsth->bind_param( 1, 'imported' );
+ $updsth->bind_param( 2, $item->{itemnumber} );
+ $updsth->bind_param( 3, $row->{'import_items_id'} );
+ $updsth->execute();
+ $updsth->finish();
+ $num_items_replaced++;
+ } elsif ( $action eq "replace" && $duplicate_barcode ) {
+ my $itemnumber = GetItemnumberFromBarcode( $item->{'barcode'} );
+ ModItemFromMarc( $item_marc, $biblionumber, $itemnumber );
+ $updsth->bind_param( 1, 'imported' );
+ $updsth->bind_param( 2, $item->{itemnumber} );
+ $updsth->bind_param( 3, $row->{'import_items_id'} );
+ $updsth->execute();
+ $updsth->finish();
+ $num_items_replaced++;
+ } elsif ($duplicate_barcode) {
+ $updsth->bind_param( 1, 'error' );
+ $updsth->bind_param( 2, 'duplicate item barcode' );
+ $updsth->bind_param( 3, $row->{'import_items_id'} );
$updsth->execute();
$num_items_errored++;
} else {
- my ($item_biblionumber, $biblioitemnumber, $itemnumber) = AddItemFromMarc($item_marc, $biblionumber);
- my $updsth = $dbh->prepare("UPDATE import_items SET status = ?, itemnumber = ? WHERE import_items_id = ?");
- $updsth->bind_param(1, 'imported');
- $updsth->bind_param(2, $itemnumber);
- $updsth->bind_param(3, $row->{'import_items_id'});
+ my ( $item_biblionumber, $biblioitemnumber, $itemnumber ) = AddItemFromMarc( $item_marc, $biblionumber );
+ $updsth->bind_param( 1, 'imported' );
+ $updsth->bind_param( 2, $itemnumber );
+ $updsth->bind_param( 3, $row->{'import_items_id'} );
$updsth->execute();
$updsth->finish();
$num_items_added++;
}
}
- $sth->finish();
- return ($num_items_added, $num_items_errored);
+
+ return ( $num_items_added, $num_items_replaced, $num_items_errored );
}
=head2 BatchRevertRecords
sub BatchRevertRecords {
my $batch_id = shift;
+ $logger->trace("C4::ImportBatch::BatchRevertRecords( $batch_id )");
+
my $record_type;
my $num_deleted = 0;
my $num_errors = 0;
my $old_record = MARC::Record->new_from_xml(StripNonXmlChars($rowref->{'marcxml_old'}), 'UTF-8', $rowref->{'encoding'}, $marc_type);
if ($record_type eq 'biblio') {
my $biblionumber = $rowref->{'matched_biblionumber'};
- my ($count, $oldbiblio) = GetBiblio($biblionumber);
+ my $oldbiblio = GetBiblio($biblionumber);
+
+ $logger->info("C4::ImportBatch::BatchRevertRecords: Biblio record $biblionumber does not exist, restoration of this record was skipped") unless $oldbiblio;
+ next unless $oldbiblio; # Record has since been deleted. Deleted records should stay deleted.
+
$num_items_deleted += BatchRevertItems($rowref->{'import_record_id'}, $rowref->{'matched_biblionumber'});
ModBiblio($old_record, $biblionumber, $oldbiblio->{'frameworkcode'});
} else {
return $count;
}
+=head2 GetImportBiblios
+
+ my $results = GetImportBiblios($importid);
+
+=cut
+
+sub GetImportBiblios {
+ my ($import_record_id) = @_;
+
+ my $dbh = C4::Context->dbh;
+ my $query = "SELECT * FROM import_biblios WHERE import_record_id = ?";
+ return $dbh->selectall_arrayref(
+ $query,
+ { Slice => {} },
+ $import_record_id
+ );
+
+}
+
=head2 GetImportRecordsRange
my $results = GetImportRecordsRange($batch_id, $offset, $results_per_group);
=cut
sub GetImportRecordsRange {
- my ($batch_id, $offset, $results_per_group, $status) = @_;
+ my ( $batch_id, $offset, $results_per_group, $status, $parameters ) = @_;
my $dbh = C4::Context->dbh;
+
+ my $order_by = $parameters->{order_by} || 'import_record_id';
+ ( $order_by ) = grep( /^$order_by$/, qw( import_record_id title status overlay_status ) ) ? $order_by : 'import_record_id';
+
+ my $order_by_direction =
+ uc( $parameters->{order_by_direction} ) eq 'DESC' ? 'DESC' : 'ASC';
+
+ $order_by .= " $order_by_direction, authorized_heading" if $order_by eq 'title';
+
my $query = "SELECT title, author, isbn, issn, authorized_heading, import_records.import_record_id,
record_sequence, status, overlay_status,
matched_biblionumber, matched_authid, record_type
$query .= " AND status=?";
push(@params,$status);
}
- $query.=" ORDER BY import_record_id";
+
+ $query.=" ORDER BY $order_by $order_by_direction";
if($results_per_group){
$query .= " LIMIT ?";
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare("SELECT candidate_match_id
FROM import_record_matches
- WHERE import_record_id = ?
+ JOIN import_records ON ( import_record_matches.import_record_id = import_records.import_record_id )
+ LEFT JOIN biblio ON ( candidate_match_id = biblio.biblionumber )
+ LEFT JOIN auth_header ON ( candidate_match_id = auth_header.authid )
+ WHERE import_record_matches.import_record_id = ? AND
+ ( (import_records.record_type = 'biblio' AND biblio.biblionumber IS NOT NULL) OR
+ (import_records.record_type = 'auth' AND auth_header.authid IS NOT NULL) )
ORDER BY score DESC, candidate_match_id DESC");
$sth->execute($import_record_id);
my ($record_id) = $sth->fetchrow_array();
=head2 GetImportRecordStatus
- my $overlay_status = GetImportRecordStatus($import_record_id);
+ my $status = GetImportRecordStatus($import_record_id);
=cut
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare("SELECT status FROM import_records WHERE import_record_id = ?");
$sth->execute($import_record_id);
- my ($overlay_status) = $sth->fetchrow_array();
+ my ($status) = $sth->fetchrow_array();
$sth->finish();
- return $overlay_status;
+ return $status;
}
=head2 SetImportRecordStatus
- SetImportRecordStatus($import_record_id, $new_overlay_status);
+ SetImportRecordStatus($import_record_id, $new_status);
=cut
sub SetImportRecordStatus {
- my ($import_record_id, $new_overlay_status) = @_;
+ my ($import_record_id, $new_status) = @_;
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare("UPDATE import_records SET status = ? WHERE import_record_id = ?");
- $sth->execute($new_overlay_status, $import_record_id);
+ $sth->execute($new_status, $import_record_id);
$sth->finish();
}
my ($title, $author, $isbn, $issn) = _parse_biblio_fields($marc_record);
my $dbh = C4::Context->dbh;
# FIXME no controlnumber, originalsource
- $isbn = C4::Koha::_isbn_cleanup($isbn); # FIXME C4::Koha::_isbn_cleanup should be made public
+ $isbn = C4::Koha::GetNormalizedISBN($isbn);
my $sth = $dbh->prepare("INSERT INTO import_biblios (import_record_id, title, author, isbn, issn) VALUES (?, ?, ?, ?, ?)");
$sth->execute($import_record_id, $title, $author, $isbn, $issn);
$sth->finish();
my ($marc_record) = @_;
my $dbh = C4::Context->dbh;
- my $bibliofields = TransformMarcToKoha($dbh, $marc_record, '');
+ my $bibliofields = TransformMarcToKoha($marc_record, '');
return ($bibliofields->{'title'}, $bibliofields->{'author'}, $bibliofields->{'isbn'}, $bibliofields->{'issn'});
}
} elsif ($overlay_action eq 'ignore') {
$bib_result = 'ignore';
}
- $item_result = ($item_action eq 'always_add' or $item_action eq 'add_only_for_matches') ? 'create_new' : 'ignore';
+ if($item_action eq 'always_add' or $item_action eq 'add_only_for_matches'){
+ $item_result = 'create_new';
+ }
+ elsif($item_action eq 'replace'){
+ $item_result = 'replace';
+ }
+ else {
+ $item_result = 'ignore';
+ }
} else {
$bib_result = $nomatch_action;
$item_result = ($item_action eq 'always_add' or $item_action eq 'add_only_for_new') ? 'create_new' : 'ignore';
projects / koha.git / blobdiff