# Suite 330, Boston, MA 02111-1307 USA
use strict;
+use warnings;
+
require Exporter;
use C4::Context;
use CGI;
@ISA = qw(Exporter);
@EXPORT = qw(
- &checkdigit &checkvalidisbn
+ &checkdigit
&buildCGIsort
);
-# FIXME - This is never used.
-#sub checkflds {
-# my ($env,$reqflds,$data) = @_;
-# my $numrflds = @$reqflds;
-# my @probarr;
-# my $i = 0;
-# while ($i < $numrflds) {
-# if ($data->{@$reqflds[$i]} eq "") {
-# push(@probarr, @$reqflds[$i]);
-# }
-# $i++
-# }
-# return (\@probarr);
-#}
-
=item checkdigit
- $valid = &checkdigit($env, $cardnumber $nounique);
+ $valid = &checkdigit($cardnumber $nounique);
Takes a card number, computes its check digit, and compares it to the
checkdigit at the end of C<$cardnumber>. Returns a true value iff
C<$cardnumber> has a valid check digit.
-C<$env> is ignored.
-
=cut
+
#'
-sub checkdigit {
+sub checkdigit ($;$) {
- my ($env,$infl, $nounique) = @_;
+ my ($infl, $nounique) = @_;
$infl = uc $infl;
-
- #Check to make sure the cardnumber is unique
+ # Check to make sure the cardnumber is unique
#FIXME: We should make the error for a nonunique cardnumber
#different from the one where the checkdigit on the number is
unless ( $nounique )
{
- my $dbh=C4::Context->dbh;
my $query=qq{SELECT * FROM borrowers WHERE cardnumber=?};
- my $sth=$dbh->prepare($query);
+ my $sth=C4::Context->prepare($query);
$sth->execute($infl);
my %results = $sth->fetchrow_hashref();
if ( $sth->rows != 0 )
my @weightings = (8,4,6,3,5,2,1);
my $sum;
- my $i = 1;
- my $valid = 0;
-
- foreach $i (1..7) {
+ foreach my $i (1..7) {
my $temp1 = $weightings[$i-1];
my $temp2 = substr($infl,$i,1);
$sum += $temp1 * $temp2;
}
my $rem = ($sum%11);
if ($rem == 10) {
- $rem = "X";
+ $rem = "X";
}
if ($rem eq substr($infl,8,1)) {
- $valid = 1;
+ return 1;
}
- return $valid;
+ return 0;
} # sub checkdigit
-=item checkvalidisbn
-
- $valid = &checkvalidisbn($isbn);
-
-Returns a true value iff C<$isbn> is a valid ISBN: it must be ten
-digits long (counting "X" as a digit), and must have a valid check
-digit at the end.
-
-=cut
-#'
-#--------------------------------------
-# Determine if a number is a valid ISBN number, according to length
-# of 10 digits and valid checksum
-sub checkvalidisbn {
- use strict;
- my ($q)=@_ ; # Input: ISBN number
-
- my $isbngood = 0; # Return: true or false
-
- $q=~s/x$/X/g; # upshift lower case X
- $q=~s/[^X\d]//g;
- $q=~s/X.//g;
-
- #return 0 if $q is not ten digits long
- if (length($q)!=10) {
- return 0;
- }
-
- #If we get to here, length($q) must be 10
- my $checksum=substr($q,9,1);
- my $isbn=substr($q,0,9);
- my $i;
- my $c=0;
- for ($i=0; $i<9; $i++) {
- my $digit=substr($q,$i,1);
- $c+=$digit*(10-$i);
- }
- $c %= 11;
- ($c==10) && ($c='X');
- $isbngood = $c eq $checksum;
- return $isbngood;
-
-} # sub checkvalidisbn
-
=item buildCGISort
- $CGIScrollingList = &BuildCGISort($name string, $input_name string);
+ $CGIScrollingList = &buildCGISort($name string, $input_name string);
Returns the scrolling list with name $input_name, built on authorised Values named $name.
Returns NULL if no authorised values found
=cut
+
sub buildCGIsort {
- use strict;
my ($name,$input_name,$data) = @_;
my $dbh=C4::Context->dbh;
my $query=qq{SELECT * FROM authorised_values WHERE category=? order by lib};