use C4::Circulation;
use C4::Accounts;
+# for _koha_notify_reserve
+use C4::Members::Messaging;
+use C4::Members qw( GetMember );
+use C4::Letters;
+use C4::Branch qw( GetBranchDetail );
+use List::MoreUtils qw( firstidx );
+
use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
my $library_name = C4::Context->preference("LibraryName");
my $usth = $dbh->prepare($query);
$usth->execute( $borrowernumber, $nextacctno, $fee,
"Reserve Charge - $title", $fee );
- $usth->finish;
}
#if ($const eq 'a'){
$const, $priority, $notes, $checkitem,
$found, $waitingdate
);
- $sth->finish;
#}
- if ( ( $const eq "o" ) || ( $const eq "e" ) ) {
- my $numitems = @$bibitems;
- my $i = 0;
- while ( $i < $numitems ) {
- my $biblioitem = @$bibitems[$i];
- my $query = qq/
- INSERT INTO reserveconstraints
- (borrowernumber,biblionumber,reservedate,biblioitemnumber)
- VALUES
+ ($const eq "o" || $const eq "e") or return; # FIXME: why not have a useful return value?
+ $query = qq/
+ INSERT INTO reserveconstraints
+ (borrowernumber,biblionumber,reservedate,biblioitemnumber)
+ VALUES
(?,?,?,?)
- /;
- my $sth = $dbh->prepare("");
- $sth->execute( $borrowernumber, $biblionumber, $resdate,
- $biblioitem );
- $sth->finish;
- $i++;
- }
+ /;
+ $sth = $dbh->prepare($query); # keep prepare outside the loop!
+ foreach (@$bibitems) {
+ $sth->execute($borrowernumber, $biblionumber, $resdate, $_);
}
- return;
+ return; # FIXME: why not have a useful return value?
}
=item GetReservesFromBiblionumber
my $i = 0;
while ( my $data = $sth->fetchrow_hashref ) {
- # FIXME - What is this if-statement doing? How do constraints work?
- if ( $data->{constrainttype} eq 'o' ) {
+ # FIXME - What is this doing? How do constraints work?
+ if ($data->{constrainttype} eq 'o') {
$query = '
SELECT biblioitemnumber
- FROM reserveconstraints
- WHERE biblionumber = ?
- AND borrowernumber = ?
- AND reservedate = ?
+ FROM reserveconstraints
+ WHERE biblionumber = ?
+ AND borrowernumber = ?
+ AND reservedate = ?
';
my $csth = $dbh->prepare($query);
$csth->execute( $data->{biblionumber}, $data->{borrowernumber},
$data->{reservedate}, );
-
+
my @bibitemno;
while ( my $bibitemnos = $csth->fetchrow_array ) {
- push( @bibitemno, $bibitemnos );
+ push( @bibitemno, $bibitemnos ); # FIXME: inefficient: use fetchall_arrayref
}
- my $count = @bibitemno;
-
+ my $count = scalar @bibitemno;
+
# if we have two or more different specific itemtypes
# reserved by same person on same day
my $bdata;
$i++;
}
else {
-
# Look up the book we just found.
$bdata = GetBiblioItemData( $bibitemno[0] );
}
- $csth->finish;
-
# Add the results of this latest search to the current
# results.
# FIXME - An 'each' would probably be more efficient.
}
push @results, $data;
}
- $sth->finish;
return ( $#results + 1, \@results );
}
my $sth = $dbh->prepare($query);
$sth->execute($borrowernumber);
my $row = $sth->fetchrow_hashref;
- $sth->finish;
-
return $row->{counter};
}
);
#launch the subroutine dotransfer
- C4::Circulation::ModItemTransfer(
+ C4::Items::ModItemTransfer(
$itemnumber,
$iteminfo->{'holdingbranch'},
$checkreserves->{'branchcode'}
$transreserv[$i] = $data;
$i++;
}
- $sth->finish;
return (@transreserv);
}
$transreserv[$i] = $data;
$i++;
}
- $sth->finish;
return (@transreserv);
}
";
my $sth_set = $dbh->prepare($query);
$sth_set->execute( $newstatus, $itemnumber );
- $sth_set->finish;
}
=item ModReserveAffect
my $sth = $dbh->prepare("SELECT biblionumber FROM items WHERE itemnumber=?");
$sth->execute($itemnumber);
my ($biblionumber) = $sth->fetchrow;
+
+ # get request - need to find out if item is already
+ # waiting in order to not send duplicate hold filled notifications
+ my $request = GetReserveInfo($borrowernumber, $biblionumber);
+ my $already_on_shelf = ($request && $request->{found} eq 'W') ? 1 : 0;
+
# If we affect a reserve that has to be transfered, don't set to Waiting
my $query;
if ($transferToDo) {
}
$sth = $dbh->prepare($query);
$sth->execute( $itemnumber, $borrowernumber,$biblionumber);
- $sth->finish;
+ _koha_notify_reserve( $itemnumber, $borrowernumber, $biblionumber ) if ( !$transferToDo && !$already_on_shelf );
+
return;
}
";
my $sth_upd = $dbh->prepare($query);
$sth_upd->execute( $itemnumber, $borrowernumber, $biblionumber );
- $sth_upd->finish;
# second step update all others reservs
_FixPriority($biblionumber, $borrowernumber, '0');
}
$item->{wthdrawn} or
$notforloan_per_itemtype;
+
if (C4::Context->preference('AllowOnShelfHolds')) {
return $available_per_item;
} else {
while ( my $data = $sth->fetchrow_hashref ) {
push( @results, $data );
}
- $sth->finish;
return @results;
}
+=item _koha_notify_reserve
+
+=over 4
+
+_koha_notify_reserve( $itemnumber, $borrowernumber, $biblionumber );
+
+=back
+
+Sends a notification to the patron that their hold has been filled (through
+ModReserveAffect, _not_ ModReserveFill)
+
+=cut
+
+sub _koha_notify_reserve {
+ my ($itemnumber, $borrowernumber, $biblionumber) = @_;
+
+ my $dbh = C4::Context->dbh;
+ my $messagingprefs = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrowernumber, message_name => 'Hold Filled' } );
+
+ return if ( !defined( $messagingprefs->{'letter_code'} ) );
+
+ my $sth = $dbh->prepare("
+ SELECT *
+ FROM reserves
+ WHERE borrowernumber = ?
+ AND biblionumber = ?
+ ");
+ $sth->execute( $borrowernumber, $biblionumber );
+ my $reserve = $sth->fetchrow_hashref;
+ my $branch_details = GetBranchDetail( $reserve->{'branchcode'} );
+
+ my $admin_email_address = $branch_details->{'branchemail'} || C4::Context->preference('KohaAdminEmailAddress');
+
+ my $letter = getletter( 'reserves', $messagingprefs->{'letter_code'} );
+
+ C4::Letters::parseletter( $letter, 'branches', $reserve->{'branchcode'} );
+ C4::Letters::parseletter( $letter, 'borrowers', $reserve->{'borrowernumber'} );
+ C4::Letters::parseletter( $letter, 'biblio', $reserve->{'biblionumber'} );
+ C4::Letters::parseletter( $letter, 'reserves', $reserve->{'borrowernumber'}, $reserve->{'biblionumber'} );
+
+ if ( $reserve->{'itemnumber'} ) {
+ C4::Letters::parseletter( $letter, 'items', $reserve->{'itemnumber'} );
+ }
+ $letter->{'content'} =~ s/<<[a-z0-9_]+\.[a-z0-9]+>>//g; #remove any stragglers
+
+ if ( -1 != firstidx { $_ eq 'email' } @{$messagingprefs->{transports}} ) {
+ # aka, 'email' in ->{'transports'}
+ C4::Letters::EnqueueLetter(
+ { letter => $letter,
+ borrowernumber => $borrowernumber,
+ message_transport_type => 'email',
+ from_address => $admin_email_address,
+ }
+ );
+ }
+
+ if ( -1 != firstidx { $_ eq 'sms' } @{$messagingprefs->{transports}} ) {
+ C4::Letters::EnqueueLetter(
+ { letter => $letter,
+ borrowernumber => $borrowernumber,
+ message_transport_type => 'sms',
+ }
+ );
+ }
+}
+
=back
=head1 AUTHOR
projects / koha.git / blobdiff