Bug 16889: Remove C4::Items::columns and use Koha::Items->columns instead

[koha.git] / C4 / Review.pm

diff --git a/C4/Review.pm b/C4/Review.pm
index c8819d5..5d56396 100644 (file)
--- a/C4/Review.pm
+++ b/C4/Review.pm
@@ -22,15 +22,13 @@ use warnings;
 
 use C4::Context;
 
-use vars qw($VERSION @ISA @EXPORT);
+use vars qw(@ISA @EXPORT);
 
 BEGIN {
-  # set the version for version checking
-    $VERSION = 3.07.00.049;
-  require Exporter;
-  @ISA    = qw(Exporter);
-  @EXPORT = qw(getreview savereview updatereview numberofreviews numberofreviewsbybiblionumber
-    getreviews getallreviews approvereview unapprovereview deletereview);
+    require Exporter;
+    @ISA    = qw(Exporter);
+    @EXPORT = qw(getreview savereview updatereview numberofreviews numberofreviewsbybiblionumber
+      getreviews getallreviews approvereview unapprovereview deletereview);
 }
 
 =head1 NAME
@@ -66,9 +64,8 @@ Takes a borrowernumber and a biblionumber and returns the review of that biblio
 sub getreview {
     my ( $biblionumber, $borrowernumber ) = @_;
     my $dbh   = C4::Context->dbh;
-    my $query =
-      "SELECT * FROM reviews WHERE biblionumber=? and borrowernumber=?";
-    my $sth = $dbh->prepare($query);
+    my $query = "SELECT * FROM reviews WHERE biblionumber=? and borrowernumber=?";
+    my $sth   = $dbh->prepare($query);
     $sth->execute( $biblionumber, $borrowernumber );
     return $sth->fetchrow_hashref();
 }
@@ -88,7 +85,7 @@ sub savereview {
   review,approved,datereviewed) VALUES
   (?,?,?,0,now())";
     my $sth = $dbh->prepare($query);
-    $sth->execute( $borrowernumber, $biblionumber, $review);
+    $sth->execute( $borrowernumber, $biblionumber, $review );
 }
 
 =head2 updatereview
@@ -103,7 +100,7 @@ sub updatereview {
     my ( $biblionumber, $borrowernumber, $review ) = @_;
     my $dbh   = C4::Context->dbh;
     my $query = "UPDATE reviews SET review=?,datereviewed=now(),approved=0  WHERE borrowernumber=? and biblionumber=?";
-    my $sth = $dbh->prepare($query);
+    my $sth   = $dbh->prepare($query);
     $sth->execute( $review, $borrowernumber, $biblionumber );
 }
 
@@ -118,13 +115,12 @@ Return the number of reviews where in the 'reviews' database : 'approved' = $sta
 
 sub numberofreviews {
     my ($param) = @_;
-    my $status = (defined($param) ? $param : 1);
-    my $dbh            = C4::Context->dbh;
-    my $query          =
-      "SELECT count(*) FROM reviews WHERE approved=?";
-    my $sth = $dbh->prepare($query);
-    $sth->execute( $status );
-  return $sth->fetchrow;
+    my $status = ( defined($param) ? $param : 1 );
+    my $dbh    = C4::Context->dbh;
+    my $query  = "SELECT count(*) FROM reviews WHERE approved=?";
+    my $sth    = $dbh->prepare($query);
+    $sth->execute($status);
+    return $sth->fetchrow;
 }
 
 =head2 numberofreviewsbybiblionumber
@@ -138,11 +134,10 @@ Return the number of reviews approved for a given biblionumber
 sub numberofreviewsbybiblionumber {
     my ($biblionumber) = @_;
     my $dbh            = C4::Context->dbh;
-    my $query          =
-      "SELECT count(*) FROM reviews WHERE biblionumber=? and approved=?";
-    my $sth = $dbh->prepare($query);
+    my $query          = "SELECT count(*) FROM reviews WHERE biblionumber=? and approved=?";
+    my $sth            = $dbh->prepare($query);
     $sth->execute( $biblionumber, 1 );
-  return $sth->fetchrow;
+    return $sth->fetchrow;
 }
 
 =head2 getreviews
@@ -157,11 +152,10 @@ Return all reviews where in the 'reviews' database :
 sub getreviews {
     my ( $biblionumber, $approved ) = @_;
     my $dbh   = C4::Context->dbh;
-    my $query =
-      "SELECT * FROM reviews WHERE biblionumber=? and approved=? order by datereviewed desc";
-    my $sth = $dbh->prepare($query);
+    my $query = "SELECT * FROM reviews WHERE biblionumber=? and approved=? order by datereviewed desc";
+    my $sth   = $dbh->prepare($query);
     $sth->execute( $biblionumber, $approved );
-  return $sth->fetchall_arrayref({});
+    return $sth->fetchall_arrayref( {} );
 }
 
 =head2 getallreviews
@@ -177,14 +171,13 @@ $offset position and the ($offset + $row_count) position.
 =cut
 
 sub getallreviews {
-    my ($status, $offset, $row_count) = @_;
-    my @params = ($status,($offset ? $offset : 0),($row_count ? $row_count : 20));
-    my $dbh      = C4::Context->dbh;
-    my $query    =
-      "SELECT * FROM reviews WHERE approved=? order by datereviewed desc LIMIT ?, ?";
-    my $sth = $dbh->prepare($query);
+    my ( $status, $offset, $row_count ) = @_;
+    my @params = ( $status, ( $offset ? $offset : 0 ), ( $row_count ? $row_count : 20 ) );
+    my $dbh    = C4::Context->dbh;
+    my $query  = "SELECT * FROM reviews WHERE approved=? order by datereviewed desc LIMIT ?, ?";
+    my $sth    = $dbh->prepare($query);
     $sth->execute(@params);
-  return $sth->fetchall_arrayref({});
+    return $sth->fetchall_arrayref( {} );
 }
 
 =head2 approvereview