Bug 8429: Remove unnecessary use of Exporter from SIP/ILS

[koha.git] / C4 / SIP / ILS / Transaction / Renew.pm

diff --git a/C4/SIP/ILS/Transaction/Renew.pm b/C4/SIP/ILS/Transaction/Renew.pm
index 57db003..aa300d4 100644 (file)
--- a/C4/SIP/ILS/Transaction/Renew.pm
+++ b/C4/SIP/ILS/Transaction/Renew.pm
@@ -8,49 +8,53 @@ use warnings;
 use strict;
 
 use ILS;
-use ILS::Transaction;
 
 use C4::Circulation;
 use C4::Members;
 
-our @ISA = qw(ILS::Transaction);
+use parent qw(ILS::Transaction);
 
 my %fields = (
-       renewal_ok => 0,
+    renewal_ok => 0,
 );
 
 sub new {
-       my $class = shift;
-       my $self = $class->SUPER::new();
+    my $class = shift;
+    my $self = $class->SUPER::new();
 
     foreach my $element (keys %fields) {
-               $self->{_permitted}->{$element} = $fields{$element};
-       }
+        $self->{_permitted}->{$element} = $fields{$element};
+    }
 
-       @{$self}{keys %fields} = values %fields;        # overkill?
-       return bless $self, $class;
+    @{$self}{keys %fields} = values %fields;   # overkill?
+    return bless $self, $class;
 }
 
 sub do_renew_for  {
-       my $self = shift;
-       my $borrower = shift;
-       my ($renewokay,$renewerror) = CanBookBeRenewed($borrower->{borrowernumber},$self->{item}->{itemnumber});
-       if ($renewokay){
-               $self->{due} = AddIssue( $borrower, $self->{item}->id, undef, 0 );
-               $self->renewal_ok(1);
-       } else {
-               $self->screen_msg(($self->screen_msg || '') . " " . $renewerror);
-               $self->renewal_ok(0);
-       }
-    $! and warn "do_renew_for error: $!";
-       $self->ok(1) unless $!;
-       return $self;
+    my $self = shift;
+    my $borrower = shift;
+    my ($renewokay,$renewerror) = CanBookBeRenewed($borrower->{borrowernumber},$self->{item}->{itemnumber});
+    if ($renewokay){
+        $self->{due} = undef;
+        my $due_date = AddIssue( $borrower, $self->{item}->id, undef, 0 );
+        if ($due_date) {
+            $self->{due} = $due_date;
+        }
+        $self->renewal_ok(1);
+    } else {
+        $renewerror=~s/on_reserve/Item unavailable due to outstanding holds/;
+        $renewerror=~s/too_many/Item has reached maximum renewals/;
+        $self->screen_msg($renewerror);
+        $self->renewal_ok(0);
+    }
+    $self->ok(1);
+    return;
 }
 
 sub do_renew {
-       my $self = shift;
-       my $borrower = GetMember( 'cardnumber'=>$self->{patron}->id);
-       return $self->do_renew_for($borrower);
-}      
+    my $self = shift;
+    my $borrower = GetMember( cardnumber => $self->{patron}->id );
+    return $self->do_renew_for($borrower);
+}
 
 1;