Bug 8216: Allow SIP modules to pass critic tests

[koha.git] / C4 / SIP / ILS / Transaction / RenewAll.pm

diff --git a/C4/SIP/ILS/Transaction/RenewAll.pm b/C4/SIP/ILS/Transaction/RenewAll.pm
index 2e49bf7..adc467a 100644 (file)
--- a/C4/SIP/ILS/Transaction/RenewAll.pm
+++ b/C4/SIP/ILS/Transaction/RenewAll.pm
@@ -23,9 +23,8 @@ my %fields = (
 sub new {
        my $class = shift;
        my $self = $class->SUPER::new();
-       my $element;
 
-       foreach $element (keys %fields) {
+    foreach my $element (keys %fields) {
                $self->{_permitted}->{$element} = $fields{$element};
        }
 
@@ -53,8 +52,8 @@ sub do_renew_all {
                $self->{item} = $item;
                $self->do_renew_for($borrower);
                if ($self->ok) {
-                       $item->{due_date} = $self->{due};
-            push @{$self->{renewed}  }, $item_id;
+                   $item->{due_date} = $self->{due}->clone();
+                   push @{$self->renewed  }, $item_id;
                } else {
             push @{$self->{unrenewed}}, $item_id;
                }