Bug 8216: Allow SIP modules to pass critic tests

[koha.git] / C4 / SIP / ILS / Transaction / RenewAll.pm

diff --git a/C4/SIP/ILS/Transaction/RenewAll.pm b/C4/SIP/ILS/Transaction/RenewAll.pm
index a712806..adc467a 100644 (file)
--- a/C4/SIP/ILS/Transaction/RenewAll.pm
+++ b/C4/SIP/ILS/Transaction/RenewAll.pm
@@ -23,9 +23,8 @@ my %fields = (
 sub new {
        my $class = shift;
        my $self = $class->SUPER::new();
-       my $element;
 
-       foreach $element (keys %fields) {
+    foreach my $element (keys %fields) {
                $self->{_permitted}->{$element} = $fields{$element};
        }
 
@@ -38,6 +37,8 @@ sub do_renew_all {
        my $patron = $self->{patron};                                                   # SIP's  patron
        my $borrower = GetMember('cardnumber'=>$patron->id);    # Koha's patron
        my $all_ok = 1;
+    $self->{renewed} = [];
+    $self->{unrenewed} = [];
        foreach my $itemx (@{$patron->{items}}) {
                my $item_id = $itemx->{barcode};
                my $item = new ILS::Item $item_id;
@@ -51,10 +52,10 @@ sub do_renew_all {
                $self->{item} = $item;
                $self->do_renew_for($borrower);
                if ($self->ok) {
-                       $item->{due_date} = $self->{due};
-                       push @{$self->renewed  }, $item_id;
+                   $item->{due_date} = $self->{due}->clone();
+                   push @{$self->renewed  }, $item_id;
                } else {
-                       push @{$self->unrenewed}, $item_id;
+            push @{$self->{unrenewed}}, $item_id;
                }
        }
        $self->ok($all_ok);