#
# This file is part of Koha.
#
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
#
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
#
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
+#use warnings; FIXME - Bug 2505
use C4::Output;
use C4::Auth;
-use CGI;
+use CGI qw ( -utf8 );
use C4::Context;
use C4::Biblio;
my $input = new CGI;
my ($template, $borrowernumber, $cookie)
- = get_template_and_user({template_name => "admin/checkmarc.tmpl",
+ = get_template_and_user({template_name => "admin/checkmarc.tt",
query => $input,
type => "intranet",
authnotrequired => 0,
- flagsrequired => {parameters => 1},
+ flagsrequired => {parameters => 'parameters_remaining_permissions'},
debug => 1,
});
# checks itemnum field
my $sth = $dbh->prepare("select tab from marc_subfield_structure where kohafield=\"items.itemnumber\"");
$sth->execute;
-my ($res) = $sth->fetchrow;
-if ($res==-1) {
- $template->param(itemnum => 0);
-} else {
- $template->param(itemnum => 1);
- $total++;
+while (my ($res) = $sth->fetchrow) {
+ if ($res==-1) {
+ $template->param(itemnum => 0);
+ } else {
+ $template->param(itemnum => 1);
+ $total++;
+ last;
+ }
}
# checks biblio.biblionumber and biblioitem.biblioitemnumber (same tag and tab=-1)
-$sth = $dbh->prepare("select tagfield,tab from marc_subfield_structure where kohafield=\"biblio.biblionumber\"");
+$sth = $dbh->prepare("select tagfield,tab,frameworkcode from marc_subfield_structure where kohafield=\"biblio.biblionumber\"");
$sth->execute;
-my $tab;
-($res,$tab) = $sth->fetchrow;
-$sth = $dbh->prepare("select tagfield,tab from marc_subfield_structure where kohafield=\"biblioitems.biblioitemnumber\"");
-$sth->execute;
-my ($res2,$tab2) = $sth->fetchrow;
-if ($res && $res2 && $tab==-1 && $tab2==-1) {
- $template->param(biblionumber => 0);
-} else {
- $template->param(biblionumber => 1);
- $total++;
+my $first = 1;
+my $bibliotag = '';
+while (my ($res,$tab,$frameworkcode) = $sth->fetchrow) {
+ if ($first) {
+ $bibliotag = $res;
+ $first = 0;
+ } else {
+ if ($bibliotag != $res) {
+ $template->param(biblionumber => 1);
+ $total++;
+ last;
+ }
+ }
+ my $sth2 = $dbh->prepare("SELECT tagfield,tab
+ FROM marc_subfield_structure
+ WHERE kohafield=\"biblioitems.biblioitemnumber\"
+ AND frameworkcode = ? ");
+ $sth2->execute($frameworkcode);
+ my ($res2,$tab2) = $sth2->fetchrow;
+ if ($res && $res2 && $tab==-1 && $tab2==-1) {
+ $template->param(biblionumber => 0);
+ } else {
+ $template->param(biblionumber => 1);
+ $total++;
+ last;
+ }
}
# checks all item fields are in the same tag and in tab 10
$sth = $dbh->prepare("select tagfield,tab,kohafield from marc_subfield_structure where kohafield like \"items.%\" and tab >=0");
$sth->execute;
my $field;
+my $res;
+my $res2;
+my $tab;
($res,$res2,$field) = $sth->fetchrow;
my $tagfield = $res;
$tab = $res2;
# checks biblioitems.itemtype must be mapped and use authorised_value=itemtype
$sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"biblioitems.itemtype\"");
$sth->execute;
-($res,$res2,$field) = $sth->fetchrow;
-if ($res && $res2>=0 && $field eq "itemtypes") {
- $template->param(itemtype => 0);
-} else {
- $template->param(itemtype => 1);
- $total++;
+while (($res,$res2,$field) = $sth->fetchrow) {
+ if ($res && $res2>=0 && $field eq "itemtypes") {
+ $template->param(itemtype => 0);
+ } else {
+ $template->param(itemtype => 1);
+ $total++;
+ last;
+ }
}
# checks items.homebranch must be mapped and use authorised_value=branches
$sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"items.homebranch\"");
$sth->execute;
-($res,$res2,$field) = $sth->fetchrow;
-if ($res && $res2 eq 10 && $field eq "branches") {
- $template->param(branch => 0);
-} else {
- $template->param(branch => 1);
- $total++;
+while (($res,$res2,$field) = $sth->fetchrow) {
+ if ($res && $res2 eq 10 && $field eq "branches") {
+ $template->param(branch => 0);
+ } else {
+ $template->param(branch => 1);
+ $total++;
+ last;
+ }
}
+
# checks items.homebranch must be mapped and use authorised_value=branches
$sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"items.holdingbranch\"");
$sth->execute;
-($res,$res2,$field) = $sth->fetchrow;
-if ($res && $res2 eq 10 && $field eq "branches") {
- $template->param(holdingbranch => 0);
-} else {
- $template->param(holdingbranch => 1);
- $total++;
+while (($res,$res2,$field) = $sth->fetchrow) {
+ if ($res && $res2 eq 10 && $field eq "branches") {
+ $template->param(holdingbranch => 0);
+ } else {
+ $template->param(holdingbranch => 1);
+ $total++;
+ last; #MR
+ }
}
# checks that itemtypes & branches tables are not empty
$total++;
}
-# verify that all of a field's subfields (except the ones explicitly ignore)
+# verify that all of a field's subfields (except the ones explicitly ignored)
# are in the same tab
$sth = $dbh->prepare("SELECT tagfield, frameworkcode, frameworktext, GROUP_CONCAT(DISTINCT tab) AS tabs
FROM marc_subfield_structure
$template->param(tab_info => $inconsistent_tabs);
}
+# verify that authtypecodes used in the framework
+# are defined in auth_types
+$sth = $dbh->prepare("SELECT frameworkcode, frameworktext, tagfield, tagsubfield, authtypecode
+ FROM marc_subfield_structure
+ LEFT JOIN biblio_framework USING (frameworkcode)
+ WHERE authtypecode IS NOT NULL
+ AND authtypecode <> ''
+ AND tab > '-1'
+ AND authtypecode NOT IN (SELECT authtypecode FROM auth_types)
+ ORDER BY frameworkcode, tagfield, tagsubfield");
+$sth->execute;
+my $invalid_authtypecodes = $sth->fetchall_arrayref({});
+if (scalar(@$invalid_authtypecodes) > 0) {
+ $total++;
+ $template->param(invalid_authtypecodes => 1);
+ $template->param(authtypecode_info => $invalid_authtypecodes);
+}
+
+# checks items.permanent_location is not mapped
+$sth = $dbh->prepare("SELECT frameworkcode, frameworktext, tagfield, tagsubfield
+ FROM marc_subfield_structure
+ LEFT JOIN biblio_framework USING (frameworkcode)
+ WHERE kohafield='permanent_location' OR
+ kohafield='items.permanent_location'");
+$sth->execute;
+my $permanent_location_mapped = $sth->fetchall_arrayref({});
+if (scalar(@$permanent_location_mapped) > 0) {
+ $total++;
+ $template->param(permanent_location_mapped => 1);
+ $template->param(mapped_permanent_location => $permanent_location_mapped);
+}
+
+
$template->param(total => $total,
);