Bug 15258: Fix Perl scripts declaring unused variables

[koha.git] / admin / koha2marclinks.pl

diff --git a/admin/koha2marclinks.pl b/admin/koha2marclinks.pl
index fc320ad..9ccca37 100755 (executable)
--- a/admin/koha2marclinks.pl
+++ b/admin/koha2marclinks.pl
@@ -4,24 +4,24 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use strict;
 use warnings;
 use C4::Output;
 use C4::Auth;
-use CGI;
+use CGI qw ( -utf8 );
 use C4::Context;
 use C4::Biblio;
 
@@ -35,7 +35,7 @@ my $script_name = 'koha2marclinks.pl';
 
 my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
     {
-        template_name   => "admin/koha2marclinks.tmpl",
+        template_name   => "admin/koha2marclinks.tt",
         query           => $input,
         type            => "intranet",
         authnotrequired => 0,
@@ -59,11 +59,11 @@ else {
 }
 
 my $dbh = C4::Context->dbh;
+my $cache = Koha::Cache->get_instance();
 
 ################## ADD_FORM ##################################
 # called by default. Used to create form to add or  modify a record
 if ( $op eq 'add_form' ) {
-    my $data;
     my $sth =
       $dbh->prepare(
 "select tagfield,tagsubfield,liblibrarian as lib,tab from marc_subfield_structure where kohafield=? AND frameworkcode=''"
@@ -85,14 +85,10 @@ if ( $op eq 'add_form' ) {
         {
             push @marcarray, "$field $tagsubfield - $liblibrarian";
         }
-        my $marclist = CGI::scrolling_list(
-            -name   => 'marc',
-            -values => \@marcarray,
-            -default =>
-              "$defaulttagfield $defaulttagsubfield - $defaultliblibrarian",
-            -size     => 1,
-            -multiple => 0,
-        );
+        my $marclist = {
+            values  => \@marcarray,
+            default => "$defaulttagfield $defaulttagsubfield - $defaultliblibrarian",
+        };
         $template->param( "marclist$i" => $marclist );
     }
     $template->param(
@@ -116,8 +112,10 @@ elsif ( $op eq 'add_validate' ) {
     $dbh->do(
 "update marc_subfield_structure set kohafield='$tablename.$kohafield' where tagfield='$temp[0]' and tagsubfield='$temp[1]'"
     );
-    print
-"Content-Type: text/html\n\n<META HTTP-EQUIV=Refresh CONTENT=\"0; URL=koha2marclinks.pl?tablename=$tablename\"></html>";
+    # We could get a list of all frameworks and do them one-by-one, or zap
+    # everything.
+    $cache->flush_all();
+    print $input->redirect("/cgi-bin/koha/admin/koha2marclinks.pl?tablename=$tablename");
     exit;
 
     # END $OP eq ADD_VALIDATE
@@ -154,19 +152,13 @@ q|select tagfield,tagsubfield,liblibrarian,kohafield from marc_subfield_structur
 "$script_name?op=add_form&amp;tablename=$tablename&amp;kohafield=$field";
         push( @loop_data, \%row_data );
     }
+    my $tablenames = {
+        values  => [ 'biblio', 'biblioitems', 'items' ],
+        default => $tablename,
+    };
     $template->param(
         loop      => \@loop_data,
-        tablename => CGI::scrolling_list(
-            -name   => 'tablename',
-            -values => [
-                'biblio',
-                'biblioitems',
-                'items',
-            ],
-            -default  => $tablename,
-            -size     => 1,
-            -multiple => 0
-        )
+        tablename => $tablenames,
     );
 }    #---- END $OP eq DEFAULT
 output_html_with_http_headers $input, $cookie, $template->output;