# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
-use strict;
-#use warnings; FIXME - Bug 2505
+use Modern::Perl;
+
use CGI qw ( -utf8 );
use C4::Auth;
use C4::Output;
use C4::Koha;
use C4::ClassSource;
use Koha::DateUtils;
+use Koha::Items;
+use Koha::ItemTypes;
use Koha::Libraries;
+use Koha::Patrons;
use List::MoreUtils qw/any/;
use C4::Search;
use Storable qw(thaw freeze);
$subfield_data{repeatable} = $subfieldlib->{repeatable};
$subfield_data{maxlength} = $subfieldlib->{maxlength};
- $value =~ s/"/"/g;
if ( ! defined( $value ) || $value eq '') {
$value = $subfieldlib->{defaultvalue};
- # get today date & replace <<YYYY>>, <<MM>>, <<DD>> if provided in the default value
- my $today_dt = dt_from_string;
- my $year = $today_dt->year;
- my $month = $today_dt->month;
- my $day = $today_dt->day;
- $value =~ s/<<YYYY>>/$year/g;
- $value =~ s/<<MM></$month/g;
- $value =~ s/<<DD>>/$day/g;
- # And <<USER>> with surname (?)
- my $username=(C4::Context->userenv?C4::Context->userenv->{'surname'}:"superlibrarian");
- $value=~s/<<USER>>/$username/g;
+ if ( $value ) {
+ # get today date & replace <<YYYY>>, <<MM>>, <<DD>> if provided in the default value
+ my $today_dt = dt_from_string;
+ my $year = $today_dt->strftime('%Y');
+ my $month = $today_dt->strftime('%m');
+ my $day = $today_dt->strftime('%d');
+ $value =~ s/<<YYYY>>/$year/g;
+ $value =~ s/<<MM>>/$month/g;
+ $value =~ s/<<DD>>/$day/g;
+ # And <<USER>> with surname (?)
+ my $username=(C4::Context->userenv?C4::Context->userenv->{'surname'}:"superlibrarian");
+ $value=~s/<<USER>>/$username/g;
+ }
}
-
+
$subfield_data{visibility} = "display:none;" if (($subfieldlib->{hidden} > 4) || ($subfieldlib->{hidden} <= -4));
-
+
my $pref_itemcallnumber = C4::Context->preference('itemcallnumber');
if (!$value && $subfieldlib->{kohafield} eq 'items.itemcallnumber' && $pref_itemcallnumber) {
my $CNtag = substr($pref_itemcallnumber, 0, 3);
my $CNsubfield2 = substr($pref_itemcallnumber, 4, 1);
my $temp2 = $temp->field($CNtag);
if ($temp2) {
- $value = ($temp2->subfield($CNsubfield)).' '.($temp2->subfield($CNsubfield2));
+ $value = join ' ', $temp2->subfield($CNsubfield) || q{}, $temp2->subfield($CNsubfield2) || q{};
#remove any trailing space incase one subfield is used
$value =~ s/^\s+|\s+$//g;
}
$value = $input->param('barcode');
}
- # Getting list of subfields to keep when restricted editing is enabled
- my $subfieldsToAllowForRestrictedEditing = C4::Context->preference('SubfieldsToAllowForRestrictedEditing');
- my $allowAllSubfields = (
- not defined $subfieldsToAllowForRestrictedEditing
- or $subfieldsToAllowForRestrictedEditing == q||
- ) ? 1 : 0;
- my @subfieldsToAllow = split(/ /, $subfieldsToAllowForRestrictedEditing);
-
if ( $subfieldlib->{authorised_value} ) {
my @authorised_values;
my %authorised_lib;
}
}
elsif ( $subfieldlib->{authorised_value} eq "itemtypes" ) {
- push @authorised_values, "" unless ( $subfieldlib->{mandatory} );
- my $itemtypes = GetItemTypes( style => 'array' );
- for my $itemtype ( @$itemtypes ) {
- push @authorised_values, $itemtype->{itemtype};
- $authorised_lib{$itemtype->{itemtype}} = $itemtype->{translated_description};
+ push @authorised_values, "";
+ my $itemtypes = Koha::ItemTypes->search_with_localization;
+ while ( my $itemtype = $itemtypes->next ) {
+ push @authorised_values, $itemtype->itemtype;
+ $authorised_lib{$itemtype->itemtype} = $itemtype->translated_description;
}
unless ( $value ) {
#---- class_sources
}
elsif ( $subfieldlib->{authorised_value} eq "cn_source" ) {
- push @authorised_values, "" unless ( $subfieldlib->{mandatory} );
+ push @authorised_values, "";
my $class_sources = GetClassSources();
my $default_source = C4::Context->preference("DefaultClassificationSource");
#---- "true" authorised value
}
else {
- push @authorised_values, qq{} unless ( $subfieldlib->{mandatory} );
+ push @authorised_values, qq{};
my $av = GetAuthorisedValues( $subfieldlib->{authorised_value} );
for my $r ( @$av ) {
push @authorised_values, $r->{authorised_value};
$subfield_data{marc_value} = {
type => 'hidden',
id => $subfield_data{id},
- maxlength => $subfield_data{max_length},
+ maxlength => $subfield_data{maxlength},
value => $value,
};
}
labels => \%authorised_lib,
default => $value,
};
- # If we're on restricted editing, and our field is not in the list of subfields to allow,
- # then it is read-only
- $subfield_data{marc_value}->{readonlyselect} = (
- not $allowAllSubfields
- and $restrictededition
- and !grep { $tag . '$' . $subfieldtag eq $_ } @subfieldsToAllow
- ) ? 1: 0;
}
}
# it's a thesaurus / authority field
$subfield_data{marc_value} = {
type => 'text_auth',
id => $subfield_data{id},
- maxlength => $subfield_data{max_length},
+ maxlength => $subfield_data{maxlength},
value => $value,
authtypecode => $subfieldlib->{authtypecode},
};
$subfield_data{marc_value} = {
type => 'text_plugin',
id => $subfield_data{id},
- maxlength => $subfield_data{max_length},
+ maxlength => $subfield_data{maxlength},
value => $value,
class => $class,
nopopup => $plugin->noclick,
$subfield_data{marc_value} = {
type => 'text',
id => $subfield_data{id},
- maxlength => $subfield_data{max_length},
+ maxlength => $subfield_data{maxlength},
value => $value,
}; # supply default input form
}
$subfield_data{marc_value} = {
type => 'hidden',
id => $subfield_data{id},
- maxlength => $subfield_data{max_length},
+ maxlength => $subfield_data{maxlength},
value => $value,
};
}
$subfield_data{marc_value} = {
type => 'text',
id => $subfield_data{id},
- maxlength => $subfield_data{max_length},
+ maxlength => $subfield_data{maxlength},
value => $value,
};
}
elsif (
- length($value) > 100
+ (
+ $value and length($value) > 100
+ )
or (
C4::Context->preference("marcflavour") eq "UNIMARC"
and 300 <= $tag && $tag < 400 && $subfieldtag eq 'a'
$subfield_data{marc_value} = {
type => 'text',
id => $subfield_data{id},
- maxlength => $subfield_data{max_length},
+ maxlength => $subfield_data{maxlength},
value => $value,
};
}
-
+
+ # Getting list of subfields to keep when restricted editing is enabled
+ my $subfieldsToAllowForRestrictedEditing = C4::Context->preference('SubfieldsToAllowForRestrictedEditing');
+ my $allowAllSubfields = (
+ not defined $subfieldsToAllowForRestrictedEditing
+ or $subfieldsToAllowForRestrictedEditing eq q||
+ ) ? 1 : 0;
+ my @subfieldsToAllow = split(/ /, $subfieldsToAllowForRestrictedEditing);
+
+ # If we're on restricted editing, and our field is not in the list of subfields to allow,
+ # then it is read-only
+ $subfield_data{marc_value}->{readonly} = (
+ not $allowAllSubfields
+ and $restrictededition
+ and !grep { $tag . '$' . $subfieldtag eq $_ } @subfieldsToAllow
+ ) ? 1: 0;
+
return \%subfield_data;
}
my $error = $input->param('error');
my $biblionumber = $input->param('biblionumber');
my $itemnumber = $input->param('itemnumber');
-my $op = $input->param('op');
+my $op = $input->param('op') || q{};
my $hostitemnumber = $input->param('hostitemnumber');
my $marcflavour = C4::Context->preference("marcflavour");
my $searchid = $input->param('searchid');
# Does the user have a restricted item editing permission?
-my $uid = $loggedinuser ? GetMember( borrowernumber => $loggedinuser )->{userid} : undef;
+my $uid = Koha::Patrons->find( $loggedinuser )->userid;
my $restrictededition = $uid ? haspermission($uid, {'editcatalogue' => 'edit_items_restricted'}) : undef;
# In case user is a superlibrarian, editing is not restricted
$restrictededition = 0 if ($restrictededition != 0 && C4::Context->IsSuperLibrarian());
$restrictededition = 0 if ($restrictededition != 0 && $frameworkcode eq 'FA' && haspermission($uid, {'editcatalogue' => 'fast_cataloging'}));
my $tagslib = &GetMarcStructure(1,$frameworkcode);
-my $record = GetMarcBiblio($biblionumber);
+my $record = GetMarcBiblio({ biblionumber => $biblionumber });
my $oldrecord = TransformMarcToKoha($record);
my $itemrecord;
my $nextop="additem";
my $oldbarcode = $addedolditem->{'barcode'};
my ($tagfield,$tagsubfield) = &GetMarcFromKohaField("items.barcode",$frameworkcode);
- # If there is a barcode and we can't find him new values, we can't add multiple copies
+ # If there is a barcode and we can't find their new values, we can't add multiple copies
my $testbarcode;
$testbarcode = $barcodeobj->next_value($oldbarcode) if $barcodeobj;
if ($oldbarcode && !$testbarcode) {
#-------------------------------------------------------------------------------
} elsif ($op eq "delallitems") {
#-------------------------------------------------------------------------------
- my @biblioitems = &GetBiblioItemByBiblioNumber($biblionumber);
- my $errortest=0;
- my $itemfail;
- foreach my $biblioitem (@biblioitems) {
- my $items = &GetItemsByBiblioitemnumber( $biblioitem->{biblioitemnumber} );
-
- foreach my $item (@$items) {
- $error =&DelItemCheck( $biblionumber, $item->{itemnumber} );
- $itemfail =$item;
- if($error == 1){
- next
- }
- else {
- push @errors,$error;
- $errortest++
- }
- }
- if($errortest > 0){
- $nextop="additem";
- }
- else {
- my $defaultview = C4::Context->preference('IntranetBiblioDefaultView');
- my $views = { C4::Search::enabled_staff_search_views };
- if ($defaultview eq 'isbd' && $views->{can_view_ISBD}) {
- print $input->redirect("/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=$biblionumber&searchid=$searchid");
- } elsif ($defaultview eq 'marc' && $views->{can_view_MARC}) {
- print $input->redirect("/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=$biblionumber&searchid=$searchid");
- } elsif ($defaultview eq 'labeled_marc' && $views->{can_view_labeledMARC}) {
- print $input->redirect("/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=$biblionumber&searchid=$searchid");
- } else {
- print $input->redirect("/cgi-bin/koha/catalogue/detail.pl?biblionumber=$biblionumber&searchid=$searchid");
- }
- exit;
+ my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber })->get_column('itemnumber');
+ foreach my $itemnumber ( @itemnumbers ) {
+ $error = C4::Items::DelItemCheck( $biblionumber, $itemnumber );
+ next if $error == 1; # Means ok
+ push @errors,$error;
+ }
+ if ( @errors ) {
+ $nextop="additem";
+ } else {
+ my $defaultview = C4::Context->preference('IntranetBiblioDefaultView');
+ my $views = { C4::Search::enabled_staff_search_views };
+ if ($defaultview eq 'isbd' && $views->{can_view_ISBD}) {
+ print $input->redirect("/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=$biblionumber&searchid=$searchid");
+ } elsif ($defaultview eq 'marc' && $views->{can_view_MARC}) {
+ print $input->redirect("/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=$biblionumber&searchid=$searchid");
+ } elsif ($defaultview eq 'labeled_marc' && $views->{can_view_labeledMARC}) {
+ print $input->redirect("/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=$biblionumber&searchid=$searchid");
+ } else {
+ print $input->redirect("/cgi-bin/koha/catalogue/detail.pl?biblionumber=$biblionumber&searchid=$searchid");
}
- }
+ exit;
+ }
#-------------------------------------------------------------------------------
} elsif ($op eq "saveitem") {
#-------------------------------------------------------------------------------
if ($exist_itemnumber && $exist_itemnumber != $itemnumber) {
push @errors,"barcode_not_unique";
} else {
- ModItemFromMarc($itemtosave,$biblionumber,$itemnumber);
- $itemnumber="";
- }
- my $item = GetItem( $itemnumber );
- my $olditemlost = $item->{'itemlost'};
-
- my ($lost_tag,$lost_subfield) = GetMarcFromKohaField("items.itemlost",'');
-
- my $newitemlost = $itemtosave->subfield( $lost_tag, $lost_subfield );
- if (($olditemlost eq '0' or $olditemlost eq '' ) and $newitemlost ge '1'){
- LostItem($itemnumber,'MARK RETURNED');
+ my $item = GetItem( $itemnumber );
+ my $newitem = ModItemFromMarc($itemtosave, $biblionumber, $itemnumber);
+ $itemnumber = q{};
+ my $olditemlost = $item->{itemlost};
+ my $newitemlost = $newitem->{itemlost};
+ LostItem( $item->{itemnumber}, 'additem' )
+ if $newitemlost && $newitemlost ge '1' && !$olditemlost;
}
$nextop="additem";
} elsif ($op eq "delinkitem"){
#-------------------------------------------------------------------------------
# now, build existiing item list
-my $temp = GetMarcBiblio( $biblionumber );
+my $temp = GetMarcBiblio({ biblionumber => $biblionumber });
#my @fields = $record->fields();
#---- finds where items.itemnumber is stored
my ( $itemtagfield, $itemtagsubfield) = &GetMarcFromKohaField("items.itemnumber", $frameworkcode);
my ($branchtagfield, $branchtagsubfield) = &GetMarcFromKohaField("items.homebranch", $frameworkcode);
-C4::Biblio::EmbedItemsInMarcBiblio($temp, $biblionumber);
+C4::Biblio::EmbedItemsInMarcBiblio({
+ marc_record => $temp,
+ biblionumber => $biblionumber });
my @fields = $temp->fields();
foreach my $hostfield ($temp->field($analyticfield)){
my $hostbiblionumber = $hostfield->subfield('0');
if ($hostbiblionumber){
- my $hostrecord = GetMarcBiblio($hostbiblionumber, 1);
+ my $hostrecord = GetMarcBiblio({
+ biblionumber => $hostbiblionumber,
+ embed_items => 1 });
if ($hostrecord) {
my ($itemfield, undef) = GetMarcFromKohaField( 'items.itemnumber', GetFrameworkCode($hostbiblionumber) );
foreach my $hostitem ($hostrecord->field($itemfield)){
}
$this_row{itemnumber} = $subfieldvalue if ($field->tag() eq $itemtagfield && $subfieldcode eq $itemtagsubfield);
- if ( C4::Context->preference('EasyAnalyticalRecords') ) {
- foreach my $hostitemnumber (@hostitemnumbers){
- if ($this_row{itemnumber} eq $hostitemnumber){
- $this_row{hostitemflag} = 1;
- $this_row{hostbiblionumber}= GetBiblionumberFromItemnumber($hostitemnumber);
- last;
- }
- }
-
-# my $countanalytics=GetAnalyticsCount($this_row{itemnumber});
-# if ($countanalytics > 0){
-# $this_row{countanalytics} = $countanalytics;
-# }
- }
-
+ if ( C4::Context->preference('EasyAnalyticalRecords') ) {
+ foreach my $hostitemnumber (@hostitemnumbers) {
+ my $item = Koha::Items->find( $hostitemnumber );
+ if ($this_row{itemnumber} eq $hostitemnumber) {
+ $this_row{hostitemflag} = 1;
+ $this_row{hostbiblionumber}= $item->biblio->biblionumber;
+ last;
+ }
+ }
+ }
}
if (%this_row) {
push(@big_array, \%this_row);
}
@loop_data = sort {$a->{subfield} cmp $b->{subfield} } @loop_data;
+my $item = Koha::Items->find($itemnumber); # We certainly want to fetch it earlier
+
# what's the next op ? it's what we are not in : an add if we're editing, otherwise, and edit.
$template->param(
biblionumber => $biblionumber,
item_header_loop => \@header_value_loop,
item => \@loop_data,
itemnumber => $itemnumber,
- barcode => GetBarcodeFromItemnumber($itemnumber),
+ barcode => $item ? $item->barcode : undef,
itemtagfield => $itemtagfield,
itemtagsubfield => $itemtagsubfield,
op => $nextop,
projects / koha.git / blobdiff