Bug 5385: POD Cleanups (part 2)

[koha.git] / cataloguing / value_builder / unimarc_field_110.pl

diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl
index 0a7a3d7..848a53a 100755 (executable)
--- a/cataloguing/value_builder/unimarc_field_110.pl
+++ b/cataloguing/value_builder/unimarc_field_110.pl
@@ -1,6 +1,5 @@
 #!/usr/bin/perl
 
-# $Id$
 
 # Copyright 2000-2002 Katipo Communications
 #
@@ -15,11 +14,12 @@
 # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
 # A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
 use CGI;
 use C4::Context;
@@ -27,38 +27,40 @@ use C4::Context;
 use C4::Search;
 use C4::Output;
 
-=head1
+=head1 FUNCTIONS
 
-plugin_parameters : other parameters added when the plugin is called by the dopop function
+=head2 plugin_parameters
+
+Other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
-my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
-return "";
+    my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
+    return "";
 }
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
-my $function_name= "110".(int(rand(100000))+1);
-my $res="
-<script>
-function Focus$function_name(subfield_managed) {
-return 1;
-}
+    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my $res="
+    <script type='text/javascript'>
+    function Focus$field_number() {
+        return 1;
+    }
 
-function Blur$function_name(subfield_managed) {
-       return 1;
-}
+    function Blur$field_number() {
+            return 1;
+    }
 
-function Clic$function_name(i) {
-       defaultvalue=document.forms['f'].field_value[i].value;
-       newin=window.open(\"plugin_launcher.pl?plugin_name=unimarc_field_110.pl&index=\"+i+\"&result=\"+defaultvalue,\"unimarc field 110\",'width=700,height=600,toolbar=false,scrollbars=yes');
+    function Clic$field_number() {
+            defaultvalue=document.getElementById(\"$field_number\").value;
+            window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_110.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_110\",'width=700,height=600,toolbar=false,scrollbars=yes');
 
-}
-</script>
-";
+    }
+    </script>
+    ";
 
-return ($function_name,$res);
+    return ($field_number,$res);
 }
 sub plugin {
 my ($input) = @_;
@@ -71,7 +73,7 @@ my ($template, $loggedinuser, $cookie)
                             query => $input,
                             type => "intranet",
                             authnotrequired => 0,
-                            flagsrequired => {editcatalogue => 1},
+                            flagsrequired => {editcatalogue => '*'},
                             debug => 1,
                             });
        my $f1 = substr($result,0,1);
@@ -85,17 +87,17 @@ my ($template, $loggedinuser, $cookie)
        my $f9 = substr($result,10,1);
 
        $template->param(index => $index,
-                                                       "f1$f1" => 1,
-                                                       "f2$f2" => 1,
-                                                       "f3$f3" => 1,
-                                                       "f4$f4" => 1,
-                                                        f5 => $f5,
-                                                       "f6$f6" => 1,
-                                                       "f7$f7" => 1,
-                                                       "f8$f8" => 1,
-                                                       "f9$f9" => 1
+                        "f1$f1" => 1,
+                        "f2$f2" => 1,
+                        "f3$f3" => 1,
+                        "f4$f4" => 1,
+                            f5 => $f5,
+                        "f6$f6" => 1,
+                        "f7$f7" => 1,
+                        "f8$f8" => 1,
+                        "f9$f9" => 1
  );
-       print $input->header(-cookie => $cookie),$template->output;
+        output_html_with_http_headers $input, $cookie, $template->output;
 }
 
 1;