Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl

[koha.git] / cataloguing / value_builder / unimarc_field_123j.pl

diff --git a/cataloguing/value_builder/unimarc_field_123j.pl b/cataloguing/value_builder/unimarc_field_123j.pl
index da6d38d..52cb4bf 100755 (executable)
--- a/cataloguing/value_builder/unimarc_field_123j.pl
+++ b/cataloguing/value_builder/unimarc_field_123j.pl
@@ -5,54 +5,36 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
-use CGI;
+use CGI qw ( -utf8 );
 use C4::Context;
 
 use C4::Search;
 use C4::Output;
 
-=head1
-
-plugin_parameters : other parameters added when the plugin is called by the dopop function
-
-=cut
-
-sub plugin_parameters {
-       my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
-       return "";
-}
-
 sub plugin_javascript {
 my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
 my $function_name= $field_number;
 my $res="
     <script>
-        function Focus$function_name(subfield_managed) {
-               return 1;
-        }
-
-        function Blur$function_name(subfield_managed) {
-               return 1;
-        }
-
         function Clic$function_name(i) {
                defaultvalue=document.getElementById(\"$field_number\").value;
-               newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_123j.pl&index=$field_number&result=\"+defaultvalue,\"unimarc field 123j\",'width=800,height=400,toolbar=false,scrollbars=yes');
+               newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_123j.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_123j\",'width=800,height=400,toolbar=false,scrollbars=yes');
 
         }
     </script>
@@ -72,7 +54,7 @@ sub plugin {
        my ($template, $loggedinuser, $cookie)
     = get_template_and_user(
        {
-               template_name => "cataloguing/value_builder/unimarc_field_123j.tmpl",
+            template_name => "cataloguing/value_builder/unimarc_field_123i_j.tt",
                        query => $input,
                        type => "intranet",
                        authnotrequired => 0,
@@ -85,11 +67,9 @@ sub plugin {
        my $f3 = substr($result,4,2);
        my $f4 = substr($result,6,2);
        $template->param(index => $index,
-                        "f1$f1" => 1,
+             "f1".($f1 eq '-'?'s':'n') => 1,
                         f2 => $f2,
                         f3 => $f3,
                         f4 => $f4);
         output_html_with_http_headers $input, $cookie, $template->output;
 }
-
-1;