Bug 6874: QA follow-up

[koha.git] / cataloguing / value_builder / unimarc_field_686a.pl

diff --git a/cataloguing/value_builder/unimarc_field_686a.pl b/cataloguing/value_builder/unimarc_field_686a.pl
old mode 100644 (file)
new mode 100755 (executable)
index 8d04df9..2a7ca70
--- a/cataloguing/value_builder/unimarc_field_686a.pl
+++ b/cataloguing/value_builder/unimarc_field_686a.pl
@@ -4,59 +4,36 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
-use CGI;
+use CGI qw ( -utf8 );
 use C4::Context;
 
 use C4::Search;
 use C4::Output;
 
-=head1 NAME
-
-plugin unimarc_field_686a
-
-=head1 SYNOPSIS
-
-This plug-in deals with unimarc field 686a (
-
-=head1 DESCRIPTION
-
-=head1 FUNCTIONS
-
-=over 2
-
-=cut
-
 sub plugin_javascript {
 my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
 my $function_name= $field_number;
 my $res  = "
 <script>
-function Focus$function_name(index) {
-       return 1;
-}
-
-function Blur$function_name(subfield_managed) {
-       return 1;
-}
-
 function Clic$function_name(subfield_managed) {
        defaultvalue=document.getElementById(\"$field_number\").value;
-       newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_686a.pl&result=\"+defaultvalue+\"&index=$field_number\",\"value builder\",'width=700,height=600,toolbar=false,scrollbars=yes');
+       newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_686a.pl&result=\"+defaultvalue+\"&index=$field_number\",\"value_builder\",'width=700,height=600,toolbar=false,scrollbars=yes');
 
 }
 </script>
@@ -74,19 +51,19 @@ my ($input) = @_;
 
        my $dbh = C4::Context->dbh;
 
-       my ($template, $loggedinuser, $cookie)
-       = get_template_and_user({template_name => "cataloguing/value_builder/unimarc_field_686a.tmpl",
-                                       query => $input,
-                                       type => "intranet",
-                                       authnotrequired => 0,
-                                       flagsrequired => {editcatalogue => 1},
-                                       debug => 1,
-                                       });
+    my ($template, $loggedinuser, $cookie) = get_template_and_user(
+        {
+            template_name   => "cataloguing/value_builder/unimarc_field_686a.tt",
+            query           => $input,
+            type            => "intranet",
+            authnotrequired => 0,
+            flagsrequired   => { editcatalogue => '*' },
+            debug           => 1,
+        }
+    );
        $template->param(index => $index,
                                                        index2 => $index2,
                                                        authtypecode => 'CLASSCD',
                                                        );
         output_html_with_http_headers $input, $cookie, $template->output;
 }
-
-1;