Bug 17698: (QA follow-up) Fix minors design issues

[koha.git] / circ / branchoverdues.pl

diff --git a/circ/branchoverdues.pl b/circ/branchoverdues.pl
index 1430caa..ed4b855 100755 (executable)
--- a/circ/branchoverdues.pl
+++ b/circ/branchoverdues.pl
@@ -16,8 +16,7 @@
 # You should have received a copy of the GNU General Public License
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-#use warnings; FIXME - Bug 2505
+use Modern::Perl;
 use C4::Context;
 use CGI qw ( -utf8 );
 use C4::Output;
@@ -28,6 +27,7 @@ use C4::Koha;
 use C4::Debug;
 use Koha::DateUtils;
 use Koha::BiblioFrameworks;
+use Koha::Checkouts;
 use Data::Dumper;
 
 =head1 branchoverdues.pl
@@ -35,27 +35,6 @@ use Data::Dumper;
  this module is a new interface, allow to the librarian to check all items on overdues (based on the acountlines type 'FU' )
  this interface is filtered by branches (automatically), and by location (optional) ....
 
- FIXME for this time, we have only four methods to notify :
-       - mail : work with a batch programm
-       - letter : for us, the letters are generated by an open-office program
-       - phone : Simple method, when the method 'phone' is selected, we consider, that the borrower as been notified, and the notify send date is implemented
-       - considered lost : for us if the document is on the third overduelevel,
-
- FIXME the methods are actually hardcoded for the levels : (maybe can be improved by a new possibility in overduerule)
-
-       level 1 : three methods are possible : - mail, letter, phone
-       level 2 : only one method is possible : - letter
-       level 3 : only methode is possible  : - Considered Lost
-
-       the documents displayed on this interface, are checked on three points
-       - 1) the document must be on accountlines (Type 'FU')
-       - 2) item issues is not returned
-       - 3) this item as not been already notify
-
-  FIXME: who is the author?
-  FIXME: No privisions (i.e. "actions") for handling notices are implemented.
-  FIXME: This is linked as "Overdue Fines" but the relationship to fines in GetOverduesForBranch is more complicated than that.
-
 =cut
 
 my $input       = new CGI;
@@ -77,7 +56,6 @@ my $borrowernumber = $input->param('borrowernumber');
 my $itemnumber     = $input->param('itemnumber');
 my $method         = $input->param('method');
 my $overduelevel   = $input->param('overduelevel');
-my $notifyId       = $input->param('notifyId');
 my $location       = $input->param('location');
 
 # FIXME: better check that borrowernumber is defined and valid.
@@ -118,29 +96,16 @@ foreach my $num (@getoverdues) {
     $overdueforbranch{'itemnumber'}        = $num->{'itemnumber'};
     $overdueforbranch{'cardnumber'}        = $num->{'cardnumber'};
 
-    # now we add on the template, the differents values of notify_level
-    # FIXME: numerical comparison, not string eq.
-    if ( $num->{'notify_level'} eq '1' ) {
-        $overdueforbranch{'overdue1'}     = 1;
-        $overdueforbranch{'overdueLevel'} = 1;
-    }
-    elsif ( $num->{'notify_level'} eq '2' ) {
-        $overdueforbranch{'overdue2'}     = 1;
-        $overdueforbranch{'overdueLevel'} = 2;
-    }
-    elsif ( $num->{'notify_level'} eq '3' ) {
-        $overdueforbranch{'overdue3'}     = 1;
-        $overdueforbranch{'overdueLevel'} = 3;
-    }
-    $overdueforbranch{'notify_id'} = $num->{'notify_id'};
-
     push( @overduesloop, \%overdueforbranch );
 }
 
+my $pending_checkout_notes = Koha::Checkouts->search({ noteseen => 0 })->count;
+
 # initiate the templates for the overdueloop
 $template->param(
     overduesloop => \@overduesloop,
     location     => $location,
+    pending_checkout_notes => $pending_checkout_notes,
 );
 
 # Checking if there is a Fast Cataloging Framework