Bug 15072: Breadcrumbs and titles inconsistent in Label creator

[koha.git] / labels / label-manage.pl

diff --git a/labels/label-manage.pl b/labels/label-manage.pl
index 70302e8..3399c8f 100755 (executable)
--- a/labels/label-manage.pl
+++ b/labels/label-manage.pl
@@ -5,36 +5,35 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
+use Modern::Perl;
 
-use strict;
-use warnings;
 use vars qw($debug);
 
-use CGI;
+use CGI qw ( -utf8 );
 use Data::Dumper;
 
 use C4::Auth qw(get_template_and_user);
 use C4::Output qw(output_html_with_http_headers);
-use autouse 'C4::Branch' => qw(get_branch_code_from_name);
-use C4::Creators 1.000000;
-use C4::Labels 1.000000;
+use C4::Creators;
+use C4::Labels;
 
 my $cgi = new CGI;
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
-        template_name   => "labels/label-manage.tmpl",
+        template_name   => "labels/label-manage.tt",
         query           => $cgi,
         type            => "intranet",
         authnotrequired => 0,
@@ -50,22 +49,26 @@ my $display_columns = { layout =>   [  # db column       => {col label
                                         {barcode_type    => {label => 'Barcode Type',   link_field      => 0}},
                                         {printing_type   => {label => 'Print Type',     link_field      => 0}},
                                         {format_string   => {label => 'Fields to Print',link_field      => 0}},
-                                        {select          => {label => 'Select',         value           => 'layout_id'}},
+                                        {select         => {label => 'Actions',         value           => 'layout_id'}},
                                     ],
-                        template => [   {template_id     => {label => 'Template ID',    link_field      => 0}},
+                        template => [
+                                        {template_id     => {label => 'Template ID',    link_field      => 0}},
                                         {template_code   => {label => 'Template Name',  link_field      => 0}},
                                         {template_desc   => {label => 'Description',    link_field      => 0}},
-                                        {select          => {label => 'Select',         value           => 'template_id'}},
+                                        {select         => {label => 'Actions',         value           => 'template_id'}},
                                     ],
-                        profile =>  [   {profile_id      => {label => 'Profile ID',     link_field      => 0}},
+                        profile =>  [
+                                        {profile_id      => {label => 'Profile ID',     link_field      => 0}},
                                         {printer_name    => {label => 'Printer Name',   link_field      => 0}},
                                         {paper_bin       => {label => 'Paper Bin',      link_field      => 0}},
                                         {_template_code  => {label => 'Template Name',  link_field      => 0}},     # this display column does not have a corrisponding db column in the profile table, hence the underscore
-                                        {select          => {label => 'Select',         value           => 'profile_id'}},
+                                        {select          => {label => 'Actions',         value           => 'profile_id'}},
                                     ],
-                        batch =>    [   {batch_id        => {label => 'Batch ID',       link_field      => 0}},
+                        batch =>    [
+                                        {batch_id        => {label => 'Batch ID',       link_field      => 0}},
                                         {_item_count     => {label => 'Item Count',     link_field      => 0}},
-                                        {select          => {label => 'Select',         value           => 'batch_id'}},
+                                        {select          => {label => 'Actions',         value           => 'batch_id'}},
+                                        {select1         => {label => ' ',           link_field       => 'batch_id'}},
                                     ],
 };
 
@@ -74,7 +77,7 @@ my $op = $cgi->param('op') || 'none';
 my $element_id = $cgi->param('element_id') || undef;
 my $error = $cgi->param('error') || 0;
 
-my $branch_code = ($label_element eq 'batch' ? get_branch_code_from_name($template->{VARS}->{'LoginBranchname'}) : '');
+my $branch_code = ($label_element eq 'batch' ? C4::Context->userenv->{'branch'} : '');
 
 if ($op eq 'delete') {
     if          ($label_element eq 'layout')    {$error = C4::Labels::Layout::delete(layout_id => $element_id);}
@@ -95,16 +98,16 @@ my $table = html_table($display_columns->{$label_element}, $db_rows);
 $template->param(error => $error) if ($error) && ($error ne 0);
 $template->param(print => 1) if ($label_element eq 'batch');
 $template->param(
-                op              => $op,
-                element_id      => $element_id,
-                table_loop      => $table,
-                label_element   => $label_element,
-                label_element_title     => ($label_element eq 'layout' ? 'Layouts' :
-                                            $label_element eq 'template' ? 'Templates' :
-                                            $label_element eq 'profile' ? 'Profiles' :
-                                            $label_element eq 'batch' ? 'Batches' :
-                                            ''
-                                            ),
+    op              => $op,
+    element_id      => $element_id,
+    table_loop      => $table,
+    label_element   => $label_element,
+    label_element_title => (
+        $label_element eq 'layout'   ? 'Layouts' :
+        $label_element eq 'template' ? 'Templates' :
+        $label_element eq 'profile'  ? 'Profiles' :
+        $label_element eq 'batch'    ? 'Batches' :
+        '' )
 );
 
 output_html_with_http_headers $cgi, $cookie, $template->output;