Bug 7298: (follow-up) fix uninitialized variable warning

[koha.git] / labels / spinelabel-print.pl

diff --git a/labels/spinelabel-print.pl b/labels/spinelabel-print.pl
index 04d7935..7076a08 100755 (executable)
--- a/labels/spinelabel-print.pl
+++ b/labels/spinelabel-print.pl
@@ -1,17 +1,30 @@
 #!/usr/bin/perl
 
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it under the
+# terms of the GNU General Public License as published by the Free Software
+# Foundation; either version 2 of the License, or (at your option) any later
+# version.
+#
+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
+# Suite 330, Boston, MA  02111-1307 USA
+
 use warnings;
 use strict;
 use CGI;
 use C4::Auth;
 use C4::Output;
-use HTML::Template::Pro;
 
 my $scheme = C4::Context->preference('SpineLabelFormat');
-my $query = new CGI;
+my $query  = new CGI;
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
-    {
-        template_name   => "labels/spinelabel-print.tmpl",
+    {   template_name   => "labels/spinelabel-print.tmpl",
         query           => $query,
         type            => "intranet",
         authnotrequired => 0,
@@ -20,7 +33,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     }
 );
 
-
 my $barcode = $query->param('barcode');
 
 my $dbh = C4::Context->dbh;
@@ -32,42 +44,48 @@ my $sql = "SELECT * FROM biblio, biblioitems, items
           WHERE biblio.biblionumber = items.biblionumber 
           AND biblioitems.biblioitemnumber = items.biblioitemnumber 
           AND items.barcode = ?";
-$sth = $dbh->prepare( $sql );
-$sth->execute( $barcode );
+$sth = $dbh->prepare($sql);
+$sth->execute($barcode);
 $item = $sth->fetchrow_hashref;
 
+unless (defined $item) {
+  $template->param( 'Barcode' => $barcode );
+  $template->param( 'BarcodeNotFound' => 1 );
+}
+
 my $body;
 
 my $data;
-while ( my ($key, $value ) = each(%$item) ) {
-  $data->{$key} .= "<span class='field' id='$key'>";
-
-  my @characters = split(//, $value );
-  my $charnum = 1;
-  my $wordnum = 1;
-  my $i = 1;
-  foreach my $char ( @characters ) {
-    if ( $char ne ' ' ) {
-      $data->{$key} .= "<span class='character word$wordnum character$charnum' id='$key$i'>$char</span>";
-    } else {
-      $data->{$key} .= "<span class='space character$charnum' id='$key$i'>$char</span>";
-      $wordnum++;
-      $charnum = 1;
+while ( my ( $key, $value ) = each(%$item) ) {
+    $data->{$key} .= "<span class='field' id='$key'>";
+
+    $value = '' unless defined $value;
+    my @characters = split( //, $value );
+    my $charnum    = 1;
+    my $wordernumber    = 1;
+    my $i          = 1;
+    foreach my $char (@characters) {
+        if ( $char ne ' ' ) {
+            $data->{$key} .= "<span class='character word$wordernumber character$charnum' id='$key$i'>$char</span>";
+        } else {
+            $data->{$key} .= "<span class='space character$charnum' id='$key$i'>$char</span>";
+            $wordernumber++;
+            $charnum = 1;
+        }
+        $charnum++;
+        $i++;
     }
-    $charnum++;
-    $i++;
-  }
-  
-  $data->{$key} .= "</span>";
+
+    $data->{$key} .= "</span>";
 }
 
-while ( my ($key, $value ) = each(%$data) ) {
-  $scheme =~ s/<$key>/$value/g;
+while ( my ( $key, $value ) = each(%$data) ) {
+    $scheme =~ s/<$key>/$value/g;
 }
 
 $body = $scheme;
 
 $template->param( autoprint => C4::Context->preference("SpineLabelAutoPrint") );
-$template->param( content => $body );
+$template->param( content   => $body );
 
 output_html_with_http_headers $query, $cookie, $template->output;