invalidate filters on other datasets
[MojoFacets.git] / lib / MojoFacets / Data.pm
index 2eba1f7..eff5f2a 100644 (file)
@@ -13,9 +13,14 @@ use File::Find;
 use Storable;
 use Time::HiRes qw(time);
 use File::Path qw(mkpath);
+use Text::Unaccent::PurePerl;
+use Digest::MD5;
 
 use MojoFacets::Import::File;
 use MojoFacets::Import::HTMLTable;
+use MojoFacets::Import::CSV;
+use MojoFacets::Import::CouchDB;
+use MojoFacets::Import::SQL;
 
 our $loaded;
 our $filters;
@@ -38,12 +43,17 @@ sub index {
                } elsif ( -d $file && $file =~ m/\.html$/ ) {
                        $file =~ s/$data_dir\/*//;
                        push @files, $file;
+               } elsif ( -f $file && $file =~ m/\.(csv|storabe|couchdb|sql)$/i ) {
+                       $file =~ s/$data_dir\/*//;
+                       push @files, $file;
                } else {
                        #warn "IGNORE: $file\n";
                }
        }, $data_dir);
 
-       @files = sort { lc $a cmp lc $b } @files;
+       no warnings qw(uninitialized); # mtime
+       @files = sort { $loaded->{$b}->{mtime} <=> $loaded->{$a}->{mtime} || lc $a cmp lc $b } @files,
+                       grep { defined $loaded->{$_}->{generated} } keys %$loaded;
        my $size;
        $size->{$_} = -s "$data_dir/$_" foreach @files;
 
@@ -150,15 +160,17 @@ sub stats {
        my $path = $self->_param_or_session('path');
        warn "stats $path\n";
        delete $loaded->{$path}->{stats};
-       $self->redirect_to( '/data/columns' );
+       return $self->redirect_to( '/data/columns' );
 }
 
 
 sub _load_path {
        my ( $self, $path ) = @_;
 
+       return if defined $loaded->{$path}->{generated};
+
        my $full_path = $self->app->home->rel_file( 'data/' . $path );
-       die "$full_path $!" unless -r $full_path;
+       return $self->redirect_to('/data/index') unless -r $full_path;
 
        my $dump_path = $self->_dump_path( $path );
 
@@ -175,7 +187,28 @@ sub _load_path {
 
        my $data;
        if ( -f $full_path ) {
-               $data = MojoFacets::Import::File->new( full_path => $full_path, path => $path )->data;
+               if ( $full_path =~ m/.csv/i ) {
+                       $data = MojoFacets::Import::CSV->new( full_path => $full_path )->data;
+               } elsif ( $full_path =~ m/.sql/i ) {
+                       $data = MojoFacets::Import::SQL->new( full_path => $full_path )->data;
+               } elsif ( $full_path =~ m/.couchdb/i ) {
+                       $data = MojoFacets::Import::CouchDB->new( full_path => $full_path )->data;
+               } elsif ( $full_path =~ m/.storable/ ) {
+                       warn "open $full_path ", -s $full_path, " bytes";
+                       open(my $pipe, "<", $full_path) || die $!;
+                       while ( my $o = eval { Storable::fd_retrieve $pipe } ) {
+                               if ( defined $o->{item} ) {
+                                       push @{ $data->{items} }, $o->{item};
+                               } else {
+                                       warn "SKIP ",dump($o);
+                               }
+                       }
+                       close($pipe);
+                       warn "loaded ", $#{ $data->{items} } + 1, " items from $full_path\n";
+                       $data->{generated}++;
+               } else {
+                       $data = MojoFacets::Import::File->new( full_path => $full_path, path => $path )->data;
+               }
        } elsif ( -d $full_path && $full_path =~ m/.html/ ) {
                $data = MojoFacets::Import::HTMLTable->new( dir => $full_path )->data;
        } else {
@@ -206,10 +239,11 @@ sub _load_path {
                size => -s $full_path,
                mtime => (stat($full_path))[9],
                data => $data,
+               defined $data->{generated} ? ( generated => 1 ) : (),
        };
 
        $loaded->{ $path } = $info;
-       $self->_save( $path );
+       $self->_save( $path ) unless $info->{generated};
 
 }
 
@@ -217,7 +251,7 @@ sub _load_path {
 sub load {
        my $self = shift;
 
-       my $path = $self->param('path') || $self->redirect_to( '/data/index' );
+       my $path = $self->param('path') || return $self->redirect_to( '/data/index' );
 
        my @paths = $self->param('paths');
        warn "# paths ", dump @paths;
@@ -241,7 +275,7 @@ sub load {
        if ( ! defined $loaded->{$path}->{columns} ) {
                my $columns_path = $self->_permanent_path( 'columns' );
                if ( -e $columns_path ) {
-                       my @columns = map { s/[\r\n]+$//; $_ } read_file $columns_path;
+                       my @columns = map { s/[\r\n]+$//; $_ } read_file $columns_path, binmode => ':utf8';
                        $loaded->{$path}->{columns} = [ @columns ];
                        warn "# columns_path $columns_path ",dump(@columns);
                } else {
@@ -252,14 +286,14 @@ sub load {
        }
        $self->session( 'columns' => $loaded->{$path}->{columns} );
        $self->session( 'order'   => $loaded->{$path}->{columns}->[0] );
-       $self->redirect_to( $redirect_to );
+       return $self->redirect_to( $redirect_to );
 }
 
 
 sub _loaded {
        my ( $self, $name ) = @_;
        my $path = $self->session('path') || $self->param('path');
-       $self->redirect_to('/data/index') unless $path;
+       return $self->redirect_to('/data/index') unless $path;
 
        if ( defined $loaded->{$path}->{modified} && $loaded->{$path}->{modified} > 1 ) {
                my $caller = (caller(1))[3];
@@ -267,11 +301,18 @@ sub _loaded {
                        warn "rebuild stats for $path ignored caller $caller\n";
                } else {
                        warn "rebuild stats for $path FORCED by modified caller $caller\n";
-                       $loaded->{$path}->{stats} = __stats( $loaded->{$path}->{data}->{items} );
+#                      $loaded->{$path}->{stats} = __stats( $loaded->{$path}->{data}->{items} );
+                       $loaded->{$path}->{rebuild_stats} = 1;
                        $loaded->{$path}->{modified} = 1;
                }
        }
 
+       if ( defined $loaded->{$path}->{rebuild_stats} ) {
+               warn "rebuild_stats $path";
+               $loaded->{$path}->{stats} = __stats( $loaded->{$path}->{data}->{items} );
+               delete $loaded->{$path}->{rebuild_stats};
+       }
+
        if ( ! defined $loaded->{$path}->{$name} ) {
                warn "$path $name isn't loaded\n";
                $self->_load_path( $path );
@@ -281,7 +322,7 @@ sub _loaded {
                }
                if ( ! defined $loaded->{$path}->{$name} ) {
                        warn "MISSING $name for $path\n";
-                       $self->redirect_to('/data/index')
+                       return $self->redirect_to('/data/index')
                }
        }
 
@@ -305,6 +346,22 @@ sub _permanent_path {
        $self->app->home->rel_dir('data') . '/' . join('.', $path, @_);
 }
 
+sub __unac {
+       my $n = shift;
+       $n = unac_string($n);
+       $n =~ s/\W+/_/g;
+       return $n;
+}
+
+sub _column_from_unac {
+       my ($self,$name) = @_;
+
+       my $stats = $self->_loaded('stats');
+       my $cols_norm = { map { __unac( $_ ) => $_ } keys %$stats };
+
+       $cols_norm->{$name} || die "can't find column $name in ", dump($cols_norm);
+}
+
 sub _export_path {
        my $self = shift;
        my $path = $self->_param_or_session('path');
@@ -314,16 +371,51 @@ sub _export_path {
        }
        my $dir = $self->app->home->rel_dir('public') . "/export/$path";
        mkpath $dir unless -e $dir;
-       $dir . '/' . join('.', @_);
+       my $name = __export_path_name( $path, @_ );
+       my $full = $dir . '/' . $name;
+       $full =~ s/\/+$// if -d $full; # strip trailing slash for dirs
+       return $full;
+}
+
+sub __export_path_name {
+       my $max_length = 80;
+
+       my $path = shift;
+       my $name = join('.', map { __unac($_) } @_ );
+       if ( length($name) > $max_length ) {
+               $name = substr($name,0,$max_length) . Digest::MD5::md5_hex substr($name,$max_length);
+       }
+       return $name;
 }
 
 sub columns {
     my $self = shift;
 
+       my $view_path = $self->_permanent_path( 'views' );
+
        if ( $self->param('columns') ) {
                my @columns = $self->_param_array('columns');
-               write_file( $self->_permanent_path( 'columns' ), map { "$_\n" } @columns );
-               $self->redirect_to('/data/items');
+               write_file( $self->_permanent_path( 'columns' ), { binmode => ':utf8' }, map { "$_\n" } @columns );
+               if ( my $view = $self->param('view') ) {
+                       mkdir $view_path unless -e $view_path;
+                       write_file( "$view_path/$view", { binmode => ':utf8' }, map { "$_\n" } @columns );
+                       warn "view $view_path/$view ", -s "$view_path/$view", " bytes\n";
+               }
+
+               return $self->redirect_to('/data/items');
+
+       } elsif ( ! $self->session('header') ) {
+               return $self->redirect_to('/data/load');
+       }
+
+       if ( my $id = $self->param('id') ) {
+               my $view_full = "$view_path/$id";
+               if ( -f $view_full ) {
+                       my @columns = map { chomp; $_ } read_file $view_full, binmode => ':utf8';
+                       warn "view $view_full loaded ", dump @columns;
+                       $self->session( 'columns' => [ @columns ] );
+                       return $self->redirect_to('/data/items');
+               }
        }
 
        my $stats = $self->_loaded( 'stats' );
@@ -335,11 +427,18 @@ sub columns {
                push @columns, $c unless grep { /^\Q$c\E$/ } @columns;
        }
 
+       my @views;
+       if ( -d $view_path ) {
+               @views = map { s{^\Q$view_path\E/*}{}; $_ } glob "$view_path/*";
+               warn "# views ",dump @views;
+       }
+
     $self->render(
                message => 'Select columns to display',
                stats => $stats,
                columns => \@columns,
                checked => $self->_checked( $self->_param_array('columns') ),
+               views => \@views,
        );
 }
 
@@ -395,14 +494,14 @@ sub filter {
                $self->_filter_on_data( $name, @vals );
                if ( my $permanent = $self->param('_permanent') ) {
                        my $permanent_path = $self->_export_path( 'filter', $name, $permanent );
-                       write_file $permanent_path, map { "$_\n" } @vals;
+                       write_file $permanent_path, { binmode => ':utf8' }, map { "$_\n" } @vals;
                        warn "permanent filter $permanent_path ", -s $permanent_path;
                }
        }
 
        $self->session( 'offset' => 0 );
 
-       $self->redirect_to('/data/items');
+       return $self->redirect_to('/data/items');
 }
 
 sub _filter_on_data {
@@ -445,6 +544,12 @@ sub _filter_on_data {
 
        #warn "# filter $name ",dump($filtered_items);
 
+       # invalidate filters on other datasets
+       foreach my $dataset ( grep { exists $loaded->{$_}->{filters}->{$name} } keys %$loaded ) {
+               delete $loaded->{$dataset}->{filters}->{$name};
+               delete $loaded->{$dataset}->{filtered};
+       }
+
        $loaded->{$path}->{filters}->{$name} = $filtered_items;
        warn "filter $name with ", scalar keys %$filtered_items, " items created\n";
 }
@@ -453,12 +558,12 @@ sub _filter_on_data {
 sub _current_filters {
        my $self = shift;
        my $current_filters;
+       my $stats = $self->_loaded('stats');
+
        $current_filters->{ $_ } = $filters->{ $_ }
-               foreach (
-                       grep { defined $filters->{ $_ } }
-                       @{ $self->_loaded('columns') }
-               );
-       #warn "# current_filters ",dump($current_filters);
+               foreach ( grep { defined $filters->{ $_ } } keys %$stats )
+       ;
+       warn "# _current_filters ",dump( keys %$current_filters );
        return $current_filters;
 }
 
@@ -487,8 +592,16 @@ sub _data_sorted_by {
                        $a->[1] cmp $b->[1]
                }
        } map {
-               [ $nr++, exists $_->{$order} ? join('', @{$_->{$order}}) : $missing ]
-       } grep { ref $_->{$order} eq 'ARRAY' } @{ $data->{items} }
+               my $v;
+               if ( ! exists $_->{$order} ) {
+                       $v = $missing;
+               } elsif ( ref $_->{$order} eq 'ARRAY' ) {
+                       $v = join('', @{$_->{$order}});
+               } else {
+                       $v = $_->{$order};
+               }
+               [ $nr++, $v ]
+       } @{ $data->{items} }
        ;
 
        warn "sorted: $order numeric: $numeric items: ", $#sorted + 1, "\n";
@@ -498,18 +611,57 @@ sub _data_sorted_by {
 }
 
 
+sub __all_filters {
+       my $order = pop @_;
+       join(',', sort(@_), 'order', $order);
+}
+
+our ($out, $key,$value);
+
+sub __commit_path_code {
+       my ( $path, $i, $code, $commit_changed ) = @_;
+
+       my $items = $loaded->{$path}->{data}->{items} || die "no items for $path";
+       my $row = $items->[$i];
+       my $update;
+       eval $code;
+       foreach ( keys %$update ) {
+               $$commit_changed->{$_}++;
+               $loaded->{$path}->{data}->{items}->[$i]->{$_} = $update->{$_};
+       }
+       #warn "__commit_path_code $path $i ",dump( $update );
+}
+
+# uses templates/admin.html.ep
+sub _switch_dataset {
+       my $self = shift;
+
+       my $datasets;
+
+       foreach my $path ( keys %$loaded ) {
+               next unless exists $loaded->{$path}->{data};
+               push @$datasets, $path;
+       }
+
+       warn "# datasets ",dump($datasets);
+
+       $self->stash( 'datasets' => $datasets );
+}
+
 sub items {
        my $self = shift;
 
+       $self->_switch_dataset;
+
        if ( my $show = $self->param('id') ) {
                $self->param('show', $show);
                warn "show $show\n";
        }
 
-       my $path = $self->session('path');
+       my $path = $self->_param_scalar('path');
 
        my @columns = $self->_param_array('columns');
-       $self->redirect_to('/data/columns') unless @columns;
+       return $self->redirect_to('/data/columns') unless @columns;
        my $order   = $self->_param_scalar('order', $columns[0]);
        my $sort    = $self->_param_scalar('sort', 'a');
        my $offset  = $self->_param_scalar('offset', 0);
@@ -541,7 +693,7 @@ sub items {
                }
        }
 
-       my $all_filters = join(' ',sort @filter_names,'order:',$order);
+       my $all_filters = __all_filters( @filter_names,$order );
 
 #      warn "# all_filters $all_filters ", dump( $loaded->{$path}->{filtered}->{$all_filters} );
 
@@ -549,7 +701,7 @@ sub items {
 
                my $path_filters = $loaded->{$path}->{filters};
 
-               warn "create combined filter for $all_filters\n";
+               warn "create combined filter for $all_filters from ", $#$sorted + 1, " items\n";
 
                my @filtered;
                foreach my $i ( 0 .. $#$sorted ) {
@@ -580,76 +732,197 @@ sub items {
        my $data = $self->_loaded('data');
 
        my $code = $self->_param_scalar('code','');
-       $code =~ s{[\r\n]+$}{}s;
+       $code =~ s{\r}{}gs;
+       $code =~ s{\n+$}{\n}s;
 
        my $commit = $self->param('commit');
        my $test = $self->param('test');
 
-       my $cols_changed;
+       my $commit_changed;
 
        if ( $code && ( $test || $commit ) ) {
                # XXX find columns used in code snippet and show them to user
-               foreach my $column ( $code =~ m/\$row->{(.+?)}/g ) {
+               my $order = 0;
+               foreach my $column ( $code =~ m/\$row->{([^}]+)}/g ) {
                        if ( $column =~ s/^(['"])// ) {
                                $column =~ s/$1$//;
                        }
-                       $cols_changed->{$column}++;
-                       next if grep { /$column/ } @columns;
-                       $cols_changed->{$column}++;
-                       unshift @columns, $column;
-                       if ( $commit ) {
-                               $self->session('columns', [ @columns ]);
-                               $loaded->{$path}->{columns} = [ @columns ];
-                               __path_modified( $path, 2 );
-                       }
+                       next if $column =~ m/\$/; # hide columns with vars in them
+                       $commit_changed->{$column} = 0;
                }
        }
 
        my $code_path = $self->app->home->rel_dir('public') . "/code";
        if ( $commit ) {
+
                warn "# commit on ", $#$filtered + 1, " items:\n$code\n";
+               ( $key, $value, $out ) = ( 'key', 'value' );
                foreach ( 0 .. $#$filtered ) {
                        my $i = $filtered->[$_];
-                       my $row = $data->{items}->[$i];
-                       eval $code;
+                       __commit_path_code( $path, $i, $code, \$commit_changed );
                }
+
+               # this might move before $out to recalculate stats on source dataset?
+               __path_rebuild_stats( $path );
+               my $c = { map { $_ => 1 } @columns };
+               my @added_columns = sort grep { ! $c->{$_} } keys %$commit_changed;
+               warn "# added_columns ",dump( @added_columns );
+               unshift @columns, @added_columns;
+
+               $loaded->{$path}->{columns} = [ @columns ];
+               warn "# new columns ",dump( @columns );
+
+               __invalidate_path_column( $path, $_ ) foreach keys %$commit_changed;
+
+               $self->_save_change({
+                       path => $path,
+                       time => $self->param('time') || time(),
+                       user => $self->param('user') || $ENV{'LOGNAME'},
+                       code => $code,
+                       commit_changed => $commit_changed,
+               });
+
                if ( my $description = $self->param('code_description') ) {
                        my $depends = $self->param('code_depends') || die "no code_depends?";
                        my $path = "$code_path/$depends.$description.pl";
                        if ( -e $path && ! $self->param('overwrite') ) {
                                warn "# code $path not saved\n";
                        } else {
-                               write_file $path, $code;
+                               write_file(  $path, { binmode => ':utf8' }, "$code\n" );
                                warn "code $path ", -s $path, " bytes saved\n";
                        }
                }
+
+               # remove console
                $code = '';
+               if ( $out ) {
+                       my $commit_dataset = join('.'
+                               , $self->param('code_depends')
+                               , $self->param('code_description')
+                               , time()
+                       );
+                       $key ||= 'key';
+                       $value ||= 'value';
+                       warn "key $key value $value";
+                       my $items;
+                       foreach my $n ( keys %$out ) {
+                               my $i = { $key => [ $n ] };
+                               my $ref = ref $out->{$n};
+                               if ( $ref eq 'HASH' ) {
+                                       $i->{$_} = [ $out->{$n}->{$_} ] foreach keys %{ $out->{$n} };
+                               } elsif ( $ref eq 'ARRAY' ) {
+                                       $i->{$_} = $out->{$n};
+                               } elsif ( ! $ref ) {
+                                       $i->{$value} = [ $out->{$n} ];
+                               } else {
+                                       $i->{_error} = [ dump($out->{$n}) ];
+                               }
+                               push @$items, $i;
+                       };
+                       undef $out;
+                       my $stats = __stats( $items );
+                       my @columns = grep { ! m/^\Q$key\E$/ } sort keys %$stats;
+                       unshift @columns, $key;
+
+                       $loaded->{$commit_dataset} = {
+                               header => [ @columns ],
+                               columns => [ @columns ],
+                               mtime => time(),
+                               data => { items => $items },
+                               stats => $stats,
+                               generated => 1,
+                       };
+                       warn "# loaded out ", dump( $loaded->{$commit_dataset} );
+                       $self->session('path', $commit_dataset);
+                       $self->session('columns', [ @columns ]);
+                       $self->session('order', $key);
+                       return $self->redirect_to('/data/items');
+               }
+
+               $self->session('columns', [ @columns ]);
        }
 
        my $sorted_items;
        my $from_end = $sort eq 'd' ? $#$filtered : 0;
+       my $test_changed;
+       my ( $key, $value, $out ) = ( 'key', 'value' ); # XXX make local
        foreach ( 0 .. $limit ) {
                my $i = $_ + $offset;
                last unless defined $filtered->[$i];
                $i = $from_end - $i if $from_end;
                my $id = $filtered->[$i];
-               my $row = $data->{items}->[ $id ];
+               my $row = Storable::dclone $data->{items}->[ $id ];
                if ( $code && $test ) {
-                       $row = Storable::dclone $row;
+                       my $update;
                        eval $code;
                        if ( $@ ) {
-                               warn "ERROR evaling\n$code\n$@";
+                               warn "ERROR evaling $@", dump($code);
                                $self->stash('eval_error', $@) if $@;
                        } else {
-                               warn "EVAL ",dump($row);
+                               warn "EVAL ",dump($update);
+                               foreach ( keys %$update ) {
+                                       $test_changed->{$_}++;
+                                       $row->{$_} = $update->{$_};
+                               }
                        }
                }
                $row->{_row_id} ||= $id;
                push @$sorted_items, $row;
        }
 
+       if ( $self->param('export') ) {
+               my $export_path = $self->_export_path( 'items', @columns);
+               open(my $fh, '>', $export_path) || die "ERROR: can't open $export_path: $!";
+               print $fh "#",join("\t",@columns),"\n";
+               foreach my $f ( 0 .. $#$filtered ) {
+                       print $fh join("\t", map {
+                               my $i = $data->{items}->[ $filtered->[$f] ];
+                               my $v = '\N';
+                               if ( ! defined $i->{$_} ) {
+                                       # nop
+                               } elsif ( ref $i->{$_} eq 'ARRAY' ) {
+                                       $v =join(',', @{ $i->{$_} });
+                                       $v = '\N' if length($v) == 0;
+                               } elsif ( ! ref $i->{$_} ) {
+                                       $v = $i->{$_};
+                               } else {
+                                       $v = dump $i->{$_};
+                               }
+                               $v;
+                       } @columns),"\n";
+               }
+               close($fh);
+               warn "export $export_path ", -s $export_path, " bytes\n";
+       }
+
+       warn "# test_changed ",dump( $test_changed );
+       my $c = { map { $_ => 1 } @columns };
+       my @added_columns = sort grep { ! $c->{$_} } keys %$test_changed;
+       unshift @columns, @added_columns;
+
        warn "# sorted_items ", $#$sorted_items + 1, " offset $offset limit $limit order $sort";
 
+       my $depends_on;
+       my $tmp = $code; $tmp =~ s/\$row->{(['"]?)(\w+)\1/$depends_on->{$2}++/gse;
+       warn "# depends_on ",dump $depends_on;
+
+       my $test_added = Storable::dclone $test_changed;
+       delete $test_added->{$_} foreach keys %$depends_on;
+
+       my $code_depends = $self->param('code_depends')
+       || join(',', keys %$depends_on);
+
+       my $code_description = $self->param('code_description') ||
+       join(',', keys %$test_added);
+
+       $code_depends ||= $code_description; # self-modifing
+       if ( ! $code_depends && $out ) {
+               $code_depends = $key;
+               $code_description = $value;
+       }
+
+       warn "# test_changed ",dump( $test_changed, $code_depends, $code_description );
+
        $self->render(
                order => $order,
                offset => $offset,
@@ -658,16 +931,14 @@ sub items {
                columns => [ @columns ],
                rows => $#$filtered + 1,
                numeric => { map { $_, $self->_is_numeric($_) } @columns },
+               unique  => { map { $_, $self->_is_unique( $_) } @columns },
                filters => $self->_current_filters,
                code => $code,
-               cols_changed => $cols_changed,
-               code_depends => 
-                       $self->param('code_depends') ||
-                       join(',', grep { defined $cols_changed->{$_} && $cols_changed->{$_} == 1 } @columns ),
-               code_description =>
-                       $self->param('code_description') ||
-                       join(',', grep { defined $cols_changed->{$_} && $cols_changed->{$_} == 2 } @columns ),
+               cols_changed => $commit ? $commit_changed : $test_changed,
+               code_depends => $code_depends,
+               code_description => $code_description,
                code_path => $code_path,
+               out => $out,
        );
 
 }
@@ -677,7 +948,7 @@ sub order {
        my $self = shift;
        $self->session('order', $self->param('order'));
        $self->session('sort', $self->param('sort'));
-       $self->redirect_to('/data/items');
+       return $self->redirect_to('/data/items');
 }
 
 sub _is_numeric {
@@ -692,6 +963,12 @@ sub _is_numeric {
                $stats->{$name}->{numeric} > $count / 2;
 }
 
+sub _is_unique {
+       my ( $self, $name ) = @_;
+       my $stats = $self->_loaded( 'stats' );
+       defined $stats->{$name}->{unique};
+}
+
 sub _remove_filter {
        my ($self,$name) = @_;
        warn "_remove_filter $name\n";
@@ -714,11 +991,11 @@ sub _remove_filter {
 sub facet {
        my $self = shift;
 
-       my $path = $self->session('path') || $self->redirect_to( '/data/index' );
+       my $path = $self->session('path') || return $self->redirect_to( '/data/index' );
 
        if ( my $name = $self->param('remove') ) {
                $self->_remove_filter( $name );
-               $self->redirect_to( '/data/items' );
+               return $self->redirect_to( '/data/items' );
        }
 
        my $facet;
@@ -728,7 +1005,7 @@ sub facet {
        my $data = $self->_loaded('data');
 
        my $filters = $self->_current_filters;
-       my $all_filters = join(' ',sort keys %$filters,'order:',$self->session('order'));
+       my $all_filters = __all_filters( keys %$filters,$self->session('order') );
        my $filtered = $loaded->{$path}->{filtered}->{$all_filters}
                if defined $loaded->{$path}->{filtered}->{$all_filters};
 
@@ -750,16 +1027,34 @@ sub facet {
                }
        }
 
+       my $checked_values = $self->_checked( @{ $filters->{$name} } ) if defined $filters->{$name};
+
+       if ( my $code = $self->param('code') ) {
+               my $out;
+               foreach my $value ( keys %$facet ) {
+                       my $count = $facet->{$value};
+                       my $checked = $checked_values->{$value};
+                       eval $code;
+                       if ( $@ ) {
+                               $out = $@;
+                               warn "ERROR: $@\n$code\n";
+                               last;
+                       } elsif ( $checked != $checked_values->{$value} ) {
+                               warn "checked $value $count -> $checked\n";
+                               $checked_values->{$value} = $checked;
+                       }
+               }
+               warn "out ",dump( $out );
+               $self->stash( out => $out );
+       }
+
 #      warn "# facet $name ",dump $facet;
 
-       my $checked;
        my @facet_names =
                  $all                      ? keys %$facet
                : defined $filters->{$name} ? @{ $filters->{$name} }
                : keys %$facet;
 
-       $checked = $self->_checked( @{ $filters->{$name} } ) if defined $filters->{$name};
-
        my $numeric = $self->_is_numeric($name);
 
        my $sort = $self->param('sort');
@@ -782,7 +1077,7 @@ sub facet {
                $result;
        } @facet_names;
 
-       $self->render( name => $name, facet => $facet, checked => $checked,
+       $self->render( name => $name, facet => $facet, checked => $checked_values,
                facet_names => \@facet_names, sort => $sort, numeric => $numeric,
        );
 }
@@ -811,6 +1106,19 @@ sub __path_modified {
        warn "# __path_modified $path $value\n";
 }
 
+sub __path_rebuild_stats { $loaded->{ $_[0] }->{rebuild_stats} = 1 };
+
+sub _save_change {
+       my ($self,$change) = @_;
+
+       my $change_path = $self->_permanent_path( 'changes' );
+       mkdir $change_path unless -d $change_path;
+       $change_path .= '/' . $change->{time};
+       store $change, $change_path;
+       utime $change->{time}, $change->{time}, $change_path;
+       warn "_save_change $change_path ", dump($change);
+}
+
 sub edit {
        my $self = shift;
        my $new_content = $self->param('new_content');
@@ -839,7 +1147,7 @@ sub edit {
                if ( $old ne $new
                        && ! ( $old eq 'undef' && length($new_content) == 0 ) # new value empty, previous undef
                ) {
-                       my $change = {
+                       $self->_save_change({
                                path => $path,
                                column => $name,
                                pos => $i,
@@ -852,13 +1160,7 @@ sub edit {
                                        grep { defined $loaded->{$path}->{stats}->{$_}->{unique} }
                                        keys %{ $loaded->{$path}->{stats} }
                                },
-                       };
-                       my $change_path = $self->_permanent_path( 'changes' );
-                       mkdir $change_path unless -d $change_path;
-                       $change_path .= '/' . $change->{time};
-                       store $change, $change_path;
-                       utime $change->{time}, $change->{time}, $change_path;
-                       warn "# $change_path ", dump($change);
+                       });
 
                        warn "# change $path $i $old -> $new\n";
                        $loaded->{$path}->{data}->{items}->[$i]->{$name} = $v;
@@ -866,8 +1168,7 @@ sub edit {
                        __invalidate_path_column( $path, $name );
 
                        $status = 201; # created
-                       # modified = 2 -- force rebuild of stats
-                       __path_modified( $path, 2 );
+                       __path_rebuild_stats( $path );
        
                        $new_content = join("\xB6",@$v);
 
@@ -895,30 +1196,44 @@ sub save {
        my $dump_path = $self->_save( $path );
        __path_modified( $path, 0 );
 
-       $self->redirect_to( '/data/items' );
+       return $self->redirect_to( '/data/items' );
 }
 
 sub export {
        my $self = shift;
 
+       my $dir = $self->app->home->rel_dir('public');
+
        if ( my $import = $self->param('import') ) {
 
                if ( $import =~ m{/filter\.(.+?)\..+} ) {
-                       my $name = $1;
+                       my $name = $self->_column_from_unac( $1 );
+
                        my @vals = map { chomp; $_ }
-                               read_file $self->app->home->rel_dir('public') . "/export/$import";
+                               read_file "$dir/export/$import", binmode => ':utf8';
+
                        $self->_remove_filter( $name );
                        $self->_filter_on_data( $name, @vals );
                        $self->session( 'offset' => 0 );
-                       $self->redirect_to('/data/items');
+                       return $self->redirect_to('/data/items');
                } else {
                        warn "UNKNOWN IMPORT $import";
                }
        }
 
-       $self->render( export => [
-               glob( $self->_export_path . '*' )
-       ] );
+       if ( my $remove = $self->param('remove') ) {
+               my $path = "$dir/export/$remove";
+               unlink $path if -e $path;
+               $path .= '.png';
+               unlink $path if -e $path;
+       }
+
+       my $path = $self->_export_path || return $self->redirect_to('/data/index');
+
+       my @files = grep { ! /\.png$/ } glob "$path/*";
+       my $mtime = { map { $_ => (stat($_))[9] } @files };
+       @files = sort { $mtime->{$b} <=> $mtime->{$a} } @files;
+       $self->render( export => [ @files ] );
 }
 
 sub __loaded_paths {
@@ -927,4 +1242,20 @@ sub __loaded_paths {
                keys %$loaded;
 }
 
+sub remove {
+       my $self = shift;
+       my $path = $self->param('path');
+       if ( $path =~ m{^/tmp/mojo_facets\.} ) {
+               unlink $path;
+               warn "# unlink $path";
+               if ( my $name = $self->param('name') ) {
+                       delete $loaded->{$name};
+                       warn "# remove $name from memory";
+               }
+       } else {
+               warn "WARNING: $path unlink ignored";
+       }
+       return $self->redirect_to( '/data/load' );
+}
+
 1;