Bug 7684: QA Followup and bugfixes

[koha.git] / members / member-picupload.pl

diff --git a/members/member-picupload.pl b/members/member-picupload.pl
index 6ca68a7..75bbea4 100755 (executable)
--- a/members/member-picupload.pl
+++ b/members/member-picupload.pl
@@ -20,11 +20,13 @@
 # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
 # A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+use warnings;
+
 use C4::Auth;
 use C4::Context;
 use C4::Output;
@@ -37,7 +39,6 @@ my $borrowernumber = $input->param('borrowernumber');
 my $photo = $input->param('photo');
 
 my $template_name;
-my $upload_dir= 
 my $htdocs = C4::Context->config('intrahtdocs');
 my $upload_dir = $htdocs."/borrowerimages";
 if($photo eq  ""){
@@ -58,13 +59,13 @@ if ($photo){
 
        my $filename=$borrowernumber.'.jpg';
        my $upload_filehandle = $input->upload("photo");
-       open UPLOADFILE, ">$upload_dir/$filename";
-       binmode UPLOADFILE;
+    open (my $upload_fh, '>', "$upload_dir/$filename");
+    binmode $upload_fh;
        while ( <$upload_filehandle> )
        {
-               print UPLOADFILE;
+        print $upload_fh;
        }
-       close UPLOADFILE;
+    close $upload_fh;
 }
 else {
        $template->param(
@@ -73,4 +74,4 @@ else {
                 );
        output_html_with_http_headers $input, $cookie, $template->output;
 }
-print $input->redirect("http://intranet/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrowernumber");
\ No newline at end of file
+print $input->redirect("http://intranet/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrowernumber");